Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anh5W-00024j-Um for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Apr 2016 06:37:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1anh5W-0002of-90 for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Apr 2016 06:37:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1anh5V-0002oW-Gj for pgadmin-hackers@postgresql.org; Wed, 06 Apr 2016 06:37:13 +0000 Received: from mail-yw0-x236.google.com ([2607:f8b0:4002:c05::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1anh5R-0001Nf-16 for pgadmin-hackers@postgresql.org; Wed, 06 Apr 2016 06:37:12 +0000 Received: by mail-yw0-x236.google.com with SMTP id d68so44933114ywe.1 for ; Tue, 05 Apr 2016 23:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=8LVRgJnOwiXLmszirA2YbjjUyUeAhO8HllNe4zHykdo=; b=qM+yII4MF+Z1rNf0PloEWQcQutRtPKnLq5xOiwLGPfevOLcVkcwq2B3ReJgSPYgWuX FT2UROk36NbPdIEKEMLSraID84QCSSwEtYVse8Jqrf2WtgimrfrhfN3QvMO7gXwfNV+2 I2+IL05pNITk5c9tE1knSFG+lgEgUAQWpVgmGM+iw3G5U4lJA4bvRBZinVoRbN9ZljE6 8r+v/qfjKGCuryJQmNdqNTFYB/OIsGRzwWRMTgGonfdjuXT8eAV1rtftkMXX8hGOnxu/ TOdeCTl2DbIV1lP73VgXhDa6agavJQFiGVuA4JxLRlX7yDM9pTfX76kgiweG3WvNJDZP K9Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=8LVRgJnOwiXLmszirA2YbjjUyUeAhO8HllNe4zHykdo=; b=iQxB2dn07umBwDkt3GjV00hatlnjwSzfS8g1xzGdevPu8JGVQsUUy4F9I2ROVwb6oR 4LnchbEnra9Grn+knVX3KYd9CQlS3qAihwCxzPLElYQd+rFEaVkYJacR7mI1urvV/T3b cnsY1kMqdcB/eDPz7KgiRZbFMnDtgEJE97IyvG/b2Pl+MMx+As9XVbEj9teiJF0wNpis tpAK+izTjwDbFTfKARqHZMboE49Kq6GDqlJFINwvldDgVI6mVjzGL6fvn7yqW0NGy9zg Zab7j5ngclMMJn6oB1aIId5UrsOB1f0/pluIxxCvnsHk7GAydVHbUj5SOGRXUe/b6HF/ hIvQ== X-Gm-Message-State: AD7BkJLFG4nJSQhjyJmAu61W7g5sqWDjrbJFsQMPxg9iAGp2NPoiD5iXNETrXqCQDKs5lyZzd6pCEyseFtfSR+8F MIME-Version: 1.0 X-Received: by 10.13.234.85 with SMTP id t82mr14719700ywe.195.1459924627350; Tue, 05 Apr 2016 23:37:07 -0700 (PDT) Received: by 10.37.218.76 with HTTP; Tue, 5 Apr 2016 23:37:07 -0700 (PDT) In-Reply-To: References: Date: Wed, 6 Apr 2016 12:07:07 +0530 Message-ID: Subject: Re: [pgAdmin4][Debugger]: Initial Patch From: Neel Patel To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c06c434d00d5a052fcb307b X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c06c434d00d5a052fcb307b Content-Type: text/plain; charset=UTF-8 Hi Dave, Updated above information. We want this pgadmin4 log information to debug the debugger blank tab open issue. Thanks, Neel Patel On Wed, Apr 6, 2016 at 11:50 AM, Neel Patel wrote: > One more additional information. > > Follow the below steps and send us pgAdmin4.log file. > > - Browse till function which we want to debug. Do not click on the > "Debug" context menu. > - Stop the server > > Stop the web server. > > - Enable the "Debug" option in the config file under "web" folder. > > Set the Log setting to "Debug" and save the log to files and send the updated debug log information. > > - Start the server. > > Start the Web Server. > > - Now click on the "Debug" context menu and add requirement input. > After clicking on the debug button on the input dialog send us the > pgAdmin4.log file. > > Thanks, > Neel Patel > > On Wed, Apr 6, 2016 at 11:38 AM, Neel Patel > wrote: > >> Hi Dave, >> >> We will fix the error "KeyError: 'session_id'" but regarding the blank >> tab, we have tried with PostgreSQL 9.4 with both the version of python (2.7 >> & 3.4) but we are not able to reproduce the issue. >> >> Below are some of the questions to debug the issue. >> >> - Is it only reproduce on PostgreSQL 9.4 ? Is it working on >> PostgreSQL 9.5 ? >> - Is it possible to know the debugger version ? >> - The issue is reproduce on specific functions ? If yes, can you >> please give definition of the function ? >> - Are you able to see toolbar buttons ? Or nothing on the screen ? >> Only blank panel ? >> - Can you please share request/response of last request URL sent to >> server in browser ? >> >> Thanks, >> Neel Patel >> >> On Tue, Apr 5, 2016 at 9:59 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Apr 5, 2016 at 12:40 PM, Neel Patel >>> wrote: >>> > Hi, >>> > >>> > Please find attached debugger v1 patch. To test this patch we need to >>> apply >>> > the "function" module patch submitted by Khushboo. >>> > >>> > For the debugger functionality, direct and indirect debugging is >>> working as >>> > per pgadmin3 except below TODOs. >>> > >>> > Below are the TODOs which will be submitted in next patch along with >>> the >>> > fixed review comments. >>> > >>> > For the direct debugging, 'NULL' and 'Expression' column value should >>> be >>> > validated before pressing the debug button. >>> > User can deposit the value of input arguments and local variable but >>> need to >>> > be >>> > validated against respective data types. >>> > Currently we have tested for plpgsql functions only, We need to test >>> against >>> > EDB SPL functions and trigger functions. >>> > For the direct debugging, once the execution is completed, only >>> > "Continue/Restart" button will be enabled and user should allow to >>> restart >>> > the debugging with same function and previous values. >>> > Values entered by the user in input dialog during direct debugging >>> should be >>> > saved. >>> > >>> > >>> > Currently we have tested this patch with PostgreSQL v9.5. >>> > >>> > Do review it and let us know for the comments. >>> >>> I just get a blank tab when I try to debug something. I do see the >>> params dialogue, but then nothing. Note: >>> >>> - I have Akshay's Query Tool patch applied, and am running from git >>> master >>> >>> - PostgreSQL 9.4, with the debugger plugin in the public schema. >>> >>> - Various functions in the pem schema tested, both with and without >>> parameters. >>> >>> - Both direct and indirect debugging have the same issue. >>> >>> - No errors seen in the console, except when closing the debugger tab: >>> >>> 2016-04-05 17:27:37,720: INFO werkzeug: 127.0.0.1 - - [05/Apr/2016 >>> 17:27:37] "GET /debugger/close/8569717 HTTP/1.1" 500 - >>> Traceback (most recent call last): >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1836, in __call__ >>> return self.wsgi_app(environ, start_response) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1820, in wsgi_app >>> response = self.make_response(self.handle_exception(e)) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1403, in handle_exception >>> reraise(exc_type, exc_value, tb) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1817, in wsgi_app >>> response = self.full_dispatch_request() >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1477, in full_dispatch_request >>> rv = self.handle_user_exception(e) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1381, in handle_user_exception >>> reraise(exc_type, exc_value, tb) >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1475, in full_dispatch_request >>> rv = self.dispatch_request() >>> File >>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >>> line 1461, in dispatch_request >>> return self.view_functions[rule.endpoint](**req.view_args) >>> File >>> "/Users/dpage/git/pgadmin4-demo/web/pgadmin/tools/debugger/__init__.py", >>> line 397, in close >>> session_id=obj['session_id']) >>> KeyError: 'session_id' >>> >>> >>> Thanks. >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --94eb2c06c434d00d5a052fcb307b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

Updated above information.
We want this pgadmin4 log information to debug the debugger blank ta= b open issue.

Thanks,
Neel Patel

On Wed, Apr 6,= 2016 at 11:50 AM, Neel Patel <neel.patel@enterprisedb.com&g= t; wrote:
One mor= e additional information.

Follow the below steps and sen= d us pgAdmin4.log file.
  • Browse till function which we wan= t to debug. Do not click on the "Debug" context menu.
  • Sto= p the server
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 Stop the web server.=C2=A0
  • Enable the "Debug" option = in the config file under "web" folder.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Set the Log se= tting to "Debug" and save the log to files and send the updated d= ebug log information.
=
  • Start the server.
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Start the Web Server.= =C2=A0
  • No= w click on the "Debug" context menu and add requirement input. Af= ter clicking on the debug button on the input dialog send us the pgAdmin4.l= og file.
Thanks,
Neel Patel

On Wed, Apr 6, 2016 at 11:38 AM, Neel Patel <ne= el.patel@enterprisedb.com> wrote:
Hi Dave,

We will fix the error "KeyError: 'session_id'" but regarding the blank tab, we have tried with PostgreSQL 9.4 with both t= he version of python (2.7 & 3.4) but we are not able to reproduce the i= ssue.

Below are some of the questions t= o debug the issue.
  • Is it only reproduce on PostgreSQL 9.4= ? Is it working on PostgreSQL 9.5 ?
  • Is it possible to know the deb= ugger version ?
  • The issue is reproduce on specific functions ? If y= es, can you please give definition of the function ?
  • Are you able t= o see toolbar buttons ? Or nothing on the screen ? Only blank panel ?
    • <= li>Can you please share request/response of last request URL sent to server= in browser ?
Thanks,
Neel Patel
<= /div>

On= Tue, Apr 5, 2016 at 9:59 PM, Dave Page <dpage@pgadmin.org> = wrote:
Hi

On Tue, Apr 5, 2016 at 12:40 PM, Neel Patel <neel.patel@enterprisedb.com> w= rote:
> Hi,
>
> Please find attached debugger v1 patch. To test this patch we need to = apply
> the "function" module patch submitted by Khushboo.
>
> For the debugger functionality, direct and indirect debugging is worki= ng as
> per pgadmin3 except below TODOs.
>
> Below are the TODOs which will be submitted in next patch along with t= he
> fixed review comments.
>
> For the direct debugging, 'NULL' and 'Expression' colu= mn value should be
> validated before pressing the debug button.
> User can deposit the value of input arguments and local variable but n= eed to
> be
> validated against respective data types.
> Currently we have tested for plpgsql functions only, We need to test a= gainst
> EDB SPL functions and trigger functions.
> For the direct debugging, once the execution is completed, only
> "Continue/Restart" button will be enabled and user should al= low to restart
> the debugging with same function and previous values.
> Values entered by the user in input dialog during direct debugging sho= uld be
> saved.
>
>
> Currently we have tested this patch with PostgreSQL v9.5.
>
> Do review it and let us know for the comments.

I just get a blank tab when I try to debug something. I do see the params dialogue, but then nothing. Note:

- I have Akshay's Query Tool patch applied, and am running from git mas= ter

- PostgreSQL 9.4, with the debugger plugin in the public schema.

- Various functions in the pem schema tested, both with and without paramet= ers.

- Both direct and indirect debugging have the same issue.

- No errors seen in the console, except when closing the debugger tab:

2016-04-05 17:27:37,720: INFO werkzeug: 127.0.0.1 - - [05/Apr/2016
17:27:37] "GET /debugger/close/8569717 HTTP/1.1" 500 -
Traceback (most recent call last):
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1836, in __call__
=C2=A0 =C2=A0 return self.wsgi_app(environ, start_response)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1820, in wsgi_app
=C2=A0 =C2=A0 response =3D self.make_response(self.handle_exception(e))
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1403, in handle_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1817, in wsgi_app
=C2=A0 =C2=A0 response =3D self.full_dispatch_request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1477, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1381, in handle_user_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1475, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1461, in dispatch_request
=C2=A0 =C2=A0 return self.view_functions[rule.endpoint](**req.view_args) =C2=A0 File "/Users/dpage/git/pgadmin4-demo/web/pgadmin/tools/debugger= /__init__.py",
line 397, in close
=C2=A0 =C2=A0 session_id=3Dobj['session_id'])
KeyError: 'session_id'


Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--94eb2c06c434d00d5a052fcb307b--