Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8Lz8-0002Y8-CA for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 07:24:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d8Lz7-0008M7-P6 for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 07:24:33 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d8Lz6-0008Lk-Cw for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 07:24:32 +0000 Received: from mail-pg0-x234.google.com ([2607:f8b0:400e:c05::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d8Lyy-0008Hw-C0 for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 07:24:30 +0000 Received: by mail-pg0-x234.google.com with SMTP id 64so12222748pgb.3 for ; Wed, 10 May 2017 00:24:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3W6i+i9C8VQLEkqWx5mdeAWkBtbGWN3kxId/MnTfKEk=; b=asCU0D4P+poAlPqmsxqyxsZBF0qjMso1gBvurckx7DkOSaeVMet5ywqPP8DJbe4X5a 8/7UtHYs2FHhoBPzEPI3bNAs+nBP6268QfBHORGJdv6FhmJoqLP/lA46WHKw3D8gKkuG chrMQG6ETUB9eTP+AalRpjlE9m9U+8qvThZwd0o3exVdGA3RmHVzMko3z+oOh960bdWq ZCcp6jc6alfpASGYjHXv8n7YfQB2hyLafuENfuUG9t95IGDAgda0C9D5B7/7EJ8C4bM6 92hzLwDlOxAKFD+B8JuOlW0feva3iR/5+SmrYQBTYjrXyC7ZyoOFH9EK55pI0qkGlaow UiVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3W6i+i9C8VQLEkqWx5mdeAWkBtbGWN3kxId/MnTfKEk=; b=jazTFA7VjFqtz19mp9ho1BgJgvih/6s5o3ijLom6lXie0knivNTSLTJ+q15Ah8VmnR aLxPkDECEEyvzeuyy4h6KT8Qwb/JZTSghfv8deyQ7Tf+45UfWZzZU8NDYqMHFhmN2tmN zB5hnFjM/rPvndBCqssp94CQufKSHBK+nQuUgGcpuOCSwPFrfsTuvAEg6vh046XB3tQC hoqPkyktO/Ar1mUGR8qu2SAQAvN4SsRw+py6e0v5+UETMjjPtYTQENew2S6OB49xM8hm NbhsGkEKIRA/hG35lFr++GLoBIVB7CdTDsSJXrABHPn11L/xap/B50bjEZ45GoK7mBSf f3Qg== X-Gm-Message-State: AODbwcCiGucTxJeImUqIzsM99KMfDAmTKe0S7TPlWzaZ9M21iw34O+eZ 9bME1R730whs8poOo4MuafN5DOEcFxvx X-Received: by 10.98.66.214 with SMTP id h83mr4610631pfd.182.1494401062649; Wed, 10 May 2017 00:24:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.137.16 with HTTP; Wed, 10 May 2017 00:24:22 -0700 (PDT) In-Reply-To: <1F9A3F3B-A4C7-4DA2-BE6C-254781F564E1@pgadmin.org> References: <8A654A56-BC41-46FC-AE7A-5C1F48D07208@pgadmin.org> <1F9A3F3B-A4C7-4DA2-BE6C-254781F564E1@pgadmin.org> From: Neel Patel Date: Wed, 10 May 2017 12:54:22 +0530 Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c0c0bce7dd946054f265cc1 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c0c0bce7dd946054f265cc1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Should I ask Akshay to review and commit ? On Wed, May 10, 2017 at 12:34 PM, Dave Page wrote: > Cool :-) > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK:http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On 10 May 2017, at 08:01, Neel Patel wrote: > > It does not give any error with standard QtWebkit. > > On Wed, May 10, 2017 at 12:25 PM, Dave Page wrote: > >> Hi >> >> What happens on a standard QtWebKit if we try to trigger >> QWebPage::ToggleVideoFullscreen + 1? Does it error, or get silently >> ignored? >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK:http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On 10 May 2017, at 07:30, Neel Patel wrote= : >> >> Hi, >> >> Please find attached patch file with the fix of compilation issues with >> Qt4. Tested with both the version of Qt4 and Qt5 webkit and it is worki= ng >> now. >> >> As triggerAction code will not be applicable for Qt4 so we made >> conditional macro for Qt5 version check and for backward compatibility >> webkit version with Qt5, as in new webkit new enum is added so we have >> incremented with one to previous enum value which will solve the problem >> with both old and new webkit. >> >> Do review it and let me know for any issue. >> >> Thanks, >> Neel Patel >> >> On Tue, May 9, 2017 at 3:18 PM, Neel Patel >> wrote: >> >>> Hi Dave, >>> >>> On Tue, May 9, 2017 at 3:08 PM, Dave Page >>> wrote: >>> >>>> Hi >>>> >>>> On Tue, May 9, 2017 at 10:28 AM, Neel Patel < >>>> neel.patel@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' >>>>> related compilation error in Qt4. BUT >>>>> >>>>> Below compilation error is coming because we have not applied the >>>>> latest patch of webkit which was fixed in annulen/webkit repo which w= as >>>>> raised at below path. >>>>> >>>>> https://github.com/annulen/webkit/issues/519 >>>>> >>>>> BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is no= t a member of >>>>> =E2=80=98QWebPage=E2=80=99 >>>>> webviewPtr->page()->triggerAc >>>>> tion(QWebPage::RequestClose); >>>>> >>>>> To fix the above compilation error currently we have two solution. >>>>> >>>>> - Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file >>>>> ) . >>>>> - Comment the below line temporary for compilation until we get >>>>> the releases from annulen/webkit. >>>>> >>>>> webviewPtr->page()->triggerAc >>>>> tion(QWebPage::RequestClose); >>>>> >>>>> Other compilation issues, (Me and Akshay) will fix and commit it but >>>>> need your input on above issue. >>>>> >>>> >>>> For various reasons we need to retain compatibility with the previous >>>> versions of qtwebkit. Can we detect at build time what version we have= , and >>>> enable/disable that code as appropriate? >>>> >>> >>> Make sense. We will check if we are getting any webkit version in >>> application or not and update you. >>> >>> >>>> >>>>> >>>>> Thanks, >>>>> Neel Patel >>>>> >>>>> On Tue, May 9, 2017 at 2:02 PM, Dave Page >>>>> wrote: >>>>> >>>>>> It's running CentOS 7.3, with packages from EPEL: >>>>>> >>>>>> [dpage@jenkins ~]$ rpm -qa |grep qt >>>>>> qt5-qtbase-common-5.6.1-10.el7.noarch >>>>>> qt5-qtbase-devel-5.6.1-10.el7.x86_64 >>>>>> qt-4.8.5-13.el7.x86_64 >>>>>> qt5-qtbase-5.6.1-10.el7.x86_64 >>>>>> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 >>>>>> qt5-qtwebchannel-5.6.1-10.el7.x86_64 >>>>>> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64 >>>>>> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64 >>>>>> qt-devel-4.8.5-13.el7.x86_64 >>>>>> qt-settings-19-23.5.el7.centos.noarch >>>>>> qt5-qtbase-gui-5.6.1-10.el7.x86_64 >>>>>> qt5-qtlocation-5.6.1-10.el7.x86_64 >>>>>> qt5-qtwebsockets-5.6.1-10.el7.x86_64 >>>>>> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64 >>>>>> qtwebkit-2.3.4-6.el7.x86_64 >>>>>> qt3-3.3.8b-51.el7.x86_64 >>>>>> qt5-qtdeclarative-5.6.1-10.el7.x86_64 >>>>>> qt5-rpm-macros-5.6.1-10.el7.noarch >>>>>> qtwebkit-devel-2.3.4-6.el7.x86_64 >>>>>> qt-x11-4.8.5-13.el7.x86_64 >>>>>> qt5-qtsensors-5.6.1-10.el7.x86_64 >>>>>> >>>>>> On Tue, May 9, 2017 at 9:28 AM, Neel Patel < >>>>>> neel.patel@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> Yes, It looks like compilation fails on Qt4. We will fix this issue >>>>>>> but which version of Qt4 we are using in Jenkins ? >>>>>>> >>>>>>> Thanks, >>>>>>> Neel Patel >>>>>>> >>>>>>> On Tue, May 9, 2017 at 1:56 PM, Dave Page < >>>>>>> dave.page@enterprisedb.com> wrote: >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page < >>>>>>>>> dave.page@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> This appears to have made Jenkins get all angry and red :-( >>>>>>>>>> >>>>>>>>>> https://jenkins.pgadmin.org/ >>>>>>>>>> >>>>>>>>> >>>>>>>>> We(Neel and I) have tested it and working fine. >>>>>>>>> >>>>>>>> >>>>>>>> It clearly doesn't compile on QT4. Please review the Jenkins logs. >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < >>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Thanks patch applied. >>>>>>>>>>> >>>>>>>>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Akshay, could you review this please? >>>>>>>>>>>> >>>>>>>>>>>> Thanks. >>>>>>>>>>>> >>>>>>>>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel < >>>>>>>>>>>> neel.patel@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> Please find attached patch file with the fix of RM #2328 - >>>>>>>>>>>>> [Runtime]: Unable to launch query tool and debugger in new br= owser tab. >>>>>>>>>>>>> >>>>>>>>>>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>>>>>>>>>> >>>>>>>>>>>>> https://github.com/annulen/webkit/releases >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> As there was a bug in QWebKit regarding "unload" event. We >>>>>>>>>>>>> have raised and also they have provided patch file to fix thi= s issue. I >>>>>>>>>>>>> have applied the patch in linux and compile the webkit and te= sted the >>>>>>>>>>>>> attached patch with compiled webkit which is now working fine= . >>>>>>>>>>>>> >>>>>>>>>>>>> Below is the link for reference regarding unload issue. They >>>>>>>>>>>>> have provided test webkit release for Mac in below URL but fo= r other >>>>>>>>>>>>> platform we need to apply the patch and compile the webkit un= til they >>>>>>>>>>>>> provide webkit-releases for all platforms. >>>>>>>>>>>>> >>>>>>>>>>>>> https://github.com/annulen/webkit/issues/519 >>>>>>>>>>>>> >>>>>>>>>>>>> Do review it and let me know in case of any issue. >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Neel Patel >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>>>>>> To make changes to your subscription: >>>>>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Dave Page >>>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>>> >>>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>> *Principal Software Engineer * >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>>>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> VP, Chief Architect, Tools & Installers >>>>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Akshay Joshi* >>>>>>>>> *Principal Software Engineer * >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> VP, Chief Architect, Tools & Installers >>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> VP, Chief Architect, Tools & Installers >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> VP, Chief Architect, Tools & Installers >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>> >>> >> >> >> > --94eb2c0c0bce7dd946054f265cc1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Should I ask Akshay to review and commit ?

On Wed, May 10, 2017 at 12:= 34 PM, Dave Page <dpage@pgadmin.org> wrote:
Cool :-)

<= span style=3D"background-color:rgba(255,255,255,0)">--=C2=A0
Dave PageBlog:=C2=A0htt= p://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB = UK:http://www.en= terprisedb.com
The Enterprise PostgreSQL Company
=

On 10 May 2017, at 08:01, Neel Patel <neel.patel@e= nterprisedb.com> wrote:

=
It does not give any error with standard QtWebkit.

On Wed, May 10, 201= 7 at 12:25 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

What happens= on a standard QtWebKit if we try to trigger=C2=A0QWebPage::ToggleVideoFullscreen + 1? Does = it error, or get silently ignored?

--=C2=A0
Dave Page
Blog:=C2=A0http://pgsnake.blogspo= t.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company

On 10 May 2017, at 07:30, Neel Patel <= neel.patel= @enterprisedb.com> wrote:

Hi,

Please find attached patch file w= ith the fix of compilation issues with Qt4.=C2=A0 Tested with both the vers= ion of Qt4 and Qt5 webkit and it is working now.

A= s triggerAction code will not be applicable for Qt4 so we made conditional = macro for Qt5 version check and for backward compatibility webkit version w= ith Qt5, as in new webkit new enum is added so we have incremented with one= to previous enum value which will solve the problem with both old and new = webkit.

Do review it and let me know for any issue= .

Thanks,
Neel Patel

On Tue, May 9, 2017 at 3:= 18 PM, Neel Patel <neel.patel@enterprisedb.com> wr= ote:
Hi Dave,

On Tue, May 9, 2017 a= t 3:08 PM, Dave Page <dave.page@enterprisedb.com> w= rote:
Hi

On Tue, May 9, 2017 a= t 10:28 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave= ,

Here there are 2 compilation issue. We have fixe= d 'QNetworkCookieJar' related compilation error in Qt4. BUT

Below compilation error is coming because we have not app= lied the latest patch of webkit which was fixed in annulen/webkit repo whic= h was raised at below path.


BrowserWindow= .cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is not a member of =E2= =80=98QWebPage=E2=80=99
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0webviewPtr->page()->= triggerAction(QWebPage::RequestClose);

= To fix the above compilation error currently we have two solution.
  • Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h f= ile ) .
  • Comment the below line temporary for compilation until we g= et the releases from annulen/webkit.
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0webviewPtr->page()->triggerAction= (QWebPage::RequestClose);

Other compilat= ion issues, (Me and Akshay) will fix and commit it but need your input on a= bove issue.

For various = reasons we need to retain compatibility with the previous versions of qtweb= kit. Can we detect at build time what version we have, and enable/disable t= hat code as appropriate?
=C2=A0
Make sense.=C2=A0 We will check if we are getting any webkit= version in application or not and update you.

=C2=A0

Thanks,
Neel Patel

On Tue, May 9, 2017 at 2:02 PM, Dave= Page <dave.page@enterprisedb.com> wrote:
It's running CentOS 7.3, with= packages from EPEL:

[dpage@jenkins ~]$ rpm -qa |gr= ep qt
qt5-qtbase-common-5.6.1-10.el7.noarch
qt5-qt= base-devel-5.6.1-10.el7.x86_64
qt-4.8.5-13.el7.x86_64
<= div>qt5-qtbase-5.6.1-10.el7.x86_64
qt5-qtxmlpatterns-5.6.1-10.el7= .x86_64
qt5-qtwebchannel-5.6.1-10.el7.x86_64
= qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
qt5-qtdeclarative= -devel-5.6.1-10.el7.x86_64
qt-devel-4.8.5-13.el7.x86_64
qt-settings-19-23.5.el7.centos.noarch
qt5-qtbase-gui-5= .6.1-10.el7.x86_64
qt5-qtlocation-5.6.1-10.el7.x86_64
qt5-qtwebsockets-5.6.1-10.el7.x86_64
qt5-qtwebkit-d= evel-5.6.1-3.b889f46git.el7.x86_64
qtwebkit-2.3.4-6.el7.x86_= 64
qt3-3.3.8b-51.el7.x86_64
qt5-qtdeclarative-5.6.1-10.= el7.x86_64
qt= webkit-devel-2.3.4-6.el7.x86_64
qt-x11-4.8.5-13.el7.x86_64
qt5-qtsensors-5.6.1-10.el7.x86_64

= On Tue, May 9, 2017 at 9:28 AM, Neel Patel <neel.patel@enterpris= edb.com> wrote:
Hi Dave,

Yes, It looks like compilation fails on Q= t4. We will fix this issue but which version of Qt4 we are using in Jenkins= ?

Thanks,
Neel Patel

On Tue, May 9, 2017 at 1:56= PM, Dave Page <dave.page@enterprisedb.com> wrote:<= br>


On Tue, May 9, 2017 at 9:18 AM,= Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi

On Tue, May 9, 2017 a= t 1:42 PM, Dave Page <dave.page@enterprisedb.com> w= rote:
This appears to have made Jenkin= s get all angry and red :-(

=

=C2=A0 =C2=A0We(Neel and I) have te= sted it and working fine.=C2=A0=C2=A0
<= div>
It clearly doesn't compile on QT4. Please rev= iew the Jenkins logs.
=C2=A0

<= div class=3D"m_1757313796581100076m_7279646494025740165m_364691597805287587= 6m_-4780963339364194306m_2216630011400908436m_-2016239111006808430m_-674534= 015089129385m_-2183617756405375713m_4373938761770165468gmail-h5">
On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch applied.

On Mon, May 8, 2017 at = 3:21 PM, Dave Page <dpage@pgadmin.org> wrote:
Akshay, could you review this please?

=
Thanks.

On Fri, May 5, 2017 at 11:53 = AM, Neel Patel <neel.patel@enterprisedb.com> wrote= :
Hi,

Please find attached patch file with = the fix of RM #2328 - [Runtime]: Unable to launch query tool and debugger i= n new browser tab.

I have used Qt 5.8 with webkit mentioned in below URL.


As there was a bug in QWebKit regarding "unload" event. We = have raised and also they have provided patch file to fix this issue. I hav= e applied the patch in linux and compile the webkit and tested the attached= patch with compiled webkit which is now working fine.

Below is the lin= k for reference regarding unload issue. They have provided test webkit rele= ase for Mac in below URL but for other platform we need to apply the patch = and compile the webkit until they provide webkit-releases for all platforms= .

https://github.com/annulen/webkit/issues/519

Do review it and let me know in case of any issue.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
= Blog: http://pgsn= ake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer=C2=A0
<= font color=3D"#3333FF">
=



--
Dave Page
VP, Chief Architect, Tools & Installers
Enterprise= DB: http://www.en= terprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake
=


--
Akshay Joshi
Principal So= ftware Engineer=C2=A0
<= b>



=

--
Dave Page
VP, Chief Architect, Tools &= amp; Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQ= L Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake




--
=
Dave Page
VP, Chief Architec= t, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise= PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake




--
Dave Page
VP, Chief Architect, Tools & Insta= llers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company<= br>
Blog: http= ://pgsnake.blogspot.com
Twitter: @pgsnake


<webkit_co= mpile_issue.patch>


--94eb2c0c0bce7dd946054f265cc1--