MIME-Version: 1.0
From: Neel Patel <neel.patel@enterprisedb.com>
Date: Mon, 8 Aug 2016 18:41:44 +0530
Message-ID: 
 <CACCA4P1HeN9YL1Lpo-PSL9EVU7+xHneEP_ShHSTRQOkZDpnofQ@mail.gmail.com>
Subject: [pgAdmin4][runtime][patch]: Runtime not working in all platform
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary=94eb2c082982802c5105398f28df
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--94eb2c082982802c5105398f28df
Content-Type: multipart/alternative; boundary=94eb2c082982802c4c05398f28dd

--94eb2c082982802c4c05398f28dd
Content-Type: text/plain; charset=UTF-8

Hi,

Please find attached patch file to fix the below issue.

*Issue:-*
Runtime was not working in all platform due to syntax error in javascript.
This issue was introduced due to below commit.

Prevent the user attempting to run external commands if the bin path is not
configured. Fixes #1177

f78024808e80fef67de1aef5c97d1756c6771c0e

It is working in browser but Qt's web engine is not able to handle the
error and goes into infinite loop of paint event which may crash the
pgAdmin4 application.

Can you please review and commit this patch ?

Thanks,
Neel Patel

--94eb2c082982802c4c05398f28dd
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>Please find attached patch file to =
fix the below issue.</div><div><br></div><div><b>Issue:-</b></div><div>Runt=
ime was not working in all platform due to syntax error in javascript.</div=
><div>This issue was introduced due to below commit.</div><div>


<p class=3D""><span class=3D""><span style=3D"font-size:12.8px">Prevent the=
 user attempting to run external commands if the bin path is not configured=
. Fixes #1177</span><br></span></p><p class=3D""><span class=3D"">f78024808=
e80fef67de1aef5c97d1756c6771c0e</span></p></div><div><br></div><div>It is w=
orking in browser but Qt&#39;s web engine is not able to handle the error a=
nd goes into infinite loop of paint event which may crash the pgAdmin4 appl=
ication.</div><div><br></div><div>Can you please review and commit this pat=
ch ?</div><div><br></div><div>Thanks,</div><div>Neel Patel</div></div>

--94eb2c082982802c4c05398f28dd--

--94eb2c082982802c5105398f28df
Content-Type: application/octet-stream; name="runtime_issue.patch"
Content-Disposition: attachment; filename="runtime_issue.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_irm1wjvg0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVtcGxhdGVzL2Jy
b3dzZXIvanMvYnJvd3Nlci5qcyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIvdGVt
cGxhdGVzL2Jyb3dzZXIvanMvYnJvd3Nlci5qcwppbmRleCA5NTUyOGIwLi44
OTEwMjQwIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3RlbXBs
YXRlcy9icm93c2VyL2pzL2Jyb3dzZXIuanMKKysrIGIvd2ViL3BnYWRtaW4v
YnJvd3Nlci90ZW1wbGF0ZXMvYnJvd3Nlci9qcy9icm93c2VyLmpzCkBAIC02
OTQsOCArNjk0LDggQEAgZnVuY3Rpb24ocmVxdWlyZSwgJCwgXywgUywgQm9v
dHN0cmFwLCBwZ0FkbWluLCBhbGVydGlmeSwgQ29kZU1pcnJvcikgewogICAg
ICAgfQogICAgIH0sCiAKLSAgICBnZXRfcHJlZmVyZW5jZShtb2R1bGUsIHBy
ZWZlcmVuY2VfbmFtZSkgewotICAgICAgcHJlZmVyZW5jZSA9IG51bGw7Cisg
ICAgZ2V0X3ByZWZlcmVuY2U6IGZ1bmN0aW9uIChtb2R1bGUsIHByZWZlcmVu
Y2VfbmFtZSkgeworICAgICAgdmFyIHByZWZlcmVuY2UgPSBudWxsOwogICAg
ICAgJC5hamF4KHsKICAgICAgICAgYXN5bmM6IGZhbHNlLAogICAgICAgICB1
cmw6ICJ7eyB1cmxfZm9yKCdwcmVmZXJlbmNlcy5wcmVmZXJlbmNlcycpIH19
IiArIi8iKyBtb2R1bGUgKyIvIisgcHJlZmVyZW5jZV9uYW1lLAo=

--94eb2c082982802c5105398f28df
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--94eb2c082982802c5105398f28df--