Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aGQf3-0000Hy-CR for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jan 2016 12:24:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aGQf2-0001JW-RK for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jan 2016 12:24:24 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aGQeo-00014N-Oa for pgadmin-hackers@postgresql.org; Tue, 05 Jan 2016 12:24:10 +0000 Received: from mail-yk0-x22f.google.com ([2607:f8b0:4002:c07::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aGQel-0006S0-7U for pgadmin-hackers@postgresql.org; Tue, 05 Jan 2016 12:24:09 +0000 Received: by mail-yk0-x22f.google.com with SMTP id a85so201867904ykb.1 for ; Tue, 05 Jan 2016 04:24:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=8HSeaGEYxCOOlSqXUMG8p7n/DkDqu1KAN/Zv6T/pC4s=; b=ns20FRisD8lsGft2/eWnc53a527mYU/S/W80EfsBmkTGz+icpVYFf51JFUQ0eXrv8H UAUIahC1vaiFWgQ7l2YfcPnGkk3MqGCjepYMuhOkb6Xvqs5QJEP+fanJG6OI4gtCamTa Mz2m09XwpeG6Exbhfabz7K6z83jfCIgOKr4qSaNPMBl9cJAE3uRfg0mqrTxKDFjHQu1M o7/lsHpa7gmfaImetCgt/2kVjUtkgpt5e1Xm8riQq+dyzaULg+VPZ1fOrWSKGrAZbVWg Bi2+GXWYfbWnKaQ1QzU9Iz5LMEdJsAD6oB/SBFGUjS4iKyXt67lA5CI6zTf6qZwyjbZM LSRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=8HSeaGEYxCOOlSqXUMG8p7n/DkDqu1KAN/Zv6T/pC4s=; b=Y82+dFiiQTwjKE0kffL/RTFaE1g3mbnJ1nBN78CZj/KEAZoOJ7a0txbdG5HSHY5a9t PnUf1EPoM2cf1bnGg9s/22qxItbz3e0JVW28b35W+FIdjajtf221Skxzno2WlVCddDFm Iw0cPICcIPXbbkHomQX+F+09L1TG7ea2goS015RYayJxM7FmYpPt+fnd48OHpdWnK/zo jntLxAemh5tejhBszhYwh14wHQS8bl1bKLF2W0i6EmrI9i5cSbXZbIdliOMIr6zJHOgT W9YNFO+1dv1mPV+16VZcl5iVt6Z5kwYU2C+1FfmrHwWaPB1f8MthUF+3lnvvwR1OmRnR Wd7w== X-Gm-Message-State: ALoCoQkZN1lHGxJaYaAYcSYs+90Ya1MRQ+skdPIjhSEXACKKQXKld1CcfO7LJyq4q7EKSyDs670k+wmRbOZjWt07sKfs/5/AN84FyPAXGEEk0UJtiW2//Mk= MIME-Version: 1.0 X-Received: by 10.129.85.88 with SMTP id j85mr69250445ywb.194.1451996646251; Tue, 05 Jan 2016 04:24:06 -0800 (PST) Received: by 10.37.202.75 with HTTP; Tue, 5 Jan 2016 04:24:06 -0800 (PST) In-Reply-To: References: <568BA29D.2070305@yandex.ru> Date: Tue, 5 Jan 2016 17:54:06 +0530 Message-ID: Subject: Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 From: Neel Patel To: Dave Page Cc: Nikolai Zhubr , pgadmin-hackers Content-Type: multipart/mixed; boundary=001a113f27e650e14d0528955089 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f27e650e14d0528955089 Content-Type: multipart/alternative; boundary=001a113f27e650e1450528955087 --001a113f27e650e1450528955087 Content-Type: text/plain; charset=UTF-8 Hi, Please find attached patch file with below fix. - Return value of the function will be displayed as "SETOF record" instead of "SETOF SETOF record" under SQL tab within properties window. Let me know for any comments. Thanks, Neel Patel On Tue, Jan 5, 2016 at 5:08 PM, Neel Patel wrote: > Hi Dave, > > Sure, I will look into this issue. > > Thanks, > Neel Patel > > On Tue, Jan 5, 2016 at 4:47 PM, Dave Page wrote: > >> Neel, can you look at this please? >> >> Thanks. >> >> On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr >> wrote: >> > Hi all, >> > >> > Running 1.22-rc1 now I observe that this commit has apparently still not >> > solved the issue in at least one place. That is: >> > >> > - "RETURNS SETOF record" is correctly displayed in SQL panel now. >> > >> > - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL >> tab >> > within the properties window (effectively preventing set-returning >> function >> > to be changed in any way through the properties window). >> > >> > >> > Thank you, >> > Nikolai >> > >> > 12.10.2015 5:33, Ashesh Vashi: >> >> >> >> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use >> >> pg_get_function_result(..) function to identify the return type of the >> >> function, hence - we don't need to add SETOF keyword explicitly, when a >> >> function returns set of records. >> >> >> >> Branch >> >> ------ >> >> master >> >> >> >> Details >> >> ------- >> >> >> >> >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e531 >> >> >> >> Modified Files >> >> -------------- >> >> pgadmin/schema/pgFunction.cpp | 2 -- >> >> 1 file changed, 2 deletions(-) >> >> >> >> >> > >> > >> > >> > -- >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> > To make changes to your subscription: >> > http://www.postgresql.org/mailpref/pgadmin-hackers >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a113f27e650e1450528955087 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Please find attached patch file wit= h below fix.
=C2=A0- Return value of the function will be display= ed as "SETOF record" instead of "SETOF SETOF record" un= der SQL tab within properties window.

Let me know = for any comments.

Thanks,
Neel Patel

On Tue, J= an 5, 2016 at 5:08 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi = Dave,

Sure, I will look into this issue.

<= /div>
Thanks,
Neel Patel

On= Tue, Jan 5, 2016 at 4:47 PM, Dave Page <dpage@pgadmin.org> = wrote:
Neel, can you look at this please?=

Thanks.

On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <n-a-zhubr@yandex.ru> wrote:
> Hi all,
>
> Running 1.22-rc1 now I observe that this commit has apparently still n= ot
> solved the issue in at least one place. That is:
>
> - "RETURNS SETOF record" is correctly displayed in SQL panel= now.
>
> - "RETURNS SETOF SETOF record" is still erroneously displaye= d under SQL tab
> within the properties window (effectively preventing set-returning fun= ction
> to be changed in any way through the properties window).
>
>
> Thank you,
> Nikolai
>
> 12.10.2015 5:33, Ashesh Vashi:
>>
>> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use=
>> pg_get_function_result(..) function to identify the return type of= the
>> function, hence - we don't need to add SETOF keyword explicitl= y, when a
>> function returns set of records.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> http://git.postgresql.org/gitweb?p=3Dpgadmin3.git;a=3Dcom= mitdiff;h=3D9d7596dc552cf9315d4aa83eafe19db1acf7e531
>>
>> Modified Files
>> --------------
>> pgadmin/schema/pgFunction.cpp |=C2=A0 =C2=A0 2 --
>> 1 file changed, 2 deletions(-)
>>
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-ha= ckers



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a113f27e650e1450528955087-- --001a113f27e650e14d0528955089 Content-Type: application/octet-stream; name="function_sql_setof.patch" Content-Disposition: attachment; filename="function_sql_setof.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ij1d7w2c0 ZGlmZiAtLWdpdCBhL3BnYWRtaW4vZGxnL2RsZ0Z1bmN0aW9uLmNwcCBiL3Bn YWRtaW4vZGxnL2RsZ0Z1bmN0aW9uLmNwcAppbmRleCAxMTlhOTJjLi5hMTMz ZGY3IDEwMDY0NAotLS0gYS9wZ2FkbWluL2RsZy9kbGdGdW5jdGlvbi5jcHAK KysrIGIvcGdhZG1pbi9kbGcvZGxnRnVuY3Rpb24uY3BwCkBAIC05MzIsOSAr OTMyLDYgQEAgd3hTdHJpbmcgZGxnRnVuY3Rpb246OkdldFNxbCgpCiAJCWlm ICghaXNQcm9jZWR1cmUpCiAJCXsKIAkJCXNxbCArPSB3eFQoIiBSRVRVUk5T ICIpOwotCQkJaWYgKGNoa1NldG9mLT5HZXRWYWx1ZSgpICYmICFjYlJldHVy bnR5cGUtPkdldFZhbHVlKCkuU3RhcnRzV2l0aCh3eFQoIlRBQkxFIikpKQot CQkJCXNxbCArPSB3eFQoIlNFVE9GICIpOwotCiAJCQlzcWwgKz0gY2JSZXR1 cm50eXBlLT5HZXRWYWx1ZSgpOwogCQl9CiAK --001a113f27e650e14d0528955089 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a113f27e650e14d0528955089--