Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aLCxX-0000g0-02 for pgadmin-support@arkaria.postgresql.org; Mon, 18 Jan 2016 16:47:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aLCxW-0002iu-J6 for pgadmin-support@arkaria.postgresql.org; Mon, 18 Jan 2016 16:47:14 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aLCxW-0002ig-2j for pgadmin-support@postgresql.org; Mon, 18 Jan 2016 16:47:14 +0000 Received: from mail-yk0-x22e.google.com ([2607:f8b0:4002:c07::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aLCxN-0006sO-FF for pgadmin-support@postgresql.org; Mon, 18 Jan 2016 16:47:12 +0000 Received: by mail-yk0-x22e.google.com with SMTP id a85so541049473ykb.1 for ; Mon, 18 Jan 2016 08:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=R0Gfl+kqPGaLICAmn09Pm948eZCpfelotK/wbPfZfkY=; b=Mo05P2nLtN46/Bs9OAXSsoOZSrsIt8i0K54QnhbTiqAbEq3HBqvDMhE2OYsSJ3EiA2 kYrqtIThCPJAZQj1ggJw2ITv1ADTwQcQ8qgo/IZbGxf2ffY+5ecwX2KYHAqA8GzbGlMd VoaEb6rmlt6R5eIKeR0iVxD1tyJnvEPc7MCN986LmY1/VrxrnA5frxsSJRUHjydaDrRb bv99Vcqcrf+wJiocvisdf6J2cAP8xg/0yxQrX55HlY6Ysj9VqpSFnYvTByCrUbmFOrJF k47nCz6YfrLgLvkf6A3MkfkYQBJIPUl8pQCQSTuAkDw86uszl8AWtgob0bctTvgK9ODv koKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=R0Gfl+kqPGaLICAmn09Pm948eZCpfelotK/wbPfZfkY=; b=Ee76/d/fvcPs55FUeP9LtceJZgiWV5SaDVGZkk2LyVNKh1D8vycyjB7hiOoqYLf0jc dXWeQqi8QDbJTw3e/7bTyURV6pnitUKicoXkebIXBtqWKgxCweERVQmTEMLA92JIN6FK bFXQOjJYt5xqz0rf4iIZffoO5C/ZK1mcoYk55ES9WCoz39Z6lhuGPyzaj+xqGGjEoCRp M89ZPotpHsJ7e8XySjhQ4GDMSf/9z6N0QsCCHQJzJWKFXzGAAdgsZs12IoXHdBKVbIAh fZbePvnFv+26m+gb926r6uU6qyx4WdZFI+G0qlMKc9HEXws8SFghapQcK0nPr31naZpV lsGA== X-Gm-Message-State: ALoCoQlytwBYi83uEYTtysy39T4laPfuITMPr2/e6dD9qs4UyM4DrgKiFcyF2k0Z6xSCFtrc4VR6Bg/9MjGwDHromxcmi0hoUi6QyISCtT3naXT4GnhJctE= MIME-Version: 1.0 X-Received: by 10.129.137.193 with SMTP id z184mr17126254ywf.257.1453135624236; Mon, 18 Jan 2016 08:47:04 -0800 (PST) Received: by 10.37.202.75 with HTTP; Mon, 18 Jan 2016 08:47:04 -0800 (PST) In-Reply-To: References: Date: Mon, 18 Jan 2016 22:17:04 +0530 Message-ID: Subject: Re: [pgAdmin4] - Desktop runtime patch From: Neel Patel To: Dave Page Cc: pgadmin-hackers , pgAdmin Support Content-Type: multipart/alternative; boundary=94eb2c064ab6b1a23c05299e807e X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-support Precedence: bulk Sender: pgadmin-support-owner@postgresql.org --94eb2c064ab6b1a23c05299e807e Content-Type: text/plain; charset=UTF-8 Thanks Dave. I will test on Windows and Linux and keep you updated. Thanks, Neel Patel On Mon, Jan 18, 2016 at 8:07 PM, Dave Page wrote: > Thanks Neel. I've committed this with various minor tweaks, mostly > around the tab button text and sizing. > > Please test on Windows and Linux to ensure I didn't inadvertently > break anything. Mac seems fine here. > > On Fri, Jan 15, 2016 at 2:06 PM, Neel Patel > wrote: > > Hi, > > > > Please find the attached patch file for the below fix when pgAdmin 4 run > in > > desktop mode. > > > > Added functionality to open different website link and load the website > data > > to different tab. To achieve this, new customized QTabWidget and QWebView > > are added to render the data to WebView widget. All the widgets (New Tab, > > WebViewWinodw, and QToolButton) are added dynamically. QToolButton is > used > > to traverse back and forward to web document opened in WebViewWindow. > > > > Introduced the New class called WebViewWindow which is derived from > > QWebView. Each tab of the QTabWidget contains the instance of > WebViewWindow > > class. WebViewWindow class is useful to display the web document. > > > > Introduced New class called TabWindow which is derived from QTabWidget. > This > > class is useful to achieve following functionality. > > - Customize the close button of tabbar so that it can only be visible > > other then main pgAdmin 4 window. > > - Enable/Disable the toolbutton added left side of tabbar depending on > > the web history traversed by the user in WebViewWindow. > > - Set the tooltip text of the tabbar depending on the title change > event > > of WebViewWindow class. > > > > Modified the Qt project file to support the both the version of python 2 > and > > python 3. > > > > Qt5 is recommended to test pgAdmin4 in dektop mode. > > > > Attached patch is applied and tested on Linux, do let us know for any > > comments/issues. > > > > Thanks, > > Neel Patel > > > > > > -- > > Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-support > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c064ab6b1a23c05299e807e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks Dave.
I will test on Windows and Linux and keep= you updated.

Thanks,
Neel Patel

On Mon, Jan 1= 8, 2016 at 8:07 PM, Dave Page <dpage@pgadmin.org> wrote:
=
Thanks Neel. I've committed this with va= rious minor tweaks, mostly
around the tab button text and sizing.

Please test on Windows and Linux to ensure I didn't inadvertently
break anything. Mac seems fine here.

On Fri, Jan 15, 2016 at 2:06 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch file for the below fix when pgAdmin 4 r= un in
> desktop mode.
>
> Added functionality to open different website link and load the websit= e data
> to different tab. To achieve this, new customized QTabWidget and QWebV= iew
> are added to render the data to WebView widget. All the widgets (New T= ab,
> WebViewWinodw, and QToolButton) are added dynamically. QToolButton is = used
> to traverse back and forward to web document opened in WebViewWindow.<= br> >
> Introduced the New class called WebViewWindow which is derived from > QWebView. Each tab of the QTabWidget contains the instance of WebViewW= indow
> class. WebViewWindow class is useful to display the web document.
>
> Introduced New class called TabWindow which is derived from QTabWidget= . This
> class is useful to achieve following functionality.
>=C2=A0 =C2=A0- Customize the close button of tabbar so that it can only= be visible
> other then main pgAdmin 4 window.
>=C2=A0 =C2=A0- Enable/Disable the toolbutton added left side of tabbar= =C2=A0 depending on
> the web history traversed by the user in WebViewWindow.
>=C2=A0 =C2=A0- Set the tooltip text of the tabbar depending on the titl= e change event
> of WebViewWindow class.
>
> Modified the Qt project file to support the both the version of python= 2 and
> python 3.
>
> Qt5 is recommended to test pgAdmin4 in dektop mode.
>
> Attached patch is applied and tested on Linux, do let us know for any<= br> > comments/issues.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-su= pport
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--94eb2c064ab6b1a23c05299e807e--