Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aGPwa-0006jl-Nt for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jan 2016 11:38:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aGPwa-0002rM-Ai for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jan 2016 11:38:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aGPwM-0002ci-Jy for pgadmin-hackers@postgresql.org; Tue, 05 Jan 2016 11:38:14 +0000 Received: from mail-yk0-x235.google.com ([2607:f8b0:4002:c07::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aGPwI-0000QR-Kd for pgadmin-hackers@postgresql.org; Tue, 05 Jan 2016 11:38:14 +0000 Received: by mail-yk0-x235.google.com with SMTP id x67so278004049ykd.2 for ; Tue, 05 Jan 2016 03:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=PSk9A0fXIelBtINw5VEPy5u5obLZ46vyr2h/imXZR08=; b=JwdSTYLMi4Iq+neCQABkb6s98rxyFM0UcPmHnldWLRvDQcc0CNoYpS1xpVbqVVSC7X 2ARdplIvAqIfUuaCL5kvwWhdyWm5N47L3PeJKa6BxW37aXUcowVMIVhN2tI6p76yYLF5 D6PLJiB/3bAcod7mAe1ZMG+Snnk9rDwsj6bAjOJxFXH02HgnZ4jR3g3/BEvrOn9FTgcc /y9YEEpsYZixRjZKtad9a4QO2Bv1nHNbwtdMRDsGzJ0Dkdn6URdW2opHI/PSEejAS91c Jrzf5PXsiDGyRobkjbEmWyI/4UwIb/g5Z2yEt7qYh78/YmsJVG2dqdAqhvdo+Z/INunE Uyfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=PSk9A0fXIelBtINw5VEPy5u5obLZ46vyr2h/imXZR08=; b=kGpb1PQ3mRkJCu9irTmu4Ilpx3L4gqyjWGdDYn117UTI38jSTK40X286Cu6tMiVnUI aPWiOofpioLqfyckYqEKjj6hBfjaCpegTQl3nV6rn40g3cksHy1VjXk614+tLfZ4DYIn UICvp/QwlwQCkT70H9UIprqar8Or202//jBi9PZjLuLlbPjjGIFtqVXqb2696wyRyCAL h9Irex/daNCw5dPpihlB8BpyaA7Yn2kTdjaX0Mk4VIuo0T5MUFlYa+xU22deDiNdXk/l DwzQ5nWzXqTUxAQApgJ+Y4BrD6lprDkRgyHBbja0FQ2cfMaV7lbkhqlO3sPxm0Mpsg7T IIvw== X-Gm-Message-State: ALoCoQlYjc2Ed2QKVSkKLbm1O/7Cgzo1Ubg41wCf6gVgiiyVNm2+WK0HM4tbrgeioQ7MXf+eka46cAMBehO3z70AOyNq9xYs/7INjSvBnwB4SqOiZICexTY= MIME-Version: 1.0 X-Received: by 10.129.130.195 with SMTP id s186mr74756652ywf.257.1451993888634; Tue, 05 Jan 2016 03:38:08 -0800 (PST) Received: by 10.37.202.75 with HTTP; Tue, 5 Jan 2016 03:38:08 -0800 (PST) In-Reply-To: References: <568BA29D.2070305@yandex.ru> Date: Tue, 5 Jan 2016 17:08:08 +0530 Message-ID: Subject: Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 From: Neel Patel To: Dave Page Cc: Nikolai Zhubr , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c07efa6f31635052894ab0d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c07efa6f31635052894ab0d Content-Type: text/plain; charset=UTF-8 Hi Dave, Sure, I will look into this issue. Thanks, Neel Patel On Tue, Jan 5, 2016 at 4:47 PM, Dave Page wrote: > Neel, can you look at this please? > > Thanks. > > On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr > wrote: > > Hi all, > > > > Running 1.22-rc1 now I observe that this commit has apparently still not > > solved the issue in at least one place. That is: > > > > - "RETURNS SETOF record" is correctly displayed in SQL panel now. > > > > - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL > tab > > within the properties window (effectively preventing set-returning > function > > to be changed in any way through the properties window). > > > > > > Thank you, > > Nikolai > > > > 12.10.2015 5:33, Ashesh Vashi: > >> > >> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use > >> pg_get_function_result(..) function to identify the return type of the > >> function, hence - we don't need to add SETOF keyword explicitly, when a > >> function returns set of records. > >> > >> Branch > >> ------ > >> master > >> > >> Details > >> ------- > >> > >> > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e531 > >> > >> Modified Files > >> -------------- > >> pgadmin/schema/pgFunction.cpp | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> > > > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c07efa6f31635052894ab0d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

Sure, I will look into this is= sue.

Thanks,
Neel Patel

On Tue, Jan 5, 2016 at= 4:47 PM, Dave Page <dpage@pgadmin.org> wrote:
Neel, can you look at this please?

Thanks.

On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <n-a-zhubr@yandex.ru> wrote:
> Hi all,
>
> Running 1.22-rc1 now I observe that this commit has apparently still n= ot
> solved the issue in at least one place. That is:
>
> - "RETURNS SETOF record" is correctly displayed in SQL panel= now.
>
> - "RETURNS SETOF SETOF record" is still erroneously displaye= d under SQL tab
> within the properties window (effectively preventing set-returning fun= ction
> to be changed in any way through the properties window).
>
>
> Thank you,
> Nikolai
>
> 12.10.2015 5:33, Ashesh Vashi:
>>
>> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use=
>> pg_get_function_result(..) function to identify the return type of= the
>> function, hence - we don't need to add SETOF keyword explicitl= y, when a
>> function returns set of records.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> http://git.postgresql.org/gitweb?p=3Dpgadmin3.git;a=3Dcom= mitdiff;h=3D9d7596dc552cf9315d4aa83eafe19db1acf7e531
>>
>> Modified Files
>> --------------
>> pgadmin/schema/pgFunction.cpp |=C2=A0 =C2=A0 2 --
>> 1 file changed, 2 deletions(-)
>>
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-ha= ckers



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--94eb2c07efa6f31635052894ab0d--