MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELf-QTMAgNkTT8AsRwJ38Jn_1BSFRV_G5ZmcHnrKmPsTog@mail.gmail.com>
References: 
 <CAFOhELf-n8mM4h8RZuqxUs-Z+f97N6Ux5KT6aoAdWFiHVVURyw@mail.gmail.com>
 <CAFOhELf-QTMAgNkTT8AsRwJ38Jn_1BSFRV_G5ZmcHnrKmPsTog@mail.gmail.com>
Date: Wed, 20 Jan 2016 12:50:44 +0530
Message-ID: 
 <CACCA4P1caumXOrpEXrrETMuNGj3G3ctY-PN9=V6GUPF=dTBnWg@mail.gmail.com>
Subject: Re: pgAdmin4 PATCH: Domain Module
From: Neel Patel <neel.patel@enterprisedb.com>
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a114fbcfc0305260529bed3ad
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a114fbcfc0305260529bed3ad
Content-Type: text/plain; charset=UTF-8

Hi Khushboo,

While applying the patch file, we are getting below warnings.

#########################################
domains (1).patch:1340: trailing whitespace.
          oid: undefined,
domains (1).patch:1483: trailing whitespace.
    (nspname = 'pg_catalog' AND EXISTS
domains (1).patch:1487: trailing whitespace.
    OR (nspname = 'information_schema' AND EXISTS
domains (1).patch:1489: trailing whitespace.
    OR (nspname LIKE '_%' AND EXISTS
domains (1).patch:1642: trailing whitespace.
 (select 1 from pg_class where relnamespace=typnamespace and relname =
typname and relkind != 'c') AND (typname not like '_%' OR NOT EXISTS
(select 1 from pg_class where relnamespace=typnamespace and relname =
substring(typname from 2)::name and relkind != 'c'))
warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.
#########################################

Can you please remove the whitespace and regenerate the patch ?

Thanks,
Neel Patel

On Wed, Jan 20, 2016 at 12:37 PM, Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Resending patch with binary option.
>
> On Wed, Jan 20, 2016 at 10:18 AM, Khushboo Vashi <
> khushboo.vashi@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find attached patch for the Domain Module.
>>
>> The patch will be modified after Types module implementation as we need
>> to populate Base Type  and some Type related validations from the Types
>> module.
>>
>> Please review it and let me know the feedback.
>>
>> Thanks,
>> Khushboo
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--001a114fbcfc0305260529bed3ad
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Khushboo,<div><br></div><div>While applying the patch f=
ile, we are getting below warnings.</div><div><br></div><div>##############=
###########################</div><div><div>domains (1).patch:1340: trailing=
 whitespace.</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 oid: undefined,=
=C2=A0</div><div>domains (1).patch:1483: trailing whitespace.</div><div>=C2=
=A0 =C2=A0 (nspname =3D &#39;pg_catalog&#39; AND EXISTS=C2=A0</div><div>dom=
ains (1).patch:1487: trailing whitespace.</div><div>=C2=A0 =C2=A0 OR (nspna=
me =3D &#39;information_schema&#39; AND EXISTS=C2=A0</div><div>domains (1).=
patch:1489: trailing whitespace.</div><div>=C2=A0 =C2=A0 OR (nspname LIKE &=
#39;_%&#39; AND EXISTS=C2=A0</div><div>domains (1).patch:1642: trailing whi=
tespace.</div><div>=C2=A0(select 1 from pg_class where relnamespace=3Dtypna=
mespace and relname =3D typname and relkind !=3D &#39;c&#39;) AND (typname =
not like &#39;_%&#39; OR NOT EXISTS (select 1 from pg_class where relnamesp=
ace=3Dtypnamespace and relname =3D substring(typname from 2)::name and relk=
ind !=3D &#39;c&#39;))=C2=A0</div><div>warning: squelched 4 whitespace erro=
rs</div><div>warning: 9 lines add whitespace errors.</div></div><div>######=
###################################<br></div><div><br></div><div>Can you pl=
ease remove the whitespace and regenerate the patch ?</div><div><br></div><=
div>Thanks,</div><div>Neel Patel</div></div><div class=3D"gmail_extra"><br>=
<div class=3D"gmail_quote">On Wed, Jan 20, 2016 at 12:37 PM, Khushboo Vashi=
 <span dir=3D"ltr">&lt;<a href=3D"mailto:khushboo.vashi@enterprisedb.com" t=
arget=3D"_blank">khushboo.vashi@enterprisedb.com</a>&gt;</span> wrote:<br><=
blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px=
 #ccc solid;padding-left:1ex"><div dir=3D"ltr">Resending patch with binary =
option.<br></div><div class=3D"HOEnZb"><div class=3D"h5"><div class=3D"gmai=
l_extra"><br><div class=3D"gmail_quote">On Wed, Jan 20, 2016 at 10:18 AM, K=
hushboo Vashi <span dir=3D"ltr">&lt;<a href=3D"mailto:khushboo.vashi@enterp=
risedb.com" target=3D"_blank">khushboo.vashi@enterprisedb.com</a>&gt;</span=
> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo=
rder-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><div><div>=
<div>Hi,<br><br></div>Please find attached patch for the Domain Module.<br>=
<br></div>The patch will be modified after Types module implementation as w=
e need to populate Base Type=C2=A0 and some Type related validations from t=
he Types module.<br><br></div><div>Please review it and let me know the fee=
dback.<br></div><div><br></div>Thanks,<br></div>Khushboo<br></div>
</blockquote></div><br></div>
</div></div><br><br>
--<br>
Sent via pgadmin-hackers mailing list (<a href=3D"mailto:pgadmin-hackers@po=
stgresql.org">pgadmin-hackers@postgresql.org</a>)<br>
To make changes to your subscription:<br>
<a href=3D"http://www.postgresql.org/mailpref/pgadmin-hackers" rel=3D"noref=
errer" target=3D"_blank">http://www.postgresql.org/mailpref/pgadmin-hackers=
</a><br>
<br></blockquote></div><br></div>

--001a114fbcfc0305260529bed3ad--