Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d81kt-0005Ki-1x for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 09:48:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d81ks-0004BC-Kn for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 May 2017 09:48:30 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d81kr-0004B0-N0 for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 09:48:29 +0000 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d81ko-0000nW-3U for pgadmin-hackers@postgresql.org; Tue, 09 May 2017 09:48:28 +0000 Received: by mail-pf0-x22a.google.com with SMTP id v14so46787691pfd.2 for ; Tue, 09 May 2017 02:48:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=D/qNUyI2ytbLn5mFwWohNEFB5A8862yXRGKFW+gw7DI=; b=L3S7hV8xdUbjsPoWbyuaHW9tp44SOgFbDYjlOkHMxOXJtQ0o8hXb+keQ3KX19Y0G5u F0Ts8JRY+X3JVrHbrJfGwWuTlZawWtYV0K9BAp8gT5m10VlosKLmtnC1EbNxcR3ozf9Y XlE+JntZwnMPDyte0rbjfT4v90rlP2m7Eo7t4KbWP/UNPGsrnaOqFdS2keu0VMpzUpM1 CmzF68r+JrS7GitpYBzd9vegILAxGKTJs3eEnqMs0aYbVg+C7bYuV+hyub4YKaNRofyw jVv8G0rHHSdxSHFFE1+XAIHyLQ5GCcm/XDxKmf+dtvmG1gh0NvkLo5xaoI7zg3bXxSBI CBIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=D/qNUyI2ytbLn5mFwWohNEFB5A8862yXRGKFW+gw7DI=; b=GfZ3ayAu1UJEdbsD5MmOKxJDDaisth0Xt7bUEtIwyQrC9RbjHv5RiPAiZ0zUNvfsa2 igbXYvs4p7x15X9ahLO7vOUHbV/gHERo+CPhRBbvTrHTLBdvQRvUo3hXacvLjcDk2ry6 RdHrtupagzxrjjQ5EHPxXwyALt66DRe7FTDw07LiRorfBd7sDDNmoUsZJ5x8PLyPN0cn yH9FN02whcoamJR1c2ZFWCh+XlvFzF6Kq1nQhrCCYtXxf8t8MxKfmyfV0abpckKIyAwz Hq/gi5nKpzWCTFyycQ3xSci2N+l9aBleDtIQg1J2HP6eLh0D7nIdQjNa3v/gOLYWZICc h+2g== X-Gm-Message-State: AODbwcA/Q8QlYDYvVMJaXJoW2NLi2vkDYj92y6+86sviDgTTbv6IuaJX JUkvwLDTNDuX7EDYvKRzXQyCfMzDMKeo X-Received: by 10.98.87.87 with SMTP id l84mr1872134pfb.173.1494323304616; Tue, 09 May 2017 02:48:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.137.16 with HTTP; Tue, 9 May 2017 02:48:24 -0700 (PDT) In-Reply-To: References: From: Neel Patel Date: Tue, 9 May 2017 15:18:24 +0530 Message-ID: Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1147d012c07689054f144167 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1147d012c07689054f144167 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Dave, On Tue, May 9, 2017 at 3:08 PM, Dave Page wrote: > Hi > > On Tue, May 9, 2017 at 10:28 AM, Neel Patel > wrote: > >> Hi Dave, >> >> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' >> related compilation error in Qt4. BUT >> >> Below compilation error is coming because we have not applied the latest >> patch of webkit which was fixed in annulen/webkit repo which was raised = at >> below path. >> >> https://github.com/annulen/webkit/issues/519 >> >> BrowserWindow.cpp:842:59: error: =E2=80=98RequestClose=E2=80=99 is not a= member of >> =E2=80=98QWebPage=E2=80=99 >> webviewPtr->page()->triggerAc >> tion(QWebPage::RequestClose); >> >> To fix the above compilation error currently we have two solution. >> >> - Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) = . >> - Comment the below line temporary for compilation until we get the >> releases from annulen/webkit. >> >> webviewPtr->page()->triggerAction(QWebPage::RequestClose)= ; >> >> Other compilation issues, (Me and Akshay) will fix and commit it but nee= d >> your input on above issue. >> > > For various reasons we need to retain compatibility with the previous > versions of qtwebkit. Can we detect at build time what version we have, a= nd > enable/disable that code as appropriate? > Make sense. We will check if we are getting any webkit version in application or not and update you. > >> >> Thanks, >> Neel Patel >> >> On Tue, May 9, 2017 at 2:02 PM, Dave Page >> wrote: >> >>> It's running CentOS 7.3, with packages from EPEL: >>> >>> [dpage@jenkins ~]$ rpm -qa |grep qt >>> qt5-qtbase-common-5.6.1-10.el7.noarch >>> qt5-qtbase-devel-5.6.1-10.el7.x86_64 >>> qt-4.8.5-13.el7.x86_64 >>> qt5-qtbase-5.6.1-10.el7.x86_64 >>> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 >>> qt5-qtwebchannel-5.6.1-10.el7.x86_64 >>> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64 >>> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64 >>> qt-devel-4.8.5-13.el7.x86_64 >>> qt-settings-19-23.5.el7.centos.noarch >>> qt5-qtbase-gui-5.6.1-10.el7.x86_64 >>> qt5-qtlocation-5.6.1-10.el7.x86_64 >>> qt5-qtwebsockets-5.6.1-10.el7.x86_64 >>> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64 >>> qtwebkit-2.3.4-6.el7.x86_64 >>> qt3-3.3.8b-51.el7.x86_64 >>> qt5-qtdeclarative-5.6.1-10.el7.x86_64 >>> qt5-rpm-macros-5.6.1-10.el7.noarch >>> qtwebkit-devel-2.3.4-6.el7.x86_64 >>> qt-x11-4.8.5-13.el7.x86_64 >>> qt5-qtsensors-5.6.1-10.el7.x86_64 >>> >>> On Tue, May 9, 2017 at 9:28 AM, Neel Patel >>> wrote: >>> >>>> Hi Dave, >>>> >>>> Yes, It looks like compilation fails on Qt4. We will fix this issue bu= t >>>> which version of Qt4 we are using in Jenkins ? >>>> >>>> Thanks, >>>> Neel Patel >>>> >>>> On Tue, May 9, 2017 at 1:56 PM, Dave Page >>>> wrote: >>>> >>>>> >>>>> >>>>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page >>>>> > wrote: >>>>>> >>>>>>> This appears to have made Jenkins get all angry and red :-( >>>>>>> >>>>>>> https://jenkins.pgadmin.org/ >>>>>>> >>>>>> >>>>>> We(Neel and I) have tested it and working fine. >>>>>> >>>>> >>>>> It clearly doesn't compile on QT4. Please review the Jenkins logs. >>>>> >>>>> >>>>>> >>>>>>> >>>>>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi < >>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Thanks patch applied. >>>>>>>> >>>>>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Akshay, could you review this please? >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel < >>>>>>>>> neel.patel@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> Please find attached patch file with the fix of RM #2328 - >>>>>>>>>> [Runtime]: Unable to launch query tool and debugger in new brows= er tab. >>>>>>>>>> >>>>>>>>>> I have used Qt 5.8 with webkit mentioned in below URL. >>>>>>>>>> >>>>>>>>>> https://github.com/annulen/webkit/releases >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> As there was a bug in QWebKit regarding "unload" event. We have >>>>>>>>>> raised and also they have provided patch file to fix this issue.= I have >>>>>>>>>> applied the patch in linux and compile the webkit and tested the= attached >>>>>>>>>> patch with compiled webkit which is now working fine. >>>>>>>>>> >>>>>>>>>> Below is the link for reference regarding unload issue. They hav= e >>>>>>>>>> provided test webkit release for Mac in below URL but for other = platform we >>>>>>>>>> need to apply the patch and compile the webkit until they provid= e >>>>>>>>>> webkit-releases for all platforms. >>>>>>>>>> >>>>>>>>>> https://github.com/annulen/webkit/issues/519 >>>>>>>>>> >>>>>>>>>> Do review it and let me know in case of any issue. >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Neel Patel >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>>>> To make changes to your subscription: >>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Akshay Joshi* >>>>>>>> *Principal Software Engineer * >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> VP, Chief Architect, Tools & Installers >>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Akshay Joshi* >>>>>> *Principal Software Engineer * >>>>>> >>>>>> >>>>>> >>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> VP, Chief Architect, Tools & Installers >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> VP, Chief Architect, Tools & Installers >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >> >> > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > --001a1147d012c07689054f144167 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

On Tue, May 9, 2017 at 3:08 PM, Dave Page <dave.page@ente= rprisedb.com> wrote:
Hi

= On Tue, May 9, 2017 at 10:28 AM, Neel Patel <ne= el.patel@enterprisedb.com> wrote:
Hi Dave,

Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar&#= 39; related compilation error in Qt4. BUT

Below co= mpilation error is coming because we have not applied the latest patch of w= ebkit which was fixed in annulen/webkit repo which was raised at below path= .


BrowserWindow.cpp:842:59: error: =E2=80= =98RequestClose=E2=80=99 is not a member of =E2=80=98QWebPage=E2=80=99
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0webviewPtr->page()->triggerAction(QWebPage:= :RequestClose);

To fix the above compilation= error currently we have two solution.
  • Apply the given pa= tch in webkit ( qwebpage.cpp & qwebpage.h file ) .
  • Comment the = below line temporary for compilation until we get the releases from annulen= /webkit.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0webviewPtr->page()->triggerAction(QWebPage::RequestClose);

Other compilation issues, (Me and Akshay) = will fix and commit it but need your input on above issue.

For various reasons we need to retain co= mpatibility with the previous versions of qtwebkit. Can we detect at build = time what version we have, and enable/disable that code as appropriate?
=C2=A0
Make sense.=C2=A0 We= will check if we are getting any webkit version in application or not and = update you.

=C2=A0

Thanks,
Neel Patel

On Tue, May 9, 2017 at 2:= 02 PM, Dave Page <dave.page@enterprisedb.com> wrote= :
It's running CentO= S 7.3, with packages from EPEL:

[dpage@jenkins ~]$ = rpm -qa |grep qt
qt5-qtbase-common-5.6.1-10.el7.noarch
=
qt5-qtbase-devel-5.6.1-10.el7.x86_64
qt-4.8.5-13.el7.x8= 6_64
qt5-qtbase-5.6.1-10.el7.x86_64
qt5-qtxmlpatterns-5= .6.1-10.el7.x86_64
qt5-qtwebchannel-5.6.1-10.el7.x86_64=
qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
qt5-qt= declarative-devel-5.6.1-10.el7.x86_64
qt-devel-4.8.5-13.el7.= x86_64
qt-settings-19-23.5.el7.centos.noarch
qt5-q= tbase-gui-5.6.1-10.el7.x86_64
qt5-qtlocation-5.6.1-10.el7.x8= 6_64
qt5-qtwebsockets-5.6.1-10.el7.x86_64
qt5= -qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64
qtwebkit-2.3.4= -6.el7.x86_64
qt3-3.3.8b-51.el7.x86_64
qt5-qtdeclarativ= e-5.6.1-10.el7.x86_64
qt5-rpm-macros-5.6.1-10.el7.noarch
qtwebkit-devel-2.3.4-6.el7.x86_64
qt-x11-4.8.5-13.e= l7.x86_64
qt5-qtsensors-5.6.1-10.el7.x86_64

On Tue, May 9, 2017 at 9:28 AM, Neel Pat= el <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Yes, I= t looks like compilation fails on Qt4. We will fix this issue but which ver= sion of Qt4 we are using in Jenkins ?

Thanks,
Neel Patel
=
On Tue, May 9, 2017 at 1:56 PM, Dave Page <dave.page@enterprisedb.com> wrote:


On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi
<= br>
On Tue, May 9, 2017 at 1:42 PM, Dave Pa= ge <dave.page@enterprisedb.com> wrote:
This appears to have made Jenkins get all angry an= d red :-(

=
=C2=A0 =C2=A0We(Neel and I) have tested it and workin= g fine.=C2=A0=C2=A0

It clearly doesn't compile on QT4. Please review the Jenkins lo= gs.
=C2=A0

=

On Tue, May 9, 2017 at 8:39 AM, Aksh= ay Joshi <akshay.joshi@enterprisedb.com> wr= ote:
Thanks patch applied.

On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage@pgadmin.org>= ; wrote:
Akshay, could you revi= ew this please?

Thanks.

On Fri, May 5, 2017 at 11:53 AM, Neel Patel = <neel.p= atel@enterprisedb.com> wrote:
Hi,
Please find attached patch file with the fix of RM #2328 -= [Runtime]: Unable to launch query tool and debugger in new browser tab.

I have used Qt 5.8 w= ith webkit mentioned in below URL.


As there was a = bug in QWebKit regarding "unload" event. We have raised and also = they have provided patch file to fix this issue. I have applied the patch i= n linux and compile the webkit and tested the attached patch with compiled = webkit which is now working fine.

=
Below is the link for reference regar= ding unload issue. They have provided test webkit release for Mac in below = URL but for other platform we need to apply the patch and compile the webki= t until they provide webkit-releases for all platforms.


Do review it and = let me know in case of any issue.

Thanks,
Neel Patel


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




-= -
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

En= terpriseDB UK: ht= tp://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
=
Principal Softwa= re Engineer=C2=A0

<= br>



--
Dave Page
VP, Chief Architect, = Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Po= stgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake



--
Akshay = Joshi
Principal Software Engineer=C2=A0
=
=



--
Dave Page
VP, = Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
= The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake




--
=
Dave Page
VP, Ch= ief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
Th= e Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake




--
Dave Page
VP, Chief Arch= itect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterp= rise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

--001a1147d012c07689054f144167--