Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aLkjR-00020Z-AR for pgadmin-hackers@arkaria.postgresql.org; Wed, 20 Jan 2016 04:50:57 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aLkjQ-00067W-Tz for pgadmin-hackers@arkaria.postgresql.org; Wed, 20 Jan 2016 04:50:56 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aLkjQ-00067L-Dc for pgadmin-hackers@postgresql.org; Wed, 20 Jan 2016 04:50:56 +0000 Received: from mail-yk0-x235.google.com ([2607:f8b0:4002:c07::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aLkjN-0000rP-Ir for pgadmin-hackers@postgresql.org; Wed, 20 Jan 2016 04:50:55 +0000 Received: by mail-yk0-x235.google.com with SMTP id x67so676664356ykd.2 for ; Tue, 19 Jan 2016 20:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3WPFrLvmSPCyK5tIaprdy77+ihMPOVFr5HAPG9eOEH4=; b=DLLAN3YEf6aDSVPkiZ9YUl78/PNE1Nl5e6pzrhb22qq35tQm49Vn6XVu9YgZDynVyO 1zQjKrvgPbhSc7TLFU0evr7QMDwAg7kQJn6PgFkUoPuGRYngB032Z6KZByrBoWhQ59Yn a+g4ke6Yslu63JkCCw/ps4XYvLY3vV86L6u0UQjewGRJh5Mpg63v8kei2Qsmu4um+QRy NeKZ7wbMhESkA3Sq6ZBFO+4SrLRQeDwxZ930MqD8Sn5j6jw8ku/3X/b3rgo69Ke1KmYn MUmCi7MFkjKeCjSo7htnYjkRaKjl1W3BHHlwQ5XfwlS622fpQX5kHKj+oISGjlgEBeUv VwEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=3WPFrLvmSPCyK5tIaprdy77+ihMPOVFr5HAPG9eOEH4=; b=bGtyj1k6IwuwFGb7VYwjZ3GJd53RTN8kGDGXxILyr2xHXMxBAH/fmNSfwjxSN0JM1u O+IAr7PjZf/9J8Gjt1B8KU8z4ThPYAJbIacGobO5QjNUifol9hIKux4Kel5ZfgumLMdU yl8KDFvWcWjYHNo/VgW4xmmYRmqFTpJtWHZUQolguoRT1ePZZI2yDWpj5Vv0d6kJfiDu gbn60HWwg1alJBZnyPFGZzglEbaysB6RbiTsRM3RhRFIZXeXUYkH1vQYSeGnnB+od29h K/OcApb/X+8J7OAP1B8qDZnAhDR0COogaUaZYleIlcQn8JQ8tPisri049igppEd0h5nc 9dHA== X-Gm-Message-State: ALoCoQkLJbtVcgPlOQBmBNjoHiv0NZKDugmNpbgJyvRpyyOaAkb/Qtq9zxZlwrTsrGi6C+A759ucvVdm0W45o8FzI2L1tfFHh1ownPGQ82F49m7AzPQ6dAk= MIME-Version: 1.0 X-Received: by 10.129.137.193 with SMTP id z184mr21769993ywf.257.1453265452439; Tue, 19 Jan 2016 20:50:52 -0800 (PST) Received: by 10.37.202.75 with HTTP; Tue, 19 Jan 2016 20:50:52 -0800 (PST) In-Reply-To: References: Date: Wed, 20 Jan 2016 10:20:52 +0530 Message-ID: Subject: Re: patch for cast module From: Neel Patel To: Sanket Mehta Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c064ab60ed00e0529bcbb3d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c064ab60ed00e0529bcbb3d Content-Type: text/plain; charset=UTF-8 Hi Sanket, Below are the review comments. - When we edit any existing cast node then it gives error "*Response object has no attribute strip*". This error is coming because generated SQL is wrong. - Unnecessary debug logs are coming on console. Please remove unnecessary debug logs. - In some of the sql file, 'qtIdent' and 'qtLiteral' is not used. Please check all the SQL files. - "Delete" cast functionality is not working. Error is getting displayed saying *"syntax error at or near "castsource"*. - "Delete cascade" functionality is not working - error is getting displayed saying *"The requested URL not found".* - Do the proper comments, in some of the function like "script_load" , comments are wrong. - Is "configs" really required in __init__.py file ? We have not seen any usage for this. Please remove it if it is not required. - Remove commented code from the source file. Please check all the generated SQL statements . Test the basic functionality of "create", "Edit" and "Delete" node before sending patch file. Do let us know for any comments/issues. Thanks, Neel Patel On Tue, Jan 19, 2016 at 8:06 PM, Sanket Mehta wrote: > Hi, > > PFA updated patch for cast module as per check list provided by Neel. > Please do review it and let me know in case of anything is missing. > > > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Mon, Jan 18, 2016 at 7:16 PM, Sanket Mehta < > sanket.mehta@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch for cast module. >> Please do review it and let me know in case of any issue. >> >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --94eb2c064ab60ed00e0529bcbb3d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Sanket,

Below are the rev= iew comments.

- When we edit any existing cast node the= n it gives error "Response object has no attribute strip".= This error is coming because generated SQL is=C2=A0
=C2=A0 wrong.
= - Unnecessary debug logs are coming on console. Please remove unnecessary d= ebug logs.
- In some of the sql file, 'qtIdent' and '= qtLiteral' is not used. Please check all the SQL files.
- "Delete" cast functionality is not working. Error is getting d= isplayed saying "syntax error at or near "castsource"= .=C2=A0
-=C2=A0"Delete cascade" functionality is not wo= rking=C2=A0- error is getting displayed saying "The requested URL n= ot found".
- Do the proper comments, in some of the func= tion like "script_load" , comments are wrong.
- Is &quo= t;configs" really required in __init__.py file ? We have not seen any = usage for this. Please remove it if it is not required.
- Remove = commented code from the source file.

Please check = all the generated SQL statements . Test the basic functionality of "cr= eate", "Edit" and "Delete" node before sending pat= ch file.

Do let us know for any comments/issues.

Thanks,
Neel Patel

On Tue, Jan 19, 2016 at 8:0= 6 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

PFA updated patch for cast module as per check list provided by Ne= el.
Please do review it and let me know in case of anything is mi= ssing.


=
Regards,
= Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Jan 18= , 2016 at 7:16 PM, Sanket Mehta <sanket.mehta@enterprisedb.com= > wrote:
H= i,

PFA patch for cast module.
Please do review= it and let me know in case of any issue.


Regards,
Sanket Mehta
Sr= Software engineer
Enterprisedb



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--94eb2c064ab60ed00e0529bcbb3d--