Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avReX-0008KP-G3 for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Apr 2016 15:45:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1avReX-0005Cn-2I for pgadmin-hackers@arkaria.postgresql.org; Wed, 27 Apr 2016 15:45:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1avReJ-0004fP-7U for pgadmin-hackers@postgresql.org; Wed, 27 Apr 2016 15:45:11 +0000 Received: from mail-yw0-x22e.google.com ([2607:f8b0:4002:c05::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1avReE-00078W-F2 for pgadmin-hackers@postgresql.org; Wed, 27 Apr 2016 15:45:10 +0000 Received: by mail-yw0-x22e.google.com with SMTP id g133so79396588ywb.2 for ; Wed, 27 Apr 2016 08:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=hoEnT+EthuGC0yW7AwM9lQ58xoxQyJfQAFjXGfcmCXg=; b=SsNvENmOqNHDtOmnY9gWPOsRNSqTXJ2aH8uXIYXsWPCbZXlz80AMxd1BQD9hp8hgVz WeGdRykKkv6e6x3Gq2fG49fQAlFggG+srkU1tFYqOfyPFrk/XYv2al2jKCI/j4bKLbYx pYM0vnCuXx6ezfWsNGX7WHCYVU/PX8Wmz8boGKxnx7ivLKpZ9OTV5XFmWZiubZQH4oYh rhVpzn6WUtUtCtUJg/Ni9QIcO9WW9a3o/5Y2SN37wMy8Mz2a/S/RpsoTY0w8x4k5n9JW 1GnC52z3quqItE9fDJ0iVZyv7FPhucUplYw09UVA03wPk78Hxw+oJ3ivXecX+RxaGLsN fu5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=hoEnT+EthuGC0yW7AwM9lQ58xoxQyJfQAFjXGfcmCXg=; b=gI4Pr697NAo0B45ljB5TyVDw6kOgKH8iKEIhBJuglJIuRjER/l2G5Zr2kv7g5clN0A 1v7lGSMIbEWQTtEX4DG/7hs20iAktrqa1GhN0+abXRHKjPtmqL8d4ydJFaDfpkIGIUqC R90uJJPESOJGgNsA80vDMTOoLdEcaplU/03vr3Tu8/A8utq/Gs26iR74unpKVmC0s/vv 3xQsbDILJk85qUiwNYf+/tbK3qh+/qlMH2y8xKuDKMkPKyP+j21zoFkQVBaf/2gw5MO6 7e/ppDNSIdn2XjK84zgY9U8flEEh+jjaXg5xAiFW4sonHM8SYF6A9SAVcUI58+jb8KNj rpKg== X-Gm-Message-State: AOPr4FW1RC0qcvZwYVGujri5pmOkE9J4Yq2a3sTPMB1Ptq4cTsTvZk6868lfGikcV6pwsFg2aZR0zguDR2T/goJl MIME-Version: 1.0 X-Received: by 10.129.135.196 with SMTP id x187mr5022338ywf.297.1461771904650; Wed, 27 Apr 2016 08:45:04 -0700 (PDT) Received: by 10.37.203.134 with HTTP; Wed, 27 Apr 2016 08:45:04 -0700 (PDT) In-Reply-To: References: Date: Wed, 27 Apr 2016 21:15:04 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: File Manager & Backform FileControl From: Neel Patel To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114f22621ebef00531794bf5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114f22621ebef00531794bf5 Content-Type: text/plain; charset=UTF-8 Hi Surinder, I have applied the patch file and below are some observations. - When we create the new folder and hit the enter then we are getting the below error. TypeError: argument of type 'NoneType' is not iterable - I have just added the new control in "Import" dialog and observed that new control is getting added in new tab called "General". I think it should not create the new "General" tab. - "Select" and "Cancel" buttons font is different then other dialogs. Thanks, Neel Patel On Wed, Apr 27, 2016 at 6:18 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi, > > The patch is for *File Manager and Backform FileControl*. > > *File Manager:* It allows user to store their files at one place. The > user can set path to this directory in preferences which file manger will > use. > > It will be used by various modules of pgAdmin4 such as > *import data from file, query tool, backup & recovery tool* so on.. It > allows user to perform various operations such as: > > - File deletion > - File upload > - Create new directory > - File rename > - File download and > - List files & folders in list and grid view. > > *FileControl: *This control is used with *File Manager. *It can be used > for: > > - File Selection > - Folder Selection > - File Creation > - Storage Manager Dialog.( it supports all operations listed above). > > > Usage*:* > > schema:[{ > id: 'select_file', label: '{{ _('Select File')}}', > type: 'text', *control*: *Backform.FileControl*, > *dialog_type: 'select_file'*, *supp_types: ['*', 'pdf', 'text', > 'patch', 'py']* > } > > Where: > > - *control* - It should be *Backform.FileControl* > - *dialog_type *- the type of dialog to use. > - options can be: *select_file, select_folder, create_file & > storage_dialog*. > - *supp_types(*not mandatory) - the types of files allowed to show and > upload. > > Please review the patch and let me know for the review comments. > > > Thanks > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --001a114f22621ebef00531794bf5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Surinder,

I have applied the patch f= ile and below are some observations.
  • When we create the n= ew folder and hit the enter then we are getting the below error.
<= div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0Typ= eError: argument of type 'NoneType' is not iterable
  • I have just added the new control in "Import" dialog and= observed that new control is getting added in new tab called "General= ". I think it should not create the new "General" tab.
    • <= li>"Select" and "Cancel" buttons font is different then= other dialogs.

Thanks,
Neel P= atel

O= n Wed, Apr 27, 2016 at 6:18 PM, Surinder Kumar <surinder.kum= ar@enterprisedb.com> wrote:
Hi,

The patch is for File Manager a= nd Backform=C2=A0FileControl.

File Manag= er:=C2=A0It allows user to store their files at one place. The user= can set path to this directory in preferences which file manger will use.<= /div>

It will be used by various modules of pgAdmin4 suc= h as
import data from file, query tool, backup & recovery = tool=C2=A0so on.. It allows user to perform various operations such as:= =C2=A0
  • File deletion
  • File upload
  • Crea= te new directory
  • File rename
  • File download and=C2=A0
  • List files & folders in list and grid view.
FileControl:=C2=A0This control is used with=C2=A0File M= anager.=C2=A0It=C2=A0can be used for:
  • File Selection = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
  • Folder=C2=A0Selection= =C2=A0 =C2=A0 =C2=A0=C2=A0
  • File Creation =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0=C2=A0
  • Storage Manager Dialog.( it supports= all operations listed above).

Usage:

schema:[{
=C2=A0 id: 'select_file', label: '{{ _('Select File'= ;)}}',=C2=A0
=C2=A0 = type: 'text',=C2=A0control:=C2=A0Backform.FileControl= ,
=C2=A0=C2=A0dialog_= type: 'select_file',=C2=A0supp_types: ['*', 'pdf= ', 'text', 'patch', 'py']
= }

W= here:
  • control=C2=A0- It should be=C2=A0Backform.FileControl
  • dia= log_type=C2=A0- the type of dialog to use.
  • options can be:= =C2=A0=C2=A0select_file, select_folder, create_file & storage_dialog= .
  • supp_types(not mandatory)=C2=A0- the types = of files allowed to show and upload.
Please= review the patch and let me know for the review comments.


Thanks
Surinder Kumar


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--001a114f22621ebef00531794bf5--