Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aRDPt-0004d6-C2 for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Feb 2016 06:29:21 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aRDPs-0003fX-Ul for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Feb 2016 06:29:20 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aRDPr-0003fB-Ri for pgadmin-hackers@postgresql.org; Thu, 04 Feb 2016 06:29:20 +0000 Received: from mail-yk0-x232.google.com ([2607:f8b0:4002:c07::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aRDPk-0001bX-C8 for pgadmin-hackers@postgresql.org; Thu, 04 Feb 2016 06:29:18 +0000 Received: by mail-yk0-x232.google.com with SMTP id r207so36704714ykd.2 for ; Wed, 03 Feb 2016 22:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9cZDQASv//Mksw0OAtiEkmwpVdmzsdSKqu+cI22gwLw=; b=n18m6ipJhfxDWhPTNgbM1OGcMAf4UxskwfSXdMoaCbEqhRs6GoQd9elLrF8oOSUE9G 7CaaNqqvBxQhsmUvghMFHOhM2PbcJ1LmuC9Hq+JHgApyt8vdphKPVi0GPcoFz4UtJY+8 gqOiYicbKRoJaRingSXZWuXXMIUpipTUm6x/C5zjoxWYujaVc1lGiFkZrZZE5l4zVUw6 zFu9xFHSXkuQ/wUFmpnAnffhSJQ5CkdfKJSdBZ3zKOoPN/RHtDxbkQ9Qbx/MPdtVO3f6 CmWH3/dbsXTITwYFgk8sEKf6J0HLVX/f569hTaRoE2o0p8aULiMt43DvMR6ZkSK+SSEb h46w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=9cZDQASv//Mksw0OAtiEkmwpVdmzsdSKqu+cI22gwLw=; b=a84gzRwqO1Q14TsqBmRqAax2HiT/FRARQ7zVzwRmlh4ea6y12wGVZtKCaQdCWiUbgc 8UySzfdeJO7ZGs2svnNTep+ILU6o6Op85MRcBQaKncsCU9JM/WV4xODBRNhL94rB43FT rky6cM+Ql4ElEl1qhMz6vZcYTDdMe3s/PpeivLt17SZI/02yNH49FOPNMpkJRAksOMDN 1Vgkh8kJJ0XJSJki+LHz9cBtoBsNRntFFEvj0LPApoZOWVzIdjFS8Fs8v80J2zOEZCs7 3kBCyNrUW6bFrWBb6S+/QtSoII/80cWPPfl6XFQ27pvfzO4lZ/HXntrGjryKrM3s3lJQ RRUA== X-Gm-Message-State: AG10YOR05amdRsleVY42xQxKA7fpB+7xkT4KTKWkUHBPc3vzfBXux+EzJCwPRfjYDyHyCJeCUB4GMIg2yPTr26y7 MIME-Version: 1.0 X-Received: by 10.37.231.21 with SMTP id e21mr2886159ybh.51.1454567351640; Wed, 03 Feb 2016 22:29:11 -0800 (PST) Received: by 10.37.202.75 with HTTP; Wed, 3 Feb 2016 22:29:11 -0800 (PST) In-Reply-To: References: Date: Thu, 4 Feb 2016 11:59:11 +0530 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Extension Module From: Neel Patel To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c0b14cc4c1949052aebda52 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c0b14cc4c1949052aebda52 Content-Type: text/plain; charset=UTF-8 Hi, New patch is working fine. Ashesh - Can you please review it? If it looks good then we can commit the extension module. Thanks, Neel Patel On Thu, Feb 4, 2016 at 11:40 AM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi Neel, > > Please find the patch with following changes: > 1. Removed Whitespace from files. > 2. Fixed an issue in which json object converted into [object object] > string. > 3. Fixed python3 issue of unicode type where code breaks at > "isinstance(SQL, str)" in python3 if str is unicode, > because python no longer support unicode type of string. > > Please review the patch and Let me know for any comments. > > Thanks, > Surinder Kumar > > On Thu, Feb 4, 2016 at 10:16 AM, Neel Patel > wrote: > >> Hi Surinder, >> >> While applying the patch, we are getting below warnings. >> >> extension_v3.patch:362: trailing whitespace. >> This function will generate sql for sql panel >> extension_v3.patch:646: trailing whitespace. >> -- Extension: {{ conn|qtIdent(data.name) }} >> warning: 2 lines add whitespace errors. >> >> >> Can you please resend the patch file, after fixing above warnings ? >> >> Thanks, >> Neel Patel >> >> On Fri, Jan 22, 2016 at 12:25 PM, Surinder Kumar < >> surinder.kumar@enterprisedb.com> wrote: >> >>> Hi >>> >>> Please find the updated patch with following fixes: >>> 1. Missing `owner` column under properties for `extensions collection`. >>> Add cell: 'string' property for owner fixed it >>> 2. Schema object identifier should be wrapped with in function qtIdent . >>> Using function `qtIdent` for schema in create.sql fixed it. >>> >>> >>> Thanks >>> Surinder Kumar >>> >>> On Thu, Jan 21, 2016 at 8:04 PM, Surinder Kumar < >>> surinder.kumar@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> I've fixed the issues given in review comments. >>>> >>>> Please find the attached updated patch for extension module, review it >>>> and let me know for any comments. >>>> >>>> On Mon, Jan 18, 2016 at 5:44 PM, Surinder Kumar < >>>> surinder.kumar@enterprisedb.com> wrote: >>>> >>>>> Thanks Neel for reviewing. I'll send the patch with the fixes >>>>> suggested. >>>>> >>>>> On Mon, Jan 18, 2016 at 4:52 PM, Neel Patel < >>>>> neel.patel@enterprisedb.com> wrote: >>>>> >>>>>> Hi Surinder, >>>>>> >>>>>> We have applied/tested the patch and below are the review comments. >>>>>> >>>>>> 1. When we select the extension "plpython3u", "plperl", "plperu" etc. >>>>>> then it gives 'TypeError' in Javascript. >>>>>> TypeError: d.version is undefined >>>>>> 'version': (!_.isNull(d.version[0]) ? d.version[0]: '') >>>>>> >>>>>> We are getting this error while selecting many extensions so please >>>>>> test with all types of extensions, it should not give any error at client >>>>>> side. >>>>>> >>>>> Fixed. >>>> >>>>> >>>>>> 2. Use 2 space indentation instead of 4 space in javascript file. >>>>>> >>>>> Done >>>> >>>>> >>>>>> 3. In "validate" function in "extension.js" file, validate only the >>>>>> changed values not all, and "this.get('name') - should be called only one >>>>>> time not multiple >>>>>> time". >>>>>> >>>>> Fixed. >>>> >>>>> >>>>>> 4. When we pass object identifier, use the function 'qtIdent', and >>>>>> for the values, use function 'qtLiteral' in all the sql files. >>>>>> >>>>> Done. >>>> >>>>> >>>>>> 5. By default, when we create the extension, "schema_name" and >>>>>> "version" should not be be set with value. It should be set blank by >>>>>> default. >>>>>> >>>>> Kept blank while creating extension. >>>> >>>>> >>>>>> 6. When we create any extension like "citext" then we are not able to >>>>>> create the same extension again after deleting the same extension. May be >>>>>> issue >>>>>> with caching mechanism. >>>>>> >>>>> It is an architecture change. we'll fix it later. >>>> >>>>> >>>>>> 7. When we remove the schema_name during the "Edit" operation then >>>>>> wrong SQL is getting generated. >>>>>> >>>>> Fixed, Now it generates right SQL. >>>> >>>>> >>>>>> >>>>> 8. Remove "Use Slony" option. As discussed with Ashesh, we will >>>>>> implement it as separate module. >>>>>> >>>>> Removed. >>>> >>>>> >>>>>> Please fix the above issues. Let us know if you want more information. >>>>>> >>>>>> Thanks, >>>>>> Neel Patel >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Neel Patel >>>>>> >>>>>> >>>>>> On Tue, Jan 12, 2016 at 1:15 PM, Surinder Kumar < >>>>>> surinder.kumar@enterprisedb.com> wrote: >>>>>> >>>>>>> Please find the updated patch with following changes: >>>>>>> >>>>>>> 1. corrected copyright. >>>>>>> 2. Added proper comment for script_module function in >>>>>>> __init__.py file. >>>>>>> 3. Renamed collection Node's label to Extensions in >>>>>>> extensions.js file. >>>>>>> >>>>>>> >>>>>>> On Tue, Jan 12, 2016 at 12:44 PM, Surinder Kumar < >>>>>>> surinder.kumar@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> Please find attached patch for the extension module. >>>>>>>> Please review it and Let me know for any comments. >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Surinder Kumar >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>> pgadmin-hackers@postgresql.org) >>>>>>> To make changes to your subscription: >>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> > --94eb2c0b14cc4c1949052aebda52 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

New patch is working fine.
Ashesh - Can you please review it? If it looks good then we can commit th= e extension module.

Thanks,
Neel Patel


On Thu, Feb 4, 2016 at 11:40 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi Neel,

Please find the = patch with following changes:
1. Removed Whitespace from files.
2. Fixed an issue in which json object converted into [object obje= ct] string.
3. Fixed python3 issue of unicode type where code bre= aks at "isinstance(SQL, str)" in python3 if str is unicode,
=
because python no longer support unicode type of string.
Please review the patch and Let = me know for any comments.

Thanks,
Surinder Kumar

On Thu, Feb 4, 2016 at 10:16 AM, Neel Patel <n= eel.patel@enterprisedb.com> wrote:
Hi Surinder,

While applying the= patch, we are getting below warnings.

extens= ion_v3.patch:362: trailing whitespace.
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 This function will generate sql for sql panel=C2=A0
extension= _v3.patch:646: trailing whitespace.
-- Extension: {{ conn|qtIdent= (data.name) }}=C2=A0
warning: 2 lines add whitespace errors.


Can you please resend the patch file, after fixing above = warnings ?

Thanks,
Neel Patel

On Fri= , Jan 22, 2016 at 12:25 PM, Surinder Kumar <surinder.kumar@e= nterprisedb.com> wrote:
Hi

Please find the updated patch with foll= owing fixes:
1. Missing `owner` column under properties for `exte= nsions collection`. Add cell: 'string' property for owner fixed it<= /div>
2. Schema object identifier should be wrapped with in function qt= Ident . Using function `qtIdent` for schema in create.sql fixed it.


Thanks
=
Surinder Kumar

On Thu, Jan 21, 2016 at 8:04 PM, Suri= nder Kumar <surinder.kumar@enterprisedb.com> w= rote:
Hi,

=
I've fixed the issues given in review comments.

Please find the attached updated patch for extension module, review = it and let me know for any comments.

On Mon, Jan 18, 2016 at 5:44 PM, S= urinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Thanks Neel for= reviewing. I'll send the patch with the fixes suggested.

On Mon, Jan 18,= 2016 at 4:52 PM, Neel Patel <neel.patel@enterprisedb.com>= ; wrote:
Hi Surin= der,

We have applied/tested the patch and below are the = review comments.

1. When we select the extens= ion "plpython3u", "plperl", "plperu" etc. the= n it gives 'TypeError' in Javascript.
TypeError: d.versio= n is undefined
'version': (!_.isNull(d.version[0]) ? d.ve= rsion[0]: '')

We are getting this error wh= ile selecting many extensions so please test with all types of extensions, = it should not give any error at client side.
=
Fixed.=C2=A0

2.=C2=A0 Use 2 space indentation instead of 4 space in java= script file.
Done
<= div class=3D"gmail_extra">

3. In "validate" fu= nction in "extension.js" file, validate only the changed values n= ot all, and "this.get('name') - should be called only one time= not multiple=C2=A0
=C2=A0 =C2=A0 time".
Fixed.=C2=A0

4.=C2=A0When we pass objec= t identifier, use the function 'qtIdent', and for the values, use f= unction =C2=A0'qtLiteral' in all the sql files.
<= /blockquote>
Done.=C2=A0

5. By default, when we create the extension, "sc= hema_name" and "version" should not be be set with value. It= should be set blank by default.
=
Kept blank while creating extension.=C2=A0

6. When we create any extension like "citext&qu= ot; then we are not able to create the same extension again after deleting = the same extension. May be issue=C2=A0
=C2=A0 =C2=A0 with caching= mechanism.
It is an architecture change. we'll fix it later.=C2=A0
=
<= div class=3D"gmail_quote">
<= div>
7. When we remove the schema_name during the "Edit&= quot; operation then wrong SQL is getting generated.
Fixed, Now it generates = right SQL.
=
=C2=A0
8. Remov= e "Use Slony" option. As discussed with Ashesh, we will implement= it as separate module.
Removed.=C2=A0

Please fix the= above issues. Let us know if you want more information.

Thanks,
Neel Patel


Thanks,
Neel Patel


On Tue, Jan 12, 2016 at 1:= 15 PM, Surinder Kumar <surinder.kumar@enterprisedb.com&g= t; wrote:
Please find the updated patch with following changes:
  • corrected copyright.
  • Added proper comment for script_module f= unction in __init__.py file.
  • Renamed collection Node's label to= Extensions in extensions.js file.

    • On Tue, Jan 12, 2016 at 12= :44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com&= gt; wrote:
    H= i,

    Please find attached patch for the extension mo= dule.
    Please review it and Let me know for any comments.

    <= /div>

    Thanks,
    Surinder Kumar



    --
    Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
    To make changes to your subscription:
    http://www.postgresql.org/mailpref/pgadmin-hackers=








    --94eb2c0b14cc4c1949052aebda52--