MIME-Version: 1.0
References: 
 <CANQrdXBzJNK+_tDgju_qTq-OuG7dKdqNZ6Xv=-n0-RoYM0PXhA@mail.gmail.com>
In-Reply-To: 
 <CANQrdXBzJNK+_tDgju_qTq-OuG7dKdqNZ6Xv=-n0-RoYM0PXhA@mail.gmail.com>
From: Neel Patel <neel.patel@enterprisedb.com>
Date: Wed, 4 Mar 2020 10:53:36 +0530
Message-ID: 
 <CACCA4P2A=t9UcKYyiB3-Z0J3zNQNsa48UwWrwUJ90koTxNL99g@mail.gmail.com>
Subject: Re: PgAgent leap year problem
To: =?UTF-8?Q?Mehmet_Emin_KARAKA=C5=9E?= <emin100@gmail.com>,
	Dave Page <dpage@pgadmin.org>, Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000f977ce05a0009f1b"
Precedence: bulk

--000000000000f977ce05a0009f1b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Mehmet,

It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed
and tested, it is working fine.

Dave/Ashesh:-  Can we commit this patch ?

Thanks,
Neel Patel

On Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKA=C5=9E <emin100@gmail.com>
wrote:

> Hi,
>
> Scheduled tasks set as the last day of February this year did not work. I=
n
> your schedule function have a small bug.  Leap year function get year
> parameter, but your code is sending day as a parameter.  Fixing patch
> attached in this mail.
>
> Best Regards...
>
> --
> MEHMET EM=C4=B0N KARAKA=C5=9E
> PostgreSQL DBA
>
> Turksat Satellite Communication and Cable TV Operations
> Konya Yolu 40. Km. 06839 Golbasi / ANKARA - T=C3=9CRK=C4=B0YE
> Tel     :  +90 312 615 32 73
> Faks  :  +90 312 615 32 77
>

--000000000000f977ce05a0009f1b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Mehmet,<div><br></div><div>It was a bug in pgAgent. Tha=
nk you for sharing the patch. I have reviewed and tested, it is working fin=
e.</div><div><br></div><div>Dave/Ashesh:-=C2=A0 Can we commit this patch ?<=
/div><div><br></div><div>Thanks,</div><div>Neel Patel</div></div><br><div c=
lass=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Mar 2, 2=
020 at 5:26 PM Mehmet Emin KARAKA=C5=9E &lt;<a href=3D"mailto:emin100@gmail=
.com">emin100@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Scheduled ta=
sks set as the last day of February this year did not work. In your schedul=
e function have a small bug.=C2=A0 Leap year function get year parameter, b=
ut your code is sending day as a parameter.=C2=A0 Fixing patch attached in =
this mail.</div><div><br></div><div>Best Regards...<br clear=3D"all"><div><=
br></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div>MEHMET EM=C4=B0N KAR=
AKA=C5=9E<br><span style=3D"font-family:Arial,Helvetica,sans-serif;font-siz=
e:small;letter-spacing:normal">PostgreSQL DBA</span><br><br>Turksat Satelli=
te Communication and Cable TV Operations<br>Konya Yolu 40. Km. 06839 Golbas=
i / ANKARA - T=C3=9CRK=C4=B0YE<br>Tel=C2=A0 =C2=A0=C2=A0 :=C2=A0 +90 312 61=
5 32 73<br>Faks=C2=A0 :=C2=A0 +90 312 615 32 77</div></div></div></div></di=
v>
</blockquote></div>

--000000000000f977ce05a0009f1b--