Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an2by-0002JS-BI for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Apr 2016 11:24:02 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1an2bx-0000s3-J8 for pgadmin-hackers@arkaria.postgresql.org; Mon, 04 Apr 2016 11:24:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1an2bj-0000aq-Qb for pgadmin-hackers@postgresql.org; Mon, 04 Apr 2016 11:23:47 +0000 Received: from mail-yw0-x231.google.com ([2607:f8b0:4002:c05::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1an2bg-0003Vf-Il for pgadmin-hackers@postgresql.org; Mon, 04 Apr 2016 11:23:47 +0000 Received: by mail-yw0-x231.google.com with SMTP id d68so109943699ywe.1 for ; Mon, 04 Apr 2016 04:23:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:date:message-id:subject:from:to; bh=7MFbJg1ReHpTUbhZbGaFRbizwWN3sTdDSIa7nP7Ut9w=; b=sdTiCUS9x1LuDmLELcMYWQHfG1nPal5McJ2u3cjGR925+SueGwa4ySV/6J4fC7hnrY S0JpSyltnuCAWF1RkNAdCV9cFCb+2sXcr4srU84DlP2qggBwgYafGHOHUZVleIK7RPTS T44Lt3SL3yBGzLpR1lQx5SlpGlgeQ15ti6tUJwG7xZCMB9+kW28F90yeVmdJeweJch4w Cez0UgyLcthgjk0a3AGmf17H+RVPGwEo6HeQxwnodA9pL+upkZc+SgLe1HGfJ9kAkJSo Pam90DeZ36ZBvCzOIq0QyOAXwnPtwmdkuyx2UYpqB6kJyZLKq3dkVH1u6tbuCG5NMQrj SPGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=7MFbJg1ReHpTUbhZbGaFRbizwWN3sTdDSIa7nP7Ut9w=; b=i+myz3FwelC+zpWrTmKKl5WR63TjDDSaf6wH/uzqUsuDJ2QiOHo3oGTWt8mXlUjSJg Y5lRjpRC1ZJAttKbeysmT7Sifi20Tp4WziAXtq1tR5vmvFvb3Sfr+/OcE/cmxkZM0o4e N9bFEL5FbnB+vdlHGMwYA2bJFgNkmerXI1fC37gW7AR3toNEVbSKwz4Cv6VM2BTRXoon TxbrWCPODCjXxPeNmhxRN+1o3bJkycLN/Kzilw7YfwxQicCKbQDL6knS4/udZbdxGsa7 pEhrxD1q3coKc/epDfajAKKv9mvbS5aLxh7/kw2w+5VvCV5uHp1RygGTbmUeyyxFgqr/ 5QWg== X-Gm-Message-State: AD7BkJL1WS4klEvRAE2h5ybfBnh3e+tVtBaptCY8DsX1DxhyLfwc/zBXh47CEGnG3UjJsqAgcwDay/1Jexv795EG MIME-Version: 1.0 X-Received: by 10.37.230.211 with SMTP id d202mr4957981ybh.26.1459769022800; Mon, 04 Apr 2016 04:23:42 -0700 (PDT) Received: by 10.37.218.76 with HTTP; Mon, 4 Apr 2016 04:23:42 -0700 (PDT) Date: Mon, 4 Apr 2016 16:53:42 +0530 Message-ID: Subject: [pgAdmin4][psycopg2] - Modified status message implementation From: Neel Patel To: pgadmin-hackers Content-Type: multipart/mixed; boundary=94eb2c0a7a3c0f973b052fa6f656 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c0a7a3c0f973b052fa6f656 Content-Type: multipart/alternative; boundary=94eb2c0a7a3c0f9736052fa6f654 --94eb2c0a7a3c0f9736052fa6f654 Content-Type: text/plain; charset=UTF-8 Hi, Please find attached patch file which modified the earlier statusmessage implementation. *Previous implementation:- * statusmessage was implemented inside the poll function and if poll result row is greater than zero then statusmessage was replaced by the result row returned so if user wants the statusmessage along with returned rows then current implementation will not work. *Changes:-* Now "status_message()" function is implemented to get the status message returned by last command executed on the server and removed from the poll function. If user wants to status messages then they have to call "status_message()" which will return the status message text. Do review it and let us know for any comments. Thanks, Neel Patel --94eb2c0a7a3c0f9736052fa6f654 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Please find attached patch file whi= ch modified the earlier statusmessage implementation.

<= div>Previous implementation:-=C2=A0

statusm= essage was implemented inside the poll function and if poll result row is g= reater than zero then statusmessage was replaced by the result row returned= so if user wants the statusmessage along with returned rows then current i= mplementation will not work.

Changes:-

Now "status_message()" function is implement= ed to get the status message returned by last command executed on the serve= r and removed from the poll function.
If user wants to status mes= sages then they have to call "status_message()" which will return= the status message text.

Do review it and let us = know for any comments.

Thanks,
Neel Pate= l
--94eb2c0a7a3c0f9736052fa6f654-- --94eb2c0a7a3c0f973b052fa6f656 Content-Type: application/octet-stream; name="psycopg2_status_message.patch" Content-Disposition: attachment; filename="psycopg2_status_message.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_imlwg3ax0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3V0aWxzL2RyaXZlci9hYnN0cmFj dC5weSBiL3dlYi9wZ2FkbWluL3V0aWxzL2RyaXZlci9hYnN0cmFjdC5weQpp bmRleCA1MzY5MjUxLi5lMDY4Y2E0IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1p bi91dGlscy9kcml2ZXIvYWJzdHJhY3QucHkKKysrIGIvd2ViL3BnYWRtaW4v dXRpbHMvZHJpdmVyL2Fic3RyYWN0LnB5CkBAIC0yMDYsNSArMjA2LDkgQEAg Y2xhc3MgQmFzZUNvbm5lY3Rpb24ob2JqZWN0KToKICAgICAgICAgcGFzcwog CiAgICAgQGFic3RyYWN0bWV0aG9kCisgICAgZGVmIHN0YXR1c19tZXNzYWdl KHNlbGYpOgorICAgICAgICBwYXNzCisKKyAgICBAYWJzdHJhY3RtZXRob2QK ICAgICBkZWYgY2FuY2VsX3RyYW5zYWN0aW9uKHNlbGYsIGNvbm5faWQsIGRp ZD1Ob25lKToKICAgICAgICAgcGFzcwpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRt aW4vdXRpbHMvZHJpdmVyL3BzeWNvcGcyL19faW5pdF9fLnB5IGIvd2ViL3Bn YWRtaW4vdXRpbHMvZHJpdmVyL3BzeWNvcGcyL19faW5pdF9fLnB5CmluZGV4 IDczMzBhMjguLjg0OTYzNzkgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3V0 aWxzL2RyaXZlci9wc3ljb3BnMi9fX2luaXRfXy5weQorKysgYi93ZWIvcGdh ZG1pbi91dGlscy9kcml2ZXIvcHN5Y29wZzIvX19pbml0X18ucHkKQEAgLTk1 LDYgKzk1LDkgQEAgY2xhc3MgQ29ubmVjdGlvbihCYXNlQ29ubmVjdGlvbik6 CiAgICAgICAtIFRoaXMgbWV0aG9kIGlzIHVzZWQgdG8gcG9sbCB0aGUgZGF0 YSBvZiBxdWVyeSBydW5uaW5nIG9uIGFzeW5jaHJvbm91cwogICAgICAgICBj b25uZWN0aW9uLgogCisgICAgKiBzdGF0dXNfbWVzc2FnZSgpCisgICAgICAt IFJldHVybnMgdGhlIHN0YXR1cyBtZXNzYWdlIHJldHVybmVkIGJ5IHRoZSBs YXN0IGNvbW1hbmQgZXhlY3V0ZWQgb24gdGhlIHNlcnZlci4KKwogICAgICog Y2FuY2VsX3RyYW5zYWN0aW9uKGNvbm5faWQsIGRpZD1Ob25lKQogICAgICAg LSBUaGlzIG1ldGhvZCBpcyB1c2VkIHRvIGNhbmNlbCB0aGUgdHJhbnNhY3Rp b24gZm9yIHRoZQogICAgICAgICBzcGVjaWZpZWQgY29ubmVjdGlvbiBpZCBh bmQgZGF0YWJhc2UgaWQuCkBAIC00NjQsNiArNDY3LDcgQEAgQXR0ZW1wdCB0 byByZWNvbm5lY3QgaXQgZmFpbGVkIHdpdGggdGhlIGJlbG93IGVycm9yOgog ICAgICAgICAgICAgcGFyYW1zOiBleHRyYSBwYXJhbWV0ZXJzIHRvIHRoZSBm dW5jdGlvbgogICAgICAgICAgICAgZm9ybWF0dGVkX2V4Y2VwdGlvbl9tc2c6 IGlmIFRydWUgdGhlbiBmdW5jdGlvbiByZXR1cm4gdGhlIGZvcm1hdHRlZCBl eGNlcHRpb24gbWVzc2FnZQogICAgICAgICAiIiIKKyAgICAgICAgc2VsZi5f X2FzeW5jX2N1cnNvciA9IE5vbmUKICAgICAgICAgc3RhdHVzLCBjdXIgPSBz ZWxmLl9fY3Vyc29yKCkKIAogICAgICAgICBpZiBub3Qgc3RhdHVzOgpAQCAt NzY3LDcgKzc3MSw3IEBAIEZhaWxlZCB0byByZXNldCB0aGUgY29ubmVjdGlv biBvZiB0aGUgc2VydmVyIGR1ZSB0byBmb2xsb3dpbmcgZXJyb3I6CiAgICAg ICAgIGN1ciA9IHNlbGYuX19hc3luY19jdXJzb3IKICAgICAgICAgaWYgbm90 IGN1cjoKICAgICAgICAgICAgIHJldHVybiBGYWxzZSwgZ2V0dGV4dCgKLSAg ICAgICAgICAgICAgICAiQ3Vyc29yIGNvdWxkIG5vdCBiZSBmb3VuZCBmb3Ig dGhlIGF5c25jIGNvbm5lY3Rpb24uIgorICAgICAgICAgICAgICAgICJDdXJz b3IgY291bGQgbm90IGJlIGZvdW5kIGZvciB0aGUgYXN5bmMgY29ubmVjdGlv bi4iCiAgICAgICAgICAgICAgICAgKSwgTm9uZQogCiAgICAgICAgIGN1cnJl bnRfYXBwLmxvZ2dlci5sb2coCkBAIC03ODQsMTkgKzc4OCwxOSBAQCBGYWls ZWQgdG8gcmVzZXQgdGhlIGNvbm5lY3Rpb24gb2YgdGhlIHNlcnZlciBkdWUg dG8gZm9sbG93aW5nIGVycm9yOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNl LCBlcnJtc2csIE5vbmUKIAogICAgICAgICBjb2xpbmZvID0gTm9uZQorICAg ICAgICByZXN1bHQgPSBOb25lCiAgICAgICAgIGlmIHN0YXR1cyA9PSBzZWxm LkFTWU5DX09LOgogCiAgICAgICAgICAgICAjIGlmIHVzZXIgaGFzIGNhbmNl bGxlZCB0aGUgdHJhbnNhY3Rpb24gdGhlbiBjaGFuZ2VkIHRoZSBzdGF0dXMK ICAgICAgICAgICAgIGlmIHNlbGYuZXhlY3V0aW9uX2Fib3J0ZWQ6CiAgICAg ICAgICAgICAgICAgc3RhdHVzID0gc2VsZi5BU1lOQ19FWEVDVVRJT05fQUJP UlRFRAogICAgICAgICAgICAgICAgIHNlbGYuZXhlY3V0aW9uX2Fib3J0ZWQg PSBGYWxzZQotICAgICAgICAgICAgICAgIHJldHVybiBzdGF0dXMsIE5vbmUs IGNvbGluZm8KKyAgICAgICAgICAgICAgICByZXR1cm4gc3RhdHVzLCByZXN1 bHQsIGNvbGluZm8KIAogICAgICAgICAgICAgIyBGZXRjaCB0aGUgY29sdW1u IGluZm9ybWF0aW9uCiAgICAgICAgICAgICBpZiBjdXIuZGVzY3JpcHRpb24g aXMgbm90IE5vbmU6CiAgICAgICAgICAgICAgICAgY29saW5mbyA9IFtkZXNj IGZvciBkZXNjIGluIGN1ci5kZXNjcmlwdGlvbl0KIAotICAgICAgICAgICAg cmVzdWx0ID0gY3VyLnN0YXR1c21lc3NhZ2UKICAgICAgICAgICAgIGlmIGN1 ci5yb3djb3VudCA+IDA6CiAgICAgICAgICAgICAgICAgcmVzdWx0ID0gW10K IApAQCAtODA5LDEyICs4MTMsMjYgQEAgRmFpbGVkIHRvIHJlc2V0IHRoZSBj b25uZWN0aW9uIG9mIHRoZSBzZXJ2ZXIgZHVlIHRvIGZvbGxvd2luZyBlcnJv cjoKICAgICAgICAgICAgICAgICAgICAgZm9yIHJvdyBpbiBjdXI6CiAgICAg ICAgICAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5kKGRpY3Qocm93KSkK ICAgICAgICAgICAgICAgICBleGNlcHQgcHN5Y29wZzIuUHJvZ3JhbW1pbmdF cnJvcjoKLSAgICAgICAgICAgICAgICAgICAgcmVzdWx0ID0gY3VyLnN0YXR1 c21lc3NhZ2UKKyAgICAgICAgICAgICAgICAgICAgcmVzdWx0ID0gTm9uZQog Ci0gICAgICAgICAgICBzZWxmLl9fYXN5bmNfY3Vyc29yID0gTm9uZQotICAg ICAgICAgICAgcmV0dXJuIHN0YXR1cywgcmVzdWx0LCBjb2xpbmZvCisgICAg ICAgIHJldHVybiBzdGF0dXMsIHJlc3VsdCwgY29saW5mbworCisgICAgZGVm IHN0YXR1c19tZXNzYWdlKHNlbGYpOgorICAgICAgICAiIiIKKyAgICAgICAg VGhpcyBmdW5jdGlvbiB3aWxsIHJldHVybiB0aGUgc3RhdHVzIG1lc3NhZ2Ug cmV0dXJuZWQgYnkgdGhlIGxhc3QgY29tbWFuZCBleGVjdXRlZCBvbiB0aGUg c2VydmVyLgorICAgICAgICAiIiIKKyAgICAgICAgY3VyID0gc2VsZi5fX2Fz eW5jX2N1cnNvcgorICAgICAgICBpZiBub3QgY3VyOgorICAgICAgICAgICAg cmV0dXJuIGdldHRleHQoIkN1cnNvciBjb3VsZCBub3QgYmUgZm91bmQgZm9y IHRoZSBhc3luYyBjb25uZWN0aW9uLiIpCisKKyAgICAgICAgY3VycmVudF9h cHAubG9nZ2VyLmxvZygKKyAgICAgICAgICAgIDI1LAorICAgICAgICAgICAg IlN0YXR1cyBtZXNzYWdlIGZvciAoUXVlcnktaWQ6IHtxdWVyeV9pZH0pIi5m b3JtYXQoCisgICAgICAgICAgICAgICAgcXVlcnlfaWQ9c2VsZi5fX2FzeW5j X3F1ZXJ5X2lkCisgICAgICAgICAgICAgICAgKQorICAgICAgICAgICAgKQog Ci0gICAgICAgIHJldHVybiBzdGF0dXMsIE5vbmUsIGNvbGluZm8KKyAgICAg ICAgcmV0dXJuIGN1ci5zdGF0dXNtZXNzYWdlCiAKICAgICBkZWYgY2FuY2Vs X3RyYW5zYWN0aW9uKHNlbGYsIGNvbm5faWQsIGRpZD1Ob25lKToKICAgICAg ICAgIiIiCg== --94eb2c0a7a3c0f973b052fa6f656 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --94eb2c0a7a3c0f973b052fa6f656--