Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1angpi-0001FO-B1 for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Apr 2016 06:20:54 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1angpg-0005op-Qf for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Apr 2016 06:20:52 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1angpS-0005aE-7j for pgadmin-hackers@postgresql.org; Wed, 06 Apr 2016 06:20:38 +0000 Received: from mail-yw0-x232.google.com ([2607:f8b0:4002:c05::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1angpK-0005K9-91 for pgadmin-hackers@postgresql.org; Wed, 06 Apr 2016 06:20:36 +0000 Received: by mail-yw0-x232.google.com with SMTP id t10so44603403ywa.0 for ; Tue, 05 Apr 2016 23:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=GHpP85fhr774ahxWASiVH2KgJQV2+wgxK9olk091emc=; b=sWVRipDSFryYwB4XSmOQGWoH6uJGgpnbap0+PArXtX9AL7jGv1fyKYGeeJBkmV/wnp UwWPUY4J3QVDGbu1YuudRUq8qhXeQ1FWn1tys4INRA9gnf+C9+DZX2pFyOUhK9MkSl7r 64rZi0ORxNJnJDubaf4DZ4MAniSW/HCJNlbfYbkIAxNx/CzCp6ysiLzTJk/B5k8A4EQH +c208k513Dm2xgMA9HWROoQ4tJa/idJ8WcgSSoxypTqUM6qYgkxLMU1MP3R2TwwlShSn ikkl0VnjgLhA18LhVXVpe4argvWyPAOgy4GSSHqjI22IqUDYor5t/ThZrUpueBYLQ9eH YlXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=GHpP85fhr774ahxWASiVH2KgJQV2+wgxK9olk091emc=; b=VyzzfseF1QXR2euVQK+0od4G74+qzJDvGCp4NwdA3+Dsf6p5R5wexspf1qelzI23Xi Ws5Wjj0QIA0vdtXSQZM1CEmCP7Nq/21IhhvxtZ8Q71Gn3JvEs65N3PASVWoQbaBXf1Zd nrtBVDr5wAmUtxAQNmPWrv1FbSFyHsx/OqxVXbDixq8N4uq85bWePsUUlgIeX2CeaHZl e5a4TMWUvNsgRyd8Eq9RG0GjhaGcqonenKa92LRZ1gqh+4PmAsufEsQzdKF/DF+bhok7 6VI204YbO/CYMW+fuY7DNxL3tTeO+VPCRZHZZ2jbbOH5VeAOG4VpzYKeSWZnAEPTfNgT tqgg== X-Gm-Message-State: AD7BkJKdLCrc62jKN6GKxdqZwRFhAA/ycfvvRMePcS+s989pYjhA3pc1SB7vZKWbip5blp7IJT73aFbCkxzAVDf3 MIME-Version: 1.0 X-Received: by 10.129.83.196 with SMTP id h187mr14453970ywb.319.1459923629378; Tue, 05 Apr 2016 23:20:29 -0700 (PDT) Received: by 10.37.218.76 with HTTP; Tue, 5 Apr 2016 23:20:29 -0700 (PDT) In-Reply-To: References: Date: Wed, 6 Apr 2016 11:50:29 +0530 Message-ID: Subject: Re: [pgAdmin4][Debugger]: Initial Patch From: Neel Patel To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114d6f26544187052fcaf5e9 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114d6f26544187052fcaf5e9 Content-Type: text/plain; charset=UTF-8 One more additional information. Follow the below steps and send us pgAdmin4.log file. - Browse till function which we want to debug. Do not click on the "Debug" context menu. - Stop the server - Enable the "Debug" option in the config file under "web" folder. - Start the server. - Now click on the "Debug" context menu and add requirement input. After clicking on the debug button on the input dialog send us the pgAdmin4.log file. Thanks, Neel Patel On Wed, Apr 6, 2016 at 11:38 AM, Neel Patel wrote: > Hi Dave, > > We will fix the error "KeyError: 'session_id'" but regarding the blank > tab, we have tried with PostgreSQL 9.4 with both the version of python (2.7 > & 3.4) but we are not able to reproduce the issue. > > Below are some of the questions to debug the issue. > > - Is it only reproduce on PostgreSQL 9.4 ? Is it working on PostgreSQL > 9.5 ? > - Is it possible to know the debugger version ? > - The issue is reproduce on specific functions ? If yes, can you > please give definition of the function ? > - Are you able to see toolbar buttons ? Or nothing on the screen ? > Only blank panel ? > - Can you please share request/response of last request URL sent to > server in browser ? > > Thanks, > Neel Patel > > On Tue, Apr 5, 2016 at 9:59 PM, Dave Page wrote: > >> Hi >> >> On Tue, Apr 5, 2016 at 12:40 PM, Neel Patel >> wrote: >> > Hi, >> > >> > Please find attached debugger v1 patch. To test this patch we need to >> apply >> > the "function" module patch submitted by Khushboo. >> > >> > For the debugger functionality, direct and indirect debugging is >> working as >> > per pgadmin3 except below TODOs. >> > >> > Below are the TODOs which will be submitted in next patch along with the >> > fixed review comments. >> > >> > For the direct debugging, 'NULL' and 'Expression' column value should be >> > validated before pressing the debug button. >> > User can deposit the value of input arguments and local variable but >> need to >> > be >> > validated against respective data types. >> > Currently we have tested for plpgsql functions only, We need to test >> against >> > EDB SPL functions and trigger functions. >> > For the direct debugging, once the execution is completed, only >> > "Continue/Restart" button will be enabled and user should allow to >> restart >> > the debugging with same function and previous values. >> > Values entered by the user in input dialog during direct debugging >> should be >> > saved. >> > >> > >> > Currently we have tested this patch with PostgreSQL v9.5. >> > >> > Do review it and let us know for the comments. >> >> I just get a blank tab when I try to debug something. I do see the >> params dialogue, but then nothing. Note: >> >> - I have Akshay's Query Tool patch applied, and am running from git master >> >> - PostgreSQL 9.4, with the debugger plugin in the public schema. >> >> - Various functions in the pem schema tested, both with and without >> parameters. >> >> - Both direct and indirect debugging have the same issue. >> >> - No errors seen in the console, except when closing the debugger tab: >> >> 2016-04-05 17:27:37,720: INFO werkzeug: 127.0.0.1 - - [05/Apr/2016 >> 17:27:37] "GET /debugger/close/8569717 HTTP/1.1" 500 - >> Traceback (most recent call last): >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >> line 1836, in __call__ >> return self.wsgi_app(environ, start_response) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >> line 1820, in wsgi_app >> response = self.make_response(self.handle_exception(e)) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >> line 1403, in handle_exception >> reraise(exc_type, exc_value, tb) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >> line 1817, in wsgi_app >> response = self.full_dispatch_request() >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >> line 1477, in full_dispatch_request >> rv = self.handle_user_exception(e) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >> line 1381, in handle_user_exception >> reraise(exc_type, exc_value, tb) >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >> line 1475, in full_dispatch_request >> rv = self.dispatch_request() >> File >> "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", >> line 1461, in dispatch_request >> return self.view_functions[rule.endpoint](**req.view_args) >> File >> "/Users/dpage/git/pgadmin4-demo/web/pgadmin/tools/debugger/__init__.py", >> line 397, in close >> session_id=obj['session_id']) >> KeyError: 'session_id' >> >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a114d6f26544187052fcaf5e9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
One more additional information.

Follow= the below steps and send us pgAdmin4.log file.
  • Browse ti= ll function which we want to debug. Do not click on the "Debug" c= ontext menu.
  • Stop the server
  • Enable the "Debug" o= ption in the config file under "web" folder.
  • Start the se= rver.
  • Now click on the "Debug" context menu and add requi= rement input. After clicking on the debug button on the input dialog send u= s the pgAdmin4.log file.
Thanks,
Neel Patel

On Wed,= Apr 6, 2016 at 11:38 AM, Neel Patel <neel.patel@enterprisedb.co= m> wrote:
= Hi Dave,

We will fix the erro= r "KeyError: 'session_id'" but regarding the blank= tab, we have tried with PostgreSQL 9.4 with both the version of python (2.= 7 & 3.4) but we are not able to reproduce the issue.

Below are some of the questions to debug the issue.
=
  • Is it only reproduce on PostgreSQL 9.4 ? Is it working on Post= greSQL 9.5 ?
  • Is it possible to know the debugger version ?
  • = The issue is reproduce on specific functions ? If yes, can you please give = definition of the function ?
  • Are you able to see toolbar buttons ? = Or nothing on the screen ? Only blank panel ?
  • Can you please share = request/response of last request URL sent to server in browser ?
<= div>Thanks,
Neel Patel

On Tue, Apr 5, 2016 at 9:59 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Apr 5, 2016 at 12:40 PM, Neel Patel <neel.patel@enterprisedb.com> w= rote:
> Hi,
>
> Please find attached debugger v1 patch. To test this patch we need to = apply
> the "function" module patch submitted by Khushboo.
>
> For the debugger functionality, direct and indirect debugging is worki= ng as
> per pgadmin3 except below TODOs.
>
> Below are the TODOs which will be submitted in next patch along with t= he
> fixed review comments.
>
> For the direct debugging, 'NULL' and 'Expression' colu= mn value should be
> validated before pressing the debug button.
> User can deposit the value of input arguments and local variable but n= eed to
> be
> validated against respective data types.
> Currently we have tested for plpgsql functions only, We need to test a= gainst
> EDB SPL functions and trigger functions.
> For the direct debugging, once the execution is completed, only
> "Continue/Restart" button will be enabled and user should al= low to restart
> the debugging with same function and previous values.
> Values entered by the user in input dialog during direct debugging sho= uld be
> saved.
>
>
> Currently we have tested this patch with PostgreSQL v9.5.
>
> Do review it and let us know for the comments.

I just get a blank tab when I try to debug something. I do see the params dialogue, but then nothing. Note:

- I have Akshay's Query Tool patch applied, and am running from git mas= ter

- PostgreSQL 9.4, with the debugger plugin in the public schema.

- Various functions in the pem schema tested, both with and without paramet= ers.

- Both direct and indirect debugging have the same issue.

- No errors seen in the console, except when closing the debugger tab:

2016-04-05 17:27:37,720: INFO werkzeug: 127.0.0.1 - - [05/Apr/2016
17:27:37] "GET /debugger/close/8569717 HTTP/1.1" 500 -
Traceback (most recent call last):
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1836, in __call__
=C2=A0 =C2=A0 return self.wsgi_app(environ, start_response)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1820, in wsgi_app
=C2=A0 =C2=A0 response =3D self.make_response(self.handle_exception(e))
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1403, in handle_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1817, in wsgi_app
=C2=A0 =C2=A0 response =3D self.full_dispatch_request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1477, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1381, in handle_user_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1475, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1461, in dispatch_request
=C2=A0 =C2=A0 return self.view_functions[rule.endpoint](**req.view_args) =C2=A0 File "/Users/dpage/git/pgadmin4-demo/web/pgadmin/tools/debugger= /__init__.py",
line 397, in close
=C2=A0 =C2=A0 session_id=3Dobj['session_id'])
KeyError: 'session_id'


Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a114d6f26544187052fcaf5e9--