Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aRBp8-0007Xi-U7 for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Feb 2016 04:47:19 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aRBp7-0002WD-V2 for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Feb 2016 04:47:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aRBot-0002HX-Ok for pgadmin-hackers@postgresql.org; Thu, 04 Feb 2016 04:47:04 +0000 Received: from mail-yw0-x233.google.com ([2607:f8b0:4002:c05::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aRBof-0007pp-Fa for pgadmin-hackers@postgresql.org; Thu, 04 Feb 2016 04:47:02 +0000 Received: by mail-yw0-x233.google.com with SMTP id h129so19258003ywb.1 for ; Wed, 03 Feb 2016 20:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=78bbCKDLHoaRBIae0wt6xQrUL9d32HWGYeF1HY0/Uc0=; b=rPUoRGaOqasyrkFgAO1G6KbTguyX5JOelUj2MR+oGe1JDhN+fjaEZjFHD5VRu47QX9 RB7qSbOq4vCdE9lM9C6jF7RptzR+gmdclTFU0vdb8CgBeU2Bg2AHFGHPrEUC5r+RWLxF Tagw/PJ3krwLxk3zBeLiWDXrb1hZYzPtWWGEhUr/v0UCmujYQEEDrUN/F2giCdjL057R Yl9omtH3+MTrLtNbdSlmTLkAOxT3cxJiwnq+1ofieQac2tqxK6VtspR8xpfzpHQ0IXua nYFKBe6WQHR5owUTytD6v2nc8H1JLsQxLDTJxwUNG1lnjQFNWwJ3S8KP9dohpVut2MZr 3xOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=78bbCKDLHoaRBIae0wt6xQrUL9d32HWGYeF1HY0/Uc0=; b=CoVfaSAlWa0NzcHyvzm0mD0pyy7O5UfuABi+RhqFiVGf9J1ZV/NbJxnI19rx+vVcHj 8IXWnrwfee9mYSCAk7H773uqd+08O6dtglAV48hdkJELdNtVhf5vECcKnhZ0SoL6wcgC SNUoWmPkuyNiLVO1Aa3eVWYUvZvIHr6KvPbVP0XsUw8HoTdvn5a1MhRyZGy/ob/+GP6W mPR8+5O3/pfXpoTuNRGG9RdR6YTQIT3+gm+c7R5EXXPt5ijPos0mV6ZcYuOFL4F2GBH4 uUDyUDZlb1cMOjAovIPE0IO8bfIajjd0ENe7R457EeZsqnceiudcJY+c8EtuEG/PMVFt k73w== X-Gm-Message-State: AG10YOR6uWdciSbkTuk8kL3d7qv18oCoPA6tjCce/JhDhxcIwlGT6cJEEgA4UidTAcnqR8wPLsAV51ykaoxZvyZw MIME-Version: 1.0 X-Received: by 10.13.240.69 with SMTP id z66mr3056893ywe.330.1454561208357; Wed, 03 Feb 2016 20:46:48 -0800 (PST) Received: by 10.37.202.75 with HTTP; Wed, 3 Feb 2016 20:46:48 -0800 (PST) In-Reply-To: References: Date: Thu, 4 Feb 2016 10:16:48 +0530 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Extension Module From: Neel Patel To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c035cd82105ee052aea6ceb X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c035cd82105ee052aea6ceb Content-Type: text/plain; charset=UTF-8 Hi Surinder, While applying the patch, we are getting below warnings. extension_v3.patch:362: trailing whitespace. This function will generate sql for sql panel extension_v3.patch:646: trailing whitespace. -- Extension: {{ conn|qtIdent(data.name) }} warning: 2 lines add whitespace errors. Can you please resend the patch file, after fixing above warnings ? Thanks, Neel Patel On Fri, Jan 22, 2016 at 12:25 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi > > Please find the updated patch with following fixes: > 1. Missing `owner` column under properties for `extensions collection`. > Add cell: 'string' property for owner fixed it > 2. Schema object identifier should be wrapped with in function qtIdent . > Using function `qtIdent` for schema in create.sql fixed it. > > > Thanks > Surinder Kumar > > On Thu, Jan 21, 2016 at 8:04 PM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> Hi, >> >> I've fixed the issues given in review comments. >> >> Please find the attached updated patch for extension module, review it >> and let me know for any comments. >> >> On Mon, Jan 18, 2016 at 5:44 PM, Surinder Kumar < >> surinder.kumar@enterprisedb.com> wrote: >> >>> Thanks Neel for reviewing. I'll send the patch with the fixes suggested. >>> >>> On Mon, Jan 18, 2016 at 4:52 PM, Neel Patel >> > wrote: >>> >>>> Hi Surinder, >>>> >>>> We have applied/tested the patch and below are the review comments. >>>> >>>> 1. When we select the extension "plpython3u", "plperl", "plperu" etc. >>>> then it gives 'TypeError' in Javascript. >>>> TypeError: d.version is undefined >>>> 'version': (!_.isNull(d.version[0]) ? d.version[0]: '') >>>> >>>> We are getting this error while selecting many extensions so please >>>> test with all types of extensions, it should not give any error at client >>>> side. >>>> >>> Fixed. >> >>> >>>> 2. Use 2 space indentation instead of 4 space in javascript file. >>>> >>> Done >> >>> >>>> 3. In "validate" function in "extension.js" file, validate only the >>>> changed values not all, and "this.get('name') - should be called only one >>>> time not multiple >>>> time". >>>> >>> Fixed. >> >>> >>>> 4. When we pass object identifier, use the function 'qtIdent', and for >>>> the values, use function 'qtLiteral' in all the sql files. >>>> >>> Done. >> >>> >>>> 5. By default, when we create the extension, "schema_name" and >>>> "version" should not be be set with value. It should be set blank by >>>> default. >>>> >>> Kept blank while creating extension. >> >>> >>>> 6. When we create any extension like "citext" then we are not able to >>>> create the same extension again after deleting the same extension. May be >>>> issue >>>> with caching mechanism. >>>> >>> It is an architecture change. we'll fix it later. >> >>> >>>> 7. When we remove the schema_name during the "Edit" operation then >>>> wrong SQL is getting generated. >>>> >>> Fixed, Now it generates right SQL. >> >>> >>>> >>> 8. Remove "Use Slony" option. As discussed with Ashesh, we will >>>> implement it as separate module. >>>> >>> Removed. >> >>> >>>> Please fix the above issues. Let us know if you want more information. >>>> >>>> Thanks, >>>> Neel Patel >>>> >>>> >>>> Thanks, >>>> Neel Patel >>>> >>>> >>>> On Tue, Jan 12, 2016 at 1:15 PM, Surinder Kumar < >>>> surinder.kumar@enterprisedb.com> wrote: >>>> >>>>> Please find the updated patch with following changes: >>>>> >>>>> 1. corrected copyright. >>>>> 2. Added proper comment for script_module function in __init__.py >>>>> file. >>>>> 3. Renamed collection Node's label to Extensions in extensions.js >>>>> file. >>>>> >>>>> >>>>> On Tue, Jan 12, 2016 at 12:44 PM, Surinder Kumar < >>>>> surinder.kumar@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Please find attached patch for the extension module. >>>>>> Please review it and Let me know for any comments. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Surinder Kumar >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>> >> > --94eb2c035cd82105ee052aea6ceb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Surinder,

While applying the patch, = we are getting below warnings.

extension_v3.p= atch:362: trailing whitespace.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 This f= unction will generate sql for sql panel=C2=A0
extension_v3.patch:= 646: trailing whitespace.
-- Extension: {{ conn|qtIdent(data.name) }}=C2=A0
warning: 2 lines ad= d whitespace errors.


Can you = please resend the patch file, after fixing above warnings ?

<= /div>
Thanks,
Neel Patel

On Fri, Jan 22, 2016 at 12:25 PM, Surinder= Kumar <surinder.kumar@enterprisedb.com> wrote= :
Hi

= Please find the updated patch with following fixes:
1. Missing `o= wner` column under properties for `extensions collection`. Add cell: 's= tring' property for owner fixed it
2. Schema object identifie= r should be wrapped with in function qtIdent . Using function `qtIdent` for= schema in create.sql fixed it.


Tha= nks
Surinder Kumar=

On Thu, Jan 21, 2016 at 8:= 04 PM, Surinder Kumar <surinder.kumar@enterprisedb.com&g= t; wrote:
Hi,
I've fixed the issues given in review comments.

Please find the attached updated patch for extension modu= le, review it and let me know for any comments.

On Mon, Jan 18, 2016 = at 5:44 PM, Surinder Kumar <surinder.kumar@enterprisedb.com<= /a>> wrote:
Th= anks Neel for reviewing. I'll send the patch with the fixes suggested.<= /div>

On= Mon, Jan 18, 2016 at 4:52 PM, Neel Patel <neel.patel@enterprise= db.com> wrote:
Hi Surinder,

We have applied/tested the patch and b= elow are the review comments.

1. When we sele= ct the extension "plpython3u", "plperl", "plperu&q= uot; etc. then it gives 'TypeError' in Javascript.
TypeEr= ror: d.version is undefined
'version': (!_.isNull(d.versi= on[0]) ? d.version[0]: '')

We are getting = this error while selecting many extensions so please test with all types of= extensions, it should not give any error at client side.
=
Fixed.=C2=A0<= /div>

2.=C2=A0 Use 2 space indentation instead of 4 = space in javascript file.
<= /div>
Done

3. In "vali= date" function in "extension.js" file, validate only the cha= nged values not all, and "this.get('name') - should be called = only one time not multiple=C2=A0
=C2=A0 =C2=A0 time".
<= /div>
Fixed.= =C2=A0

4.=C2=A0Whe= n we pass object identifier, use the function 'qtIdent', and for th= e values, use function =C2=A0'qtLiteral' in all the sql files.
Done.=C2=A0
=

5. By default, when we create the exte= nsion, "schema_name" and "version" should not be be set= with value. It should be set blank by default.
Kept blank while creating ext= ension.=C2=A0

6. When we create any extension like = "citext" then we are not able to create the same extension again = after deleting the same extension. May be issue=C2=A0
=C2=A0 =C2= =A0 with caching mechanism.
It is an architecture change. we'll fix it la= ter.=C2=A0
=

7. When we remove the schema_name duri= ng the "Edit" operation then wrong SQL is getting generated.
Fixed,= Now it generates right SQL.
= =C2=A0
=
8. Remove "Use Slony" option. As discussed with Ashesh, = we will implement it as separate module.
Removed.=C2=A0

Please fix the above issues. Let us know if you want more information.

Thanks,
Neel Patel


Thanks,
Neel Patel


On Tue, J= an 12, 2016 at 1:15 PM, Surinder Kumar <surinder.kumar@enter= prisedb.com> wrote:
Please find the updated patch with followin= g changes:
  1. corrected copyright.
  2. Added proper comment fo= r script_module function in __init__.py file.
  3. Renamed collection No= de's label to Extensions in extensions.js file.

On Tue, J= an 12, 2016 at 12:44 PM, Surinder Kumar <surinder.kumar@ente= rprisedb.com> wrote:
Hi,

Please find attached patch for= the extension module.
Please review it and Let me know for any comments= .


Thanks,
Surinder Kumar<= /div>



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






--94eb2c035cd82105ee052aea6ceb--