Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buZ2V-0001ZX-8O for pgadmin-hackers@arkaria.postgresql.org; Thu, 13 Oct 2016 05:58:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1buZ2T-00034x-Ei for pgadmin-hackers@arkaria.postgresql.org; Thu, 13 Oct 2016 05:58:45 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1buZ2S-00034o-Ol for pgadmin-hackers@postgresql.org; Thu, 13 Oct 2016 05:58:44 +0000 Received: from mail-lf0-x233.google.com ([2a00:1450:4010:c07::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1buZ2P-0000uK-BJ for pgadmin-hackers@postgresql.org; Thu, 13 Oct 2016 05:58:43 +0000 Received: by mail-lf0-x233.google.com with SMTP id b81so116586455lfe.1 for ; Wed, 12 Oct 2016 22:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=M5x/VntWHqTPhhomAvmp8gR1MF1FblUE5nvq7GrKpBY=; b=XVGn0dmGEdYPFre4xdpo0T/lyp3jq5kQPLTiOrW29SLxCj7H5oKTiyLXMSF/npD8fg 68SDLXETL6lyesPejYld2d2VNsbFtkeNZgTMTqTWoN79Md73G4RCI61eVScNX6tkkgkC BPR+UHqWgkA5CIAzt0+w3dDoLNWTkvwdMLsyr4eYFN2n+BADhDWuvoPovTf8JDQXPSyW GqSdsoLys2Gq7ZD0iWhCJ5SQGtQpuGLlUGqQ2nlmBGlH8ZeSy/QOaKHlKTnlX+Me8GjV SXobe4IiJrCyxbVlj7hc5Kbi2A+vusanLsJgLta8cg1Dhr8YNr8UE5VntGzso3no4r+R 3CFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=M5x/VntWHqTPhhomAvmp8gR1MF1FblUE5nvq7GrKpBY=; b=eaIX8kn1ujiWfjF+DurFJUWb0TyZ1dnBNULW71vnHY0hg0aNUsArT7WbkT07jWhPkt ZDbDWVeG+9FBf3GtywSsWFlOT7TLle+VXyJExJk6Z8jzyMdpM1ghzLJ0LAH0WAJajf64 Ib+W8Sa94xr2ghknGk/Rihb+a68pz3TgZ8OFYiAaNWaArAsvhPc0DbVNbRFgIz7q9H+v 1R27pT54fT59GajqQoVa9DvxlPQxiH91aNYLCFvC5+roVXFBT8FYk7OfUXhQNbUNQTVj OsctXtfYCJadQYX5v9Rzk3NBDIa98JfhpfwgQR+1+/RnW/Eg0DPHeVKuaNATLGjPDfTt HnyA== X-Gm-Message-State: AA6/9RkshQ+UmMBl1XNVQa92W9FDD4VCcYNpAaqk5uZ+ENGAQIYYd1cXviIteki2jjNUWL+cje088kOdnBHxl5J7 X-Received: by 10.28.35.75 with SMTP id j72mr764494wmj.8.1476338318146; Wed, 12 Oct 2016 22:58:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.135.227 with HTTP; Wed, 12 Oct 2016 22:58:37 -0700 (PDT) In-Reply-To: References: From: Neel Patel Date: Thu, 13 Oct 2016 11:28:37 +0530 Message-ID: Subject: Re: [Patch][pgAdmin4]: RM#1577 - Debug option for function/procedure under package node To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113eae2e05942e053eb8cd1f X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113eae2e05942e053eb8cd1f Content-Type: text/plain; charset=UTF-8 Hi Dave, On Fri, Oct 7, 2016 at 5:19 PM, Dave Page wrote: > Thanks, applied. Couple of questions/points: > > - If there is no body for a procedure, the error is handled somewhat > ungracefully - the message is displayed without line breaks, and the > debugger panel is left empty. Can we make that a little nicer? > OK, I will work on that. > > - In pgAdmin 3 there's a "Debug package initialiser?" option on the > parameter dialogue. Is that shown for appropriate packages? I don't > have an example to hand to test with. > Currently no option for "Debug package initialiser". I will submit updated patch for both above points. > > On Fri, Oct 7, 2016 at 11:55 AM, Neel Patel > wrote: > > Hi, > > > > Please find attached patch file which contains function/procedure debug > > support under package node. (RM #1577) > > > > Do review it and let me know for any comments. > > > > Thanks, > > Neel Patel > > > > > > -- > > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113eae2e05942e053eb8cd1f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

On Fri, Oct 7, 2016 at 5:19 PM, Dave Page <dpage@pgadmin.org&g= t; wrote:
Thank= s, applied. Couple of questions/points:

- If there is no body for a procedure, the error is handled somewhat
ungracefully - the message is displayed without line breaks, and the
debugger panel is left empty. Can we make that a little nicer?
=C2=A0
OK, I will work on that.

- In pgAdmin 3 there's a "Debug package initialiser?" option = on the
parameter dialogue. Is that shown for appropriate packages? I don't
have an example to hand to test with.
=C2=A0
Currently no option for "Debug package initialiser".
= =C2=A0
I will submit updated patch for both above points.



On Fri, Oct 7, 2016 at 11:55 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find attached patch file which contains function/procedure debu= g
> support under package node. (RM #1577)
>
> Do review it and let me know for any comments.
>
> Thanks,
> Neel Patel
>
>
> -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadm= in-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113eae2e05942e053eb8cd1f--