Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1angdz-0000io-Ko for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Apr 2016 06:08:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1angdz-0001yj-7Y for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Apr 2016 06:08:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1angdy-0001yb-Lg for pgadmin-hackers@postgresql.org; Wed, 06 Apr 2016 06:08:46 +0000 Received: from mail-yw0-x233.google.com ([2607:f8b0:4002:c05::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1angdu-0000hm-0p for pgadmin-hackers@postgresql.org; Wed, 06 Apr 2016 06:08:46 +0000 Received: by mail-yw0-x233.google.com with SMTP id i84so38150972ywc.2 for ; Tue, 05 Apr 2016 23:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=+M5zFUJYJXodO45W6ji+5fVusLFZHRkhC54lB/G444A=; b=TTdo06ortgEl248ubWBmeiSmZJ/bfKs//PajEyarGHYn/dyillxplVaZrl0zHbuXM9 fGDLc5DZojMncOZ5XIXaqfk0qyMnTOjPws6o7DQGVJReFX5MoCgu8yPbT43uZBygn7Zj m6MuYhK4Op9zW14VRvJTQsT0tVMktipKxv6rzl9XqhQxWzbccJjc9Dab1Bd321I30tCo Wl4qgSFKedadDuM2JAHjNF4Yw7PVDwqq9j/u1phgg7Zmh3vJcgc3C/8j5Wz0cSpv0R1c DczvfukLpJvpY77PROrWW+xwK5+UK0KT5RvsbRGnrBnjXsP2ItsKknwHHOC59tsc6iVh u/Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=+M5zFUJYJXodO45W6ji+5fVusLFZHRkhC54lB/G444A=; b=NKku0PGOqDLh1E9u7A1jVqgUB9i8pD6BgT+cgVezF8JcZHSLhjXRa1l5zqEVjlxhD1 EYgSgwe1b5aucr5Agb0MqOY26Vd7iFZjbiZDhI4kkiFBk8wz91Ot4LW0s/UZQhimdJuw 8ZFuUH5IXKN8v0BGyfpRbAf0AZ2pLjO80tnGLKh7xYnyYExU30IHvlCfILk92L7cQQ5H Bcg8vq9fRBTwyav9pR71aS2P9ayk0DsQsDqsR1xFs4GRm6OaHSsgCnT9EYikeUf/OsWK aMTA0/n/kjURDAbBZhqI/g6gdo4rvyB/8ydvzNtge3UXu02HcoxxkyZyIbHnLUeiMiMx ie6w== X-Gm-Message-State: AD7BkJKXfvpd9jgMzZUjOrWsI+fzdVzRpB6yQ8YMMJLyRBLj6OAjv+2Hq00mIXll8P5zBQab8HZSZ8nN17be41T1 MIME-Version: 1.0 X-Received: by 10.13.234.85 with SMTP id t82mr14682973ywe.195.1459922920327; Tue, 05 Apr 2016 23:08:40 -0700 (PDT) Received: by 10.37.218.76 with HTTP; Tue, 5 Apr 2016 23:08:40 -0700 (PDT) In-Reply-To: References: Date: Wed, 6 Apr 2016 11:38:40 +0530 Message-ID: Subject: Re: [pgAdmin4][Debugger]: Initial Patch From: Neel Patel To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c06c43410f9e3052fcacbb3 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c06c43410f9e3052fcacbb3 Content-Type: text/plain; charset=UTF-8 Hi Dave, We will fix the error "KeyError: 'session_id'" but regarding the blank tab, we have tried with PostgreSQL 9.4 with both the version of python (2.7 & 3.4) but we are not able to reproduce the issue. Below are some of the questions to debug the issue. - Is it only reproduce on PostgreSQL 9.4 ? Is it working on PostgreSQL 9.5 ? - Is it possible to know the debugger version ? - The issue is reproduce on specific functions ? If yes, can you please give definition of the function ? - Are you able to see toolbar buttons ? Or nothing on the screen ? Only blank panel ? - Can you please share request/response of last request URL sent to server in browser ? Thanks, Neel Patel On Tue, Apr 5, 2016 at 9:59 PM, Dave Page wrote: > Hi > > On Tue, Apr 5, 2016 at 12:40 PM, Neel Patel > wrote: > > Hi, > > > > Please find attached debugger v1 patch. To test this patch we need to > apply > > the "function" module patch submitted by Khushboo. > > > > For the debugger functionality, direct and indirect debugging is working > as > > per pgadmin3 except below TODOs. > > > > Below are the TODOs which will be submitted in next patch along with the > > fixed review comments. > > > > For the direct debugging, 'NULL' and 'Expression' column value should be > > validated before pressing the debug button. > > User can deposit the value of input arguments and local variable but > need to > > be > > validated against respective data types. > > Currently we have tested for plpgsql functions only, We need to test > against > > EDB SPL functions and trigger functions. > > For the direct debugging, once the execution is completed, only > > "Continue/Restart" button will be enabled and user should allow to > restart > > the debugging with same function and previous values. > > Values entered by the user in input dialog during direct debugging > should be > > saved. > > > > > > Currently we have tested this patch with PostgreSQL v9.5. > > > > Do review it and let us know for the comments. > > I just get a blank tab when I try to debug something. I do see the > params dialogue, but then nothing. Note: > > - I have Akshay's Query Tool patch applied, and am running from git master > > - PostgreSQL 9.4, with the debugger plugin in the public schema. > > - Various functions in the pem schema tested, both with and without > parameters. > > - Both direct and indirect debugging have the same issue. > > - No errors seen in the console, except when closing the debugger tab: > > 2016-04-05 17:27:37,720: INFO werkzeug: 127.0.0.1 - - [05/Apr/2016 > 17:27:37] "GET /debugger/close/8569717 HTTP/1.1" 500 - > Traceback (most recent call last): > File > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", > line 1836, in __call__ > return self.wsgi_app(environ, start_response) > File > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", > line 1820, in wsgi_app > response = self.make_response(self.handle_exception(e)) > File > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", > line 1403, in handle_exception > reraise(exc_type, exc_value, tb) > File > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", > line 1817, in wsgi_app > response = self.full_dispatch_request() > File > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", > line 1477, in full_dispatch_request > rv = self.handle_user_exception(e) > File > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", > line 1381, in handle_user_exception > reraise(exc_type, exc_value, tb) > File > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", > line 1475, in full_dispatch_request > rv = self.dispatch_request() > File > "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", > line 1461, in dispatch_request > return self.view_functions[rule.endpoint](**req.view_args) > File > "/Users/dpage/git/pgadmin4-demo/web/pgadmin/tools/debugger/__init__.py", > line 397, in close > session_id=obj['session_id']) > KeyError: 'session_id' > > > Thanks. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c06c43410f9e3052fcacbb3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

We = will fix the error "KeyError: 'session_id'" but re= garding the blank tab, we have tried with PostgreSQL 9.4 with both the vers= ion of python (2.7 & 3.4) but we are not able to reproduce the issue.

Below are some of the questions to debug= the issue.
  • Is it only reproduce on PostgreSQL 9.4 ? Is i= t working on PostgreSQL 9.5 ?
  • Is it possible to know the debugger v= ersion ?
  • The issue is reproduce on specific functions ? If yes, can= you please give definition of the function ?
  • Are you able to see t= oolbar buttons ? Or nothing on the screen ? Only blank panel ?
  • Can = you please share request/response of last request URL sent to server in bro= wser ?
Thanks,
Neel Patel

On Tue, Apr 5, 2016= at 9:59 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Apr 5, 2016 at 12:40 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
> Hi,
>
> Please find attached debugger v1 patch. To test this patch we need to = apply
> the "function" module patch submitted by Khushboo.
>
> For the debugger functionality, direct and indirect debugging is worki= ng as
> per pgadmin3 except below TODOs.
>
> Below are the TODOs which will be submitted in next patch along with t= he
> fixed review comments.
>
> For the direct debugging, 'NULL' and 'Expression' colu= mn value should be
> validated before pressing the debug button.
> User can deposit the value of input arguments and local variable but n= eed to
> be
> validated against respective data types.
> Currently we have tested for plpgsql functions only, We need to test a= gainst
> EDB SPL functions and trigger functions.
> For the direct debugging, once the execution is completed, only
> "Continue/Restart" button will be enabled and user should al= low to restart
> the debugging with same function and previous values.
> Values entered by the user in input dialog during direct debugging sho= uld be
> saved.
>
>
> Currently we have tested this patch with PostgreSQL v9.5.
>
> Do review it and let us know for the comments.

I just get a blank tab when I try to debug something. I do see the params dialogue, but then nothing. Note:

- I have Akshay's Query Tool patch applied, and am running from git mas= ter

- PostgreSQL 9.4, with the debugger plugin in the public schema.

- Various functions in the pem schema tested, both with and without paramet= ers.

- Both direct and indirect debugging have the same issue.

- No errors seen in the console, except when closing the debugger tab:

2016-04-05 17:27:37,720: INFO werkzeug: 127.0.0.1 - - [05/Apr/2016
17:27:37] "GET /debugger/close/8569717 HTTP/1.1" 500 -
Traceback (most recent call last):
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1836, in __call__
=C2=A0 =C2=A0 return self.wsgi_app(environ, start_response)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1820, in wsgi_app
=C2=A0 =C2=A0 response =3D self.make_response(self.handle_exception(e))
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1403, in handle_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1817, in wsgi_app
=C2=A0 =C2=A0 response =3D self.full_dispatch_request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1477, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1381, in handle_user_exception
=C2=A0 =C2=A0 reraise(exc_type, exc_value, tb)
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1475, in full_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_request()
=C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-pac= kages/flask/app.py",
line 1461, in dispatch_request
=C2=A0 =C2=A0 return self.view_functions[rule.endpoint](**req.view_args) =C2=A0 File "/Users/dpage/git/pgadmin4-demo/web/pgadmin/tools/debugger= /__init__.py",
line 397, in close
=C2=A0 =C2=A0 session_id=3Dobj['session_id'])
KeyError: 'session_id'


Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--94eb2c06c43410f9e3052fcacbb3--