Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aL7tk-0003pb-C3 for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jan 2016 11:23:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aL7tj-0004kF-11 for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jan 2016 11:22:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aL7ti-0004k8-Hz for pgadmin-hackers@postgresql.org; Mon, 18 Jan 2016 11:22:58 +0000 Received: from mail-yk0-x22f.google.com ([2607:f8b0:4002:c07::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aL7td-0005sa-AW for pgadmin-hackers@postgresql.org; Mon, 18 Jan 2016 11:22:57 +0000 Received: by mail-yk0-x22f.google.com with SMTP id v14so515882420ykd.3 for ; Mon, 18 Jan 2016 03:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HKe/ycUQMwqN2lFfvQzTrxHbvArITN2YlFbIBHTV0ko=; b=XfviWCsuPB4h4u/D70fpbhBFy+jcoNlvhJAMLF+5Fn9co6P60ZDnA3KfurhpChwLyv AVGisC6I1lxoWyRocV7Q9S1JmJ+mtGpan1a1YjA5pMz68hrxC/1VJZcRsXmntU8yxYe0 yq9CJGpPIFWT3HKib3jGndCPtTRjRLc1Oz3rFP+ArocuEJsEtGPQxyGv/xWManwXuRLt Qanc/cXteWqAgpBEgDv6DN4xBGiskBRFetx5aY4io936IKRPUNHC//k2Iz8c241SI0aZ HxrGbptLZ07SfMVaedh6+3hupKjMAvifAbhpUJMox9c9JpG7gwp8wCfNFf1MuyL+7aqv mcMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=HKe/ycUQMwqN2lFfvQzTrxHbvArITN2YlFbIBHTV0ko=; b=cmLyduYod4wnQii8hlXEyBVUr3xtcZV1x8pV9glgdQEZ5IeqKxqbr00WZakDrtt41A Hrmh7q6iNgbcw3+7fwMzZFzNSmOCOTN4jJoaBWZorgaco06zUSariUYJikdDaM+/KcFm StLrsbYLbcnFWhvK4i7+snVnxxfkXYaXz340fZ6jb3qmsvkPIG+4u6QGEIUR3k5Gh/wC S9FWLNXulIBcyK2pRRGqoZRfA5l4UByNxon3uTG+crFZ+6Rtpq76kZcL8XkbUJNXNvqB lgbnl5HOor/LUwJXAx/MzLCoud8r54MlMLhDYx3+Deafl+uyV3qQBw56aTWILxirVE+B CVXw== X-Gm-Message-State: ALoCoQlPcup7aYWAv1bMsxP/X/ZQvctOGAKoAebBE/3nVKQG93qd96DlwdOEZIV42gtW+tR3r5V83HuUgD+QkIK6EsF8dbR+N/5OAQfiGUFfeUo3gmi+c+k= MIME-Version: 1.0 X-Received: by 10.13.240.69 with SMTP id z66mr16387772ywe.330.1453116170785; Mon, 18 Jan 2016 03:22:50 -0800 (PST) Received: by 10.37.202.75 with HTTP; Mon, 18 Jan 2016 03:22:50 -0800 (PST) In-Reply-To: References: Date: Mon, 18 Jan 2016 16:52:50 +0530 Message-ID: Subject: Re: [pgAdmin4] [Patch]: Extension Module From: Neel Patel To: Surinder Kumar Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c035cd82d83bf052999f9ef X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c035cd82d83bf052999f9ef Content-Type: text/plain; charset=UTF-8 Hi Surinder, We have applied/tested the patch and below are the review comments. 1. When we select the extension "plpython3u", "plperl", "plperu" etc. then it gives 'TypeError' in Javascript. TypeError: d.version is undefined 'version': (!_.isNull(d.version[0]) ? d.version[0]: '') We are getting this error while selecting many extensions so please test with all types of extensions, it should not give any error at client side. 2. Use 2 space indentation instead of 4 space in javascript file. 3. In "validate" function in "extension.js" file, validate only the changed values not all, and "this.get('name') - should be called only one time not multiple time". 4. When we pass object identifier, use the function 'qtIdent', and for the values, use function 'qtLiteral' in all the sql files. 5. By default, when we create the extension, "schema_name" and "version" should not be be set with value. It should be set blank by default. 6. When we create any extension like "citext" then we are not able to create the same extension again after deleting the same extension. May be issue with caching mechanism. 7. When we remove the schema_name during the "Edit" operation then wrong SQL is getting generated. 8. Remove "Use Slony" option. As discussed with Ashesh, we will implement it as separate module. Please fix the above issues. Let us know if you want more information. Thanks, Neel Patel Thanks, Neel Patel On Tue, Jan 12, 2016 at 1:15 PM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Please find the updated patch with following changes: > > 1. corrected copyright. > 2. Added proper comment for script_module function in __init__.py file. > 3. Renamed collection Node's label to Extensions in extensions.js file. > > > On Tue, Jan 12, 2016 at 12:44 PM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> Hi, >> >> Please find attached patch for the extension module. >> Please review it and Let me know for any comments. >> >> >> Thanks, >> Surinder Kumar >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --94eb2c035cd82d83bf052999f9ef Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Surinder,

We have applied/tested the= patch and below are the review comments.

1. = When we select the extension "plpython3u", "plperl", &q= uot;plperu" etc. then it gives 'TypeError' in Javascript.
TypeError: d.version is undefined
'version': (!_.is= Null(d.version[0]) ? d.version[0]: '')

We = are getting this error while selecting many extensions so please test with = all types of extensions, it should not give any error at client side.
=

2.=C2=A0 Use 2 space indentation instead of 4 space in = javascript file.

3. In "validate" = function in "extension.js" file, validate only the changed values= not all, and "this.get('name') - should be called only one ti= me not multiple=C2=A0
=C2=A0 =C2=A0 time".

4.=C2=A0When we pass object identi= fier, use the function 'qtIdent', and for the values, use function = =C2=A0'qtLiteral' in all the sql files.

=
5. By default, when we create the extension, "schema_name" a= nd "version" should not be be set with value. It should be set bl= ank by default.

6. When we create any extension li= ke "citext" then we are not able to create the same extension aga= in after deleting the same extension. May be issue=C2=A0
=C2=A0 = =C2=A0 with caching mechanism.

7. When we remove t= he schema_name during the "Edit" operation then wrong SQL is gett= ing generated.

8. Remove "Use Slony" opt= ion. As discussed with Ashesh, we will implement it as separate module.


Please fix the above issues. Let us kn= ow if you want more information.

Thanks,
Neel Patel


Thanks,
Neel = Patel


On Tue, Jan 12, 2016 at 1:15 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Please find the updated patch with fol= lowing changes:
  1. corrected copyright.
  2. Added proper comme= nt for script_module function in __init__.py file.
  3. Renamed collecti= on Node's label to Extensions in extensions.js file.

<= div class=3D"gmail_quote">On Tue, Jan 12, 2016 at 12:44 PM, Surinder Kumar = <surinder.kumar@enterprisedb.com> wrote:
Hi,

=
Please find attached patch for the extension module.
Please review = it and Let me know for any comments.


Thanks,
Surinder Kumar



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--94eb2c035cd82d83bf052999f9ef--