MIME-Version: 1.0
In-Reply-To: <568A17FD.5030204@enterprisedb.com>
References: <568A17FD.5030204@enterprisedb.com>
Date: Sun, 24 Jan 2016 19:17:26 +0530
Message-ID: 
 <CACCA4P3L+C_Lvm5ri3oV2DXjiuEGsbMLeFgMVEfo4xZ55m3duw@mail.gmail.com>
Subject: Re: Observed bug in pgAdmin3
From: Neel Patel <neel.patel@enterprisedb.com>
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary=001a11c0158e54b70b052a14b1af
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a11c0158e54b70b052a14b1af
Content-Type: multipart/alternative; boundary=001a11c0158e54b703052a14b1ad

--001a11c0158e54b703052a14b1ad
Content-Type: text/plain; charset=UTF-8

Hi,

We have fixed the issue as mentioned below.

*Issue :-*
When we create any collation then two times schema name was appended to
query.

*Fix:-*
With this fix, schema name will appended only one time and create query for
collation will execute correctly.

Please find attached patch file. Review it and let us know for any comments.

Thanks,
Neel Patel

On Mon, Jan 4, 2016 at 12:28 PM, Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

> Hi All,
>
> I observed an issue while creating new collation (in schemas).
>
> Steps to reproduce,
> 1) Connect to postgres database
> 2) Expand 'postgres' database
> 3) Expand 'schemas'
> 4) Expand 'Collations'
> 5) Right click & Click "New Collation..."
>
> Provide > Properties:
>   Name: test-11
>   Owner: postgres
>   Schema: pg_toast
>
> Provide > Definition:
>   Copy collation: pg_catalog."en_IN.utf8"
>
> 6)
> Now click on SQL tab and you will see the wrong sql created, schema name
> is appended twice in alter statement.
>
> CREATE COLLATION pg_toast."test-11" FROM pg_catalog."en_IN.utf8";
> ALTER COLLATION *pg_toast."pg_toast.""test-11"""*
>   OWNER TO postgres;
>
>
> Let me know for more information.
>
> Regards,
> Murtuza Zabuawala
>
>

--001a11c0158e54b703052a14b1ad
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>We have fixed the issue as mentione=
d below.</div><div><br></div><div><b>Issue :-</b></div><div>When we create =
any collation then two times schema name was appended to query.</div><div><=
br></div><div><b>Fix:-</b></div><div>With this fix, schema name will append=
ed only one time and create query for collation will execute correctly.</di=
v><div><br></div><div>Please find attached patch file. Review it and let us=
 know for any comments.</div><div><br></div><div>Thanks,</div><div>Neel Pat=
el</div></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On =
Mon, Jan 4, 2016 at 12:28 PM, Murtuza Zabuawala <span dir=3D"ltr">&lt;<a hr=
ef=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank">murtuza.=
zabuawala@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex">
=20=20

=20=20=20=20
=20=20
  <div bgcolor=3D"#FFFFFF" text=3D"#000000">
    Hi All,<br>
    <br>
    I observed an issue while creating new collation (in schemas).<br>
    <br>
    Steps to reproduce,<br>
    1) Connect to postgres database<br>
    2) Expand &#39;postgres&#39; database<br>
    3) Expand &#39;schemas&#39;<br>
    4) Expand &#39;Collations&#39;<br>
    5) Right click &amp; Click &quot;New Collation...&quot;<br>
    <br>
    Provide &gt; Properties: <br>
    =C2=A0 Name: test-11<br>
    =C2=A0 Owner: postgres<br>
    =C2=A0 Schema: pg_toast<br>
    <br>
    Provide &gt; Definition:<br>
    =C2=A0 Copy collation: pg_catalog.&quot;en_IN.utf8&quot;<br>
    <br>
    6)<br>
    Now click on SQL tab and you will see the wrong sql created, schema
    name is appended twice in alter statement.<br>
    <br>
    CREATE COLLATION pg_toast.&quot;test-11&quot; FROM pg_catalog.&quot;en_=
IN.utf8&quot;;<br>
    ALTER COLLATION <b>pg_toast.&quot;pg_toast.&quot;&quot;test-11&quot;&qu=
ot;&quot;</b><br>
    =C2=A0 OWNER TO postgres;=C2=A0 <br>
    <br>
    <br>
    Let me know for more information.<br>
    <br>
    Regards,<br>
    Murtuza Zabuawala<br>
    <br>
  </div>

</blockquote></div><br></div>

--001a11c0158e54b703052a14b1ad--

--001a11c0158e54b70b052a14b1af
Content-Type: application/octet-stream; name="collation_fix.patch"
Content-Disposition: attachment; filename="collation_fix.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ijslkyou0

ZGlmZiAtLWdpdCBhL3BnYWRtaW4vZGxnL2RsZ0NvbGxhdGlvbi5jcHAgYi9w
Z2FkbWluL2RsZy9kbGdDb2xsYXRpb24uY3BwCmluZGV4IDQ3YWQzYzcuLjQz
MmVmZGYgMTAwNjQ0Ci0tLSBhL3BnYWRtaW4vZGxnL2RsZ0NvbGxhdGlvbi5j
cHAKKysrIGIvcGdhZG1pbi9kbGcvZGxnQ29sbGF0aW9uLmNwcApAQCAtMTc4
LDcgKzE3OCw3IEBAIHd4U3RyaW5nIGRsZ0NvbGxhdGlvbjo6R2V0U3FsKCkK
IAkJfQogCQlzcWwgKz0gd3hUKCI7XG4iKTsKIAotCQlBcHBlbmRPd25lck5l
dyhzcWwsIHd4VCgiQ09MTEFUSU9OICIpICsgc2NoZW1hLT5HZXRRdW90ZWRQ
cmVmaXgoKSArIHF0SWRlbnQobmFtZSkpOworCQlBcHBlbmRPd25lck5ldyhz
cWwsIHd4VCgiQ09MTEFUSU9OICIpICsgbmFtZSk7CiAJfQogCUFwcGVuZENv
bW1lbnQoc3FsLCB3eFQoIkNPTExBVElPTiAiKSArIHF0SWRlbnQoY2JTY2hl
bWEtPkdldFZhbHVlKCkpICsgd3hUKCIuIikgKyBxdElkZW50KEdldE5hbWUo
KSksIGNvbGxhdGlvbik7CiAK

--001a11c0158e54b70b052a14b1af
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--001a11c0158e54b70b052a14b1af--