Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRxi4-0007Hq-Kp for pgadmin-hackers@arkaria.postgresql.org; Fri, 24 Apr 2020 12:45:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jRxi1-0003eN-Pr for pgadmin-hackers@arkaria.postgresql.org; Fri, 24 Apr 2020 12:45:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jRxi1-0003da-DK for pgadmin-hackers@lists.postgresql.org; Fri, 24 Apr 2020 12:45:33 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jRxhk-0006a8-MN for pgadmin-hackers@lists.postgresql.org; Fri, 24 Apr 2020 12:45:31 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 131so7535227lfh.11 for ; Fri, 24 Apr 2020 05:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4DmRKjZ33ExElyR7iD7JxhZf+pAUJUQsrogNNJg5mIg=; b=gdF9la0LHKIEBhB6QyKSz8u3UI/K1Bg12vM2nLgTIUpopUcoiodfkIK/n4lgTC1NOQ 99IdNJtMg4Ec0uz0L2znCOJZumOZ4ETpBSotWuaxt9XjpYdI5HUdK8PQYtlaftwPEDpj D7m5rQ8nyUH15gBJnTwzTOxOAgXFftzWmCG1MY8/CAZDbn18Ni3gNGdp97xuQoy65Gs/ 0Qp86nKb/fJhcFIwj0gFfNvsldoLEgGBC8g06AJDLlB6ALfr5CYSHcFHIKGNjHXaAWzV OKcX/4L1I+xR9+VHuvZT+GH/rf9HQB8sF7CZcPc2wLVpHwgI4COXEWtPkpTAc7d0D0o1 U53Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4DmRKjZ33ExElyR7iD7JxhZf+pAUJUQsrogNNJg5mIg=; b=AmBkc0hEFoTrc6sMEdbSB7oTq1P3tSk6AjJhHRHQsOTiRg/eyhj1HDwyBr8zAQg/ZB zXmhokk5tPPY8iSQVnUhmek0l+hU3ux0zKoFZEdJAGjP2oH/pxLeTUfmHq7e4kI44Tq8 rhb5PMOQFQtI8UgE5WRafdPPsd7AZVjG4vjS+TrTFsvJ4k2HuZr1gOnx5Wkt8Lf7PuW7 V+sr6syMr2RxYEBsjJed8wOGn0q0MeLobm2+w3kR81LtZl9pkaks9n7PeaM96+m77XmL qfnk1uO872Zdu+vm6IImpaABDgw65MR7KoHCt1EGauvR4wRqgEov0udsVaHLxCB45ja/ MZHQ== X-Gm-Message-State: AGi0Pubna09NacFRWaP1abVP4ltoD+Ia1HotfU5rwipymW0l1GSXsrV/ MBPzA088y09LQEfnRUrTiSrf4g5/shs9mo47N8DuNlj2+i1biOgvsZmcfDUd2vGpUXMsaRTiBtf C0cIKTRmt1e48R1XFiC64pxNPuTpHafC8+qF00y+TpnTZ+BtAoDSdbJeHXCr1g5BD0LFK/svM8K Osg5yuqQKtk6qvpAYtNk8NEkIheZjXZI3kRKgPDiWbKpDuDtfy1ISKWaqMWBgL567T9OmCPOhOY bQUsRM= X-Google-Smtp-Source: APiQypKQ4UDs+8+j90itAQtir7+rp9SLm/aEaybZYe91hQCa+/ovu+xLW8RaoBY3qZMWtI+b8tW3a73XX7WNGL7bhSg= X-Received: by 2002:a05:6512:318a:: with SMTP id i10mr6196858lfe.96.1587732314655; Fri, 24 Apr 2020 05:45:14 -0700 (PDT) MIME-Version: 1.0 References: <19439f0142721687531b112ac0a6dfc522caeb2f.camel@gunduz.org> In-Reply-To: <19439f0142721687531b112ac0a6dfc522caeb2f.camel@gunduz.org> From: Neel Patel Date: Fri, 24 Apr 2020 18:15:03 +0530 Message-ID: Subject: Re: pgAgent build warnings on Fedora 32 To: =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009d41b605a408bc04" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009d41b605a408bc04 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I will look into it. On Fri, Apr 24, 2020 at 5:51 PM Devrim G=C3=BCnd=C3=BCz = wrote: > > Hi, > > pgAgent throws the warnings below while compiling it on Fedora 32, which > uses GCC 10. Can you please take a look? > > Thanks! Devrim > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > /usr/bin/make > DESTDIR=3D/var/lib/pgsql/rpm12/BUILDROOT/pgagent_12-4.0.0-4.f32.x86_64 in= stall > In file included from > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/pgAgent.h:36, > from > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:12: > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h: In > constructor 'DBconn::DBconn(const wstring&)': > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:117:= 19: > warning: 'DBconn::m_inUse' will be initialized after [-Wreorder] > 117 | bool m_inUse; > | ^~~~~~~ > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:113:= 19: > warning: 'DBconn* DBconn::m_next' [-Wreorder] > 113 | DBconn *m_next; > | ^~~~~~ > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:21:1: > warning: when initialized here [-Wreorder] > 21 | DBconn::DBconn(const std::wstring &connectString) > | ^~~~~~ > In file included from > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/pgAgent.h:36, > from > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:12: > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:114:= 19: > warning: 'DBconn::m_prev' will be initialized after [-Wreorder] > 114 | DBconn *m_prev; > | ^~~~~~ > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:102:= 19: > warning: 'int DBconn::m_minorVersion' [-Wreorder] > 102 | int m_minorVersion, > | ^~~~~~~~~~~~~~ > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:21:1: > warning: when initialized here [-Wreorder] > 21 | DBconn::DBconn(const std::wstring &connectString) > | ^~~~~~ > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp: In member > function 'std::wstring DBconn::ExecuteScalar(const wstring&)': > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:333:6: > warning: variable 'rows' set but not used [-Wunused-but-set-variable] > 333 | int rows =3D -1; > | ^~~~ > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/job.cpp: In member > function 'int Job::Execute()': > /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/job.cpp:157:9: warning: > unused variable 'last_n_char' [-Wunused-variable] > 157 | int last_n_char =3D 7; > | ^~~~~~~~~~~ > > -- > Devrim G=C3=BCnd=C3=BCz > Open Source Solution Architect, Red Hat Certified Engineer > Twitter: @DevrimGunduz , @DevrimGunduzTR > --0000000000009d41b605a408bc04 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I will look into it.

<= div dir=3D"ltr" class=3D"gmail_attr">On Fri, Apr 24, 2020 at 5:51 PM Devrim= G=C3=BCnd=C3=BCz <devrim@gunduz.or= g> wrote:

Hi,

pgAgent throws the warnings below while compiling it on Fedora 32, which us= es GCC 10. Can you please take a look?

Thanks! Devrim

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D
=C2=A0/usr/bin/make DESTDIR=3D/var/lib/pgsql/rpm12/BUILDROOT/pgagent_12-4.0= .0-4.f32.x86_64 install
In file included from /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/inclu= de/pgAgent.h:36,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0from /var/lib= /pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:12:
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h: In co= nstructor 'DBconn::DBconn(const wstring&)':
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:117:19= : warning: 'DBconn::m_inUse' will be initialized after [-Wreorder]<= br> =C2=A0 117 |=C2=A0 bool=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0m_in= Use;
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^~~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:113:19= : warning:=C2=A0 =C2=A0'DBconn* DBconn::m_next' [-Wreorder]
=C2=A0 113 |=C2=A0 DBconn=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *m_next;
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:21:1: warnin= g:=C2=A0 =C2=A0when initialized here [-Wreorder]
=C2=A0 =C2=A021 | DBconn::DBconn(const std::wstring &connectString)
=C2=A0 =C2=A0 =C2=A0 | ^~~~~~
In file included from /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/inclu= de/pgAgent.h:36,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0from /var/lib= /pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:12:
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:114:19= : warning: 'DBconn::m_prev' will be initialized after [-Wreorder] =C2=A0 114 |=C2=A0 DBconn=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 *m_prev;
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/include/connection.h:102:19= : warning:=C2=A0 =C2=A0'int DBconn::m_minorVersion' [-Wreorder]
=C2=A0 102 |=C2=A0 int=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 m_mi= norVersion,
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0^~~~~~~~~~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:21:1: warnin= g:=C2=A0 =C2=A0when initialized here [-Wreorder]
=C2=A0 =C2=A021 | DBconn::DBconn(const std::wstring &connectString)
=C2=A0 =C2=A0 =C2=A0 | ^~~~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp: In member f= unction 'std::wstring DBconn::ExecuteScalar(const wstring&)': /var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/connection.cpp:333:6: warni= ng: variable 'rows' set but not used [-Wunused-but-set-variable] =C2=A0 333 |=C2=A0 int rows =3D -1;
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 ^~~~
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/job.cpp: In member function= 'int Job::Execute()':
/var/lib/pgsql/rpm12/BUILD/pgAgent-4.0.0-Source/job.cpp:157:9: warning: unu= sed variable 'last_n_char' [-Wunused-variable]
=C2=A0 157 |=C2=A0 =C2=A0 =C2=A0int last_n_char =3D 7;
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~

--
Devrim G=C3=BCnd=C3=BCz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
--0000000000009d41b605a408bc04--