MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZSASdtaDZDYS-=uGrzMTBnutxQ_WvOf9mR13gUzHodEjA@mail.gmail.com>
References: 
 <CAKKotZSASdtaDZDYS-=uGrzMTBnutxQ_WvOf9mR13gUzHodEjA@mail.gmail.com>
From: Neel Patel <neel.patel@enterprisedb.com>
Date: Tue, 20 Sep 2016 15:48:26 +0530
Message-ID: 
 <CACCA4P3RzOCpbPTzvTH2pgA2NhKs=+J0-OBnwo3JN61WhOc4WA@mail.gmail.com>
Subject: Re: PATCH: To fix the issue displaying composite
 result types in debugger (pgAdmin4)
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a1130cb3cd4f29a053cedbfa4
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a1130cb3cd4f29a053cedbfa4
Content-Type: text/plain; charset=UTF-8

Hi Murtuza,

Sure. I will review it.

Thanks,
Neel Patel

On Tue, Sep 20, 2016 at 3:16 PM, Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the issue in debugger where we were not displaying result
> properly in result tab for composite types.
> RM#1662
>
> @Neel,
> Would you please review the patch?
>
> *Issue:*
> Column name key was hardcoded in dict causing overwriting other columns.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--001a1130cb3cd4f29a053cedbfa4
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Murtuza,<div><br></div><div>Sure. I will review it.</di=
v><div><br></div><div>Thanks,</div><div>Neel Patel</div></div><div class=3D=
"gmail_extra"><br><div class=3D"gmail_quote">On Tue, Sep 20, 2016 at 3:16 P=
M, Murtuza Zabuawala <span dir=3D"ltr">&lt;<a href=3D"mailto:murtuza.zabuaw=
ala@enterprisedb.com" target=3D"_blank">murtuza.zabuawala@enterprisedb.com<=
/a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:=
0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi=
,<div><br></div><div>PFA patch to fix the issue in debugger where we were n=
ot displaying result properly in result tab for composite types.</div><div>=
RM#1662</div><div>=C2=A0</div><div>@Neel,</div><div>Would you please review=
 the patch?</div><div><br></div><div><u>Issue:</u></div><div>Column name ke=
y was hardcoded in dict causing overwriting other columns.</div><div><br cl=
ear=3D"all"><div><div data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><=
span style=3D"color:rgb(136,136,136)"><font size=3D"2" face=3D"tahoma, sans=
-serif">--</font></span><div><span style=3D"color:rgb(136,136,136)"><font s=
ize=3D"2" face=3D"tahoma, sans-serif">Regards,</font></span><div><font size=
=3D"2" face=3D"tahoma, sans-serif"><font color=3D"#888888">Murtuza Zabuawal=
a</font><br style=3D"color:rgb(136,136,136)"><span style=3D"color:rgb(136,1=
36,136)">EnterpriseDB:=C2=A0</span><a href=3D"http://www.enterprisedb.com/"=
 rel=3D"noreferrer" style=3D"color:rgb(17,85,204)" target=3D"_blank">http:/=
/www.<wbr>enterprisedb.com</a><br style=3D"color:rgb(136,136,136)"><span st=
yle=3D"color:rgb(136,136,136)">The Enterprise PostgreSQL Company</span></fo=
nt><br style=3D"color:rgb(136,136,136);font-size:12.8px"></div></div></div>=
</div></div>
</div></div>
<br><br>
--<br>
Sent via pgadmin-hackers mailing list (<a href=3D"mailto:pgadmin-hackers@po=
stgresql.org">pgadmin-hackers@postgresql.<wbr>org</a>)<br>
To make changes to your subscription:<br>
<a href=3D"http://www.postgresql.org/mailpref/pgadmin-hackers" rel=3D"noref=
errer" target=3D"_blank">http://www.postgresql.org/<wbr>mailpref/pgadmin-ha=
ckers</a><br>
<br></blockquote></div><br></div>

--001a1130cb3cd4f29a053cedbfa4--