Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aDVHX-00063x-B1 for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Dec 2015 10:44:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aDVHW-000757-G7 for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Dec 2015 10:44:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aDVHI-0006qR-9j for pgadmin-hackers@postgresql.org; Mon, 28 Dec 2015 10:43:48 +0000 Received: from mail-yk0-x235.google.com ([2607:f8b0:4002:c07::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aDVHD-0000RM-JT for pgadmin-hackers@postgresql.org; Mon, 28 Dec 2015 10:43:47 +0000 Received: by mail-yk0-x235.google.com with SMTP id x67so98682537ykd.2 for ; Mon, 28 Dec 2015 02:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=DuSTOOiOKyhU8ZxUZ0UW9nVCtxjprQOHTK5GP/2IcRI=; b=rSEeePzP5CU2MWmnDrse8gUk5+nEMZ5mCkkOCOmGR6Y345K7RBrvdBj6HHFxy1MZ7l 65GeJ1PZqmXDSWG/rWTjH+bIb9O7zirFdqJJmPIIff4Ltra3zjmlzIhDH2o1MHSwOH7b 0XXisCmimM+cufuMgqsF3zMc1wEQ0VH5n9N9XVifqAXmTIeOArsbwenKTXFygO9qQwj7 B41Ijr9zMM3Kint6No5/X8gBMUVFA6JhPjFxqk29IYXLVjRJge07jjC9TfJKH25ey67b aAEcHvPlKSFxdnBLl+Df7lSaEfv7Ga0bcAAp2fMn6d3rmPXQPfnUtJULijV2O3XVHVC6 +0Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=DuSTOOiOKyhU8ZxUZ0UW9nVCtxjprQOHTK5GP/2IcRI=; b=azm+bZXPzA3hxijV22orfAh4/XSWzL3GIzEySyk2LR3IaFzKvad1NKMUhnht4pC6uZ gWjGaD2D+SxcLZibf54UKatYDdTTPNyGMVlPWgiEExAIj68J+fQUhvduyiIfdkAhGq1a irGv4niYK6MFYE/jJpK7piaJnuUPbk1dJDrAh+VogUCvs9niWB4yr/bAMSjTQmBYHmS6 A+tnTdS7XRRjehNQOkxZEZi2iLLqFM8iCq3v2B0+8ZzlIqRZ7CziA06fmbdOJC8F7f95 hxRTQazZK+U1a/10Y6vTm/4Vs2i76nU0zv97bhvBYsOQRtLyp9l9M8lk3wdLSYOkOocB CMGg== X-Gm-Message-State: ALoCoQk5iS7H0ESB2XpojAn9UUk79tXq5WzeKfPT5T3rnoooQWZU2hBg5x0xz0Ag+A/QxTGdyX+NMpzQuASba2Mwg9JrP3YqXY11ULLoMzwcA0dCiijeij0= MIME-Version: 1.0 X-Received: by 10.129.44.65 with SMTP id s62mr38956068yws.40.1451299421443; Mon, 28 Dec 2015 02:43:41 -0800 (PST) Received: by 10.37.202.75 with HTTP; Mon, 28 Dec 2015 02:43:41 -0800 (PST) In-Reply-To: References: <567AA0E4.2030101@math.uni-goettingen.de> <567BDDEC.2070102@math.uni-goettingen.de> Date: Mon, 28 Dec 2015 16:13:41 +0530 Message-ID: Subject: Re: pgAdmin3: check_option translated in View editing dialog From: Neel Patel To: Sebastian Albert Cc: Dave Page , pgadmin-hackers Content-Type: multipart/mixed; boundary=001a114287727ae13e0527f2fa34 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114287727ae13e0527f2fa34 Content-Type: multipart/alternative; boundary=001a114287727ae1360527f2fa32 --001a114287727ae1360527f2fa32 Content-Type: text/plain; charset=UTF-8 Hi Dave, I have fixed the issue. Can you please review the attached patch file ? Let me know for any comments. @Sebastian - Can you please apply and test the attached patch file ? Let us know for any issue. Thanks, Neel Patel On Thu, Dec 24, 2015 at 5:44 PM, Neel Patel wrote: > Hi Sebastian, > > Thank you for the information. Issue is reproduced with the given steps. > I will submit the patch after the fix. > > Thanks, > Neel Patel > > On Thu, Dec 24, 2015 at 5:28 PM, Sebastian Albert < > albert@math.uni-goettingen.de> wrote: > >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA256 >> >> Hi Neel >> >> Thanks for looking into it. Dave is right, it's about the SQL >> statement not working (because of translation appearing for a sort of >> keyword) *unless* edited manually. You should not *have to* edit the >> SQL manually, but due to the issue, you do, no matter what property of >> the view you are trying to change. >> >> So, to reproduce: >> 1. Create a view >> 2. Set language of pgAdmin to German >> 3. Try to change anything on the view, e.g., try to rename it, using >> the properties dialog. >> >> Unless I edit the SQL statement, I am presented an SQL error, which >> comes from the check_option setting being translated. >> >> Happy holidays >> Sebastian >> >> On 24.12.2015 12:20, Dave Page wrote: >> > On Thu, Dec 24, 2015 at 11:18 AM, Neel Patel >> > wrote: >> >> Hi Sebastian, >> >> >> >> We have just tried to reproduce the issue but not able to >> >> understand the issue from the description. >> >> >> >> We followed below steps. >> >> >> >> 1. Change the language to German. 2. Open the existing View's >> >> properties and try to change "With check option". 3. Open SQL >> >> tab - According to change in option, we are able to see and edit >> >> the query. >> >> >> >> Let me know if anything missing in above steps or Can you please >> >> give steps to understand the issue ? >> > >> > Hi Neel, >> > >> > I believe the issue is that "no" is being translated to "nein" in >> > the SQL: >> > >> > ALTER VIEW myview SET (check_option=nein); >> > >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v2 >> >> iQIcBAEBCAAGBQJWe93qAAoJEKZN7hpT3kUKTrgP/1wmrrScAtfvNc269K9+t1sa >> UKyBfyMFvSgcMgydLC6bjsV5ECN2EVeV/qtNy6tGIlpWppzTtXccQxbKvQiwkyT1 >> F3MHM6tp869kegB0N2ZU5mzE+8ko/PaFRAISQomSlpxpDsATZ+5nR3VnFnh5DMde >> 4XYbPvdZWH4Kos9yrWDKTxi5FVHbCvj4m86Qxg8hMlOGUixRDlVx77t1dccchEjq >> OJRenlQWO9x65iRQbobXJtJddyQLplulc7enBgSJapQahQ4QTqe4RTx7f4Qya2B8 >> 9bIndvgIvbI08cnss7BQ8iJvK737gMoHc9CscwEAwadaI69/2QAlB4wtwS5bwIZp >> DIeW+ulNJC40ZX6Ol/QMNZEvm1pBdwncLAUJBaiHht6M9rJcXld99uEPJDfP5wji >> 2M9WAa3fjyLJFV3d1lA2GYujPgUBAr7KCRcAxgQSXopCj8KICYJzCOkP5skHIPlL >> zYEMDML3uATmMPbabhy65/mf44WgzjebnQwM86iwnPRbWzfzSrWyK26fm+9CZ6aF >> kgZvS9bWtQDViS/+6vTMuR3YQK4H+iU88RCIDbrHa8Kn53S8ryglg1f2CKtqrV9z >> 2bNlK+iCNFxHoz1ApDw0CE8cJTKU31fL/B17+gB/bL6cCtnpzyCjNosRtO7vr89b >> 7N9Y5AOnyVwbQD42/3EN >> =KwP3 >> -----END PGP SIGNATURE----- >> > > --001a114287727ae1360527f2fa32 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

I have fixed the issue. Can yo= u please review the attached patch file ? Let me know for any comments.

@Sebastian - Can you please apply and test the attach= ed patch file ? Let us know for any issue.

Thanks,=
Neel Patel

On Thu, Dec 24, 2015 at 5:44 PM, Neel Patel <ne= el.patel@enterprisedb.com> wrote:
Hi Sebastian,

Thank you for the = information. Issue is reproduced with the given steps.
I will sub= mit the patch after the fix.

Thanks,
Nee= l Patel

On Thu, Dec 24, 2015 at 5:28 PM, = Sebastian Albert <albert@math.uni-goettingen.de>= wrote:
-----BEGIN PGP SIGNED MESSA= GE-----
Hash: SHA256

Hi Neel

Thanks for looking into it. Dave is right, it's about the SQL
statement not working (because of translation appearing for a sort of
keyword) *unless* edited manually. You should not *have to* edit the
SQL manually, but due to the issue, you do, no matter what property of
the view you are trying to change.

So, to reproduce:
1. Create a view
2. Set language of pgAdmin to German
3. Try to change anything on the view, e.g., try to rename it, using
the properties dialog.

Unless I edit the SQL statement, I am presented an SQL error, which
comes from the check_option setting being translated.

Happy holidays
Sebastian

On 24.12.2015 12:20, Dave Page wrote:
> On Thu, Dec 24, 2015 at 11:18 AM, Neel Patel
> <n= eel.patel@enterprisedb.com> wrote:
>> Hi Sebastian,
>>
>> We have just tried to reproduce the issue but not able to
>> understand the issue from the description.
>>
>> We followed below steps.
>>
>> 1. Change the language to German. 2. Open the existing View's<= br> >> properties and try to change "With check option". 3. Ope= n SQL
>> tab - According to change in option, we are able to see and edit >> the query.
>>
>> Let me know if anything missing in above steps or Can you please >> give steps to understand the issue ?
>
> Hi Neel,
>
> I believe the issue is that "no" is being translated to &quo= t;nein" in
> the SQL:
>
> ALTER VIEW myview SET (check_option=3Dnein);
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWe93qAAoJEKZN7hpT3kUKTrgP/1wmrrScAtfvNc269K9+t1sa
UKyBfyMFvSgcMgydLC6bjsV5ECN2EVeV/qtNy6tGIlpWppzTtXccQxbKvQiwkyT1
F3MHM6tp869kegB0N2ZU5mzE+8ko/PaFRAISQomSlpxpDsATZ+5nR3VnFnh5DMde
4XYbPvdZWH4Kos9yrWDKTxi5FVHbCvj4m86Qxg8hMlOGUixRDlVx77t1dccchEjq
OJRenlQWO9x65iRQbobXJtJddyQLplulc7enBgSJapQahQ4QTqe4RTx7f4Qya2B8
9bIndvgIvbI08cnss7BQ8iJvK737gMoHc9CscwEAwadaI69/2QAlB4wtwS5bwIZp
DIeW+ulNJC40ZX6Ol/QMNZEvm1pBdwncLAUJBaiHht6M9rJcXld99uEPJDfP5wji
2M9WAa3fjyLJFV3d1lA2GYujPgUBAr7KCRcAxgQSXopCj8KICYJzCOkP5skHIPlL
zYEMDML3uATmMPbabhy65/mf44WgzjebnQwM86iwnPRbWzfzSrWyK26fm+9CZ6aF
kgZvS9bWtQDViS/+6vTMuR3YQK4H+iU88RCIDbrHa8Kn53S8ryglg1f2CKtqrV9z
2bNlK+iCNFxHoz1ApDw0CE8cJTKU31fL/B17+gB/bL6cCtnpzyCjNosRtO7vr89b
7N9Y5AOnyVwbQD42/3EN
=3DKwP3
-----END PGP SIGNATURE-----


--001a114287727ae1360527f2fa32-- --001a114287727ae13e0527f2fa34 Content-Type: application/octet-stream; name="View_Fix.patch" Content-Disposition: attachment; filename="View_Fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iipu5lpz0 ZGlmZiAtLWdpdCBhL3BnYWRtaW4vZGxnL2RsZ1ZpZXcuY3BwIGIvcGdhZG1p bi9kbGcvZGxnVmlldy5jcHAKaW5kZXggNGZiNTEwYS4uOTk5MWMzOCAxMDA2 NDQKLS0tIGEvcGdhZG1pbi9kbGcvZGxnVmlldy5jcHAKKysrIGIvcGdhZG1p bi9kbGcvZGxnVmlldy5jcHAKQEAgLTM1OCwxMiArMzU4LDcgQEAgaW50IGRs Z1ZpZXc6OkdvKGJvb2wgbW9kYWwpCiAJCQkJRGlzYWJsZU1hdGVyaWFsaXpl ZFZpZXcoKTsKIAkJCX0KIAotCQkJaWYgKHZpZXctPkdldENoZWNrT3B0aW9u KCkuQ21wKHd4VCgiY2FzY2FkZWQiKSkgPT0gMCkKLQkJCQljYkNoZWNrT3B0 aW9uLT5TZXRTZWxlY3Rpb24oMik7Ci0JCQllbHNlIGlmICh2aWV3LT5HZXRD aGVja09wdGlvbigpLkNtcCh3eFQoImxvY2FsIikpID09IDApCi0JCQkJY2JD aGVja09wdGlvbi0+U2V0U2VsZWN0aW9uKDEpOwotCQkJZWxzZQotCQkJCWNi Q2hlY2tPcHRpb24tPlNldFNlbGVjdGlvbigwKTsKKwkJCWNiQ2hlY2tPcHRp b24tPlNldFNlbGVjdGlvbihHZXRJbmRleENoZWNrT3B0aW9uKHZpZXctPkdl dENoZWNrT3B0aW9uKCkpKTsKIAkJfQogCX0KIAllbHNlCkBAIC00NDYsNyAr NDQxLDcgQEAgdm9pZCBkbGdWaWV3OjpDaGVja0NoYW5nZSgpCiAKIAkJaWYg KGNvbm5lY3Rpb24tPkJhY2tlbmRNaW5pbXVtVmVyc2lvbig5LCA0KSAmJiB2 aWV3KQogCQl7Ci0JCQllbmFibGUgPSBlbmFibGUgfHwgY2JDaGVja09wdGlv bi0+R2V0VmFsdWUoKS5Mb3dlcigpLkNtcCh2aWV3LT5HZXRDaGVja09wdGlv bigpKSAhPSAwOworCQkJZW5hYmxlID0gZW5hYmxlIHx8IChjYkNoZWNrT3B0 aW9uLT5HZXRTZWxlY3Rpb24oKSAhPSBHZXRJbmRleENoZWNrT3B0aW9uKHZp ZXctPkdldENoZWNrT3B0aW9uKCkpKTsKIAkJfQogCX0KIApAQCAtNTI2LDcg KzUyMSwxMCBAQCB3eFN0cmluZyBkbGdWaWV3OjpHZXRTcWwoKQogCQkJewog CQkJCWlmICh3aXRob3B0aW9ucy5MZW5ndGgoKSA+IDApCiAJCQkJCXdpdGhv cHRpb25zICs9IHd4VCgiLCAiKTsKLQkJCQl3aXRob3B0aW9ucyArPSB3eFQo ImNoZWNrX29wdGlvbj0iKSArIGNiQ2hlY2tPcHRpb24tPkdldFZhbHVlKCku TG93ZXIoKTsKKwkJCQlpZiAoY2JDaGVja09wdGlvbi0+R2V0U2VsZWN0aW9u KCkgPT0gMSkKKwkJCQkgICAgd2l0aG9wdGlvbnMgKz0gd3hUKCJjaGVja19v cHRpb249bG9jYWwiKTsKKwkJCQlpZiAoY2JDaGVja09wdGlvbi0+R2V0U2Vs ZWN0aW9uKCkgPT0gMikKKwkJCQkgICAgd2l0aG9wdGlvbnMgKz0gd3hUKCJj aGVja19vcHRpb249Y2FzY2FkZWQiKTsKIAkJCX0KIAogCQkJaWYgKHdpdGhv cHRpb25zLkxlbmd0aCgpID4gMCkKQEAgLTczOSwxMiArNzM3LDE3IEBAIHd4 U3RyaW5nIGRsZ1ZpZXc6OkdldFNxbCgpCiAJCQl9CiAKIAkJCWlmIChjb25u ZWN0aW9uLT5CYWNrZW5kTWluaW11bVZlcnNpb24oOSwgNCkKLQkJCSAgICAg ICAgJiYgY2JDaGVja09wdGlvbi0+R2V0VmFsdWUoKS5Mb3dlcigpLkNtcCh2 aWV3LT5HZXRDaGVja09wdGlvbigpKSAhPSAwKQorCQkJICAgICAgICAmJiBj YkNoZWNrT3B0aW9uLT5HZXRTZWxlY3Rpb24oKSAhPSBHZXRJbmRleENoZWNr T3B0aW9uKHZpZXctPkdldENoZWNrT3B0aW9uKCkpICkKIAkJCXsKLQkJCQlp ZiAoY2JDaGVja09wdGlvbi0+R2V0VmFsdWUoKS5DbXAod3hUKCJObyIpKSA9 PSAwKQorCQkJCWlmICgoY2JDaGVja09wdGlvbi0+R2V0U2VsZWN0aW9uKCkp ID09IDApCiAJCQkJCXNxbCArPSB3eFQoIkFMVEVSIFZJRVcgIikgKyBuYW1l ICsgd3hUKCIgUkVTRVQgKGNoZWNrX29wdGlvbik7XG4iKTsKIAkJCQllbHNl Ci0JCQkJCXNxbCArPSB3eFQoIkFMVEVSIFZJRVcgIikgKyBuYW1lICsgd3hU KCJcbiAgU0VUIChjaGVja19vcHRpb249IikgKyBjYkNoZWNrT3B0aW9uLT5H ZXRWYWx1ZSgpLkxvd2VyKCkgKyB3eFQoIik7XG4iKTsKKwkJCQl7CisJCQkJ CWlmIChjYkNoZWNrT3B0aW9uLT5HZXRTZWxlY3Rpb24oKSA9PSAxKQorCQkJ CQkgICAgc3FsICs9IHd4VCgiQUxURVIgVklFVyAiKSArIG5hbWUgKyB3eFQo IlxuICBTRVQgKGNoZWNrX29wdGlvbj1sb2NhbCIpICsgd3hUKCIpO1xuIik7 CisJCQkJCWlmIChjYkNoZWNrT3B0aW9uLT5HZXRTZWxlY3Rpb24oKSA9PSAy KQorCQkJCQkgICAgc3FsICs9IHd4VCgiQUxURVIgVklFVyAiKSArIG5hbWUg KyB3eFQoIlxuICBTRVQgKGNoZWNrX29wdGlvbj1jYXNjYWRlZCIpICsgd3hU KCIpO1xuIik7CisJCQkJfQogCQkJfQogCiAJCQlpZiAod2l0aG9wdGlvbnMu TGVuZ3RoKCkgPiAwKQpAQCAtMTIxOCwzICsxMjIxLDEzIEBAIHZvaWQgZGxn Vmlldzo6RGlzYWJsZVN0b3JhZ2VQYXJhbWV0ZXJzKCkKIAl0eHRUb2FzdEZy ZWV6ZU1heEFnZS0+RGlzYWJsZSgpOwogCXR4dFRvYXN0RnJlZXplVGFibGVB Z2UtPkRpc2FibGUoKTsKIH0KKworaW50IGRsZ1ZpZXc6OkdldEluZGV4Q2hl Y2tPcHRpb24oY29uc3Qgd3hTdHJpbmcgJnN0cikgY29uc3QKK3sKKyAgICBp ZiAoc3RyLkNtcCh3eFQoImxvY2FsIikpID09IDApCisJcmV0dXJuIDE7Cisg ICAgaWYgKHN0ci5DbXAod3hUKCJjYXNjYWRlZCIpKSA9PSAwKQorCXJldHVy biAyOworCisgICAgcmV0dXJuIDA7Cit9CmRpZmYgLS1naXQgYS9wZ2FkbWlu L2luY2x1ZGUvZGxnL2RsZ1ZpZXcuaCBiL3BnYWRtaW4vaW5jbHVkZS9kbGcv ZGxnVmlldy5oCmluZGV4IDUwMDM0ZmEuLjI1YTBjMjAgMTAwNjQ0Ci0tLSBh L3BnYWRtaW4vaW5jbHVkZS9kbGcvZGxnVmlldy5oCisrKyBiL3BnYWRtaW4v aW5jbHVkZS9kbGcvZGxnVmlldy5oCkBAIC00NSw2ICs0NSw3IEBAIHByaXZh dGU6CiAJd3hTdHJpbmcgQXBwZW5kTnVtKGJvb2wgJmNoYW5nZWQsIHd4VGV4 dEN0cmwgKmN0bCwgd3hTdHJpbmcgdmFsKTsKIAl2b2lkIERpc2FibGVNYXRl cmlhbGl6ZWRWaWV3KCk7CiAJdm9pZCBEaXNhYmxlU3RvcmFnZVBhcmFtZXRl cnMoKTsKKwlpbnQgR2V0SW5kZXhDaGVja09wdGlvbihjb25zdCB3eFN0cmlu ZyAmc3RyKSBjb25zdDsKIAogCXBnU2NoZW1hICpzY2hlbWE7CiAJcGdWaWV3 ICp2aWV3Owo= --001a114287727ae13e0527f2fa34 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a114287727ae13e0527f2fa34--