MIME-Version: 1.0
In-Reply-To: 
 <CACCA4P0v_8JGTgqwmeL74Bfm1g7UmtCzw79_nD6g4BNhRPvjyg@mail.gmail.com>
References: 
 <CACCA4P0v_8JGTgqwmeL74Bfm1g7UmtCzw79_nD6g4BNhRPvjyg@mail.gmail.com>
From: Neel Patel <neel.patel@enterprisedb.com>
Date: Mon, 25 Jul 2016 11:31:53 +0530
Message-ID: 
 <CACCA4P3dHgkPte+NYf3yMCXGm=zHo5aEaK5CaSe2n1Hmz2Zg2w@mail.gmail.com>
Subject: Re: [pgAdmin4][patch]: Fix for RM 1320
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=001a114effc2657f1305386f85e4
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a114effc2657f1305386f85e4
Content-Type: text/plain; charset=UTF-8

Adding more details.

*Root cause:-*

When user change schema of already created fdw extension then while
creating the new fdw we should append the <schema_name>.<fdw_handler_name>.
Previously we added only <fdw_handler_name> so while executing the query it
will not be able to find fdw handler name without schema name.

e.g. If user changed the fdw handler 'postgres_fdw_handler' under schema
'test' then we should display the handler  name under fdw as "test.
 postgres_fdw_handler".

*Solution:-*

With this patch, we have added <schema_name>.<fdw_handler_name> so while
creating or updating the fdw, proper sql will be generated.

Thanks,
Neel Patel


On Mon, Jul 25, 2016 at 11:02 AM, Neel Patel <neel.patel@enterprisedb.com>
wrote:

> Hi,
>
> Please find attached patch file for the fix of RM- 1320.
>
> RM-1320 - Unable to create foreign data wrapper when user change the
> schema of extension 'postgres_fdw_handler'.
>
> Thanks,
> Neel Patel
>

--001a114effc2657f1305386f85e4
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Adding more details.<div><br></div><div><b>Root cause:-</b=
></div><div><br></div><div>When user change schema of already created fdw e=
xtension then while creating the new fdw we should append the &lt;schema_na=
me&gt;.&lt;fdw_handler_name&gt;.</div><div>Previously we added only &lt;fdw=
_handler_name&gt; so while executing the query it will not be able to find =
fdw handler name without schema name.</div><div><br></div><div>e.g. If user=
 changed the fdw handler &#39;<span style=3D"font-size:12.8px">postgres_fdw=
_handler</span>&#39; under schema &#39;test&#39; then we should display the=
 handler =C2=A0name under fdw as &quot;test.<span style=3D"font-size:12.8px=
">=C2=A0postgres_fdw_handler</span>&quot;.</div><div><br></div><div><b>Solu=
tion:-</b></div><div><br></div><div>With this patch, we have added &lt;sche=
ma_name&gt;.&lt;fdw_handler_name&gt; so while creating or updating the fdw,=
 proper sql will be generated.</div><div><br></div><div>Thanks,</div><div>N=
eel Patel</div><div><br></div></div><div class=3D"gmail_extra"><br><div cla=
ss=3D"gmail_quote">On Mon, Jul 25, 2016 at 11:02 AM, Neel Patel <span dir=
=3D"ltr">&lt;<a href=3D"mailto:neel.patel@enterprisedb.com" target=3D"_blan=
k">neel.patel@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>Please find attached =
patch file for the fix of RM- 1320.</div><div><br></div><div>RM-1320 - Unab=
le to create foreign data wrapper when user change the schema of extension =
&#39;postgres_fdw_handler&#39;.</div><div><br></div><div>Thanks,</div><div>=
Neel Patel</div></div>
</blockquote></div><br></div>

--001a114effc2657f1305386f85e4--