Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aC4mq-0005yc-Os for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Dec 2015 12:14:28 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aC4mq-0004TC-2p for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Dec 2015 12:14:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aC4mp-0004Sh-Em for pgadmin-hackers@postgresql.org; Thu, 24 Dec 2015 12:14:27 +0000 Received: from mail-yk0-x22d.google.com ([2607:f8b0:4002:c07::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aC4ml-0003zZ-LO for pgadmin-hackers@postgresql.org; Thu, 24 Dec 2015 12:14:26 +0000 Received: by mail-yk0-x22d.google.com with SMTP id x67so35446530ykd.2 for ; Thu, 24 Dec 2015 04:14:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=xOsLl4DAhmJmr9IlDhwAQc7pD1dGJvn7IiM5/N69v70=; b=Qi6PNhStNspt5v+jzU6QslC5GXrQpEKSylJ66Xy9E9Ie+v7LPLb6Sx1oGuGh53vIXg 8B8Q4ZFV5pQDQDADI9P2BwCmQ77Q7/dJ0xTPDHqCccci768OSpR/905hHWQxIzfoJtU6 dy/FPFGBAbw1KtbjxMTSB5QWAiUmKvfdJCkSRdD0uqHgEvLFuuEUOKLeNP3us4EAjuHv xfz5CZ5QUBcieT0Wcr7FqJ+xrzS8GGfDxLpaMd0TJSmR8RYUa0LxwkOw1M4UgpI6RIeq uB2hZQiBO2HK1OfHcuhk8Ta56sjPgpEFhLoagoyleRQ/WManvPlUh4MC87OpsOzI2LjL cpDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=xOsLl4DAhmJmr9IlDhwAQc7pD1dGJvn7IiM5/N69v70=; b=mSgs8lR2LuIP3Ctlb04xXuAurDQT/JHiFlFpbLfgJ40stqdjkTDCE/aRUW/LzL+hnK buxnAKewgF/0qF95Wy0lM6UECIBJMj8+iRMebxtKwsCpy+uH5iovMeJH+vebc713gaeY g8LKDzIZ7xIQYchOWglh6p/lThAb2XFXb6XgivlgytX/X3dLZhVsUPCqLUp8VuIxmLWq MkQ0FztOMIdnzPyYGOh8iWqVA9sOPm1U24CLiKYL92Zqz+L7wj/UYzwAx9cdk3doVKa7 ognIeVbpXMSTHJOP+xYqCIJCwensWf9LCBAJo9L7+I5ZmE+mm46XOKxBdGVEcmeh1SrY xF0A== X-Gm-Message-State: ALoCoQlyC0Dx+bKypKOJ0f6j4Y8yRfY4yzpp96jpgTDrfKPqzCV5LwR1RVzXsTB0lbo0nLbwz+GFSB98/8SzqabRBTEXWsL7b0t7iS+aOoMRR0L6rvoGlDE= MIME-Version: 1.0 X-Received: by 10.13.244.5 with SMTP id d5mr26488415ywf.195.1450959260861; Thu, 24 Dec 2015 04:14:20 -0800 (PST) Received: by 10.37.202.75 with HTTP; Thu, 24 Dec 2015 04:14:20 -0800 (PST) In-Reply-To: <567BDDEC.2070102@math.uni-goettingen.de> References: <567AA0E4.2030101@math.uni-goettingen.de> <567BDDEC.2070102@math.uni-goettingen.de> Date: Thu, 24 Dec 2015 17:44:20 +0530 Message-ID: Subject: Re: pgAdmin3: check_option translated in View editing dialog From: Neel Patel To: Sebastian Albert Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c034d8453fa300527a3c745 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c034d8453fa300527a3c745 Content-Type: text/plain; charset=UTF-8 Hi Sebastian, Thank you for the information. Issue is reproduced with the given steps. I will submit the patch after the fix. Thanks, Neel Patel On Thu, Dec 24, 2015 at 5:28 PM, Sebastian Albert < albert@math.uni-goettingen.de> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Hi Neel > > Thanks for looking into it. Dave is right, it's about the SQL > statement not working (because of translation appearing for a sort of > keyword) *unless* edited manually. You should not *have to* edit the > SQL manually, but due to the issue, you do, no matter what property of > the view you are trying to change. > > So, to reproduce: > 1. Create a view > 2. Set language of pgAdmin to German > 3. Try to change anything on the view, e.g., try to rename it, using > the properties dialog. > > Unless I edit the SQL statement, I am presented an SQL error, which > comes from the check_option setting being translated. > > Happy holidays > Sebastian > > On 24.12.2015 12:20, Dave Page wrote: > > On Thu, Dec 24, 2015 at 11:18 AM, Neel Patel > > wrote: > >> Hi Sebastian, > >> > >> We have just tried to reproduce the issue but not able to > >> understand the issue from the description. > >> > >> We followed below steps. > >> > >> 1. Change the language to German. 2. Open the existing View's > >> properties and try to change "With check option". 3. Open SQL > >> tab - According to change in option, we are able to see and edit > >> the query. > >> > >> Let me know if anything missing in above steps or Can you please > >> give steps to understand the issue ? > > > > Hi Neel, > > > > I believe the issue is that "no" is being translated to "nein" in > > the SQL: > > > > ALTER VIEW myview SET (check_option=nein); > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBCAAGBQJWe93qAAoJEKZN7hpT3kUKTrgP/1wmrrScAtfvNc269K9+t1sa > UKyBfyMFvSgcMgydLC6bjsV5ECN2EVeV/qtNy6tGIlpWppzTtXccQxbKvQiwkyT1 > F3MHM6tp869kegB0N2ZU5mzE+8ko/PaFRAISQomSlpxpDsATZ+5nR3VnFnh5DMde > 4XYbPvdZWH4Kos9yrWDKTxi5FVHbCvj4m86Qxg8hMlOGUixRDlVx77t1dccchEjq > OJRenlQWO9x65iRQbobXJtJddyQLplulc7enBgSJapQahQ4QTqe4RTx7f4Qya2B8 > 9bIndvgIvbI08cnss7BQ8iJvK737gMoHc9CscwEAwadaI69/2QAlB4wtwS5bwIZp > DIeW+ulNJC40ZX6Ol/QMNZEvm1pBdwncLAUJBaiHht6M9rJcXld99uEPJDfP5wji > 2M9WAa3fjyLJFV3d1lA2GYujPgUBAr7KCRcAxgQSXopCj8KICYJzCOkP5skHIPlL > zYEMDML3uATmMPbabhy65/mf44WgzjebnQwM86iwnPRbWzfzSrWyK26fm+9CZ6aF > kgZvS9bWtQDViS/+6vTMuR3YQK4H+iU88RCIDbrHa8Kn53S8ryglg1f2CKtqrV9z > 2bNlK+iCNFxHoz1ApDw0CE8cJTKU31fL/B17+gB/bL6cCtnpzyCjNosRtO7vr89b > 7N9Y5AOnyVwbQD42/3EN > =KwP3 > -----END PGP SIGNATURE----- > --94eb2c034d8453fa300527a3c745 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Sebastian,

Thank you for the informa= tion. Issue is reproduced with the given steps.
I will submit the= patch after the fix.

Thanks,
Neel Patel=

On Th= u, Dec 24, 2015 at 5:28 PM, Sebastian Albert <albert@math.uni= -goettingen.de> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Neel

Thanks for looking into it. Dave is right, it's about the SQL
statement not working (because of translation appearing for a sort of
keyword) *unless* edited manually. You should not *have to* edit the
SQL manually, but due to the issue, you do, no matter what property of
the view you are trying to change.

So, to reproduce:
1. Create a view
2. Set language of pgAdmin to German
3. Try to change anything on the view, e.g., try to rename it, using
the properties dialog.

Unless I edit the SQL statement, I am presented an SQL error, which
comes from the check_option setting being translated.

Happy holidays
Sebastian

On 24.12.2015 12:20, Dave Page wrote:
> On Thu, Dec 24, 2015 at 11:18 AM, Neel Patel
> <neel.patel@enterpri= sedb.com> wrote:
>> Hi Sebastian,
>>
>> We have just tried to reproduce the issue but not able to
>> understand the issue from the description.
>>
>> We followed below steps.
>>
>> 1. Change the language to German. 2. Open the existing View's<= br> >> properties and try to change "With check option". 3. Ope= n SQL
>> tab - According to change in option, we are able to see and edit >> the query.
>>
>> Let me know if anything missing in above steps or Can you please >> give steps to understand the issue ?
>
> Hi Neel,
>
> I believe the issue is that "no" is being translated to &quo= t;nein" in
> the SQL:
>
> ALTER VIEW myview SET (check_option=3Dnein);
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWe93qAAoJEKZN7hpT3kUKTrgP/1wmrrScAtfvNc269K9+t1sa
UKyBfyMFvSgcMgydLC6bjsV5ECN2EVeV/qtNy6tGIlpWppzTtXccQxbKvQiwkyT1
F3MHM6tp869kegB0N2ZU5mzE+8ko/PaFRAISQomSlpxpDsATZ+5nR3VnFnh5DMde
4XYbPvdZWH4Kos9yrWDKTxi5FVHbCvj4m86Qxg8hMlOGUixRDlVx77t1dccchEjq
OJRenlQWO9x65iRQbobXJtJddyQLplulc7enBgSJapQahQ4QTqe4RTx7f4Qya2B8
9bIndvgIvbI08cnss7BQ8iJvK737gMoHc9CscwEAwadaI69/2QAlB4wtwS5bwIZp
DIeW+ulNJC40ZX6Ol/QMNZEvm1pBdwncLAUJBaiHht6M9rJcXld99uEPJDfP5wji
2M9WAa3fjyLJFV3d1lA2GYujPgUBAr7KCRcAxgQSXopCj8KICYJzCOkP5skHIPlL
zYEMDML3uATmMPbabhy65/mf44WgzjebnQwM86iwnPRbWzfzSrWyK26fm+9CZ6aF
kgZvS9bWtQDViS/+6vTMuR3YQK4H+iU88RCIDbrHa8Kn53S8ryglg1f2CKtqrV9z
2bNlK+iCNFxHoz1ApDw0CE8cJTKU31fL/B17+gB/bL6cCtnpzyCjNosRtO7vr89b
7N9Y5AOnyVwbQD42/3EN
=3DKwP3
-----END PGP SIGNATURE-----

--94eb2c034d8453fa300527a3c745--