public inbox for [email protected]  

help / color / mirror / Atom feed

From: Shruti B Iyer <[email protected]>
To: Surinder Kumar <[email protected]>
To: pgadmin-hackers <[email protected]>
Cc: Matthew Kleiman <[email protected]>
Subject: Re: Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool
Date: Mon, 05 Jun 2017 18:08:49 +0000
Message-ID: <CACrUwh+iWeuscD94nZ8SGxfyvs=-JjundJ6sUZDeqDXsxFXC3g@mail.gmail.com> (raw)
In-Reply-To: <CAM5-9D_AAy6vLL3kMDVKPhtpDe_bNFH0o+uc-4RajZFeypFe+g@mail.gmail.com>
References: <CAM5-9D8qbLXBzs3rAjAMUZtj32hDNV11rnymXgxUfKePkqL-rQ@mail.gmail.com>
	<CAM5-9D_AAy6vLL3kMDVKPhtpDe_bNFH0o+uc-4RajZFeypFe+g@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Surinder!

We reviewed this patch. The changes look good and we especially like that
you have extracted out the new utility functions and the epicRandomString
function too.

This patch will likely affect the Query Results patch that is currently
under review
<https://www.postgresql.org/message-id/flat/CAAtBm9V-tNQrtjxt4n8JJek5M4v9KW_h3sgbL1ydcBB%2BtLus2w%40m...;.
In order to assist either us or yourself when making a merge between these
patches, it would help to have jasmine unit testing for the two new
functions, getHash and calculate_column_width.

Also, we suggest that you rename calculate_column_width to
calculateColumnWidth for consistency with javascript code style.

Thanks,
Shruti and Matt

On Mon, Jun 5, 2017 at 9:16 AM Surinder Kumar <
[email protected]> wrote:

> Staged changes are missed in previous patch, so please ignore.
> Please find attached updated patch.
>
> On Mon, Jun 5, 2017 at 4:29 PM, Surinder Kumar <
> [email protected]> wrote:
>
>> Hi
>>
>> This patch contains two fixes:
>>
>> 1) In Query/tool or Edit grid, the width of table column header is fixed
>> depending on the column type(int, boolean, char etc.) due to which the
>> column name or type appears cut from right and doesn't looks good from user
>> point of view. The main concern was to display as much as the content of
>> column should be displayed.
>>
>> Now the width of column is decided using the text length of column name
>> or column type so that the column takes exact width it required and it
>> don't appears cut.
>>
>> 2) Remember column size after re-running a query.
>>
>> The approach is to extract table name from the query executed and use it
>> to store its columns width.
>> Whenever the column(s) width of a table is adjusted, the corresponding
>> values are updated into the object and used every time the same query is
>> executed.
>>
>> If a query is executed for e.g:
>>
>> SELECT generate_series(1, 1000) as id, generate_series(1, 1000) as name,
>> generate_series(1, 1000) as age
>>
>> ​it ​
>> displays 3 columns
>> ​but don't have any table name. In that case,
>>  i use a hash generator function which returns unique hash for a query
>> written in query editor and adjusted column(s) width are stored against
>> that hash in object.
>>
>> Is there any way to get temporary table name(avoiding unique hash) for
>> such queries ?​
>>
>> Also, Moved utilities functions into pgadmin/static/utils.js
>>
>> Please find attached patch and review.
>>
>> Thanks,
>> Surinder Kumar
>>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Re: [pgAdmin4][Patch][Feature #1971]: Remember column sizes between executions of the same query in the query tool
  In-Reply-To: <CACrUwh+iWeuscD94nZ8SGxfyvs=-JjundJ6sUZDeqDXsxFXC3g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox