public inbox for [email protected]  

help / color / mirror / Atom feed

From: Vishal Sawale <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [Accessibility] Parse & validate the web pages
Date: Fri, 3 Apr 2020 14:36:45 +0530
Message-ID: <CADTPKNkAnc--JTERSn9sx=v5yyEJ5upTftk=Zn1ZDmgtDOsbwg@mail.gmail.com> (raw)

Hi Hackers,

PFA the patch for fixing accessibility issues. Patch includes

   1. Fix for search filter label missing in backgrid.
   2. Fix for broken aria issue for objects menu.

Please review and commit.


Regards,
Vishal


Attachments:

  [application/octet-stream] pgadmin_diff.patch (1.6K, 3-pgadmin_diff.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/static/js/browser.js b/web/pgadmin/browser/static/js/browser.js
index e5f74548f..e8ac4afef 100644
--- a/web/pgadmin/browser/static/js/browser.js
+++ b/web/pgadmin/browser/static/js/browser.js
@@ -372,7 +372,7 @@ define('pgadmin.browser', [
         // Create a dummy 'no object seleted' menu
         var create_submenu = pgAdmin.Browser.MenuGroup(
           obj.menu_categories['create'], [{
-            $el: $('<li><a class="dropdown-item disabled" href="#">' + gettext('No object selected') + '</a></li>'),
+            $el: $('<li><a class="dropdown-item disabled" href="#" role="menuitem">' + gettext('No object selected') + '</a></li>'),
             priority: 1,
             category: 'create',
             update: function() {},
diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js
index 0d01e5691..438c5e359 100644
--- a/web/pgadmin/static/js/backgrid.pgadmin.js
+++ b/web/pgadmin/static/js/backgrid.pgadmin.js
@@ -1957,6 +1957,10 @@ define([
    */
   Backgrid.Extension.ClientSideFilter = Backgrid.Extension.ClientSideFilter.extend({
     $customSearchBox: null,
+    template: function (data) {
+      return '<span class="search">&nbsp;</span><input type="search" ' + (data.placeholder ? 'aria-label= "' + data.placeholder + '"' : '')+' '+ (data.placeholder ? 'placeholder="' +
+      data.placeholder + '"' : '') + ' name="' + data.name + '" ' + (data.value ? 'value="' + data.value + '"' : '') + '/><a class="clear" data-backgrid-action="clear" href="#">&times;</a>';
+    },
 
     searchBox: function() {
       if(this.$customSearchBox) {

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [Accessibility] Parse & validate the web pages
  In-Reply-To: <CADTPKNkAnc--JTERSn9sx=v5yyEJ5upTftk=Zn1ZDmgtDOsbwg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox