Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6HxX-0004Mv-Qh for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 Apr 2018 15:46:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f6HxW-0008P8-Od for pgadmin-hackers@arkaria.postgresql.org; Wed, 11 Apr 2018 15:46:54 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6HxW-0008OW-BI for pgadmin-hackers@lists.postgresql.org; Wed, 11 Apr 2018 15:46:54 +0000 Received: from mx0a-00296801.pphosted.com ([148.163.150.38]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6HxS-00032w-5U for pgadmin-hackers@postgresql.org; Wed, 11 Apr 2018 15:46:52 +0000 Received: from pps.filterd (m0114583.ppops.net [127.0.0.1]) by mx0a-00296801.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3BFg4hV010262 for ; Wed, 11 Apr 2018 15:46:48 GMT Received: from mail-it0-f72.google.com (mail-it0-f72.google.com [209.85.214.72]) by mx0a-00296801.pphosted.com with ESMTP id 2h6mrkufw0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 11 Apr 2018 15:46:48 +0000 Received: by mail-it0-f72.google.com with SMTP id q15-v6so2195082itb.7 for ; Wed, 11 Apr 2018 08:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0IJqfpYs49UCcPCokuV2DaMYcjjqmNFqrnyljqIy7SU=; b=R+I6tjCZytZ85HsN+1lkaJNsoDJ+CG1mQZKuYc4Nhy2xql3JpnUwAcYYXCg0MPXr8C 3zdo1Kd8RcB3UpmSirwl0ojNr6r7bq3YClCHV9Hda3qI9F9RvrXAHqSBEyrLGB/sIaFd OACfxQCFVgANf14e90rYYgEPjh1OXLYu1SoCBNNQoX66NFtEje506MxrqVvaSVqzEVoR USSRaW409x/9sVpCWJXJuM0Cp4mk/UlJ4zZSTrZ+cImdKbMmEoeqeRCJiiTG2TErxBax xlmUqAMhsJ+3ApIopHzAD80iBcpLBqLJPxespHWQn1jiCF8qMv3TpsfVBckTC4/kv+23 Oouw== X-Gm-Message-State: ALQs6tA5b09mAy6qreRKYbCXRSZTTeK+XZRZOX1euV97uBMd8XTd5/Fg /Z3XUf4rYC4NNJWOZFsUzatm1dL1Bkax0C5Ne2HIjCwLFK84QRWCysxPk2UhrEuIFbUt+gBIk74 /XoFqdwSKiafhBc/7NSDv6autekJ9AwosgpZYQWlwtZawSDqrwp1wbwjkzck8yuPDA9uA X-Received: by 2002:a24:496a:: with SMTP id z103-v6mr4259896ita.133.1523461606695; Wed, 11 Apr 2018 08:46:46 -0700 (PDT) X-Google-Smtp-Source: AIpwx49BQdnZ9otqcik/Yb/Czc620zhjN2PS4bWsP6XpzYwOhHRFFCImweaO1USvOz/YkVAsVgXLKVQty/WFQlcrIiM= X-Received: by 2002:a24:496a:: with SMTP id z103-v6mr4259873ita.133.1523461606400; Wed, 11 Apr 2018 08:46:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Wed, 11 Apr 2018 15:46:35 +0000 Message-ID: Subject: Re: Bug #3083 fix To: Dave Page Cc: Harshal Dhumal , Akshay Joshi , Neethu Mariya Joy , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e114480569948b14" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-11_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804110146 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e114480569948b14 Content-Type: text/plain; charset="UTF-8" Hi Dave, Do you still have issues in your environment? Thanks Joao On Wed, Apr 11, 2018 at 5:56 AM Dave Page wrote: > Joao, are you looking at this? > > On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Tue, Apr 3, 2018 at 6:10 PM, Dave Page wrote: >> >>> Argh, managed to send before I finished typing... >>> >>> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira < >>>> jdealmeidapereira@pivotal.io> wrote: >>>> >>>>> Hi Dave, >>>>> That looks like in the surrounding area of the change. We run our >>>>> pipeline and everything was green. >>>>> Can you provide more details, which python version are you using? OS? >>>>> >>>> >>>> That was on my travel laptop, which is macOS Sierra with the Apple >>>> supplied Python 2.7. >>>> >>>> Interestingly, I'm on my dev laptop today (same OS and Python) and it's >>>> working just fine. The difference is that the travel machine is a 12" >>>> Macbook, whilst the dev machine is >>>> >>> >>> a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if >>> the small screen size is causing a problem with this test, something we >>> have seen before. >>> >>> >> >> Yes, screen size does cause problem. Slick grid does not render all >> columns if viewport is not wide enough (like it does for rows). >> Remaining columns would render when user scrolls right. >> >> To avoid similar problem in datatype feature test (commit: >> 88bcd3b5129db88975421e26c1bf188daf4892f9 >> ) >> I have executed >> queries in batch to limit number of columns in single query result. >> >> >> >>> >>>> >>>>> >>>>> Thanks >>>>> Joao >>>>> >>>>> On Thu, Mar 29, 2018 at 9:03 AM Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira < >>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>> >>>>>>> Hey Akshay and Neethu >>>>>>> >>>>>>> We refactored the patch to add tests for the resize feature. We >>>>>>> were able to write test cases for the drag event by using spies and setting >>>>>>> the rect dimensions. In cases like this, we can just test some components >>>>>>> in order to have enough confidence in the code. So we isolated the >>>>>>> function that implements the behavior of this feature and tested that it >>>>>>> was performing as expected. >>>>>>> >>>>>>> We ran the patch through the pipelines and all of the tests passed. >>>>>>> >>>>>> >>>>>> I'm consistently seeing the feature test failure below with this >>>>>> patch applied: >>>>>> >>>>>> ====================================================================== >>>>>> FAIL: runTest >>>>>> (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest) >>>>>> Validate Insert, Update operations in View/Edit data with given test >>>>>> data >>>>>> ---------------------------------------------------------------------- >>>>>> Traceback (most recent call last): >>>>>> File >>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>>>>> line 125, in runTest >>>>>> self._verify_row_data(True) >>>>>> File >>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>>>>> line 325, in _verify_row_data >>>>>> self.assertEquals(cells[idx], config_data[str(idx)][1]) >>>>>> AssertionError: u'[null]' != u'1' >>>>>> - [null] >>>>>> + 1 >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000e114480569948b14 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,
Do you still have issues in your environment?=

Thanks
Joao

On Wed, Apr 11, 2018 at 5:56 AM Dave Page= <dpage@pgadmin.org> wrote:<= br>
Joao, are you look= ing at this?

On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal <harshal.dhu= mal@enterprisedb.com> wrote:


--=C2=A0
Harshal Dhumal
Sr. Software Engineer


On Tue, Apr 3, 2018 at 6:10 PM, Dave P= age <dpage@pgadmin.org> wrote:
Argh, managed to send before I finished typing...
=

On Tue, Apr= 3, 2018 at 1:38 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Mar 29, 20= 18 at 4:29 PM, Joao De Almeida Pereira <jdealmeidapereira@pivot= al.io> wrote:
Hi Dave,
That looks like in the surrounding area of the change. We = run our pipeline and everything was green.
Can you provide more d= etails, which python version are you using? OS?

That was on my travel laptop, which is macOS Sierra= with the Apple supplied Python 2.7.

Interestingly= , I'm on my dev laptop today (same OS and Python) and it's working = just fine. The difference is that the travel machine is a 12" Macbook,= whilst the dev machine is=C2=A0

a 15" MacBook Pro with 2 24" external monito= rs. That makes me wonder if the small screen size is causing a problem with= this test, something we have seen before.
=C2=A0
<= /div>

Yes, screen size do= es cause problem. Slick grid does not render all columns if viewport is not= wide enough (like it does for rows).
Remaining columns would= render when user scrolls right.

To avoid similar problem= in datatype feature test (commit: 88bcd3b5129db88975421e26c1bf188daf4892f9) I= have executed
queries in batch to limit number of columns in single que= ry result.

=
=C2=A0
=
=C2=A0

<= /div>
Thanks
Joao

= On Thu, Mar 29, 2018 at 9:03 AM Dave Page <dpage@pgadmin.org> wrote:
Hi
<= br>
On Wed, Mar 28, 2018 at 7:06 PM= , Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>= wrote:
Hey Akshay and Neethu

We refactored the patch = to add tests for the resize feature.=C2=A0 We were able to write test cases= for the drag event by using spies and setting the rect dimensions.=C2=A0 I= n cases like this, we can just test some components in order to have enough= confidence in the code.=C2=A0 So we isolated the function that implements = the behavior of this feature and tested that it was performing as expected.=

We ran the patch through the pipelines and all of= the tests passed.

I'm consistently seeing the feature test failure below with this patc= h applied:

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D
FAIL: runTest (pgadmin.feature_tests.= view_data_dml_queries.CheckForViewDataTest)
Validate Insert, Upda= te operations in View/Edit data with given test data
------------= ----------------------------------------------------------
Traceb= ack (most recent call last):
=C2=A0 File "/Users/dpage/git/p= gadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", line 125,= in runTest
=C2=A0 =C2=A0 self._verify_row_data(True)
= =C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_= data_dml_queries.py", line 325, in _verify_row_data
=C2=A0 = =C2=A0 self.assertEquals(cells[idx], config_data[str(idx)][1])
As= sertionError: u'[null]' !=3D u'1'
- [null]
<= div>+ 1


--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL C= ompany



--
Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Ent= erprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterprise= DB UK: http://www= .enterprisedb.com
The Enterprise PostgreSQL Company
--000000000000e114480569948b14--