Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3OmR-0005Fy-Ue for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Apr 2017 15:23:00 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d3OmR-0005ik-EV for pgadmin-hackers@arkaria.postgresql.org; Wed, 26 Apr 2017 15:22:59 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d3OmC-0004tt-AM for pgadmin-hackers@postgresql.org; Wed, 26 Apr 2017 15:22:44 +0000 Received: from mail-ua0-x22b.google.com ([2607:f8b0:400c:c08::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d3Om4-0005Ku-CD for pgadmin-hackers@postgresql.org; Wed, 26 Apr 2017 15:22:42 +0000 Received: by mail-ua0-x22b.google.com with SMTP id f10so2527556uaa.2 for ; Wed, 26 Apr 2017 08:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4qdbxszFc6C2XxWZq7Lmhue5BbWazBGrpbx+wsP/0MI=; b=p8xNYKjxrkpnedBPHzCBnVqWjzUwgEg4NNjD2AN+HgHCUF/pJJglSomt369+MiN6yd +wUU6DCXSxH67gdwd5ZCpr2c9pwbNtjALg/ZUBFDjC7o7R9mHTq1se1ZTjF5EErHVsg7 uneOrMAsnenVr2UTJD4XlaMW7xC2tAvZdLwDhtF9wftirOcs7Ka4jJap+dvp90/Libll e4qs6fnnTgCtZG3EHcsT57AfEL19sQG4Z91rKz4OrokUwTTg4s9Kj8xGIt0t52Y7Fygk +n/VDAXdMPCeVDXz9dvCh1b80UWbdMByVHXGz9sZZBgMBZdprJD5hWZ/T9wy/vUNhhYs mT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4qdbxszFc6C2XxWZq7Lmhue5BbWazBGrpbx+wsP/0MI=; b=JjzOaQGFAcCNmRwRMbgsvOdU8lyXPfk66mOcTwAs+kFekcmxZGxSpx/cA5I8JQK0K5 u/zD6b72n7qK+hQ4xplwIjdQHE3LVXC58o/0tZgIYnDYdzhWNqk/QBwsI3BHGPikCfBy tBGjRnijROVuZAcn/RFcwl+z5WdbEnu8t59Dk/HRslMUHryCrOBXyGgeD3N2DripYPSG 6KHmcY7rvWgXPqCR11vtvd+590b9qcQmMnxRfjphkk0jMwSFhgR6CWn1FlIOFLd7vZ/J wyDtNP98qvr+PTejQJopcQJQXoy1QaLTCyFzPawSB+56oXrydNnUEi2qg9dza2sRy0TN av6w== X-Gm-Message-State: AN3rC/5ESV4+bewIEvoZxaRSBB4ICg68qXc5fpUssuBBfHSqx3mcGQJv o31pjZ3hQke/+6RSj+EAh3Ytw7DnPnbJ X-Received: by 10.176.4.45 with SMTP id 42mr172065uav.105.1493220153927; Wed, 26 Apr 2017 08:22:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.10.199 with HTTP; Wed, 26 Apr 2017 08:22:33 -0700 (PDT) In-Reply-To: References: From: Joao Pedro De Almeida Pereira Date: Wed, 26 Apr 2017 11:22:33 -0400 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Ashesh Vashi Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a11480dfad8b6ae054e136868 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11480dfad8b6ae054e136868 Content-Type: text/plain; charset=UTF-8 Hello Ashesh, Thanks for reviewing the patch. We added the __init__.py files into templates to convert them into packages so that the tests inside of them can be found by the test runner. Thanks! Joao & Sarah On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi wrote: > On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: > >> Ashesh, can you review/commit this please? >> >> On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Hackers, >>> >>> We found out that when you are connected to a GreenPlum database and try >>> to get Dependents and Dependencies of an object the application was >>> returning a SQL error. >>> >>> This patch splits the SQL query used to retrieve the Dependents, >>> Dependencies, and Roles SQL file into multiple versioned files. >>> Add Unit Tests for each file. >>> Also added __init__.py files to other test directories to run the tests >>> in them. >>> >> Hi Joao & Sarah, > > Why do we need to add __init__.py in the template directory? > I didn't understand the purpose of the adding __init__.py files in the > template directories. > > NOTE: The headers in those files are not consistent with the other project > files. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > >> Add ORDER BY into Copy Selection Feature test to ensure the results are >>> retrieved always in the same order >>> Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip >>> it for versions less than 9.1 >>> >>> Thanks >>> >>> Joao & Sarah >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a11480dfad8b6ae054e136868 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello Ashesh,

Thanks for reviewing the patch.=

We added the __init__.py files into templates to = convert them into packages so that the tests inside of them can be found by= the test runner.

Thanks!
Joao & Sara= h

On W= ed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi <ashesh.vashi@enterp= risedb.com> wrote:
On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <dpage@pgadmin.org>= ; wrote:
Ashesh, can you review/commit this please?

On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Per= eira <jdealmeidapereira@pivotal.io> wrote:
Hi Hackers,

We found out that when you are connected to a GreenPlum database an= d try to get Dependents and Dependencies of an object the application was r= eturning a SQL error.

This patch splits the SQL qu= ery used to retrieve the Dependents, Dependencies, and Roles SQL file into = multiple versioned files.
Add Unit Tests for each file.
Also added __init__.py files to other test directories to run the tests in= them.
= Hi Joao & Sarah,

Why do we need to add __init__.py i= n the template directory?
I didn't understand the purpose of = the adding __init__.py files in the template directories.

NOTE: The headers in those files are not consistent with the other = project files.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/= asheshvashi

<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
= Add ORDER BY into Copy Selection Feature test to ensure the results are ret= rieved always in the same order
Renamed the Scenario of the=C2=A0= xss_checks_pgadmin_debugger_test and skip it for versions less than 9.= 1

Thanks

Joao & Sarah=


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--=
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a11480dfad8b6ae054e136868--