Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ew8zf-00012S-KA for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 16:11:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ew8ze-0000EA-L1 for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Mar 2018 16:11:10 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ew8ze-0000Dv-8T for pgadmin-hackers@lists.postgresql.org; Wed, 14 Mar 2018 16:11:10 +0000 Received: from mail-io0-x243.google.com ([2607:f8b0:4001:c06::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ew8za-0002Ni-2V for pgadmin-hackers@postgresql.org; Wed, 14 Mar 2018 16:11:08 +0000 Received: by mail-io0-x243.google.com with SMTP id v6so4983865iog.7 for ; Wed, 14 Mar 2018 09:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=agGYIJBpNUnvb7gJ3zsSWMb6QoBCO0JNd3+lN0KSoZ0=; b=C9iA0+ZmSBgYEz2h+YzptDK7RMCQJB0ApNZvJdISfQt/iF1R3/116iFaPdMJNvjQOV 494/20HXOMf58ejUm9pLZGJSseS6vpFbWgSLu/ppiKtcGspR6XVcL8G3gHFwoQVX6hQW 8ZW5hnm6aiuIcCpgEw5Ugnlz4a/zknCLPoAPKtIR9fsYMwd3ZvbITKR3UvAZSeSkevF0 0lvsX64TXKCrHSUOiWOwcYapQgy/ZY0DrxWI8S4tgJiw8ikPtxEhDvegcgBamXt8qsvh wc3I34VbMIPqdNYHPZrrevsAPT5Plwr88MMdmJ/XzVEVSCvA6LatoY95RCdLM+fatz5z 7jEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=agGYIJBpNUnvb7gJ3zsSWMb6QoBCO0JNd3+lN0KSoZ0=; b=jU20v6KyilMmQ2BruhNQZ4pFFTI58WV7tkQ89y9lvMZQPdNPpmgOG56CCaT0MJD2jE FMq7CyicweKmLyRzS+jqbWP3DWdlNkRkJufwMwPk5MBxO2TMlb6v3WLLbcWSHHfcfw8D qSUcXjLroueqccEfUk+R7G8Ttin/0e29IeCr6yk6eobjUswStnh7OqgOz3w/Lq0PTO1M S1gvKG6J+wQj4Mj420cMCFbC+HSnsE2V1evpb8olNriPuen2DipS8kIUupnQeMeV5Bwf xj427Lc4iTclKmK6PR4Z6TcNbkFSfLlCWcO4jh6HvHBf7MGnOVLEyJ3RoDdB72edzQW2 o3ig== X-Gm-Message-State: AElRT7GfrZQZwnp278zaJ5wsBuGQMsIu4KMbN0R5/aUm329oIvfMK6Dq ulS8uEig3JYDZgRidqDeXQJK/qT5gI001BNRARCoTg== X-Google-Smtp-Source: AG47ELtrCULBQ7QU3PMLzPQ/vRro5DTbh1gelUdizwmcblFTx02tyd7GR4pDPvkrKEsLd3BHzdCxSFz/V5CDt3QrdXw= X-Received: by 10.107.38.80 with SMTP id m77mr5504266iom.69.1521043864498; Wed, 14 Mar 2018 09:11:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Wed, 14 Mar 2018 16:10:53 +0000 Message-ID: Subject: Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t To: Khushboo Vashi Cc: Dave Page , vhenry@pivotal.io, pgadmin-hackers Content-Type: multipart/mixed; boundary="001a1140c2843b9fcc0567619f9b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1140c2843b9fcc0567619f9b Content-Type: multipart/alternative; boundary="001a1140c2843b9fc80567619f99" --001a1140c2843b9fc80567619f99 Content-Type: text/plain; charset="UTF-8" Hi Khushboo, Good catch, attached you can find the fix for the problem. Thanks Victoria & Joao On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Joao/Victoria, > > I am getting an error while editing the server properties. Please refer > the attached screen-shot for the same. > > Thanks, > Khushboo > > On Wed, Mar 14, 2018 at 12:17 AM, Dave Page wrote: > >> Refactor server dialogue validation for better unit testing. >> >> Victoria & Joao @ Pivotal. >> >> Branch >> ------ >> master >> >> Details >> ------- >> >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b03cb78af607b04c75de44d635bf201babb4c5a >> Author: Victoria Henry >> >> Modified Files >> -------------- >> web/package.json | 3 +- >> .../server_groups/servers/static/js/server.js | 113 >> ++------------------- >> web/pgadmin/static/bundle/browser.js | 2 +- >> web/pgadmin/static/js/browser/index.js | 10 ++ >> .../static/js/browser/server_groups/index.js | 10 ++ >> .../server_groups/servers/databases/index.js | 10 ++ >> .../js/browser/server_groups/servers/index.js | 11 ++ >> .../server_groups/servers/model_validation.js | 104 >> +++++++++++++++++++ >> .../server_groups/servers/model_validation_spec.js | 101 >> ++++++++++++++++++ >> web/yarn.lock | 46 ++++++++- >> 10 files changed, 299 insertions(+), 111 deletions(-) >> >> > --001a1140c2843b9fc80567619f99 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Khushboo,
Good catch, attached you can find the fix= for the problem.

Thanks
Victoria & = Joao

On Wed, Mar 14, 2= 018 at 10:37 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Joao/Victoria,
I am getting an error while editing the server properties. Please r= efer the attached screen-shot for the same.

Thanks,
Khushboo

On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <= dpage@pgadmin.org> wrote:
Refactor server dialo= gue validation for better unit testing.

Victoria & Joao @ Pivotal.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdi= ff;h=3D6b03cb78af607b04c75de44d635bf201babb4c5a
Author: Victoria Henry <vhenry@pivotal.io>

Modified Files
--------------
web/package.json=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 = =C2=A03 +-
.../server_groups/servers/static/js/server.js=C2=A0 =C2=A0 =C2=A0 | 113 ++-= ------------------
web/pgadmin/static/bundle/browser.js=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +-
web/pgadmin/static/js/browser/index.js=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 10 ++
.../static/js/browser/server_groups/index.js=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 10 ++
.../server_groups/servers/databases/index.js=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 10 ++
.../js/browser/server_groups/servers/index.js=C2=A0 =C2=A0 =C2=A0 |=C2=A0 1= 1 ++
.../server_groups/servers/model_validation.js=C2=A0 =C2=A0 =C2=A0 | 104 +++= ++++++++++++++++
.../server_groups/servers/model_validation_spec.js | 101 ++++++++++++++++++=
web/yarn.lock=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2= =A0 46 ++++++++-
10 files changed, 299 insertions(+), 111 deletions(-)


--001a1140c2843b9fc80567619f99-- --001a1140c2843b9fcc0567619f9b Content-Type: text/x-patch; charset="US-ASCII"; name="fix-trim-function.diff" Content-Disposition: attachment; filename="fix-trim-function.diff" Content-Transfer-Encoding: base64 Content-ID: <1622547498c6f7f32a81> X-Attachment-Id: 1622547498c6f7f32a81 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9icm93c2VyL3NlcnZlcl9ncm91cHMv c2VydmVycy9tb2RlbF92YWxpZGF0aW9uLmpzIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2Jyb3dz ZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL21vZGVsX3ZhbGlkYXRpb24uanMKaW5kZXggN2FiMTI5 YmEuLjk0OGFmM2Q0IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9zdGF0aWMvanMvYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvbW9kZWxfdmFsaWRhdGlvbi5qcworKysgYi93ZWIvcGdhZG1p bi9zdGF0aWMvanMvYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvbW9kZWxfdmFsaWRhdGlv bi5qcwpAQCAtOTksNiArOTksNiBAQCBleHBvcnQgY2xhc3MgTW9kZWxWYWxpZGF0aW9uIHsKICAg fQogCiAgIHN0YXRpYyBpc0VtcHR5U3RyaW5nKHN0cmluZykgewotICAgIHJldHVybiBfLmlzVW5k ZWZpbmVkKHN0cmluZykgfHwgXy5pc051bGwoc3RyaW5nKSB8fCBzdHJpbmcudHJpbSgpID09PSAn JzsKKyAgICByZXR1cm4gXy5pc1VuZGVmaW5lZChzdHJpbmcpIHx8IF8uaXNOdWxsKHN0cmluZykg fHwgU3RyaW5nKHN0cmluZykudHJpbSgpID09PSAnJzsKICAgfQogfQpkaWZmIC0tZ2l0IGEvd2Vi L3JlZ3Jlc3Npb24vamF2YXNjcmlwdC9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9tb2Rl bF92YWxpZGF0aW9uX3NwZWMuanMgYi93ZWIvcmVncmVzc2lvbi9qYXZhc2NyaXB0L2Jyb3dzZXIv c2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL21vZGVsX3ZhbGlkYXRpb25fc3BlYy5qcwppbmRleCBhMDVj ZDQ1NS4uNTYwZDhiNjAgMTAwNjQ0Ci0tLSBhL3dlYi9yZWdyZXNzaW9uL2phdmFzY3JpcHQvYnJv d3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvbW9kZWxfdmFsaWRhdGlvbl9zcGVjLmpzCisrKyBi L3dlYi9yZWdyZXNzaW9uL2phdmFzY3JpcHQvYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMv bW9kZWxfdmFsaWRhdGlvbl9zcGVjLmpzCkBAIC0zMSw3ICszMSw3IEBAIGRlc2NyaWJlKCdTZXJ2 ZXIjTW9kZWxWYWxpZGF0aW9uJywgKCkgPT4gewogICAgICAgICBtb2RlbC5pc05ldy5hbmQucmV0 dXJuVmFsdWUodHJ1ZSk7CiAgICAgICAgIG1vZGVsLmFsbFZhbHVlc1snbmFtZSddID0gJ3NvbWUg bmFtZSc7CiAgICAgICAgIG1vZGVsLmFsbFZhbHVlc1sndXNlcm5hbWUnXSA9ICdzb21lIHVzZXJu YW1lJzsKLSAgICAgICAgbW9kZWwuYWxsVmFsdWVzWydwb3J0J10gPSAnc29tZSBwb3J0JzsKKyAg ICAgICAgbW9kZWwuYWxsVmFsdWVzWydwb3J0J10gPSAxMjM0NTsKICAgICAgIH0pOwogCiAgICAg ICBkZXNjcmliZSgnTm8gc2VydmljZSBpZCcsICgpID0+IHsK --001a1140c2843b9fcc0567619f9b--