Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0oZk-0000Pd-Vj for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Mar 2018 13:23:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0oZj-00042M-IL for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Mar 2018 13:23:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0oZj-00042C-7I for pgadmin-hackers@lists.postgresql.org; Tue, 27 Mar 2018 13:23:43 +0000 Received: from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0oZY-0004gG-PX for pgadmin-hackers@postgresql.org; Tue, 27 Mar 2018 13:23:42 +0000 Received: by mail-it0-x230.google.com with SMTP id e98-v6so15257739itd.4 for ; Tue, 27 Mar 2018 06:23:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=soTxS4e3c6ZMnDfitqrELA4/3xszrGT9jUmrwnHrK2s=; b=IthzF/vBf9UdwiDWOkCrEEvC5yuEMw4sIJva+fgDSIUSfNAdbxf0F7POj2LMWaICvG FsB8fV3OHhT1jdwQhhk3DpnSl8uZSed/83v3fwISQHSVJH4Ug3pUutlcxwtTFLNsqbuS qi/ZptY1d4kTZ9Kr/lJa0LxJMHabwrPcqANkB0y1rbZt9Z6vsJE4zsJfNL3mpDtc7mPm vJbCVLsI/8HfCa5Qk+a2BvDvjXpJL35Kys85E6JneXCHjCqAs3gig+mi5Z5d02U+SkFt A/sT8mPDJMxLKVoJQ5qYe56mYt11ifmWwLRMJKMWhRL/7RGT6TFIdrOAlASfqsWz2ZQB KIGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=soTxS4e3c6ZMnDfitqrELA4/3xszrGT9jUmrwnHrK2s=; b=h3f96zK+0hzddtTzp7LojQEhcqowco8hW84fuf1TUsvW/EJI9yz9Lb66XMgtLj4/NW oufVuM7kLGoyA35wuzM0ImxHEm84DigInW7lvoVJLWGBQlk2zwVZLNg+mYvqslYc0gfc a+EPnVCkPhWK0fO7FYhcxkpjUT8RQzqyROdEys0pqnazl06MBsD4+9PzNYrGHzVQVOTa rWJj6TsmBpGnLWECB6GWxeZuqqFMutK6NXNnJPbuvmhn0KcB+Zuoq35PtjOvZ5eWdU4N l39NfHGi+EP4IHPztd7V4gW8nGiT3ET4IRSS3L2k8quZrAAMQQG1tIjQTOc+ZEGrBcrC oP0g== X-Gm-Message-State: AElRT7GAltjvuh2wa8yqm9PG3k4YCVH+pwKO2ytz5jJn9X6s2jOdaTAB PIvMV+OtvP+qfJtmvYfT+LCbaoL7Mh1aRdPiGNs+Sg== X-Google-Smtp-Source: AIpwx4955y7MYGve7vJUvX0W4vnlPmPza3t8JXhJjQS6ihC9sEWlgREBG0fojh0RY7CQsRSGfcwO8z/6v/YgjTurr6s= X-Received: by 2002:a24:3d4f:: with SMTP id n76-v6mr8518516itn.147.1522157009335; Tue, 27 Mar 2018 06:23:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Tue, 27 Mar 2018 13:23:18 +0000 Message-ID: Subject: Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL To: Akshay Joshi Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000d5c2b0056864cbd8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000d5c2b0056864cbd8 Content-Type: text/plain; charset="UTF-8" Hi Akshay, We were not trying to imply that your fix did not solve the problem, we were trying to understand the root cause of the problem. 1. We were not able to reproduce the problem We followed your directions in RM, removed your fix but we could not reproduce the problem. So we could not make sure that the application is in fact working. This maybe have been because we missed something. 2. The fix does not tackle the big problem