MIME-Version: 1.0
References: 
 <CAE+jjakOhMJBMqsUaQuL9w4an0V4Q4nvY51K3GqWzm8jbj9cog@mail.gmail.com>
 <CAE+jja=n640Up0uWO=gQVp=A0rMJ-Y+YFSTCBjhwv98QLyRe2g@mail.gmail.com>
In-Reply-To: 
 <CAE+jja=n640Up0uWO=gQVp=A0rMJ-Y+YFSTCBjhwv98QLyRe2g@mail.gmail.com>
From: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>
Date: Wed, 07 Feb 2018 22:32:10 +0000
Message-ID: 
 <CAE+jja=L+CpYv+6q1FkyYmvkAGTOsqCM+p3-e5EdLwcifz-Cmw@mail.gmail.com>
Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and
 Explain analyze plan an error is displayed
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="001a113f8c2a4d19f60564a6de0e"
Precedence: bulk

--001a113f8c2a4d19f60564a6de0e
Content-Type: text/plain; charset="UTF-8"

Hello,
Any Feedback on this Patch?
We have other changes that we already developed that depend on this change.

Thanks

On Tue, Feb 6, 2018 at 9:33 AM Joao De Almeida Pereira <
jdealmeidapereira@pivotal.io> wrote:

> Hello,
> Any feedback on this Patch?
>
> Thanks
> Joao
>
> On Fri, Feb 2, 2018 at 5:50 PM Joao De Almeida Pereira <
> jdealmeidapereira@pivotal.io> wrote:
>
>> Hi Hackers,
>> This is quite a big patch in order to solve the problem with the Explain
>> Plan.
>>
>> We sent 2 patches that have the following:
>> *- update-javascript-packages.diff *
>>     Add package:
>>      is-docker to select a specific setting when running the Chrome tests
>> in
>>      Docker
>>
>>     Upgrade the version of:
>>     - babel-loader
>>     - extract-text-webpack-plugin
>>     - jasmine-core
>>     - jasmine-enzyme
>>     - moment
>> *- explain-plan-greenplum.diff*
>>   Extract SQLEditor.execute and SQLEditor._poll into their own files and
>> add test around them
>>   Extract SQLEditor backend functions that start executing query to their
>> own files and add tests around it
>>   Move the Explain SQL from the front-end and now pass the Explain plan
>> parameters as a JSON object in the start query call.
>>   Extract the compile_template_name into a function that can be used by
>> the different places that try to select the version of the template and the
>> server type
>>
>>
>> Thanks
>> Joao
>>
>

--001a113f8c2a4d19f60564a6de0e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello,<div>Any Feedback on this Patch?</div><div>We have o=
ther changes that we already developed that depend on this change.</div><di=
v><br></div><div>Thanks</div></div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr">On Tue, Feb 6, 2018 at 9:33 AM Joao De Almeida Pereira &lt;<a href=
=3D"mailto:jdealmeidapereira@pivotal.io">jdealmeidapereira@pivotal.io</a>&g=
t; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hello,<d=
iv>Any feedback on this Patch?</div><div><br></div><div>Thanks</div></div><=
div dir=3D"ltr"><div>Joao</div></div><br><div class=3D"gmail_quote"><div di=
r=3D"ltr">On Fri, Feb 2, 2018 at 5:50 PM Joao De Almeida Pereira &lt;<a hre=
f=3D"mailto:jdealmeidapereira@pivotal.io" target=3D"_blank">jdealmeidaperei=
ra@pivotal.io</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div d=
ir=3D"ltr">Hi Hackers,<div>This is quite a big patch in order to solve the =
problem with the Explain Plan.</div><div><br></div><div>We sent 2 patches t=
hat have the following:</div><div><b>-=C2=A0update-javascript-packages.diff=
=C2=A0</b></div><div><div>=C2=A0 =C2=A0 Add package:<br></div><div>=C2=A0 =
=C2=A0 =C2=A0is-docker to select a specific setting when running the Chrome=
 tests in</div><div>=C2=A0 =C2=A0 =C2=A0Docker</div><div><br></div><div>=C2=
=A0 =C2=A0 Upgrade the version of:</div><div>=C2=A0 =C2=A0 - babel-loader</=
div><div>=C2=A0 =C2=A0 - extract-text-webpack-plugin</div><div>=C2=A0 =C2=
=A0 - jasmine-core</div><div>=C2=A0 =C2=A0 - jasmine-enzyme</div><div>=C2=
=A0 =C2=A0 - moment</div></div><div><b>-=C2=A0explain-plan-greenplum.diff</=
b></div><div>=C2=A0 Extract SQLEditor.execute and SQLEditor._poll into thei=
r own files and add test around them</div><div>=C2=A0 Extract SQLEditor bac=
kend functions that start executing query to their own files and add tests =
around it</div><div>=C2=A0 Move the Explain SQL from the front-end and now =
pass the Explain plan parameters as a JSON object in the start query call.<=
/div><div>=C2=A0 Extract the compile_template_name into a function that can=
 be used by the different places that try to select the version of the temp=
late and the server type</div><div><br></div><div><br></div><div>Thanks</di=
v></div><div dir=3D"ltr"><div>Joao</div></div></blockquote></div></blockquo=
te></div>

--001a113f8c2a4d19f60564a6de0e--