MIME-Version: 1.0
References: 
 <CAAdJd1OqoYe1=FZkZrO-WYEYH_asph3GP8u7a6XdjmQ7FwAaiA@mail.gmail.com>
 <CAE+jjamnK3vVZYqs_6+4yVxUPgpMbgM9NM06m1L4ytaMbkXpVQ@mail.gmail.com>
 <CANxoLDdrGtD76fwSe-b3swcbFcrcm8Me-s5Du+F_xyCYfCg_9A@mail.gmail.com>
 <CAE+jjamhfMrW5p3rsDddDCdJD_i+RU+O=i2sTNeLf=TV_J==WQ@mail.gmail.com>
 <CA+OCxozsQr88HoxoCRXsxqi-7nQ6EGx3MJimqXR897GiL5WcfQ@mail.gmail.com>
In-Reply-To: 
 <CA+OCxozsQr88HoxoCRXsxqi-7nQ6EGx3MJimqXR897GiL5WcfQ@mail.gmail.com>
From: Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>
Date: Thu, 29 Mar 2018 15:29:20 +0000
Message-ID: 
 <CAE+jja=Pa3QL2XpHQTmaJP1qpvuNy9Mj6U=4BKNNQ4ip7HGE3A@mail.gmail.com>
Subject: Re: Bug #3083 fix
To: Dave Page <dpage@pgadmin.org>
Cc: Akshay Joshi <akshay.joshi@enterprisedb.com>,
	Neethu Mariya Joy <neethumariyajoy@gmail.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="94eb2c0b89ea372a4105688eca59"
Precedence: bulk

--94eb2c0b89ea372a4105688eca59
Content-Type: text/plain; charset="UTF-8"

Hi Dave,
That looks like in the surrounding area of the change. We run our pipeline
and everything was green.
Can you provide more details, which python version are you using? OS?

Thanks
Joao

On Thu, Mar 29, 2018 at 9:03 AM Dave Page <dpage@pgadmin.org> wrote:

> Hi
>
> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira <
> jdealmeidapereira@pivotal.io> wrote:
>
>> Hey Akshay and Neethu
>>
>> We refactored the patch to add tests for the resize feature.  We were
>> able to write test cases for the drag event by using spies and setting the
>> rect dimensions.  In cases like this, we can just test some components in
>> order to have enough confidence in the code.  So we isolated the function
>> that implements the behavior of this feature and tested that it was
>> performing as expected.
>>
>> We ran the patch through the pipelines and all of the tests passed.
>>
>
> I'm consistently seeing the feature test failure below with this patch
> applied:
>
> ======================================================================
> FAIL: runTest
> (pgadmin.feature_tests.view_data_dml_queries.CheckForViewDataTest)
> Validate Insert, Update operations in View/Edit data with given test data
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 125, in runTest
>     self._verify_row_data(True)
>   File
> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py",
> line 325, in _verify_row_data
>     self.assertEquals(cells[idx], config_data[str(idx)][1])
> AssertionError: u'[null]' != u'1'
> - [null]
> + 1
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--94eb2c0b89ea372a4105688eca59
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Dave,<div>That looks like in the surrounding area of th=
e change. We run our pipeline and everything was green.</div><div>Can you p=
rovide more details, which python version are you using? OS?</div><div><br>=
</div><div>Thanks</div><div>Joao</div></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr">On Thu, Mar 29, 2018 at 9:03 AM Dave Page &lt;<a href=3D"m=
ailto:dpage@pgadmin.org">dpage@pgadmin.org</a>&gt; wrote:<br></div><blockqu=
ote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc s=
olid;padding-left:1ex"><div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><b=
r><div class=3D"gmail_quote"></div></div></div><div dir=3D"ltr"><div class=
=3D"gmail_extra"><div class=3D"gmail_quote">On Wed, Mar 28, 2018 at 7:06 PM=
, Joao De Almeida Pereira <span dir=3D"ltr">&lt;<a href=3D"mailto:jdealmeid=
apereira@pivotal.io" target=3D"_blank">jdealmeidapereira@pivotal.io</a>&gt;=
</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px=
 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div di=
r=3D"ltr">Hey Akshay and Neethu<div><br></div><div>We refactored the patch =
to add tests for the resize feature.=C2=A0 We were able to write test cases=
 for the drag event by using spies and setting the rect dimensions.=C2=A0 I=
n cases like this, we can just test some components in order to have enough=
 confidence in the code.=C2=A0 So we isolated the function that implements =
the behavior of this feature and tested that it was performing as expected.=
</div><div><br></div><div>We ran the patch through the pipelines and all of=
 the tests passed.</div></div></blockquote><div><br></div></div></div></div=
><div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote"><di=
v>I&#39;m consistently seeing the feature test failure below with this patc=
h applied:</div><div><br></div><div><div>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D</div><div>FAIL: runTest (pgadmin.feature_tests.=
view_data_dml_queries.CheckForViewDataTest)</div><div>Validate Insert, Upda=
te operations in View/Edit data with given test data</div><div>------------=
----------------------------------------------------------</div><div>Traceb=
ack (most recent call last):</div><div>=C2=A0 File &quot;/Users/dpage/git/p=
gadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py&quot;, line 125,=
 in runTest</div><div>=C2=A0 =C2=A0 self._verify_row_data(True)</div><div>=
=C2=A0 File &quot;/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_=
data_dml_queries.py&quot;, line 325, in _verify_row_data</div><div>=C2=A0 =
=C2=A0 self.assertEquals(cells[idx], config_data[str(idx)][1])</div><div>As=
sertionError: u&#39;[null]&#39; !=3D u&#39;1&#39;</div><div>- [null]</div><=
div>+ 1</div></div></div></div></div><div dir=3D"ltr"><div class=3D"gmail_e=
xtra"><br clear=3D"all"><div><br></div>-- <br><div class=3D"m_3495784075707=
971938gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspo=
t.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsna=
ke<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" target=
=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL Co=
mpany<br></div>
</div></div></blockquote></div>

--94eb2c0b89ea372a4105688eca59--