Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1ZSv-00069T-IS for pgadmin-hackers@arkaria.postgresql.org; Thu, 29 Mar 2018 15:27:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f1ZSu-0006wD-Cg for pgadmin-hackers@arkaria.postgresql.org; Thu, 29 Mar 2018 15:27:48 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1ZSu-0006w3-4J for pgadmin-hackers@lists.postgresql.org; Thu, 29 Mar 2018 15:27:48 +0000 Received: from mail-it0-x236.google.com ([2607:f8b0:4001:c0b::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f1ZSq-0008M6-DR for pgadmin-hackers@postgresql.org; Thu, 29 Mar 2018 15:27:46 +0000 Received: by mail-it0-x236.google.com with SMTP id m134-v6so8646864itb.3 for ; Thu, 29 Mar 2018 08:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6BTv3WYBqmKZ9obeGFNCV3BK5XUhUGb79z2Va+OwkDc=; b=qpjot3jxcDaqKGwWde3MB34k9QedXSDOUkTTHAAGQgmU/8YlH4qqy7IIkU4wZMcV7q TXjXw+saPG7l73zUHVpALEZx7AK1V8PYuh2+217ffrJV1wjBwtI9arstHm5aYrxWVUWL f3Gu21YbKT0+fiU36qQ8Eb/1DFcqU1gZzQzM8UHLPSg0/RrUwoJKO43uqmXVn5S/9qY4 LlTpXD0d47BjBso99W/yBGA4G3hVKmc3U4Gd7j4obS3XUXw1sXas+zXmr8W0jYayXpyX YzJTsKitQgSiJ5sRDJOt3YdIn+TSZXwof3VgS8VI/+23ahmlUz/CkAHHjFAQlVp8ASxY sekg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6BTv3WYBqmKZ9obeGFNCV3BK5XUhUGb79z2Va+OwkDc=; b=KxCj/TW/kfE5LMEPuR8djUCzaKyFwh7ucCJcS/2PldZOXlqi1OPNhIz9vu4N/wBcJq dntvOXT+ms1DNzAvOasAukkOTOVuX49ZdQgB8AOolcSf8j8Zvng7eysQeja0WnvaWDK8 E8XBVr7ptpRYnncFH/yhQNFPoHKFT356J87ArRhfzczs5pNbhWwRX5VogJ5lo4wQKf0p 4KZGDv/My2SaUhOfNIAetMRdMqFoqqkk35ec43Ente4uf1eLp970rfBjoaykQRo2oeA5 a9T3yzvSCYPWI2yaHAoZMzC535QvYYENBXTEInIfeNKzYzlbKTwNdNIfQeT8REL/tlYs hDtA== X-Gm-Message-State: AElRT7H20Wjg4vbt5zV2ROVKPJOSpqgLSU4csuVAclTxzFgQnLAVhffw 6fKGSfTABD98T8D90Y8x+HVAHNq87YBUuYpNNv7t+g== X-Google-Smtp-Source: AIpwx4+8W0sDfIV2mMjfwcvvf/yknByR5GHMlMN3qTbqzblbX70xGwi6cO6hbug4yoeGdo19aURdhAf9aI8ZQTa1KsY= X-Received: by 2002:a24:c281:: with SMTP id i123-v6mr8055171itg.146.1522337263307; Thu, 29 Mar 2018 08:27:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Thu, 29 Mar 2018 15:27:32 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3155] Allow user to lock the Layout To: Dave Page Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000cee97605688ec328" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000cee97605688ec328 Content-Type: text/plain; charset="UTF-8" Hi Murtuza, After changing the setting in the preferences nothing happened, we had to reset the layout or refresh the app to see it working. It only looks the right side. Was this the intended behavior? Not sure if this is the expected behavior or not. I would expect that any change I do in the preferences would start working after I press the Save button. This also happens with other preferences that only take effect after refresh on the browser. This being said, not sure if having the templated variable in the javascript file is the best approach in this case. Do you think you can remove the requirejs tags on the tests? At the testing file you do not need to create 3 different variables for the panels, you can reuse it, because the beforeEach will run for every test Thanks Joao On Thu, Mar 29, 2018 at 9:48 AM Dave Page wrote: > Hi > > On Thu, Mar 29, 2018 at 2:15 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch which will allow user to lock the panels and it will not allow >> user to drag & drop them. >> > > Tests pass, but when I lock the layout, I can still drag panels and adjust > the splitters etc. After doing so, reset the layout and now have the > broken layout seen in the attached screenshot. I have rebuilt the bundle, > reloaded etc. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000cee97605688ec328 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Murtuza,

After changing the setting = in the preferences nothing happened, we had to reset the layout or refresh = the app to see it working. It only looks the right side. Was this the inten= ded behavior?

Not sure if this is the expected beh= avior or not. I would expect that any change I do in the preferences would = start working after I press the Save button. This also happens with other p= references that only take effect after refresh on the browser.
Th= is being said, not sure if having the templated variable in the javascript = file is the best approach in this case.

Do you thi= nk you can remove the requirejs tags on the tests?

At the testing file you do not need to create 3 different variables for th= e panels, you can reuse it, because the beforeEach will run for every test<= /div>

Thanks
Joao

On Thu, Mar 29, 2018 at 9:48 AM Dave Page &l= t;dpage@pgadmin.org> wrote:
=
Hi

<= div class=3D"gmail_extra">
On Thu, Mar 29, 2018 a= t 2:15 PM, Murtuza Zabuawala <murtuza.zabuawala@enterpris= edb.com> wrote:
Hi,
=

PFA patch which will= allow user to lock the panels and it will not allow user to drag & dro= p them.

Tests p= ass, but when I lock the layout, I can still drag panels and adjust the spl= itters etc. After doing so,=C2=A0 reset the layout and now have the broken = layout seen in the attached screenshot. I have rebuilt the bundle, reloaded= etc.=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise= PostgreSQL Company
--000000000000cee97605688ec328--