Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erPQz-0004gw-Q5 for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 14:43:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erPQy-0007He-G8 for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 14:43:48 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erPQy-0007HU-3C for pgadmin-hackers@lists.postgresql.org; Thu, 01 Mar 2018 14:43:48 +0000 Received: from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erPQt-0002Gw-Vf for pgadmin-hackers@postgresql.org; Thu, 01 Mar 2018 14:43:46 +0000 Received: by mail-it0-x230.google.com with SMTP id c11so7860848ith.4 for ; Thu, 01 Mar 2018 06:43:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fiv4XYVIaswMl73ghxsWVfVdQWeXQYWBP3/oocF+y+o=; b=CUAoYPqkoaT3PlF89tObkWnfx982lU3cAtAa28SEJvypEbjdJA/okwdc3nRXXIKQMa GT0PTvxN7pkr7amSbb1oGMABYwLPS/FgOqU0KnM/kYDCZtjryJpnA0DcPWy38RwFoHJs 44lDUU3ZTLCu1ARrp4VHvjXdntqNciZ0/G1J4x/if/JoYkNXbsOsSifyHhNS/qTgf8Yz /m10dOZnCdpItmb1rXHm779sC/9hDZsdEHugILV0kdQmHFx49rtuXHEhYWhX1Kvbxoq3 HbkPwRPgDvbjhbdzPwVm6oOpyvv/IUCLRG0r5amwpcNC8GQmwWS6KgPJIRuESBI01Yd2 u2Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fiv4XYVIaswMl73ghxsWVfVdQWeXQYWBP3/oocF+y+o=; b=Fo59m4rvRfcx/R9rnpQvwgkCL4i+tkUw4hjREUx6TpAUI+1c5IEmMjgQE4/OHCTJRf notpkEqktRAcfgdoZbHkExj3mu9oJ1q/zgwMzC4uexQao2bJc35UaHAPbFAHEroqp9Sf GWXOW42OhyRClGPqlnBrzQ6uavmJtQ2AbXCJzckYHlhuDkSsrEOOVQaIMgNEwtqwVbEL +91NedN/JcQQY+OOgnNECxT7kuh1YpIQO0gpGhjAkibpHgV5m0TC1UEdMqZcMp3+OcJf 4vpZSnaCw4roW8kGynfdUAYQW0bm+hoyFqdkTUvK0Kx+IXTJyx7D2qNOa3A6vmmK36b1 ZhuQ== X-Gm-Message-State: APf1xPB8NcAr2GHLuuQVYzJ3xcSn98NjBI2tIfbJI+sTx42m2Rx6UYSx TG+83nfUpiemtjcFs+PerXykR7VpIk68TpIDBllvYw== X-Google-Smtp-Source: AG47ELs4PiloV3MrWnRDcO7bvanu0wyW/LHd+oP1wkCD1SJL4VUpYrAwWv3wKuQpbNjf14SBlOd0J1ivL7gId+2KMXA= X-Received: by 10.36.78.14 with SMTP id r14mr2821461ita.146.1519915422452; Thu, 01 Mar 2018 06:43:42 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Thu, 01 Mar 2018 14:43:32 +0000 Message-ID: Subject: Re: [pgAdmin4][Patch]: PEP-8 fixes in the foreign data wrapper module To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113a9986d84d3305665ae25e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113a9986d84d3305665ae25e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Khushboo, I applied this patch and here is the result: 2018-03-01 09:41:00 =E2=8C=9A |ruby-2.4.1| pgadmin-dev in ~/workspace/pgad= min4/web =C2=B1 |pep-8-fdw {2} U:13 =E2=9C=97| =E2=86=92 git st On branch pep-8-fdw Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git checkout -- ..." to discard changes in working directory) modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__in= it__.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/__init__.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/tests/test_foreign_servers_add.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/tests/test_foreign_servers_delete.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/tests/test_foreign_servers_get.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/tests/test_foreign_servers_put.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/tests/utils.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/user_mapping/__init__.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/user_mapping/tests/test_user_mapping_add.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/user_mapping/tests/test_user_mapping_delete.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/user_mapping/tests/test_user_mapping_get.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/user_mapping/tests/test_user_mapping_put.py modified: pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/fore= ign_servers/user_mapping/tests/utils.py no changes added to commit (use "git add" and/or "git commit -a") 2018-03-01 09:41:03 =E2=8C=9A |ruby-2.4.1| pgadmin-dev in ~/workspace/pgad= min4/web =C2=B1 |pep-8-fdw {2} U:13 =E2=9C=97| =E2=86=92 pycodestyle --config=3D.pyc= odestyle pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/ pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__ini= t__.py:644: [E123] closing bracket does not match indentation of opening bracket's line pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/__ini= t__.py:651: [E123] closing bracket does not match indentation of opening bracket's line pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/__init__.py:593: [E123] closing bracket does not match indentation of opening bracket's line pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/__init__.py:662: [E123] closing bracket does not match indentation of opening bracket's line pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/__init__.py:669: [E123] closing bracket does not match indentation of opening bracket's line pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/user_mapping/__init__.py:622: [E123] closing bracket does not match indentation of opening bracket's line pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/user_mapping/__init__.py:685: [E123] closing bracket does not match indentation of opening bracket's line pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/user_mapping/__init__.py:692: [E123] closing bracket does not match indentation of opening bracket's line pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/user_mapping/tests/test_user_mapping_add.py:72: [E126] continuation line over-indented for hanging indent pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/user_mapping/tests/test_user_mapping_add.py:84: [E121] continuation line under-indented for hanging indent pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/user_mapping/tests/test_user_mapping_get.py:74: [E126] continuation line over-indented for hanging indent pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/tests/test_foreign_servers_put.py:69: [E126] continuation line over-indented for hanging indent pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/forei= gn_servers/tests/test_foreign_servers_put.py:71: [E121] continuation line under-indented for hanging indent pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/tests= /test_fdw_delete.py:25: [E126] continuation line over-indented for hanging indent pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/tests= /test_fdw_delete.py:28: [E121] continuation line under-indented for hanging indent pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/tests= /test_fdw_delete.py:55: [E126] continuation line over-indented for hanging indent 3 E121 continuation line under-indented for hanging indent 8 E123 closing bracket does not match indentation of opening bracket's line 5 E126 continuation line over-indented for hanging indent 16 Did I execute the command correctly? If so there are some things that need to be solved still Thanks Joao On Thu, Mar 1, 2018 at 8:08 AM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the PEP-8 issues in the foreign dat= a > wrapper module. > > Thanks, > Khushboo > --001a113a9986d84d3305665ae25e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Khushboo,
I applied this patch and here is the r= esult:

=C2=A02018-03-01 09:41:00 =E2=8C=9A |r= uby-2.4.1| pgadmin-dev in ~/workspace/pgadmin4/web
=C2=B1 |pep-8-= fdw {2} U:13 =E2=9C=97| =E2=86=92 git st
On branch pep-8-fdw
Changes not staged for commit:
=C2=A0 (use "git add &l= t;file>..." to update what will be committed)
=C2=A0 (use= "git checkout -- <file>..." to discard changes in working = directory)

modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/databases/fore= ign_data_wrappers/__init__.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/databases/= foreign_data_wrappers/foreign_servers/__init__.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_group= s/servers/databases/foreign_data_wrappers/foreign_servers/tests/test_foreig= n_servers_add.py
modified= :=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/databases/foreign_data_= wrappers/foreign_servers/tests/test_foreign_servers_delete.py
modified:=C2=A0 =C2=A0pgadmin/browser/= server_groups/servers/databases/foreign_data_wrappers/foreign_servers/tests= /test_foreign_servers_get.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/databases/f= oreign_data_wrappers/foreign_servers/tests/test_foreign_servers_put.py
modified:=C2=A0 =C2=A0pgadmin= /browser/server_groups/servers/databases/foreign_data_wrappers/foreign_serv= ers/tests/utils.py
modifi= ed:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/databases/foreign_dat= a_wrappers/foreign_servers/user_mapping/__init__.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_g= roups/servers/databases/foreign_data_wrappers/foreign_servers/user_mapping/= tests/test_user_mapping_add.py
<= /span>modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/servers/databases= /foreign_data_wrappers/foreign_servers/user_mapping/tests/test_user_mapping= _delete.py
modified:=C2= =A0 =C2=A0pgadmin/browser/server_groups/servers/databases/foreign_data_wrap= pers/foreign_servers/user_mapping/tests/test_user_mapping_get.py
= modified:=C2=A0 =C2=A0pgadmin/brows= er/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/us= er_mapping/tests/test_user_mapping_put.py
modified:=C2=A0 =C2=A0pgadmin/browser/server_groups/server= s/databases/foreign_data_wrappers/foreign_servers/user_mapping/tests/utils.= py

no changes added to commit (use "git add&q= uot; and/or "git commit -a")

=C2=A02018-= 03-01 09:41:03 =E2=8C=9A |ruby-2.4.1| pgadmin-dev in ~/workspace/pgadmin4/w= eb
=C2=B1 |pep-8-fdw {2} U:13 =E2=9C=97| =E2=86=92 pycodestyle --= config=3D.pycodestyle pgadmin/browser/server_groups/servers/databases/forei= gn_data_wrappers/
pgadmin/browser/server_groups/servers/databases= /foreign_data_wrappers/__init__.py:644: [E123] closing bracket does not mat= ch indentation of opening bracket's line
pgadmin/browser/serv= er_groups/servers/databases/foreign_data_wrappers/__init__.py:651: [E123] c= losing bracket does not match indentation of opening bracket's line
pgadmin/browser/server_groups/servers/databases/foreign_data_wrapper= s/foreign_servers/__init__.py:593: [E123] closing bracket does not match in= dentation of opening bracket's line
pgadmin/browser/server_gr= oups/servers/databases/foreign_data_wrappers/foreign_servers/__init__.py:66= 2: [E123] closing bracket does not match indentation of opening bracket'= ;s line
pgadmin/browser/server_groups/servers/databases/foreign_d= ata_wrappers/foreign_servers/__init__.py:669: [E123] closing bracket does n= ot match indentation of opening bracket's line
pgadmin/browse= r/server_groups/servers/databases/foreign_data_wrappers/foreign_servers/use= r_mapping/__init__.py:622: [E123] closing bracket does not match indentatio= n of opening bracket's line
pgadmin/browser/server_groups/ser= vers/databases/foreign_data_wrappers/foreign_servers/user_mapping/__init__.= py:685: [E123] closing bracket does not match indentation of opening bracke= t's line
pgadmin/browser/server_groups/servers/databases/fore= ign_data_wrappers/foreign_servers/user_mapping/__init__.py:692: [E123] clos= ing bracket does not match indentation of opening bracket's line
<= div>pgadmin/browser/server_groups/servers/databases/foreign_data_wrappers/f= oreign_servers/user_mapping/tests/test_user_mapping_add.py:72: [E126] conti= nuation line over-indented for hanging indent
pgadmin/browser/ser= ver_groups/servers/databases/foreign_data_wrappers/foreign_servers/user_map= ping/tests/test_user_mapping_add.py:84: [E121] continuation line under-inde= nted for hanging indent
pgadmin/browser/server_groups/servers/dat= abases/foreign_data_wrappers/foreign_servers/user_mapping/tests/test_user_m= apping_get.py:74: [E126] continuation line over-indented for hanging indent=
pgadmin/browser/server_groups/servers/databases/foreign_data_wra= ppers/foreign_servers/tests/test_foreign_servers_put.py:69: [E126] continua= tion line over-indented for hanging indent
pgadmin/browser/server= _groups/servers/databases/foreign_data_wrappers/foreign_servers/tests/test_= foreign_servers_put.py:71: [E121] continuation line under-indented for hang= ing indent
pgadmin/browser/server_groups/servers/databases/foreig= n_data_wrappers/tests/test_fdw_delete.py:25: [E126] continuation line over-= indented for hanging indent
pgadmin/browser/server_groups/servers= /databases/foreign_data_wrappers/tests/test_fdw_delete.py:28: [E121] contin= uation line under-indented for hanging indent
pgadmin/browser/ser= ver_groups/servers/databases/foreign_data_wrappers/tests/test_fdw_delete.py= :55: [E126] continuation line over-indented for hanging indent
3= =C2=A0 =C2=A0 =C2=A0 =C2=A0E121 continuation line under-indented for hangin= g indent
8=C2=A0 =C2=A0 =C2=A0 =C2=A0E123 closing bracket does no= t match indentation of opening bracket's line
5=C2=A0 =C2=A0 = =C2=A0 =C2=A0E126 continuation line over-indented for hanging indent
<= div>16

Did I execute the command correctly?<= br>
If so there are some things that need to be solved still

Thanks
Joao



On Thu, Mar 1, 201= 8 at 8:08 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the= attached patch to fix the PEP-8 issues in the foreign data wrapper module.=

Thanks,
Khushboo
--001a113a9986d84d3305665ae25e--