Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewnin-0000Yi-Hc for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Mar 2018 11:40:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewnim-0001CS-1W for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Mar 2018 11:40:28 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewnil-0001CF-F7 for pgadmin-hackers@lists.postgresql.org; Fri, 16 Mar 2018 11:40:27 +0000 Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewnic-00022X-VW for pgadmin-hackers@postgresql.org; Fri, 16 Mar 2018 11:40:25 +0000 Received: by mail-io0-x22a.google.com with SMTP id e7so1823540iof.2 for ; Fri, 16 Mar 2018 04:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qtkx8TqogQ3sFjy8cYXRPL2pM6l+k3I/yKK1Hhj5aF0=; b=ojWiFmA0cRTv8pknPf7Vj4QfCV442N+d6ZP0LfDhLVCO83CfTPhlnrc4/T5X8vUjE9 9dybuRwILs8fBGHKmzc/evouLq00P9nZur2o6mmOkvBoCQ9oouIiS3lItbN2A63BVflm E2q9pqQ9GhQA4afBqw7txM04loMuw1ykoOehduGo/v5VmyYRQ7ejlimdbogJjrNIh5To yjkD7t1Ettmv2a4ldiQJyeQ/cYaf+ZmO0NG12GOMqYCYczLqWyted9/WD4GSK0OC1lRj pCaagFCEvVBVf/if/xUzWl+Frxo59ulkdAEhSk7SFGycpi6hUWL+sx0bn9GGtTzg3s3y 1v+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qtkx8TqogQ3sFjy8cYXRPL2pM6l+k3I/yKK1Hhj5aF0=; b=aAHmJUbbjOlP4vVH1Bft2pBLze2skCIYmH+R1nZ0Irtzw2yVob1+CQoAhlG46PKBza DQGFe0wVfPWm/SlmFVaGrO1DVNdw4foP/hyI9oi7uyYkVdlUegLffVDSTvcuJEvzojuU vFmntMJiYLYcwsVqr2bUtEK3x5fhET+D9fVjXAQ6ehudBMcOI5qoKUHrFcXGIvt6pXmB PE+JB4nCDqnLfoVkLGqAj2MDGCA/9B4Fs07ZQ7qXadKg7E1+9bKmah2ejV9AlJiCUIZ6 7tPFWKsLe9W2HxoLDtQzgs6QL9VNUvmDB5Lhb8oGaTcN/Ti/WpVlbl3HoJgd19WFx3J9 uWRw== X-Gm-Message-State: AElRT7GGrLrjTYGzBLj5JfaYPwnQWVYnCQ/wzZQg3to4av8+UgtDzjkc 4K18lD/NcLHmocMOZ+EdGaiwkOuUcT44tt+v4SqdMA== X-Google-Smtp-Source: AG47ELulqZlRP8NcW6irP0bk3ZV+sWoejeCW18Ow8qWoQzrm5p0didvh9DmJKg7w5sv3gLt+zVePA0GWEaZtcOaxKEk= X-Received: by 10.107.200.84 with SMTP id y81mr1416356iof.116.1521200417325; Fri, 16 Mar 2018 04:40:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Fri, 16 Mar 2018 11:40:06 +0000 Message-ID: Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn To: Dave Page Cc: Murtuza Zabuawala , Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c0b89ea81e19a0567861282" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c0b89ea81e19a0567861282 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, Personally I believe we should fix the config_local pep issues and just ignore the migrations. Specially because the migration file should not have a lot of python code. Thanks On Thu, Mar 15, 2018 at 3:32 PM Dave Page wrote: > On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Thu, Mar 15, 2018 at 9:42 PM, Dave Page wrote: >> >>> >>> >>> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < >>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I have just noticed, we're ignoring migrations directory too. >>>>>> Should we not also check code styling for migrations directory? >>>>>> >>>>> >>>>> Yeah, I was going to ask about that :-). Is there a specific reason >>>>> why we're ignoring the migrations Murtuza? >>>>> >>>> =E2=80=8BTo ease writing long SQL's. >>>> >>>> >>> >>> Perhaps we could just skip the long line check for those files? >>> >> =E2=80=8BWe have to create separate config for that and then run pycodes= tyle >> using that config for migration.=E2=80=8B >> >> =E2=80=8B1) pycodestyle --config=3D.pycodestyle >> =E2=80=8B2) pycodestyle --config=3D.pycodestyle_migration >> >> something like that, Because I checked the documentation and I didn't >> find any option to have single config file for individual directories. >> > > Urgh. I suppose we could keep a config file in the migration directory, > but even then, we'll get two sets of stats out for running two tests. > > >> >> >>> >>>> >>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & Regards, >>>>>> >>>>>> Ashesh Vashi >>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> >>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>> >>>>>> >>>>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page wrote= : >>>>>> >>>>>>> Ignore config_local.py and config_distro.py when running PEP-8 >>>>>>> checks. >>>>>>> >>>>>>> Branch >>>>>>> ------ >>>>>>> master >>>>>>> >>>>>>> Details >>>>>>> ------- >>>>>>> >>>>>>> https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdiff;h= =3D53ae960aeba0dde6109b91c171f22758b1b04ebe >>>>>>> >>>>>>> Modified Files >>>>>>> -------------- >>>>>>> web/.pycodestyle | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c0b89ea81e19a0567861282 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,
Personally I believe we should fix the config_l= ocal pep issues and just ignore the migrations. Specially because the migra= tion file should not have a lot of python code.

Th= anks

On Thu, Mar= 15, 2018 at 3:32 PM Dave Page <dpa= ge@pgadmin.org> wrote:
On Thu, M= ar 15, 2018 at 12:25 PM, Murtuza Zabuawala <murtuza.zabua= wala@enterprisedb.com> wrote:
Hi Dave,

On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <= ;dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">

On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <= ;mu= rtuza.zabuawala@enterprisedb.com> wrote:
On Thu, Mar 15, 2018 at 4:53 PM, Dave = Page <dp= age@pgadmin.org> wrote:
Hi

On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi,

I = have just noticed, we're ignoring migrations directory too.
S= hould we not also check code styling for migrations directory?

Yeah, I was going to ask about that :-)= . Is there a specific reason why we're ignoring the migrations Murtuza?=
=E2=80=8BTo ease wri= ting long SQL's.
=C2=A0
<= br>
Perhaps we could just skip the long line check for those file= s?
=E2=80=8BWe have t= o create separate config for that and then run pycodestyle using that confi= g for migration.=E2=80=8B
=C2=A0
=E2=80=8B1) pycodestyle --config=3D.= pycodestyle
=E2=80=8B2)=C2=A0pycodestyle --config=3D.pycodestyle_migration

somethi= ng like that, Because I checked the documentation and I didn't find any= option to have single config file for individual directories.=C2=A0
<= /div>

Urgh.= I suppose we could keep a config file in the migration directory, but even= then, we'll get two sets of stats out for running two tests.
=C2=A0
=

<= div class=3D"m_-5735274142288760258h5">
=C2=A0
=C2=A0

=

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
Ignore config_local.py and config_distro.py when running= PEP-8 checks.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdi= ff;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe

Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


<= font color=3D"#888888">

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogsp= ot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company

=


--
Dave Page
Blog:= http://pgsnake.b= logspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company
--94eb2c0b89ea81e19a0567861282--