Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1er9Sn-0005MD-Pn for pgadmin-hackers@arkaria.postgresql.org; Wed, 28 Feb 2018 21:40:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1er9Sm-0001Wo-23 for pgadmin-hackers@arkaria.postgresql.org; Wed, 28 Feb 2018 21:40:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1er9Sl-0001We-N0 for pgadmin-hackers@lists.postgresql.org; Wed, 28 Feb 2018 21:40:35 +0000 Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1er9Sc-0002wv-9f for pgadmin-hackers@postgresql.org; Wed, 28 Feb 2018 21:40:34 +0000 Received: by mail-io0-x22a.google.com with SMTP id 30so4871845iog.2 for ; Wed, 28 Feb 2018 13:40:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=csHuSsft5/HQaRZYZ7hRaw93ajNeBp0WbVKce7qnQYo=; b=mHBj0jr1xfIOJZ1ZjCJKtnXSlT8OfSzLtwH2qN3LEdYMo4/q72t9zP11PSghSjY9PR uA6YkFdx/SCgAQddUrf3tGavTP2MJGHU9vgvXqp94W6IIOpivBYF8JGF91xkfoX4xZ9v mg5zxBbDIVsIwHfvN0zDmEHMzpc7U32ARhnX/BKMPzBOa3Aq+RvbzTgmYjTW5AurAntJ i6Uu+4X/6bcyD5/nNogFLSF/GwoNbgfeXlYjwIRA5KxFoJiSvT+o9GpzDppOwRlwQ9cE hxAHcZw6gwL1ziwHpoXfJ5YTBBDail7unxUJfDlU7cjSMnC/6m94Ctkb9H7Im+LmfnPg BYiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=csHuSsft5/HQaRZYZ7hRaw93ajNeBp0WbVKce7qnQYo=; b=Irjfui0d5pZowxQ9g5wNIAA2natBHvXlykGjJlSVIIP1jBvI2o0re6VQMxht5vCPpC kexljOifoTXatWRgQNxDT2+RchrWm7UzzeNp0wJV1rta2DLcm/Y6raHgijjRhRuPUChY g2GU29JfzBn5xOZZTxD06dx0LWxMCIe5Thr78Wb1e3b5ipO18vpM8x+WEiilzKRZkrGw 4+ceHSTSmIovtPT6OTW3mJdjdhYI4ire4chYZKXjiVSDWuTszsyAPB3Luw8BWZ5/k9F0 /BwSzIkawwNaQoylnwZXQ2H/27wKrCBD8yQZJCCcSk1q/rDy4Yvn7UjscNms8EH/Pq1h xZMw== X-Gm-Message-State: APf1xPDXpgO4D31zQusoEvRFUmDW6d6tVuX7OAGdb1iM7JYEPcdJzL2P npIjbhTEYyHoqFv/HJcphJLKStqyKxBzHQ20sI65Bg== X-Google-Smtp-Source: AG47ELvqgGJXa0YkEIL/vOdon333AAx5G98kJIso65rq2Jcx3rOKGhqPq1mygJeO1TzSaZ8p+Qwtqy2ummEIQewOEew= X-Received: by 10.107.38.80 with SMTP id m77mr22093549iom.69.1519854023027; Wed, 28 Feb 2018 13:40:23 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Wed, 28 Feb 2018 21:40:12 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3161] Fix PEP-8 issues To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1140c2842740d505664c97e6" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1140c2842740d505664c97e6 Content-Type: text/plain; charset="UTF-8" Hello Murtuza, I passed the patch through our CI and all test are green. Also run the codestyle in all those folders and everything is clean. 575 issues to go Thanks Joao On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the PEP8 issues in Casts, Event triggers, Extensions and > Languages module. > > pycodestyle --config=.pycodestyle > pgadmin/browser/server_groups/servers/databases/languages/ > pycodestyle --config=.pycodestyle > pgadmin/browser/server_groups/servers/databases/extensions/ > pycodestyle --config=.pycodestyle > pgadmin/browser/server_groups/servers/databases/event_triggers/ > pycodestyle --config=.pycodestyle > pgadmin/browser/server_groups/servers/databases/casts/ > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > --001a1140c2842740d505664c97e6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Murtuza,

I passed the patch throu= gh our CI and all test are green. Also run the codestyle in all those folde= rs and everything is clean.

575 issues to go
=

Thanks
Joao

On Wed, Feb 28, 2018 at 1:05 PM Murtuza Zabuawala= <murtuza.zabuawal= a@enterprisedb.com> wrote:
<= div dir=3D"ltr">
Hi,

PFA patch to fix the PEP8 issues in=C2=A0Casts, Event triggers, Exten= sions and Languages module.

pycodestyle --config=3D.pycodestyle pgadm= in/browser/server_groups/servers/databases/languages/
pycodestyle --config=3D.pycodesty= le pgadmin/browser/server_groups/servers/databases/extensions/
=
pycodestyle --config=3D.= pycodestyle pgadmin/browser/server_groups/servers/databases/event_triggers/=
pycod= estyle --config=3D.pycodestyle pgadmin/browser/server_groups/servers/databa= ses/casts/

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company

=
--001a1140c2842740d505664c97e6--