Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3hLk-0001GH-PY for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Apr 2017 11:12:41 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d3hLk-0004d4-6G for pgadmin-hackers@arkaria.postgresql.org; Thu, 27 Apr 2017 11:12:40 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d3hLU-0004EU-UC for pgadmin-hackers@postgresql.org; Thu, 27 Apr 2017 11:12:25 +0000 Received: from mail-vk0-x22f.google.com ([2607:f8b0:400c:c05::22f]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d3hLQ-0005my-Or for pgadmin-hackers@postgresql.org; Thu, 27 Apr 2017 11:12:22 +0000 Received: by mail-vk0-x22f.google.com with SMTP id k4so15135531vki.1 for ; Thu, 27 Apr 2017 04:12:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/X8DgbGLs4UzIQwF3BWz2ZVOH0JsqxG6fpoMHYGV/GY=; b=QCa9i5nJlN71HFDG78c2q1zjpbEabjR8M4d3HFLyeq73QOCA1iB8xDGRvighLdZ/Gq KkEGMe81q9UBEV5PWR/hvQXZVJWXCVI6XTzW737Pecl5Rc324ek/DJx/cSq6OHprlZvj a1qJpsXijtipgFEdYbyMVqTN4bRgLxt29tBIXYRJopcy/DlWxfssZyIeNekPv92bJRy9 apJiIBOyYNYQYtHi2YD3AgtT9uCRnRBzjAeTQ9QjB13LxUjYmyuH8NJtqWZ9LUgxMxjI 0zysWLrCfeOJM2rhNOGcvuY42ddvjtyk4E35BD9bJV+9tpDsPf1t3YGuuTnQj7295fhs 5vIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/X8DgbGLs4UzIQwF3BWz2ZVOH0JsqxG6fpoMHYGV/GY=; b=o8jHFxoG6n8FnF8Rfv1oeQl0jSKNowasoCigtYPpu/Sqo2Ud1kIqgAEaDuvIxha8Fy M2RXjUnlN2Kb7t1ljzqK+SYbW9dcRK+wmAIba29qchXm1DzXGvWZhPQHi1818cSeECuQ a0rT0pHbOzvXksHd5x5O8oua+4+eXaxZNDz1mo7s7wVVCqZSBsjEhn5+o6JRC/rRi6qm jg5WFSpB40zlKOmmF+Fl/mziI0gBIldPPQ1t8mkIYhDSM9GqRoYs7PTXqag+dugVSaSg e5+cNtgOMMFIx+x5x+ko0pBXJzzfHBbZLCaq/R/QoWVpp5du/nbV7ExuwsCGkcV6rHQN 2xHg== X-Gm-Message-State: AN3rC/6lJJorNQAeApXwFJrSlv46gzg0gphUdZ2rR5xUsQqQ9rmvYxB1 vxCU3FqOB4940Bi28SJWSFwRXKwbjCFj X-Received: by 10.31.115.130 with SMTP id o124mr1915782vkc.59.1493291538832; Thu, 27 Apr 2017 04:12:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao Pedro De Almeida Pereira Date: Thu, 27 Apr 2017 11:12:08 +0000 Message-ID: Subject: Re: Issue with SlickGrid To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c14c862b801cd054e2407f4 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c14c862b801cd054e2407f4 Content-Type: text/plain; charset=UTF-8 Hello Murtuza, Thanks for the explanation. Based on what you said it looks like a bug in the library, have you guys considered sending a PR to it? Thanks On Thu, Apr 27, 2017, 2:46 AM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > +++ > Reference: > https://www.postgresql.org/message-id/CAKKotZRjqbKAZev81Zk78nikDVXqLKEDV5r%2BsW8Me31Gpzrm_A%40mail.gmail.com > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Apr 27, 2017 at 12:09 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hello Joao, >> >> Yes, We made some changes in SlickGrid library when we integrated it into >> Query tool. >> >> *Issue:* Last row from the query result set was not displaying correctly >> in query tool when we have scrollbar in grid. >> >> The row hight/width pixel size calculations is done inside SlickGrid >> javascript code, Though we tried solve it through CSS but we had no luck, >> so we had no other choice but to do it in library it self. >> >> The changes were, >> 1) "getDataLengthIncludingAddNew()" function (slick.grid.js) to add two >> new rows instead of one when user add values into row (one row is dummy & >> not visible to user so that it displays last row correctly) >> 2) Other change was done into "appendRowHtml()" function to calculating >> the correct number of rows in SlickGrid result as we have added our own >> custom row as mentioned earlier. >> 3) Abbreviated long CSS classes as mentioed in README file. >> >> Apologies we missed to update this change in README. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hello Hackers, >>> >>> While doing some changes to the Query Results we found out that there >>> was a issue with Slick grid. >>> >>> The issue that we found was with the CellSelectModel, behaved >>> differently when pressing Ctrl and Command(Mac). We created a PR >>> with the change to changes >>> the behavior of the plugin. >>> >>> When this PR is applied to the SlickGrid library we need to apply it to >>> the current version of SlickGrid that we have vendorized. >>> According to the libraries.txt file we are in version 2.2.4 of the >>> library but a diff between our code and the libraries version 2.2.4 shows >>> differences in the code. >>> >>> Did we do any change to SlickGrid library that is vendorized? Or is just >>> the information in libraries.txt that is incorrect? >>> Does anyone know any problem if we bump the version of SlickGrid to the >>> newer version after the PR is applied? >>> >>> Thanks >>> Joao >>> >> >> > --94eb2c14c862b801cd054e2407f4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hello Murtuza,
Thanks for the explanation. Based on what you said it looks like a bug in t= he library, have you guys considered sending a PR to it?

Thanks


On Thu, Apr 27, 2017, 2:46 = AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://ww= w.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Apr= 27, 2017 at 12:09 PM, Murtuza Zabuawala <murtuza.zabuawa= la@enterprisedb.com> wrote:
Hello Joao,

Yes, We made some changes = in SlickGrid library when we integrated it into Query tool.

<= /div>
Issue: Last row from the query result set was not displayi= ng correctly in query tool when we have scrollbar in grid.
The row hight/width pixel size calculations is done insid= e SlickGrid javascript code, Though we tried solve it through CSS but we ha= d no luck, so we had no other choice but to do it in library it self.
=
=C2=A0=C2=A0
The changes were,
1) "= getDataLengthIncludingAddNew()" function (slick.grid.js) to add two ne= w rows instead of one when user add values into row (one row is dummy &= not visible to user so that it displays last row correctly)
2) O= ther change was done into "appendRowHtml()" function to calculati= ng the correct number of rows in SlickGrid result as we have added our own = custom row as mentioned earlier.
3) Abbreviated long CSS classes = as mentioed in README file.
=C2=A0
Apologies we mi= ssed to update this change in README.


--
Regards,=
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL C= ompany
<= /div>

On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro = De Almeida Pereira <jdealmeidapereira@pivotal.io>= wrote:
Hello Hackers,
While doing some changes to the Query Results we found ou= t that there was a issue with Slick grid.=C2=A0

Th= e issue that we found was with the CellSelectModel, behaved differently whe= n pressing Ctrl and Command(Mac). We created a PR with the change to chan= ges the behavior of the plugin.

When this PR is ap= plied to the SlickGrid library we need to apply it to the current version o= f SlickGrid that we have vendorized.
According to the libraries.t= xt file we are in version 2.2.4 of the library but a diff between our code = and the libraries version 2.2.4 shows differences in the code.
Did we do any change to SlickGrid library that is vendorized? = Or is just the information in libraries.txt that is incorrect?
Do= es anyone know any problem if we bump the version of SlickGrid to the newer= version after the PR is applied?

Thanks
Joao


--94eb2c14c862b801cd054e2407f4--