Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0Wv5-0003ib-7n for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 18:32:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0Wv4-0006k6-Af for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 18:32:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0WuX-00057d-1U for pgadmin-hackers@lists.postgresql.org; Mon, 26 Mar 2018 18:32:01 +0000 Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0WuR-0004H3-GE for pgadmin-hackers@postgresql.org; Mon, 26 Mar 2018 18:31:59 +0000 Received: by mail-io0-x231.google.com with SMTP id r18so24431328ioa.1 for ; Mon, 26 Mar 2018 11:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jjvMx3YeIkuWAlCKobJjBhcDBO4oUTMD/9REQDckIU4=; b=Uh7jyuRvzqcXwH8tHTCpP/P9HCHmHb6haan+0uyCpkdnas3QUiVLOCdop+j2ILdbZq kNbz/iFGmmHf4htfAfKgcAjHA09Xngv1LqM+HXoYidFnnjOnsEWdi7Uo92CvRnjOZxiG NUFHjJjwUlsMi/RqEWgBTjf7oIPBp5W4IUjqS9rFUVxEO0fc0Ysw/CvAqz8Q1O3k7vWx CbfqoOlx/63sZb/ggxVmMLkx3icojUH+aDSh2WewKqg+WH+5xuDMN7R0zSD+RodbX00r HvUZS+sut9/V1o1DaoRbkeEW4V2000LZ6bcTH0wVgoVbLJ5vCdmh2AglitsprO/Dz448 c6iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jjvMx3YeIkuWAlCKobJjBhcDBO4oUTMD/9REQDckIU4=; b=uZrxVsOJbyuUrzDN5J+FcSuWoUlRi4etz59C3mAkw9Hb0xOQ83fUywr4JTFvY9zENx wkR/hIUAU70PmdJA1+RCY0NzQTVcA3cyRThgwpO3hAQJf/Pn/4Lc0BncfsSjfMXUwyrE ieT5V90WTU/i8v8jZKmaUGS1hIix2C4FynhMX1JDdWrlqGwRESKM0LFgqCr7YxuPlxqT orh8MQlz74dNO4BIwEsPVPdINbczJDeDpl3CnUIirw2Lt3oNWY21J7dbXrR4LCITVRf0 DlFNVHA6aBbvqbIrk0rpnmobQ9GqRitRkXvEL46mQJtAZ+1IJKw0QwroY2lBsiwBYna9 lnfg== X-Gm-Message-State: AElRT7E5BnUzoA+Ml9KeVSyM/cFQYSLYBYSBskJ3KB29VXb3RkysOgIj 1lzomXZgeNVpqNxsBfsygocKITmd4aetndriwW6OEg== X-Google-Smtp-Source: AIpwx49JdfDWn7ET/BOMic8qyyfRQIVDhJbCesz81xGJmOsZOasKUEUQndo8FZU6LZZjkWj46GICM1+mLrPtgaRGtU0= X-Received: by 10.107.143.211 with SMTP id r202mr9740962iod.185.1522089112189; Mon, 26 Mar 2018 11:31:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Mon, 26 Mar 2018 18:31:41 +0000 Message-ID: Subject: Re: [pgAdmin4][patch]: RM #3090 pgadmin shows misleading "Query returned successfully" with incorrect SQL To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c05a4bcd964d7056854fce1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c05a4bcd964d7056854fce1 Content-Type: text/plain; charset="UTF-8" Hello, We tried to reproduce the issue but we were not capable to reproduce it. What it is strange on the fix is that python is complaining about a different line then the one that was fixed. Maybe this is just a Python thing.... I assume that the fix works, but I would love to see some tests to ensure it is working. Another issue that looks more problematic is the fact that, as per the Redmine issue, when an exception is thrown it sends back a Successful Query message. If this is the case then this fix doesn't look like it is enough to solve the problem. Thanks Victoria & Joao On Mon, Mar 26, 2018 at 9:00 AM Dave Page wrote: > Thanks, applied. > > On Mon, Mar 26, 2018 at 11:43 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch to fix RM #3090 pgadmin shows misleading >> "Query returned successfully" with incorrect SQL. >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --94eb2c05a4bcd964d7056854fce1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,
We tried to reproduce the issue but we were not= capable to reproduce it.=C2=A0
What it is strange on the fix is = that python is complaining about a different line then the one that was fix= ed. Maybe this is just a Python thing....

I assume= that the fix works, but I would love to see some tests to ensure it is wor= king. Another issue that looks more problematic is the fact that, as per th= e Redmine issue, when an exception is thrown it sends back a Successful Que= ry message. If this is the case then this fix doesn't look like it is e= nough to solve the problem.

Thanks
Victo= ria & Joao

O= n Mon, Mar 26, 2018 at 9:00 AM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Mon, Mar 26,= 2018 at 11:43 AM, Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
H= i Hackers,

Please find the attached patch to fix RM=C2= =A0#3090 pga= dmin shows misleading "Query returned successfully" with i= ncorrect SQL= .

--
Akshay Joshi<= /b>
= Sr. Software Architect





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company
--94eb2c05a4bcd964d7056854fce1--