Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3SFO-0005vC-LZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 20:09:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3SFN-00033u-A1 for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 20:09:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3SFM-00033h-TH for pgadmin-hackers@lists.postgresql.org; Tue, 03 Apr 2018 20:09:37 +0000 Received: from mail-it0-x22a.google.com ([2607:f8b0:4001:c0b::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3SFF-0000Lw-AR for pgadmin-hackers@postgresql.org; Tue, 03 Apr 2018 20:09:35 +0000 Received: by mail-it0-x22a.google.com with SMTP id 15-v6so14245083itl.1 for ; Tue, 03 Apr 2018 13:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cL3VllyU3ik7tB8ez5B2I8HfE9lu/6KlQc2UuFJxCTg=; b=HyUz5cgxSeUNB62sx7GF1Uabf9COJXpDuz5y/wHPOLPqzIJIUukTsffGmPV4V4jOr0 MNR8LyB2vfIYxvu/8/V+CXIqlQLJBf1fqAlPpsGJO6pXAhkxlLa4qoHMlPULGQFGA9JS YN682LdHsL/fgjYgxsTEPNWVuJ6jJVouUjeA7go+4j1HohGOV/4vGNNw3OlTfNhcep9s TiIOPXb7QcVpNujPZR8yAbH3arDJyshHjtpFxxkujT//Wjq+2xlCldaTh46cXjzNdrxf 4i6H2qN2bf5eVkdkA+tbmCKbiyumcbY9jeae2GqMIyWsLIK+wKbgSawTpaOCmHiaZrwf XVWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cL3VllyU3ik7tB8ez5B2I8HfE9lu/6KlQc2UuFJxCTg=; b=lCFBGBZ3vqTuZQT5BE659d3jlpCYv+y6xrAczRJoM9DeoW6bziX7R76KO02BpzOTBy MqDs2zCalSQ9Nl+9AjmwloWK/CKrs8qdl62t7am8nECvwFXf7yH2bDJCpXhY9dKHlnq4 8u3/xdBVOY6vWl1vAHFzcFuFeAZJ2NWoH6OXsK8K3vbsqlVB5k8iHgOrog5OHy4SJjCr maMgIl0xPZPpTBva1gqqGBIzxWzfRgtKZ+4d4/PjaLD7QIJ2zxfKpyFwSVs5mSZw9Z88 0k/kFK8oY+ks4zbuS/gukrOqUeL1Cyz2ZEG75Fn2g2RJdiLdOgisw6+MalybtCcqpd0/ WQqg== X-Gm-Message-State: ALQs6tDGbA4yQ/iitus/bDMONbCfScFMCpngJ42S3zIVa+3/VtORocmq BzJmdGkoaMwSmnv2YWjYh9w6FGEFb+4Ujw8jo1FSRA== X-Google-Smtp-Source: AIpwx48L2CFjmatqVvWq9S3zVJQxcoNPGV+Jfo6DVLEpCPwStHkuQ5F5DS7EyRJojw8A3CwumEOFnxnXQ5voZ3atjlE= X-Received: by 2002:a24:5c04:: with SMTP id q4-v6mr7070865itb.69.1522786167288; Tue, 03 Apr 2018 13:09:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Tue, 03 Apr 2018 20:09:16 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version To: Murtuza Zabuawala Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000921bca0568f748e1" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000921bca0568f748e1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Murtuza, The patches look good and they pass all tests in CI. One think that we realized was the SlickGrid as a npm package now: https://www.npmjs.com/package/slickgrid Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully supported or not...... Thanks Victoria & Joao On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > =E2=80=8BHi Dave, > > Reverted back jQuery version to 1.x because of SlickGrid dependancy. > Please find updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Please hold on my previous patch. >> >> We can't use latest jQuery version as SlickGrid has dependancy on older >> version. >> I'll send updated patch again. >> >> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find updated patches, there are two patches attached one is for >>> the story and another is for changes required as per new modules. >>> >>> >>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> PFA patch to update the modules to latest version. >>>>> >>>>> >>>> - Why isn't jQuery updated to 3.3.1? >>>> >>> =E2=80=8BDone=E2=80=8B >>> >>> >>>> =E2=80=8B >>>> >>>> >>> >>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2 >>>> and pycrypto etc? >>>> >>> =E2=80=8BDone=E2=80=8B >>> >>> >>>> >>>> >>>> >>>>> We are not able to update some of the modules to latest version due t= o >>>>> dependancy on other modules, For example >>>>> - Python: Flask-Security has dependancy on flask-babelex which causes >>>>> conflict with flask_babel >>>>> >>>> >>>> Hmm, flask-babelex might be a better option anyway; in particular, it >>>> avoids loading catalogs with every request which seems desirable given= the >>>> size of ours. On the other hand, it hasn't been updated so recently. >>>> >>> =E2=80=8BI have removed flask-babel and used flask_babelex instead.=E2= =80=8B >>> >>> >>>> >>>> >>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & Bootstrap= Datetime >>>>> picker has dependancy on Bootstrap3. >>>>> >>>> >>>> OK. >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> > --000000000000921bca0568f748e1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Murtuza,

The patches look good and t= hey pass all tests in CI.
One think that we realized was the Slic= kGrid as a npm package now:=C2=A0https://www.npmjs.com/package/slickgrid=C2=A0
Also = Slickgrid comes packaged with jquery 3.1 not sure if it is fully supported = or not......

Thanks
Victoria & Joao<= /div>
On Tue, Apr 3, 2018 at= 11:50 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
=E2=80=8BHi Dave,=

Reverted back jQuery version = to 1.x because of SlickGrid dependancy.
Please find updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

<= /div>

On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> = wrote:
Please h= old on my previous patch.=C2=A0

We can'= ;t use latest jQuery version as SlickGrid has dependancy on older version.<= /div>
I'll send updated patch again.

On Tue, Apr 3, 2018 at 8:20 PM, Murtuz= a Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,

Please find updated patches, t= here are two patches attached one is for the story and another is for chang= es required as per new modules.

<= /div>

On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to update the modules to latest version.


- Why isn't jQuery updated to 3.3.1?
=
=E2=80=8BDone=E2=80=8B
=C2= =A0
=E2=80=8B
=C2=A0

- Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2 a= nd pycrypto etc?=C2=A0
=E2=80=8BDone=E2=80=8B
=C2=A0
=C2=A0
We are not able to update= some of the modules to latest version due to dependancy on other modules, = For example
- Python: Flask-Security has dependancy on flask-babelex which causes con= flict with flask_babel

Hmm, fla= sk-babelex might be a better option anyway; in particular, it avoids loadin= g catalogs with every request which seems desirable given the size of ours.= On the other hand, it hasn't been updated so recently.
=E2=80=8BI have removed flask-babel and use= d flask_babelex instead.=E2=80=8B
=C2=A0
=C2=A0
- JS: Can't update= to Bootstrap4 because Bootstrap Switch & B= ootstrap=C2=A0Datetime picker has dependancy on Bootstrap3.

OK.=C2=A0


--
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpris= e PostgreSQL Company



--000000000000921bca0568f748e1--