public inbox for [email protected]  

help / color / mirror / Atom feed

From: Joao De Almeida Pereira <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pagdmin][patch] Update jasmine #3182
Date: Tue, 06 Mar 2018 20:56:35 +0000
Message-ID: <CAE+jjakMvTZFS5hDNc+8b_u=y24LONQgmCCTRW=tC4kQWqQ3fQ@mail.gmail.com> (raw)

Hi Hackers,

Attached you can find the patch that updates the version of jasmine to 3.0

Thanks
Joao


Attachments:

  [text/x-patch] upgrade-jasmine.diff (1.7K, 3-upgrade-jasmine.diff)
  download | inline diff:
diff --git a/web/package.json b/web/package.json
index 2707b334..a4cb58d5 100644
--- a/web/package.json
+++ b/web/package.json
@@ -18,7 +18,7 @@
     "file-loader": "^0.11.2",
     "image-webpack-loader": "^3.3.1",
     "is-docker": "^1.1.0",
-    "jasmine-core": "~2.9.0",
+    "jasmine-core": "~3.1.0",
     "jasmine-enzyme": "~4.1.1",
     "karma": "~1.5.0",
     "karma-babel-preprocessor": "^6.0.1",
diff --git a/web/regression/javascript/gettext_spec.js b/web/regression/javascript/gettext_spec.js
index 3e027450..2ad9d87c 100644
--- a/web/regression/javascript/gettext_spec.js
+++ b/web/regression/javascript/gettext_spec.js
@@ -13,7 +13,8 @@ import translations from 'translations';
 describe('translate', function () {
   describe('when there is no translation', function () {
     it('returns the original string', function () {
-      expect(gettext('something to be translated')).toEqual('something to be translated');
+      expect(gettext('something else to be translated')).toEqual('something' +
+        ' else to be translated');
     });
 
     describe('when there are substitutions', function () {
diff --git a/web/yarn.lock b/web/yarn.lock
index 666a20e6..5e310d79 100644
--- a/web/yarn.lock
+++ b/web/yarn.lock
@@ -4267,9 +4267,9 @@ isurl@^1.0.0-alpha5:
     has-to-string-tag-x "^1.2.0"
     is-object "^1.0.1"
 
-jasmine-core@~2.9.0:
-  version "2.9.1"
-  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-2.9.1.tgz#b6bbc1d8e65250d56f5888461705ebeeeb88f22f"
+jasmine-core@~3.1.0:
+  version "3.1.0"
+  resolved "https://registry.yarnpkg.com/jasmine-core/-/jasmine-core-3.1.0.tgz#a4785e135d5df65024dfc9224953df585bd2766c"
 
 jasmine-enzyme@~4.1.1:
   version "4.1.1"

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pagdmin][patch] Update jasmine #3182
  In-Reply-To: <CAE+jjakMvTZFS5hDNc+8b_u=y24LONQgmCCTRW=tC4kQWqQ3fQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox