Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0WXI-0002Gc-Ka for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 18:08:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0WXE-0006w3-LA for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 18:07:56 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0WXE-0006vt-4g for pgadmin-hackers@lists.postgresql.org; Mon, 26 Mar 2018 18:07:56 +0000 Received: from mail-io0-x22a.google.com ([2607:f8b0:4001:c06::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0WX9-0005K7-8g for pgadmin-hackers@postgresql.org; Mon, 26 Mar 2018 18:07:53 +0000 Received: by mail-io0-x22a.google.com with SMTP id d7so8988711ioc.11 for ; Mon, 26 Mar 2018 11:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HVPJPIkMA3/BIgREkemM5RBqxxsr5rkq84PVefIWr+s=; b=TIzsshxaXnkRkj7LpRUU2Es7ZQnUmBvA/9rdOBXGpCiSbqI8ORtC7OedUp2bCfttvE oYwKj7U3pgdc4mALXPhwA0VLR68xPtAw4/fyIRrdC/5tBDLNUkMFSJfDIWxsx5o0SnUR KtgJmZUu2jA0rZgG7fpPHRoHUDm6fN6w4T1R4RFMkJpmD5b+f/NEFt9BY79ok8hBupQG LWhRzpCZO7G0zHJLc6hlryjP6QB7bxy+02+XF+b2ushAApwFKUOpPmVXYo3+SjSMF2XU gnyyw6hwORpp0GhzSjY5iGIadzgk9WpFDwOXUhwifBAknqIcmfB/Hl3RhBSD5O3ArVyp Moug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HVPJPIkMA3/BIgREkemM5RBqxxsr5rkq84PVefIWr+s=; b=rJzDgqGSVG7XPyIR/RPD9veWdWJjjKf31Ord15zho6SXmJTR4Kfj6dOPOBQRUIKOov aN+AgRNwi0UULs0ucitX2RXspkZkIQZHLF8eCtnOmdiEYD7gndd62aSr+9vMNud6uZ7u QdlseXVeyjnGGlOtQpBZmzzl4mkfvIoLTk1ESF6R0qrJ4d5PJwspDv0Bv8yiJ2adYIPE v8FhId2Lpjv3vWBr/u7EKzCD4MdX8Opok/WlGFfDOB920a2LYYKQ04HA8hvvoiLB1ecx /JdcN6nQD8Ier+ypBLU+qO/h7a1DaS/86cHyoVxX5HtdBYCXelrsFMvU1j3EdvI60oYy ZgXw== X-Gm-Message-State: AElRT7HVv3H391kEcX6gBHgRtY17L/QBvBCuZ58U8G8Jbifga6cUyWVC o/C9BcANHAb6DFHBO1xLo1mv1zyLfUCuHgaef9bZ3w== X-Google-Smtp-Source: AIpwx48HyxYMyXIK8/JSrOspQgkdRj9vOHZ5o6fSyhE7IU0kkCAB8Mc34Rapg/2V1Bo3F99f5bnwA7wl5FvF7qYCTFg= X-Received: by 10.107.200.84 with SMTP id y81mr11879413iof.116.1522087669384; Mon, 26 Mar 2018 11:07:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Mon, 26 Mar 2018 18:07:38 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode To: Murtuza Zabuawala Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c0b89ead9e532056854a662" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c0b89ead9e532056854a662 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Hackers, @Murtuza: The patch codewise looks good. Nice to see that we are using axios instead of jquery ajax calls and that there is some coverage for the change. Nevertheless the Javascript testing looks a bit slim and could be improved. Also the DataSorting class could have some other member functions like the model validation could be extracted out so that it is easily tested. @Hackers: This was how we tried to test this feature: 1 - Started pgAdmin 2 - Opened the query tool for a specific server 3 - Executed a SQL statment 4 - Pressed the column header to try to order, nothing happened 5 - Right clicked the column header to see if it was there the option, nothing This is the behavior that we were expecting, not to have to open Data View and then press the icon that is not even near the grid in order to sort the column. Is this really the way we want people to use the grid in pgAdmin? Should it be more intuitive? PS: Also that Orange after the selection is like a push in the eyes and not in a good way. Maybe we should think about changing the color of the icon to blue to match the rest of the website or something. Thanks Victoria & Joao On Mon, Mar 26, 2018 at 12:13 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > On Mon, Mar 26, 2018 at 5:52 PM, Dave Page wrote: > >> Hi >> >> On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch which allow user to sort the data in View data mode. >>> >> >> The patch looks good in general, however I'm not sure about the UI, in >> particular that the closely-linked dialogue for filtering is a completel= y >> different design. I think it would be better to combine the Sort/Filter >> options and use a single dialogue for both, as pgAdmin 3 did (though, ma= ybe >> not using separate tabs for each part, but the top and bottom of the sam= e >> dialogue. >> >> That would certainly fix the consistency of the dialogues (obviously, as >> there would only be one!), and I think would perhaps be a more simple >> overall UI, particularly for those that want to sort and filter. >> > =E2=80=8BSure, I'll send updated it accordingly.=E2=80=8B > > >> >> Thoughts? >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > --94eb2c0b89ead9e532056854a662 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

@Murtuza: The patch codewis= e looks good. Nice to see that we are using axios instead of jquery ajax ca= lls and that there is some coverage for the change.
Nevertheless = the Javascript testing looks a bit slim and could be improved. Also the Dat= aSorting class could have some other member functions like the model valida= tion could be extracted out so that it is easily tested.=C2=A0

@Hackers: This was how we tried to test this fe= ature:
1 - Started pgAdmin
2 - Opened the query tool fo= r a specific server
3 - Executed a SQL statment
4 - Pre= ssed the column header to try to order, nothing happened
5 - Righ= t clicked the column header to see if it was there the option, nothing

This is the behavior that we were expecting, not to ha= ve to open Data View and then press the icon that is not even near the grid= in order to sort the column. Is this really the way we want people to use = the grid in pgAdmin? Should it be more intuitive?

=
PS: Also that Orange after the selection is like a push in t= he eyes and not in a good way. Maybe we should think about changing the col= or of the icon to blue to match the rest of the website or something.
=

Thanks
Victoria & Joao

On Mon, Mar 26, 2018 at 12:13 PM M= urtuza Zabuawala <= murtuza.zabuawala@enterprisedb.com> wrote:
On Mon, Mar 26, 2018 at 5:52 PM, Dave Page <= /span><dpage@pg= admin.org> wrote:
Hi

On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala <= mur= tuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch which allow user to sort the data in View data mode.

The patch looks good in general, howev= er I'm not sure about the UI, in particular that the closely-linked dia= logue for filtering is a completely different design. I think it would be b= etter to combine the Sort/Filter options and use a single dialogue for both= , as pgAdmin 3 did (though, maybe not using separate tabs for each part, bu= t the top and bottom of the same dialogue.

That wo= uld certainly fix the consistency of the dialogues (obviously, as there wou= ld only be one!), and I think would perhaps be a more simple overall UI, pa= rticularly for those that want to sort and filter.
<= /blockquote>
<= div class=3D"gmail_quote">
=E2=80=8BSure,= I'll send updated it accordingly.=E2=80=8B
=C2=A0

Thoughts?

=
Thanks.=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

E= nterpriseDB UK: h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company
--94eb2c0b89ead9e532056854a662--