Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyhyT-0001NJ-OB for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 17:56:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyhyS-0001dO-Ph for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 17:56:32 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyhvI-0007vQ-6k for pgadmin-hackers@lists.postgresql.org; Wed, 21 Mar 2018 17:53:16 +0000 Received: from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyhvD-0002sE-CT for pgadmin-hackers@postgresql.org; Wed, 21 Mar 2018 17:53:14 +0000 Received: by mail-it0-x243.google.com with SMTP id c1-v6so6874458itj.1 for ; Wed, 21 Mar 2018 10:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=50Ma6pN/5aE2L1WFXtirJ4hjYBWGoIzUZN1Vtbi6Rx4=; b=u+jXY55LodjESJsZxj/0Wr1ZM25Quoddt0FxtQshCd/AkR9dhdZRyv6FNP+R+0SEos neptgLsaS1PY9AC5TP62PJlYQGmOHrzNV8RXF7NDQ00L7UoyBsPGD8t1PNQwVoq6evwU ODGyCjBNNdYoTlxXgfiqfiR8LdgzDWa7137MFjqYmMUe09FIYUNG+tla4QUiVIxXCPcg lPxXh+baCXnCNgQQ5XcD2DbqjM6QUm5M9Op6cGtIJ9/rGb2NeoRL35pk5A2CX60izo6a 0AQt7OhXJQKhwtfaZrNLIwzI/7gP5feCGGc4PZ6MGhDoWk84XiWkemJUJokMJp7YawNO HkjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=50Ma6pN/5aE2L1WFXtirJ4hjYBWGoIzUZN1Vtbi6Rx4=; b=WwciQWD4Cqr3cW5SszAZw2uyR10XzZJm9nsVlBnz6J8Y5bvoqEVMfrDzJu6wBmdq7l /zVXYmkETRF8IlW7OgNAXZl5V7lc63RGmfbU+i/bKkkLy05RUp0Xf9UDyoma4RYMKsPk 5CdioAUi+5/9VFNi+E+FZNbPG7LJEIv3UDiyGpiq/Ywac4sqUnRsighBiSf9grheGAGB 76diy7ZL4C9kEPX0tEZJUaDVGXplZlMvARjGhYLwR+S2WoOujJ9ZlWgH5ajrz8AZPf6P ALv+W4IhLkSYRHj5PBCYu1C3JPFJl0iA72F2XF4vWq4+XW4tfRATXqrfIFdpHpST8bY9 ku7g== X-Gm-Message-State: AElRT7EOO8ZiLjxIxlglmRII6hxoeMz9XaM42cIU0frEi9TbSoyGcfbK uthnI5Ug9wXbqr+45gJ6StFyrN6GTeXcTixi6way5w== X-Google-Smtp-Source: AG47ELuVcNLbFSy14hOFVQAwUmzt7blblnf46LUJe+GuDlM039+tL4aN/bihmNnrSb4Q7nvOdGQpQ86Y0ncSXl5BEnM= X-Received: by 2002:a24:3609:: with SMTP id l9-v6mr5413099itl.95.1521654788746; Wed, 21 Mar 2018 10:53:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Wed, 21 Mar 2018 17:52:58 +0000 Message-ID: Subject: Re: v3.0 release on hold To: Dave Page Cc: Khushboo Vashi , pgadmin-hackers , Akshay Joshi , Murtuza Zabuawala , Syed Fahar Abbas , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary="00000000000027b3ca0567efddf8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000027b3ca0567efddf8 Content-Type: text/plain; charset="UTF-8" Hi Dave, I think that this Gnome issue should be addressed after the release of 3.0. We should create a bug and see the best way to address it after. This is my proposal, because I am not 100% sure where this application indicator should live. If we search the web for application indicators we can see that usually these are developed by 3rd parties and is are present at the applications repository, so this might be a side project that need to be undertaken, by someone in the community or not, but it is not something that should live inside our repository as it is not really part of the code source and it is more like a Hack for Gnome. The other issues I believe need to be addressed, specially if they are crippling to the application like when you click it does not start, but if they are edge cases, we can always release this week and have a new release in 2 weeks or something with more fixes to these edge case problems. I understand that the process of release at this point is a bit cumbersome and take a lot of time, but if we can get more tests around the new and old feature we can have more confidence in our code and as a result of that we can automate some of the steps in order to generate binaries more frequently. Thanks Joao On Wed, Mar 21, 2018 at 12:54 PM Dave Page wrote: > Hi > > On Wed, Mar 21, 2018 at 4:22 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Dave, >> For number 1: >> https://blogs.gnome.org/aday/2017/08/31/status-icons-and-gnome/ >> We might need to build something like: >> https://itsfoss.com/best-indicator-applets-ubuntu/ >> Not sure if it is wise to do it in such a short notice. >> > > Yeah, the problem with the suggested solutions is that they rely on 3rd > party extensions that aren't "real" packages for the OS, so we can't just > add a dependency on them. Unfortunately I think this is going to cause > quite a bit of work to get 3.0 back on track. > > >> >> Thanks >> Joao >> >> On Wed, Mar 21, 2018 at 11:38 AM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On 21 Mar 2018 21:05, "Dave Page" wrote: >>> >>> We've run into a number of unexpected issues with the v3.0 release that >>> I think we need to resolve before moving forwards. For the time being, only >>> patches critical to fix these issues should be committed. >>> >>> I'll try to look at 1, though I do have another deadline I need to meet. >>> Akshay, can you look at 2 please? >>> Fahar is already looking at 3. >>> Khushboo, can you look at 4 please? >>> >>> Sure. >>> >>> >>> Thanks all. >>> >>> 1) There is no longer a system tray in Gnome 3.26 and later, and thus >>> the runtime won't initialise in Fedora 27 and later. We need an alternative >>> for this, either a tray replacement that the RPM can depend on, or better >>> yet, support whatever it is Gnome expect such apps to use these days. >>> >>> 2) Starting a second instance of the app bundle on Mac doesn't always >>> open a new pgAdmin window as it should. It works fine in the debugger, or >>> if you start the app with a command like: "/Applications/pgAdmin\ >>> 4.app/Contents/MacOS/pgAdmin4". It doesn't work if you double-click the >>> appbundle or use a command like "open /Applications/pgAdmin\ 4.app" >>> >>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my copy, >>> but apparently his is a fresh installation. >>> >>> 4) On my Windows 7 machine, after running a backup I get no status >>> window, and see the following in the logs: >>> >>> Traceback (most recent call last): >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 209, in run_wsgi >>> execute(self.server.app) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 197, in execute >>> application_iter = app(environ, start_response) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1997, in __call__ >>> return self.wsgi_app(environ, start_response) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1985, in wsgi_app >>> response = self.handle_exception(e) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1540, in handle_exception >>> reraise(exc_type, exc_value, tb) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1982, in wsgi_app >>> response = self.full_dispatch_request() >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1614, in >>> full_dispatch_request >>> rv = self.handle_user_exception(e) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1517, in >>> handle_user_exception >>> reraise(exc_type, exc_value, tb) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1612, in >>> full_dispatch_request >>> rv = self.dispatch_request() >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask\app.py", line 1598, in dispatch_request >>> return self.view_functions[rule.endpoint](**req.view_args) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\venv\Lib\site-packages\flask_login.py", line 792, in decorated_view >>> return func(*args, **kwargs) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\web\pgadmin\misc\bgprocess\__init__.py", line 62, in index >>> return make_response(response=BatchProcess.list()) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\web\pgadmin\misc\bgprocess\processes.py", line 584, in list >>> details = desc.details(p.command, args) >>> File "C:\Program Files (x86)\pgAdmin >>> 4\v3\web\pgadmin\tools\backup\__init__.py", line 190, in details >>> res += html.safe_str(cmd + self.cmd) >>> AttributeError: 'BackupMessage' object has no attribute 'cmd' >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --00000000000027b3ca0567efddf8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,
I think that this Gnome issue should be addre= ssed after the release of 3.0. We should create a bug and see the best way = to address it after. This is my proposal, because I am not 100% sure where = this application indicator should live.
If we search the web for = application indicators we can see that usually these are developed by 3rd p= arties and is are present at the applications repository, so this might be = a side project that need to be undertaken, by someone in the community or n= ot, but it is not something that should live inside our repository as it is= not really part of the code source and it is more like a Hack for Gnome.

The other issues I believe need to be addressed, sp= ecially if they are crippling to the application like when you click it doe= s not start, but if they are edge cases, we can always release this week an= d have a new release in 2 weeks or something with more fixes to these edge = case problems.

I understand that the process of re= lease at this point is a bit cumbersome and take a lot of time, but=C2=A0 i= f we can get more tests around the new and old feature we can have more con= fidence in our code and as a result of that we can automate some of the ste= ps in order to generate binaries more frequently.

= Thanks
Joao

On Wed, Mar 21, 2018 at 12:54 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Mar 21, 2018 at 4:22 PM, Joao De = Almeida Pereira <jdealmeidapereira@pivotal.io> wr= ote:
Hello Dave,
We might need to build something like= :=C2=A0https://itsfoss.com/best-indicator-applets-ubuntu/
Not sure if it is wise to do it in such a short notice.

Yeah, the problem with the sugges= ted solutions is that they rely on 3rd party extensions that aren't &qu= ot;real" packages for the OS, so we can't just add a dependency on= them. Unfortunately I think this is going to cause quite a bit of work to = get 3.0 back on track.
=C2=A0

Thanks
Joao
=

On Wed, Mar 21, 2018 at 11:38 AM Khushboo Vashi <khushboo.vashi@enterprised= b.com> wrote:


On 2= 1 Mar 2018 21:05, "Dave Page" <dpage@pgadmin.org> wrote:
We've run into a number of unexpe= cted issues with the v3.0 release that I think we need to resolve before mo= ving forwards. For the time being, only patches critical to fix these issue= s should be committed.

I'll try to look at 1, though= I do have another deadline I need to meet.=C2=A0
Akshay, can you= look at 2 please?
Fahar is already looking at 3.
Khush= boo, can you look at 4 please?
Sure.

Thanks all.

1) There is no longer a system tray in Gnome 3.26 and= later, and thus the runtime won't initialise in Fedora 27 and later. W= e need an alternative for this, either a tray replacement that the RPM can = depend on, or better yet, support whatever it is Gnome expect such apps to = use these days.

2) Starting a second instance of t= he app bundle on Mac doesn't always open a new pgAdmin window as it sho= uld. It works fine in the debugger, or if you start the app with a command = like: "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It = doesn't work if you double-click the appbundle or use a command like &q= uot;open /Applications/pgAdmin\ 4.app"

3) Fah= ar saw a crash on Windows 7. I couldn't reproduce this on my copy, but = apparently his is a fresh installation.

4) On my W= indows 7 machine, after running a backup I get no status window, and see th= e following in the logs:

Traceback (most= recent call last):
=C2=A0 File "C:\Program Files (x86)\pgAd= min 4\v3\venv\Lib\site-packages\werkzeug\serving.py", line 209, in run= _wsgi
=C2=A0 =C2=A0 execute(self.server.app)
=C2=A0 Fil= e "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\werkzeug= \serving.py", line 197, in execute
=C2=A0 =C2=A0 application= _iter =3D app(environ, start_response)
=C2=A0 File "C:\Progr= am Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line= 1997, in __call__
=C2=A0 =C2=A0 return self.wsgi_app(environ, st= art_response)
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\= v3\venv\Lib\site-packages\flask\app.py", line 1985, in wsgi_app
<= div>=C2=A0 =C2=A0 response =3D self.handle_exception(e)
=C2=A0 Fi= le "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\a= pp.py", line 1540, in handle_exception
=C2=A0 =C2=A0 reraise= (exc_type, exc_value, tb)
=C2=A0 File "C:\Program Files (x86= )\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1982, in wsg= i_app
=C2=A0 =C2=A0 response =3D self.full_dispatch_request()
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-= packages\flask\app.py", line 1614, in full_dispatch_request
= =C2=A0 =C2=A0 rv =3D self.handle_user_exception(e)
=C2=A0 File &q= uot;C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py= ", line 1517, in handle_user_exception
=C2=A0 =C2=A0 reraise= (exc_type, exc_value, tb)
=C2=A0 File "C:\Program Files (x86= )\pgAdmin 4\v3\venv\Lib\site-packages\flask\app.py", line 1612, in ful= l_dispatch_request
=C2=A0 =C2=A0 rv =3D self.dispatch_request()
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\sit= e-packages\flask\app.py", line 1598, in dispatch_request
=C2= =A0 =C2=A0 return self.view_functions[rule.endpoint](**req.view_args)
=
=C2=A0 File "C:\Program Files (x86)\pgAdmin 4\v3\venv\Lib\site-pa= ckages\flask_login.py", line 792, in decorated_view
=C2=A0 = =C2=A0 return func(*args, **kwargs)
=C2=A0 File "C:\Program = Files (x86)\pgAdmin 4\v3\web\pgadmin\misc\bgprocess\__init__.py", line= 62, in index
=C2=A0 =C2=A0 return make_response(response=3DBatch= Process.list())
=C2=A0 File "C:\Program Files (x86)\pgAdmin = 4\v3\web\pgadmin\misc\bgprocess\processes.py", line 584, in list
=
=C2=A0 =C2=A0 details =3D desc.details(p.command, args)
=C2= =A0 File "C:\Program Files (x86)\pgAdmin 4\v3\web\pgadmin\tools\backup= \__init__.py", line 190, in details
=C2=A0 =C2=A0 res +=3D h= tml.safe_str(cmd + self.cmd)
AttributeError: 'BackupMessage&#= 39; object has no attribute 'cmd'



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
<= br>EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
=




--
Dave P= age
Blog: http= ://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterpri= sedb.com
The Enterprise PostgreSQL Company
--00000000000027b3ca0567efddf8--