MIME-Version: 1.0
From: Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io>
Date: Wed, 26 Apr 2017 16:53:08 -0400
Message-ID: 
 <CAE+jjakiOhWWPTUxLMGGCuVhL=3pKuZjFfya5WVj0snegCZ-kQ@mail.gmail.com>
Subject: Issue with SlickGrid
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=94eb2c14c862136a58054e1807b0
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--94eb2c14c862136a58054e1807b0
Content-Type: text/plain; charset=UTF-8

Hello Hackers,

While doing some changes to the Query Results we found out that there was a
issue with Slick grid.

The issue that we found was with the CellSelectModel, behaved differently
when pressing Ctrl and Command(Mac). We created a PR
<https://github.com/6pac/SlickGrid/pull/100> with the change to changes the
behavior of the plugin.

When this PR is applied to the SlickGrid library we need to apply it to the
current version of SlickGrid that we have vendorized.
According to the libraries.txt file we are in version 2.2.4 of the library
but a diff between our code and the libraries version 2.2.4 shows
differences in the code.

Did we do any change to SlickGrid library that is vendorized? Or is just
the information in libraries.txt that is incorrect?
Does anyone know any problem if we bump the version of SlickGrid to the
newer version after the PR is applied?

Thanks
Joao

--94eb2c14c862136a58054e1807b0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello Hackers,<div><br></div><div>While doing some changes=
 to the Query Results we found out that there was a issue with Slick grid.=
=C2=A0</div><div><br></div><div>The issue that we found was with the CellSe=
lectModel, behaved differently when pressing Ctrl and Command(Mac). We crea=
ted a <a href=3D"https://github.com/6pac/SlickGrid/pull/100">PR</a> with th=
e change to changes the behavior of the plugin.</div><div><br></div><div>Wh=
en this PR is applied to the SlickGrid library we need to apply it to the c=
urrent version of SlickGrid that we have vendorized.</div><div>According to=
 the libraries.txt file we are in version 2.2.4 of the library but a diff b=
etween our code and the libraries version 2.2.4 shows differences in the co=
de.</div><div><br></div><div>Did we do any change to SlickGrid library that=
 is vendorized? Or is just the information in libraries.txt that is incorre=
ct?</div><div>Does anyone know any problem if we bump the version of SlickG=
rid to the newer version after the PR is applied?</div><div><br></div><div>=
Thanks</div><div>Joao</div></div>

--94eb2c14c862136a58054e1807b0--