Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1er3Nz-0002xc-SU for pgadmin-hackers@arkaria.postgresql.org; Wed, 28 Feb 2018 15:11:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1er3Ny-0006a2-PQ for pgadmin-hackers@arkaria.postgresql.org; Wed, 28 Feb 2018 15:11:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1er3Ny-0006Zr-IR for pgadmin-hackers@lists.postgresql.org; Wed, 28 Feb 2018 15:11:14 +0000 Received: from mail-io0-x243.google.com ([2607:f8b0:4001:c06::243]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1er3Ns-0002cn-Gd for pgadmin-hackers@postgresql.org; Wed, 28 Feb 2018 15:11:13 +0000 Received: by mail-io0-x243.google.com with SMTP id e7so3568888ioj.1 for ; Wed, 28 Feb 2018 07:11:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FXsk7EXbJb+jHVVxofxS/uoOmP5lsSdH656RZ0/Jrgo=; b=NrZXVKKEYVGtHOYO5wT0n5R7DEFAD+TAZa1QwcE15HCqp5/hlYDY/Sv8zjupVA+Hvo V87nrQluOZVT5Xa1o2US7crHVKVDWh0qnTMC3yNHjP6EhVPuH3ANv8j1EAe/aiK9Blc6 WrIQh2GOs+uuUJ3Tx9YR/L5T6Ekmlz5D3VU3jxBayuViX7uxuFQhvVSyV2Hezcy4ck9C l0bToOw6JipxON5+t6GTo8Be7lL7l2mNq0ebODceUfD/G57D86gGKUQqaWxHj23XHrwZ cPgr+5RsAhesi6snoVtGVkn+YJ+uLbwq0VLY/b5BIwgnHksLQzEz6jnb5AhgXdr6ZDIq AxoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FXsk7EXbJb+jHVVxofxS/uoOmP5lsSdH656RZ0/Jrgo=; b=f1nOgJ78+7bORBa6jSQhTqIC+rADdXPzzUrV0b6YbUqizMwGUnQWhGAFwmo8zuxUal uNM3CNPkJWVZki9tCBDenzKiOdKnH7JVE0/yb59yhw1tR1OwE/NFf5FZPDainuFVRx+Q uSXgb69jSE6Tmbc8juVnxC/2MgfJKEj/WTc2H0QjVj9hqA5AZn9oleCWd1rbjI/P38Od 2JlxDDKn9De4ji4CrPHgxyABUE5vj90ADDo0yd0fQzHs4En2gQ/y8FlR1hMZ1QcUCN3i fNjO/iBe1bxLc9vxngijF6sZYzGn5yru8BYkHAqLSOQnsN57WqDFzcv4vVP+IQ3eMX/S VOkg== X-Gm-Message-State: APf1xPC9BmQ8kjfNEsHCredXuyoA8GZwtyE5qzcUSGd8T6XpzX4ubcvd RYqtDSksN/WT8iRxRgWK5iic7oxEX5LSa0f5vUwGVQ== X-Google-Smtp-Source: AG47ELu9IorPryhCCdB5Sp0BK70FAl/rkREoheuW041zKepsRP3yjXl9nnjrO5McFsTwoWUHCDzRctuBH8xjsMUU8x8= X-Received: by 10.107.31.133 with SMTP id f127mr9810272iof.234.1519830662740; Wed, 28 Feb 2018 07:11:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Wed, 28 Feb 2018 15:10:52 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI To: Murtuza Zabuawala Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1140422ac6105f0566472626" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1140422ac6105f0566472626 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Murtuza, I do not have the pgAgent installed so it was a little it hard to test this= . After looking into the code I think we are missing some testing coverage around the pga_job Javascript part so that we can catch these problems. Even some code extraction can be done around the pg_jobset change Nevertheless I passed the patch through our CI and it is all green Thanks Joao On Wed, Feb 28, 2018 at 5:36 AM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > I have found the issue, it was in Backform control itself :) > Issue: We were passing today's date value as minDate option in pgAgent > schedule schema while rendering the control, So when server was sending > previous datetime value it was not displaying it causing sync problem. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Tue, Feb 27, 2018 at 8:39 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> =E2=80=8BThanks Dave, I'll look into it. >> =E2=80=8B >> >> >> On Tue, Feb 27, 2018 at 8:37 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> I'm not able to re-produce the issue, Could you hard refresh and try >>>> again? >>>> >>> >>> I still see it. >>> >>> >>>> >>>> If possible could you please provide exact steps? >>>> >>> >>> Attached is a dump of my test pgagent schema. >>> >>> 1) Load the schema dump into the maintenance database >>> 2) Connect pgAdmin >>> 3) Browse to pgAgent Jobs >>> 4) Right-click Properties, and select the Schedules tab >>> 5) Open the subnode for sched1 >>> >>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page wrote: >>>> >>>>> Sorry - here it is. >>>>> >>>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> Could you please send screenshot? >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page wrote= : >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> Still not quite right - see the attached screenshot which is the >>>>>>> result of simply viewing the properties of an existing job. Note th= at the >>>>>>> start time is shown in the grid but not the subnode control. >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> As validation related patch was committed with RM#3148 [ Sorry >>>>>>>> about that I forgot to checkout :) ] >>>>>>>> PFA patch to fix the issues you mentioned, I have also removed >>>>>>>> extra error message from sub node collection control and made it o= ptional >>>>>>>> via flag. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Regards, >>>>>>>> Murtuza Zabuawala >>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> >>>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala < >>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> PFA patch to fix the issue where user was not able to create >>>>>>>>>> pgAgent job from UI without entering End date in schedule sectio= n. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Whilst this does resolve the validation issue, there are still a >>>>>>>>> couple of other related problems, as can be seen in the attached >>>>>>>>> screenshots: >>>>>>>>> >>>>>>>>> - The Start date/time in the subnode control doesn't seem to be >>>>>>>>> properly synchronised with the value in the grid. >>>>>>>>> >>>>>>>>> - If you leave the End date/time blank (but maybe click into it >>>>>>>>> first), the grid will show "Invalid date". >>>>>>>>> >>>>>>>>> It's possible there are other oddities as well - please check >>>>>>>>> carefully for anything else. >>>>>>>>> >>>>>>>>> Thanks. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --001a1140422ac6105f0566472626 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Murtuza,
I do not have the pgAgent installed so = it was a little it hard to test this.
After looking into the code= I think we are missing some testing coverage around the pga_job Javascript= part so that we can catch these problems.
Even some code extract= ion can be done around the pg_jobset change

Nevert= heless I passed the patch through our CI and it is all green

=
Thanks
Joao

=
On Wed, Feb 28, 2018 at 5:36 AM Murtuza Zabuawala <murtuza.zabuawala@enterpr= isedb.com> wrote:
Hi Dave,

I have found th= e issue, it was in Backform control itself :)
Issue: We were = passing today's date value as minDate option in pgAgent schedule schema= while rendering the control, So when server was sending previous datetime = value it was not displaying it causing sync problem.

--
Regards,
<= font size=3D"2">Murtuz= a Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The= Enterprise PostgreSQL Company

<= /div>

On Tue, Feb= 27, 2018 at 8:39 PM, Murtuza Zabuawala <murtuza.zabuawal= a@enterprisedb.com> wrote:
=
=E2=80=8BThanks Dave, I'll look into it.
<= /div>
=E2=80=8B


On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
=
Hi

On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
I'm not able to re-produce the issue, Could you har= d refresh and try again?

I = still see it.
=C2=A0

If possible= could you please provide exact steps?

Attached is a dump of my test pgagent schema.

<= div>1) Load the schema dump into the maintenance database
2) Conn= ect pgAdmin
3) Browse to pgAgent Jobs
4) Right-click Pr= operties, and select the Schedules tab
5) Open the subnode for sc= hed1
=C2=A0

<= div dir=3D"ltr">--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://ww= w.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Feb 27, 2018 at 5:= 30 PM, Dave Page <dpage@pgadmin.org> wrote:
Sorry - here it is.

On Tue, Feb 27, 2018 at 11:59 AM= , Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,



On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <dpage@pgadmin= .org> wrote:
Hi

Still not quite right - see the attached screensho= t which is the result of simply viewing the properties of an existing job. = Note that the start time is shown in the grid but not the subnode control.<= /div>

Thanks.

=
On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawa= la <murtuza.zabuawala@enterprisedb.com> wro= te:
Hi Dave,

As validation related p= atch was committed with RM#3148 [ Sorry about that I forgot to checkout :)= =C2=A0]
PFA patch to fix the issues you mentioned, I have also removed extra er= ror message from sub node collection control and made it optional via flag.=

=
--
Regards,
Murtuza Zabuaw= ala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company

<= div class=3D"m_2360341192199263230m_1389201754032233151m_530206492330963423= 9m_-965879955799026962m_-2077451473171040555m_4470212481382087477m_-5817609= 3225257591h5">
On Mon, Feb 26, 2018 at 10:14 PM, Dave Page = <dpage@pgadmin.org> wrote:
Hi

On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue where user was not able to create pgAge= nt job from UI without entering End date in schedule section.

=C2=A0Whilst this does resolve the validatio= n issue, there are still a couple of other related problems, as can be seen= in the attached screenshots:

- The Start date/tim= e in the subnode control doesn't seem to be properly synchronised with = the value in the grid.

- If you leave the End date= /time blank (but maybe click into it first), the grid will show "Inval= id date".

It's pos= sible there are other oddities as well - please check carefully for anythin= g else.

Thanks.=

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnak= e

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compa= ny

=



= --
Dave = Page
Blog: htt= p://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enterpr= isedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

E= nterpriseDB UK: h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseD= B UK: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company


--001a1140422ac6105f0566472626--