Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDCQB-0004Y6-MM for pgadmin-hackers@arkaria.postgresql.org; Tue, 23 May 2017 16:12:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dDCQA-0000fH-Ib for pgadmin-hackers@arkaria.postgresql.org; Tue, 23 May 2017 16:12:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dDCQ9-0000cO-E1 for pgadmin-hackers@postgresql.org; Tue, 23 May 2017 16:12:29 +0000 Received: from mail-ua0-x232.google.com ([2607:f8b0:400c:c08::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dDCQ4-0001So-Mq for pgadmin-hackers@postgresql.org; Tue, 23 May 2017 16:12:28 +0000 Received: by mail-ua0-x232.google.com with SMTP id j17so80948573uag.3 for ; Tue, 23 May 2017 09:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=o/xIlOn0a4myeP8Vlai4bYdenKUSHrOSnwVsaLYL+YI=; b=gDX5g4erD76fshM4jbdashyvf0Pl832pcQAnwV8KDHVkqwvZ3qh++cjf0Gi17AFRLG G6aVdNWzDaNxBMzIxFidi1NrU+AjYVkVDDLBoA4LnmESYdSH5eU39n3fU53NMZ/KZP2x mQyOjQpdiZOISPNCwwa1ioaJsO2FHQEBLYnjqbaBbG9iBqaDWx6GuuC3BYhV/rlDedwR GEIOzfSKgvP5KLOzbtxL8kBb3ZG15yoiSdbqkzohQctVskN6IzAyAWP6yk/CPM0Zq9NM 3Vv05xXiKx8B1YSN1qjw/t+YmRMpzxfb59euT7xM4uT7d2J29KA+6wDVWixEH6j5py2T yupw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o/xIlOn0a4myeP8Vlai4bYdenKUSHrOSnwVsaLYL+YI=; b=EvIp5pn5h2rEqXrpW7iQoRLA024CMCKf8aWh6uFIqznnksuHipH4kQRCFBlfDbR55N t+tdCKOhRDFjnZkzY0H28aLQUChxFXAu1wLokudRalqV/sOYAJSXeYA1PSjudeIP+7U3 QqO+35BYks8qzdDtNkBFrLTkr3p6WG4wgxdZa9UzfovV3e0mbBiB6JMdyOzJpBMwIxyt PG4rkwkZm3jNrWZgioFIvZjkpGpnEKV6GmamMma1vZZawxu4qomaz6rWxqvW7wELf1nN 23gnEePBq/MtV54y2pIFY7AacX7arSJkIf3Ue0MkH1vAoHajtkFfPqGwDJf4qdmu+j8W kWvA== X-Gm-Message-State: AODbwcCs5ytrllY1mdTxXvjelXmbbgI+L8F1xjoCzDHe1Ny/64H7lB3m 3TPALsaXTEfNJz5eK0pqK3a9kTPGsCAA X-Received: by 10.176.4.3 with SMTP id 3mr14840017uav.20.1495555941932; Tue, 23 May 2017 09:12:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.47.13 with HTTP; Tue, 23 May 2017 09:12:21 -0700 (PDT) In-Reply-To: References: From: Joao Pedro De Almeida Pereira Date: Tue, 23 May 2017 12:12:21 -0400 Message-ID: Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React To: Dave Page Cc: Matthew Kleiman , Murtuza Zabuawala , pgadmin-hackers , Shruti B Iyer Content-Type: multipart/alternative; boundary="94eb2c063734a93f42055033403f" X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c063734a93f42055033403f Content-Type: text/plain; charset="UTF-8" Okay Can you try removing web/node_modules and web/yarn.lock, and running $ yarn install $ grunt tests We think this might be due to a bad version of phantomjs-prebuilt. If that still fails, can you try running grunt as "yarn run grunt tests"? Joao and George On Fri, May 19, 2017 at 10:27 AM, Dave Page wrote: > On Thu, May 18, 2017 at 4:37 PM, Matthew Kleiman > wrote: > > Dave, > > > > Can you try running grunt tests on the command line? > > > > The tests task will run the eslint and karma grunt tasks, which should > > automatically webpack the React components before running the jasmine > tests > > in karma. > > > > If it still fails, send us the output of that. > > (pgadmin4)piranha:web dpage$ grunt tests > Running "eslint:target" (eslint) task > > Running "karma:unit" (karma) task > 19 05 2017 15:26:13.366:ERROR [plugin]: Error during loading > "karma-phantomjs-launcher" plugin: > Path must be a string. Received null > > webpack: Compiled successfully. > webpack: Compiling... > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > webpack: wait until bundle finished: > (node:66274) DeprecationWarning: loaderUtils.parseQuery() received a > non-string value which can be problematic, see > https://github.com/webpack/loader-utils/issues/56 > parseQuery() will be replaced with getOptions() in the next major > version of loader-utils. > 19 05 2017 15:26:18.887:WARN [karma]: No captured browser, open > http://localhost:9876/ > > webpack: Compiled successfully. > 19 05 2017 15:26:18.895:ERROR [karma]: Found 1 load error > Warning: Task "karma:unit" failed. Use --force to continue. > > Aborted due to warnings. > > > :-( > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --94eb2c063734a93f42055033403f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Okay

Can you try removing web/node_modu= les and web/yarn.lock, and running
$ yarn install
$ gru= nt tests

We think this might be due to a bad versi= on of phantomjs-prebuilt.

If that still fails, can= you try running grunt as "yarn run grunt tests"?

<= /div>
Joao and George

On Fri, May 19, 2017 at 10:27 AM, Dave Page <dpage@p= gadmin.org> wrote:
On Thu, May 18, 2017 at 4:37 PM, Matthew Kleiman <mkleiman@pivotal.io> wrote:
> Dave,
>
> Can you try running grunt tests on the command line?
>
> The tests task will run the eslint and karma grunt tasks, which should=
> automatically webpack the React components before running the jasmine = tests
> in karma.
>
> If it still fails, send us the output of that.

(pgadmin4)piranha:web dpage$ grunt tests
Running "eslint:target" (eslint) task

Running "karma:unit" (karma) task
19 05 2017 15:26:13.366:ERROR [plugin]: Error during loading
"karma-phantomjs-launcher" plugin:
=C2=A0 Path must be a string. Received null

webpack: Compiled successfully.
webpack: Compiling...
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
(node:66274) DeprecationWarning: loaderUtils.parseQuery() received a=
non-string value which can be problematic, see
https://github.com/webpack/loader-utils/issues= /56
parseQuery() will be replaced with getOptions() in the next major
version of loader-utils.
19 05 2017 15:26:18.887:WARN [karma]: No captured browser, open
http://localhost:9876/

webpack: Compiled successfully.
19 05 2017 15:26:18.895:ERROR [karma]: Found 1 load error
Warning: Task "karma:unit" failed. Use --force to continue.

Aborted due to warnings.


:-(

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers

--94eb2c063734a93f42055033403f--