Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fBKRB-0001vW-JI for pgadmin-hackers@arkaria.postgresql.org; Wed, 25 Apr 2018 13:26:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fBKR8-0001FE-Pf for pgadmin-hackers@arkaria.postgresql.org; Wed, 25 Apr 2018 13:26:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fBKR8-0001F3-HW for pgadmin-hackers@lists.postgresql.org; Wed, 25 Apr 2018 13:26:18 +0000 Received: from mx0a-00296801.pphosted.com ([148.163.150.38]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fBKQy-00054c-C8 for pgadmin-hackers@postgresql.org; Wed, 25 Apr 2018 13:26:14 +0000 Received: from pps.filterd (m0114581.ppops.net [127.0.0.1]) by mx0a-00296801.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3PDLiQP017959 for ; Wed, 25 Apr 2018 13:26:03 GMT Received: from mail-it0-f71.google.com (mail-it0-f71.google.com [209.85.214.71]) by mx0a-00296801.pphosted.com with ESMTP id 2hj3ch91f5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 25 Apr 2018 13:26:02 +0000 Received: by mail-it0-f71.google.com with SMTP id v144-v6so13945968itc.6 for ; Wed, 25 Apr 2018 06:26:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Ifye6Em1K7CWg14K+NuXPoj2HQ1ehALEe16cXmagWw=; b=nkl7PLfLqNq0ZE3gZ5zIS/Ole7np9XiW1pbXhVfcBecYWMTECXrXVBpAmGXIXGKXvN wFru7syDjQU91ElrrTmV1kS5rMntPHwylLoPg6XEuBMiOmOK0W+RRXtjWGXjjTNq+rS3 8OVjYyk7SAzL5nYRQQ57K1LFoHGPM9/lrcc6FKk/kKXfhg7OobUh6Zuz8KhKJwWyDsFR I1JQDGdxqHv2nxwQo6xGbohkBmzq5trFnlz6FMgmPuLY3a82cmMiNac5L58ijjeVMb75 5BhtCtpI6li1Ou5QrIoRP5YiMMDjzvOE98+yk34msNT362zBySAAJrQzZlXWclHF48/i 7T6w== X-Gm-Message-State: ALQs6tB88MjMCggNvCLdHdJ8SaUW53W2ig14vcc3IVetO+yvoXoNWBPd 0KtRY7sQTKapJpLBR8s4VyrsIcNwNubkIspo5XmeunL8fO9yHe6LSuPHQronnmtQjZTThdmbAmF RV4XmJ2gRwgmFYxQf5pwLWusEgksnVlGLjr66WZLsQnfG76PyWjalqmhCagrWy92wNUpF X-Received: by 2002:a24:a54b:: with SMTP id w11-v6mr9617238iti.95.1524662760854; Wed, 25 Apr 2018 06:26:00 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrIdaTImhvraBK+fBfODQ0dfqwQ+9Wmw3u8Ops4qDI5Kudx7d4deU4EGBHCZIF7ha8MwYhmeGsNAk04TZctU4c= X-Received: by 2002:a24:a54b:: with SMTP id w11-v6mr9617214iti.95.1524662760532; Wed, 25 Apr 2018 06:26:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Wed, 25 Apr 2018 13:25:49 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3155] Allow user to lock the Layout To: Dave Page Cc: Murtuza Zabuawala , Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000003e8f42056aac3620" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-25_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=10 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804250128 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000003e8f42056aac3620 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, @Murtuza: We didn't notice the issue, can you please advise on what need to change to make it work? The only change we did was to make one test pass. @Hackers: In our point of view it is never good to fork a library. But if he really have to do it, then we should fork it in Github, make our code accessible to other people, and we should add it as a dependency on package.json Thanks Anthony & Joao On Wed, Apr 25, 2018 at 7:14 AM Dave Page wrote: > On Wed, Apr 25, 2018 at 12:13 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Apr 25, 2018 at 3:36 PM, Dave Page wrote: >> >>> All, >>> >>> We just had a brief discussion in our EDB sprint planning meeting about >>> this. There is a non-zero chance that we're going to have to fork wcDoc= ker >>> in the near future, in order to update it to work with jQuery 3. If we = do >>> that, then it may be significantly easier to fix this issue in that for= k >>> (perhaps by adding a single lockLayout(bool) function, rather than tryi= ng >>> to do so from pgAdmin. >>> >>> I think (unless Murtuza believes that won't help), that we're better of= f >>> holding on this for now until we know if we've had to do that. >>> >> >> =E2=80=8BI don't have any objection forking the code and adding the flag= to lock >> the panel, But I'm certain that >> we will use the same inbuilt method *panel.moveable(false)* which we >> have used right now in the patch to prevent a panel from floating and wi= ll >> face the same issue again which Akshay mentioned in his last email. >> >> Let me know if you want me to attach latest patch onto the ticket for >> future reference and update the ticket accordingly=E2=80=8B. >> > > That's probably a good idea - thanks. > > >> >> >>> On Wed, Apr 25, 2018 at 10:23 AM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> >>>> On Wed, Apr 25, 2018 at 2:37 PM, Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Joao/Murtuza >>>>> >>>>> It break's the functionality, I am able to move "Data output", >>>>> "Explain" etc.. panel of Query Tool, even if "Lock layout?" is set to= True. >>>>> >>>> >>>> =E2=80=8BIt's working properly in v5 patch, Something went wrong while >>>> refactoring.=E2=80=8B >>>> >>>> =E2=80=8B >>>> >>>> Apart from above I have found more issue. Below are the steps to >>>>> reproduce: >>>>> >>>>> - Set the "Lock layout?" flag to False. >>>>> - Move out Dashboard panel. >>>>> - Set the "Lock layout?" flag to True. >>>>> - Close the Dashboard panel, as layout is locked and empty >>>>> Dashboard panel is still visible. (Refer attached screenshot) >>>>> >>>>> =E2=80=8BThat's because we have set the Panel moveable property to Fa= lse, they >>>> won't auto resize, As discussed earlier if user drag any panel out of = panel >>>> group it gets render in seprate wcFrame. I think that needs to be take= n >>>> care by user before they decide to lock the layout, We can not expilci= tly >>>> set panel's closeable property to False when layout is locked, If we d= o so >>>> user will not be able to close any Query tool, Debugger panels.=E2=80= =8B >>>> =E2=80=8B >>>> >>>> >>>> On Tue, Apr 24, 2018 at 9:11 PM, Joao De Almeida Pereira < >>>>> jdealmeidapereira@pivotal.io> wrote: >>>>> >>>>>> haha, >>>>>> Just joking, now we have a good version that passes tests and all. >>>>>> >>>>>> We found out that a test was failing in the patch version 5: >>>>>> >>>>>> HeadlessChrome 0.0.0 (Linux 0.0.0) Panel when we create a panel and = user created panel without defining isMoveable then it should be moveable i= t should call moveable method with true as argument FAILED >>>>>> Expected false to be true. >>>>>> at UserContext. (regression/javascript/browser/pa= nel_spec.js:12886:38) >>>>>> >>>>>> =E2=80=8B >>>>>> To solve this problem we decided to change the Panel class to match >>>>>> what the test say. >>>>>> >>>>>> Thanks >>>>>> Victoria & Joao >>>>>> >>>>>> >>>>>> On Tue, Apr 24, 2018 at 11:08 AM Joao De Almeida Pereira < >>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>> >>>>>>> Hi, >>>>>>> Apparently the last version was not applying, here is the new >>>>>>> version that should apply correctly >>>>>>> >>>>>>> Thanks >>>>>>> Victoria & Joao >>>>>>> >>>>>>> On Tue, Apr 24, 2018 at 10:56 AM Joao De Almeida Pereira < >>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>> >>>>>>>> Hi Murtuza, >>>>>>>> >>>>>>>> We tested the patch and everything looks fine. We also refactors >>>>>>>> some parts to include things like strict equality and using let/co= nst >>>>>>>> instead of var. The updated patch is attached. >>>>>>>> In the future, it will be more valuable to have the translation to >>>>>>>> ES6 and the feature work in separate commits so it is easier to un= derstand >>>>>>>> what changed. >>>>>>>> >>>>>>>> Sincerely, >>>>>>>> >>>>>>>> Joao and Victoria >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Apr 24, 2018 at 4:58 AM Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> On Tue, Apr 24, 2018 at 1:17 PM, Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Akshay, could you review/commit this please? >>>>>>>>>> >>>>>>>>>> Please also update the release_notes_3_1.rst file when you commi= t >>>>>>>>>> user-visible changes, to make it easier to build the release not= es. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Sure >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks. >>>>>>>>>> >>>>>>>>>> On Tue, Apr 24, 2018 at 8:45 AM, Murtuza Zabuawala < >>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Dave, >>>>>>>>>>> >>>>>>>>>>> Please find the updated patch, Now we are able to lock wcFrame >>>>>>>>>>> and wcPanel both. >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Regards, >>>>>>>>>>> Murtuza Zabuawala >>>>>>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Thu, Apr 5, 2018 at 6:32 PM, Robert Eckhardt < >>>>>>>>>>> reckhardt@pivotal.io> wrote: >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Apr 4, 2018 at 11:31 PM, Khushboo Vashi < >>>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Wed, Apr 4, 2018 at 8:09 PM, Dave Page >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Zabuawala < >>>>>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Wed, Apr 4, 2018 at 5:00 PM, Dave Page >>>>>>>>>>>>>> > wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala < >>>>>>>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Wed, Apr 4, 2018 at 2:47 PM, Dave Page < >>>>>>>>>>>>>>>>> dpage@pgadmin.org> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Wed, Apr 4, 2018 at 7:20 AM, Murtuza Zabuawala < >>>>>>>>>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Hi Dave, >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On Tue, Apr 3, 2018 at 9:03 PM, Dave Page < >>>>>>>>>>>>>>>>>>> dpage@pgadmin.org> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Hi >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala < >>>>>>>>>>>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Thanks Joao for reviewing. >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> PFA updated patch. >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> On Tue, Apr 3, 2018 at 1:11 AM, Joao De Almeida >>>>>>>>>>>>>>>>>>>>> Pereira wrote: >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Hello, >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> On Mon, Apr 2, 2018 at 10:07 AM Murtuza Zabuawala < >>>>>>>>>>>>>>>>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> =E2=80=8BHello, >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Please find updated patch, >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Now layout will be locked after user updates its >>>>>>>>>>>>>>>>>>>>>>> preferences, w >>>>>>>>>>>>>>>>>>>>>>> e have used =E2=80=8B >>>>>>>>>>>>>>>>>>>>>>> templated variable in the javascript file >>>>>>>>>>>>>>>>>>>>>>> =E2=80=8B because we do not have preference module = or >>>>>>>>>>>>>>>>>>>>>>> preference cache available when the page loads and = panels gets rendered, >>>>>>>>>>>>>>>>>>>>>>> =E2=80=8BI >>>>>>>>>>>>>>>>>>>>>>> =E2=80=8B also >>>>>>>>>>>>>>>>>>>>>>> made changes in JS tests as per Joao's review >>>>>>>>>>>>>>>>>>>>>>> comments. >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Looks like everything is working when we change the >>>>>>>>>>>>>>>>>>>>>> lock. >>>>>>>>>>>>>>>>>>>>>> As a personal preferences I would prefer to see this >>>>>>>>>>>>>>>>>>>>>> in at least 2 commits, one that is related to the pr= eference issue and >>>>>>>>>>>>>>>>>>>>>> another one that is related to this story. >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> All the tests are working, but he linter is failing: >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> /tmp/build/4a5630c2/pivotal-rm-3155/web /tmp/build/4= a5630c2 >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> ./pgadmin/misc/__init__.py:78: [E303] too many blank= lines (2) >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> 1 E303 too many blank lines (2) >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> 1 >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> =E2=80=8BFixed=E2=80=8B >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> @Dave/Pivotal team, >>>>>>>>>>>>>>>>>>>>>>> The given patch is working fine for all the >>>>>>>>>>>>>>>>>>>>>>> Tabs/Panels (all the panels from main window as wel= l as from Query tool and >>>>>>>>>>>>>>>>>>>>>>> Debugger) but I'm facing an issue while handling th= e Browser tree section, >>>>>>>>>>>>>>>>>>>>>>> It is a wcDocer frame >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> and not a wcDocker panel >>>>>>>>>>>>>>>>>>>>>>> . Like >>>>>>>>>>>>>>>>>>>>>>> wcDocker panel, wcDocker frame do not provide any A= PI so that a developer >>>>>>>>>>>>>>>>>>>>>>> can prevent drag-drop functionality on it. >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> It's not working fine for me. For example, if I put th= e >>>>>>>>>>>>>>>>>>>> SQL Panel on it's own below the properties/stats panel= s (so it looks like >>>>>>>>>>>>>>>>>>>> pgAdmin 3 used to by default), and then lock the layou= t, I can un-dock the >>>>>>>>>>>>>>>>>>>> SQL panel into a dialogue, but then cannot re-dock it.= I can do weird >>>>>>>>>>>>>>>>>>>> things with the browser tree as well, probably because= it's a frame as you >>>>>>>>>>>>>>>>>>>> say. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> =E2=80=8BThat is expected behaviour =E2=80=8Bbecause on= ce you drag the >>>>>>>>>>>>>>>>>>> panel out of the group of Panels then it becomes indivi= dual Frame, That is >>>>>>>>>>>>>>>>>>> what the author of the wcDocker replied on my question, >>>>>>>>>>>>>>>>>>> *"A panel must either be initialized as movable or >>>>>>>>>>>>>>>>>>> non-movable from the beginning and never changed becaus= e it generates a >>>>>>>>>>>>>>>>>>> different arrangement of elements depending. This featu= re should only ever >>>>>>>>>>>>>>>>>>> be used within the onCreate method of the panel. I shou= ld probably have >>>>>>>>>>>>>>>>>>> been more clear about this limitation in the documentat= ion."* >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> So does it become a panel again if a second panel is >>>>>>>>>>>>>>>>>> added to the new tab group? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> =E2=80=8BNo, it stays Frame.=E2=80=8B >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> As far as I understand Panel needs a Frame to render >>>>>>>>>>>>>>>>> itself if it is not attached to the main docker instance.= =E2=80=8B >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> There must be some way we can lock a tab that's not part >>>>>>>>>>>>>>>>>> of a group. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> At a moment there is no way of =E2=80=8B >>>>>>>>>>>>>>>>> locking frames out of the box :( >>>>>>>>>>>>>>>>> =E2=80=8B >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hmm, so the question becomes: do we include the lock >>>>>>>>>>>>>>>> feature, but rename it to "Lock Tabs" or something similar= , or leave it out >>>>>>>>>>>>>>>> altogether? It clearly doesn't do everything we want right= now. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> =E2=80=8BI would say lets include the feature by adding war= ning note >>>>>>>>>>>>>>> that this feature works with default layout only, And I don= 't think most >>>>>>>>>>>>>>> user will try to drag drop Browser panel =E2=80=8B >>>>>>>>>>>>>>> anyway, meanwhile I'll check what changes are required in >>>>>>>>>>>>>>> main source code to make the Frame lock. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Anyone else have any thoughts on this? Personally I don't >>>>>>>>>>>>>> like including half-baked features. >>>>>>>>>>>>>> >>>>>>>>>>>>>> +1, but we need to find out the way as this feature is >>>>>>>>>>>>> requested by many users. >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> 100% agree. I can convince my self that this feature request >>>>>>>>>>>> has to do with locking panels into a certain layout. I can als= o convince >>>>>>>>>>>> myself that the same request is simple because users are frust= rated with >>>>>>>>>>>> the fact that the tabs and panes move around and they find tha= t behavior >>>>>>>>>>>> annoying. >>>>>>>>>>>> >>>>>>>>>>>> -- Rob >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>>> Dave Page >>>>>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>>>>> >>>>>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Akshay Joshi* >>>>>>>>> >>>>>>>>> *Sr. Software Architect * >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>>>>> >>>>>>>> >>>>> >>>>> >>>>> -- >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect * >>>>> >>>>> >>>>> >>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>> 976-788-8246 <+91%2097678%2088246>* >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --0000000000003e8f42056aac3620 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,
@Murtuza: We didn't notice the issue, can you = please advise on what need to change to make it work? The only change we di= d was to make one test pass.

@Hackers: In our poin= t of view it is never good to fork a library. But if he really have to do i= t, then we should fork it in Github, make our code accessible to other peop= le, and we should add it as a dependency on package.json


Thanks
Anthony & Joao


On Wed, Apr 25, 20= 18 at 7:14 AM Dave Page <dpage@pgad= min.org> wrote:
On Wed, Apr 25, = 2018 at 12:13 PM, Murtuza Zabuawala <murtuza.zabuawala@en= terprisedb.com> wrote:
Hi= Dave,

On Wed, Apr 25, 2018 at 3:36 PM, Dave = Page <dpage@pgadmin.org> wrote:
All,

We just had a brief discussi= on in our EDB sprint planning meeting about this. There is a non-zero chanc= e that we're going to have to fork wcDocker in the near future, in orde= r to update it to work with jQuery 3. If we do that, then it may be signifi= cantly easier to fix this issue in that fork (perhaps by adding a single lo= ckLayout(bool) function, rather than trying to do so from pgAdmin.

I think (unless Murtuza believes that won't help), tha= t we're better off holding on this for now until we know if we've h= ad to do that.

=E2=80=8BI don't have any obj= ection forking the code and adding the flag to lock the panel,=C2=A0 But I&= #39;m certain that=C2=A0
we will use the same = inbuilt method panel.moveabl= e(false) which we have used right now in the patch to prevent a panel f= rom floating and will face the same issue again which Akshay mentioned in h= is last email.

Let me know if you want me to attach latest patch onto the ticket for futu= re reference and update the ticket accordingly=E2=80=8B.
=

That's= probably a good idea - thanks.
=C2=A0

<= /div>

On Wed, Apr 25, 2018 at 10:23 AM, = Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com= > wrote:
Hi Akshay,


On Wed, Apr 25, 2018 at 2:37 PM, Aksha= y Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Joao/Murtuza

<= /div>
It break's the functionality, I am able to move "Data ou= tput", "Explain" etc.. panel of Query Tool, even if "Lo= ck layout?" is set to True.
=C2=A0
<= /span>
=E2=80=8BIt's working properly in v5 patch, Something = went wrong while refactoring.=E2=80=8B
=C2=A0
=E2=80=8B
Apart from abo= ve I have found more issue. Below are the steps to reproduce:
  • Set the "Lock layout?" flag to False.
  • Move out Dashb= oard panel.
  • Set the "Lock layout?&quo= t; flag to True.
  • Close the Dashboard panel, as layout is loc= ked and empty Dashboard panel is still visible. (Refer attached screenshot)= =C2=A0=C2=A0
    • =E2= =80=8BThat's because we have set the Panel moveable property to False, = they won't auto resize, As discussed earlier if user drag any panel out= of panel group it gets render in seprate wcFrame. I think that needs to be= taken care by user before they decide to lock the layout, We can not expil= citly set panel's closeable property to False when layout is locked, If= we do so user will not be able to close any Query tool, Debugger panels.= =E2=80=8B
    =C2=A0=E2=80=8B


    On Tue, Apr 24, 201= 8 at 9:11 PM, Joao De Almeida Pereira <jdealmeidapereira@pivota= l.io> wrote:
    haha,
    Just joking, now we have a good version that passes tests and = all.

    We found out that a test was failing in the p= atch version 5:
    HeadlessChrome 0.0.0 (Linux 0.0.0) Panel when we create a panel and =
user created panel without defining isMoveable then it should be moveable i=
t should call moveable method with true as argument FAILED
    Expected false to be true.
        at UserContext.<anonymous> (regression/javascript/browser/pan=
el_spec.js:12886:38)
    =E2=80=8B
    To solve this problem we decided to change the Panel cl= ass to match what the test say.

    Thanks
    V= ictoria & Joao


    On Tue, Apr 24, 2018 at 11:08 AM Joao D= e Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
    Hi,
    Apparently the last version = was not applying, here is the new version that should apply correctly
    =

    Thanks
    Victoria & Joao

    On Tue, Apr 24, 2018 at 10:56 AM Joao De= Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
    Hi Murtuza,

    We tes= ted the patch and everything looks fine.=C2=A0 We also refactors some parts= to include things like strict equality and using let/const instead of var.= =C2=A0 The updated patch is attached.
    In the future, it will be m= ore valuable to have the translation to ES6 and the feature work in separat= e commits so it is easier to understand what changed.

    <= div>Sincerely,

    Joao and Victoria



    On Tue, Apr 24, 2018 at 4:58 AM Akshay Joshi <akshay.joshi@enterpr= isedb.com> wrote:
    On Tue, Apr = 24, 2018 at 1:17 PM, Dave Page <dpage@pgadmin.org> wrote:
    Akshay, could you review/c= ommit this please?

    Please also update the release_notes_= 3_1.rst file when you commit user-visible changes, to make it easier to bui= ld the release notes.

    =
    =C2=A0 =C2=A0Sure=C2=A0

    Thanks.

    On Tue, Apr = 24, 2018 at 8:45 AM, Murtuza Zabuawala <murtuza.zabuawala= @enterprisedb.com> wrote:
    <= div dir=3D"ltr">
    Hi Dave,
    =
    Pleas= e find the updated patch, Now we are able to lock wcFrame and wcPanel both.=

    --
    Regards,
    Murtuza Zabuawala
    EnterpriseDB:=C2=A0= http://www.enterprisedb.com
    The Enterprise PostgreSQL Company    =


    On Thu, Apr 5, 2018 at 6:32 PM, Robert Eckha= rdt <reckhardt@pivotal.io> wrote:


    On Wed, Apr 4, 2018 at 11:31 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


    On Wed= , Apr 4, 2018 at 8:09 PM, Dave Page <dpage@pgadmin.org> wrot= e:


    On Wed, Apr 4, 2018 at 12:54 PM, Murtuza Z= abuawala <murtuza.zabuawala@enterprisedb.com> wrote:
    <= div style=3D"font-family:verdana,sans-serif;color:#444444">On Wed, Apr 4, 2018 at 5:0= 0 PM, Dave Page <dpage@pgadmin.org> wrote:


    On Wed, Apr 4, 2018 at 10:45 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
    <= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
    On Wed, Apr 4, 2018 at 2:47 PM, Dave Page <= span dir=3D"ltr" style=3D"font-family:arial,sans-serif;color:rgb(34,34,34)"= ><dpage@pgadmin.o= rg> wrote:

    On Wed, Apr 4, = 2018 at 7:20 AM, Murtuza Zabuawala <murtuza.zabuawala@ent= erprisedb.com> wrote:
    Hi Dave,

    On Tue, Apr 3, 2018 at 9:03 PM, Dave P= age <dpage@pgadmin.org> wrote:
    Hi

    On Tue, Apr 3, 2018 at 12:56 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
    Hi,

    Thanks Joao for reviewing.

    <= /div>
    PFA = updated patch.

    On Tue, Apr 3, 2018 at 1:11 AM, Joao D= e Almeida Pereira <jdealmeidapereira@pivotal.io> = wrote:
    Hello,

    On Mon, Apr 2, = 2018 at 10:07 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com&= gt; wrote:

    =E2=80=8BHello,

    Please find updated patch,=C2=A0

    = Now layout will be locked after user updates its preferences, w
    =
    e have used =E2=80=8B
    template= d variable in the javascript file
    =
    =E2=80=8B because we do not have preference module or preference= cache available when the page loads and panels gets rendered,=C2=A0
    <= /font>= =E2=80=8BI
    =E2=80=8B also=C2=A0
    made changes in JS tests as per J= oao's review comments.
    =
    Looks like everything is working = when we change the lock.
    As a personal preferences I would prefer= to see this in at least 2 commits, one that is related to the preference i= ssue and another one that is related to this story.


    All the tests are working, but he linter is failing:
    = 
    /tmp/build/4a5630c2/pivotal-rm-3155/web /tmp/build/4a5630c2

    ./pgadmin/misc/__init__.py:78: [E303] too many blank lines (2)

    1       E303 too many blank lines (2)=C2=A0
    =



    =
    There must be some way we can lock a tab that's not part of a grou= p.
    At a moment there = is no way of =E2=80=8B
    locking frames ou= t of the box :(
    =E2=80=8B



    =


    =C2=A0





    --
    Dave Page=
    Blog: http://= pgsnake.blogspot.com
    Twitter: @pgsnake

    EnterpriseDB UK: http://www.enterprised= b.com
    The Enterprise PostgreSQL Company



    --
    Akshay Joshi
    Sr. Software Architect


    Phone: +91 20-= 3058-9517
    Mobile: +91 976-788-8246


    --
    <= b>Akshay Joshi
    Sr. Software Architect

    <= div>
    Phone= : +91 20-3058-9517
    Mobile: +91 976-788-8246    <= /font>



    --
    Dave Page
    Blog: http://pgsnake.blogspot.com
    Twitter: @pgsnake

    Ent= erpriseDB UK: htt= p://www.enterprisedb.com
    The Enterprise PostgreSQL Company
    =


    --
    Dave Page
    Blog:= http://pgsnake.b= logspot.com
    Twitter: @pgsnake

    EnterpriseDB UK: http://www.enterprisedb.com=
    The Enterprise PostgreSQL Company
    --0000000000003e8f42056aac3620--