Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ek9mV-0005vz-2e for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Feb 2018 14:36:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ek9mT-0005Aj-Ry for pgadmin-hackers@arkaria.postgresql.org; Fri, 09 Feb 2018 14:36:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ek9mT-0005AZ-Is for pgadmin-hackers@lists.postgresql.org; Fri, 09 Feb 2018 14:36:01 +0000 Received: from mail-it0-x242.google.com ([2607:f8b0:4001:c0b::242]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ek9mN-0002Is-Ll for pgadmin-hackers@postgresql.org; Fri, 09 Feb 2018 14:36:00 +0000 Received: by mail-it0-x242.google.com with SMTP id h129so10871795ita.2 for ; Fri, 09 Feb 2018 06:35:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FDk1CK/j+7ZVjTZzvcJOx6niS8WFGXSBlSxWoRCYP0Y=; b=1AVE0C+ad62AWLp2KWWGzeevLrbYO1vqRqlavT1NWmvCKBd+GQAfaH120MfuCRkr2D O37IziLrXhUt57ILo5DUNZXtNTMq9PvRTswOOXJGdae+pHYxn7HAt4uGfUpkast3G8m6 C5kC0S/foo+uRLH3EbAV4wETsS1gYn5CSxdl0GPa3ZX0jpFp4cYle/196JMojZIZdYIU ZqtbzcfoBeXfmJJxOtkL6A2n9/MbPlLz0BtCFj0vwV/EBlsby5Cy5ikSLwpBGYWgcjpr 9ma4WFlgqKxBXIsoqWFLlKpqSNBCCJo/ittcSqT+/PXssFVa096bCUAuWHnQIe7cLNvc cpMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FDk1CK/j+7ZVjTZzvcJOx6niS8WFGXSBlSxWoRCYP0Y=; b=WKMw2s+M3qq2rq1ikzaVTQWyrRaWCmbVpA0RPH7Pkwtl3Cjbw5oDiQ2OaYT7e7mE0j /5iu+uYSf+Lm+XeaHzw/tYy3hfeyaPXXDHdazyvOHOE1B4jyclDFt+24tabzU2yKq6E+ VbkOGQsEDU8evauC8bnSJotwjzBUFcEBn1UjwNJ/8MA1G1Ug7eh4oTCiwVdh4PF0kOk1 w0tx7baUqvvdf3ulOrQ9Meon2b/yaPbGutjeysjkDgSzK/HOBKtRjVWpVgMZj6h1TTRK JyKqx2//wv8dXgJMbbGYfpWgU8kbe+RMm+/IK5AyB4JYf8Ggus4wXcNB4mBsA1Ds2AzT 30ug== X-Gm-Message-State: APf1xPCB2nGTqfFG+ZlxhxxvfvqXp1c+U4LLczkpMdcEGix7JIxTTgkT WBC5jp9Mf6PG2a318tutfQNz+ImTpmu+zRcEgDJSbw== X-Google-Smtp-Source: AH8x226pgJFJ2taddzulH0x5C2OuG+agEEF7O5n8iWKKVJh2fDV+WYLWfcNEYkLmDKwTWquLSilzlI6Ok0UCsSqcH3U= X-Received: by 10.36.26.137 with SMTP id 131mr3580630iti.25.1518186949755; Fri, 09 Feb 2018 06:35:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Fri, 09 Feb 2018 14:35:39 +0000 Message-ID: Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="001a1143ea0ad898b40564c87161" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1143ea0ad898b40564c87161 Content-Type: multipart/alternative; boundary="001a1143ea0ad898b00564c8715f" --001a1143ea0ad898b00564c8715f Content-Type: text/plain; charset="UTF-8" Hello, Attached you can find the fix for the current pronlem On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote: > Hi Joao, > > It looks like Jenkins has taken umbrage to this change, at least with > Python 3.x. Can you take a look please? > > https://jenkins.pgadmin.org/ > > Thanks. > > On Fri, Feb 9, 2018 at 11:54 AM, Dave Page wrote: > >> Thanks, patches applied. >> >> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hi Hackers, >>> This is quite a big patch in order to solve the problem with the Explain >>> Plan. >>> >>> We sent 2 patches that have the following: >>> *- update-javascript-packages.diff * >>> Add package: >>> is-docker to select a specific setting when running the Chrome >>> tests in >>> Docker >>> >>> Upgrade the version of: >>> - babel-loader >>> - extract-text-webpack-plugin >>> - jasmine-core >>> - jasmine-enzyme >>> - moment >>> *- explain-plan-greenplum.diff* >>> Extract SQLEditor.execute and SQLEditor._poll into their own files and >>> add test around them >>> Extract SQLEditor backend functions that start executing query to >>> their own files and add tests around it >>> Move the Explain SQL from the front-end and now pass the Explain plan >>> parameters as a JSON object in the start query call. >>> Extract the compile_template_name into a function that can be used by >>> the different places that try to select the version of the template and the >>> server type >>> >>> >>> Thanks >>> Joao >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1143ea0ad898b00564c8715f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,
Attached you can find the fix for the current p= ronlem


= On Fri, Feb 9, 2018 at 7:29 AM Dave Page <dpage@pgadmin.org> wrote:
Hi Joao,

It looks like Jenkins has= taken umbrage to this change, at least with Python 3.x. Can you take a loo= k please?


Thanks.

On Fri, Feb 9, 2018 at 11:54 AM, Dave Page <dpage@pgadmin.org&= gt; wrote:
Thanks= , patches applied.

On Fri, Feb 2, 2018 at = 10:50 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io= > wrote:
H= i Hackers,
This is quite a big patch in order to solve the problem with= the Explain Plan.

We sent 2 patches that have the= following:
-=C2=A0update-javascript-packages.diff=C2=A0
=C2=A0 =C2=A0 Add package:
=C2=A0 =C2=A0 =C2=A0= is-docker to select a specific setting when running the Chrome tests in
=C2=A0 =C2=A0 =C2=A0Docker

=C2=A0 =C2=A0 Up= grade the version of:
=C2=A0 =C2=A0 - babel-loader
=C2= =A0 =C2=A0 - extract-text-webpack-plugin
=C2=A0 =C2=A0 - jasmine-= core
=C2=A0 =C2=A0 - jasmine-enzyme
=C2=A0 =C2=A0 - mom= ent
-=C2=A0explain-plan-greenplum.diff
=C2= =A0 Extract SQLEditor.execute and SQLEditor._poll into their own files and = add test around them
=C2=A0 Extract SQLEditor backend functions t= hat start executing query to their own files and add tests around it
<= div>=C2=A0 Move the Explain SQL from the front-end and now pass the Explain= plan parameters as a JSON object in the start query call.
=C2=A0= Extract the compile_template_name into a function that can be used by the = different places that try to select the version of the template and the ser= ver type


Thanks
Joao



-= -
Dave Page
Blog: http://pgsnake.blogspot.comTwitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpris= e PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterprise= DB UK: http://www= .enterprisedb.com
The Enterprise PostgreSQL Company
--001a1143ea0ad898b00564c8715f-- --001a1143ea0ad898b40564c87161 Content-Type: application/octet-stream; name="correct-tests0in-python-3.6" Content-Disposition: attachment; filename="correct-tests0in-python-3.6" Content-Transfer-Encoding: base64 Content-ID: <1617afe297a44010ec01> X-Attachment-Id: 1617afe297a44010ec01 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci90ZXN0cy90ZXN0X3N0YXJ0 X3F1ZXJ5X3Rvb2wucHkgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVzdHMvdGVzdF9z dGFydF9xdWVyeV90b29sLnB5CmluZGV4IDVlMjc1MmFlLi4xODYyNDA4NyAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3Rlc3RzL3Rlc3Rfc3RhcnRfcXVlcnlfdG9vbC5w eQorKysgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvdGVzdHMvdGVzdF9zdGFydF9xdWVy eV90b29sLnB5CkBAIC0zMyw2ICszMyw2IEBAIGNsYXNzIFN0YXJ0UXVlcnlUb29sKEJhc2VUZXN0 R2VuZXJhdG9yKToKICAgICAgICAgICAgIHJlc3BvbnNlID0gc2VsZi50ZXN0ZXIucG9zdCgnL3Nx bGVkaXRvci9xdWVyeV90b29sL3N0YXJ0LzEyMzQnLCBkYXRhPScic29tZSBzcWwgc3RhdGVtZW50 IicpCiAKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHJlc3BvbnNlLnN0YXR1cywgJzIw MCBPSycpCi0gICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhyZXNwb25zZS5kYXRhLCAnc29t ZSByZXN1bHQnKQorICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMocmVzcG9uc2UuZGF0YSwg Yidzb21lIHJlc3VsdCcpCiAgICAgICAgICAgICBTdGFydFJ1bm5pbmdRdWVyeV9leGVjdXRlX21v Y2suYXNzZXJ0X2NhbGxlZF93aXRoKCd0cmFuc2Zvcm1lZCBzcWwnLCAxMjM0LCBBTlkpCi0gICAg ICAgICAgICBleHRyYWN0X3NxbF9mcm9tX25ldHdvcmtfcGFyYW1ldGVyc19tb2NrLmFzc2VydF9j YWxsZWRfd2l0aCgnInNvbWUgc3FsIHN0YXRlbWVudCInLCBBTlksIEFOWSkKKyAgICAgICAgICAg IGV4dHJhY3Rfc3FsX2Zyb21fbmV0d29ya19wYXJhbWV0ZXJzX21vY2suYXNzZXJ0X2NhbGxlZF93 aXRoKGInInNvbWUgc3FsIHN0YXRlbWVudCInLCBBTlksIEFOWSkK --001a1143ea0ad898b40564c87161--