Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fLw3D-0008Pn-7t for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 May 2018 19:37:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fLw3B-0005fO-Pd for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 May 2018 19:37:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fLw3B-0005dm-KO for pgadmin-hackers@lists.postgresql.org; Thu, 24 May 2018 19:37:25 +0000 Received: from mx0b-00296801.pphosted.com ([148.163.153.148]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fLw34-0006jb-01 for pgadmin-hackers@postgresql.org; Thu, 24 May 2018 19:37:21 +0000 Received: from pps.filterd (m0114586.ppops.net [127.0.0.1]) by mx0b-00296801.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4OJaIOF031751 for ; Thu, 24 May 2018 19:37:14 GMT Received: from mail-io0-f199.google.com (mail-io0-f199.google.com [209.85.223.199]) by mx0b-00296801.pphosted.com with ESMTP id 2j2dbe6ny4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 24 May 2018 19:37:14 +0000 Received: by mail-io0-f199.google.com with SMTP id r140-v6so2369037iod.16 for ; Thu, 24 May 2018 12:37:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gs4rR7K8s+vRLLUFdoRic+EESNNjhi+qMDDihtdqthM=; b=q4N0R8GnZWG0sDpH9pwP99TMUI74KhHmrfUbbGTcxAfFdjyVwnEsAY0D38MA2GyPTp aQ3xnQYnGRazMjiD1qOJq6UqEKFw7rgOVIeNVmqxzR3ZxFsow7HHtJwgNhoj4HbF3paz 2/ArRPrYCPAQ1ZQ3tH5IwzZ1TCfm9QtSum5h6KOUQdCd7z9vQ43H9buW7mreTYwe/gEH 1gujsG0zPX1Pud9ov2CufTQlJ/KVvM+MPq5Taw4vtaM1MrAIpif7XDYxK7qdzp/E+HVX m98CkaE9gt4aY4q0xo9dUupAEC7e+HbKPZbQy9KMfk0sy2JAInO7zn5tybtEN5EpRt8U gYJA== X-Gm-Message-State: ALKqPwfKFvipm0qqed1eoqiI3Mti2NkSYq2EIkHcyZ2W7tPXlA6u2SxM 4ZuBduKWPHgp9usfUpjAlc7/BGFrgbo+RRzPbu0+BaZKHtRDjc1hLhZkI8yUtRyutm3VWMu9Adb Dy7ea1DTHk5kd+gnEluAXWmMZaeBT4rjoCXINuxgxF1ZhZcMQbOhgKpYP5Hd4Vu5mwBpr X-Received: by 2002:a24:10c5:: with SMTP id 188-v6mr11178388ity.69.1527190633975; Thu, 24 May 2018 12:37:13 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIcaPbLOAupsahWkBqZOifU2n800ukMY2TRqqO3F4zGIFV5FhhRfT0tzNzPvWNmiyqC6Z5Pk2oQ3klDQ8jRcGs= X-Received: by 2002:a24:10c5:: with SMTP id 188-v6mr11178369ity.69.1527190633722; Thu, 24 May 2018 12:37:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Thu, 24 May 2018 15:36:37 -0400 Message-ID: Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests To: Dave Page Cc: Anthony Emengo , pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000003a82de056cf8c740" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-24_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805240224 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000003a82de056cf8c740 Content-Type: multipart/alternative; boundary="0000000000003a82d9056cf8c73e" --0000000000003a82d9056cf8c73e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable As part of the development environment we do not see the reasoning behind not add PYTHONPATH to the environment variables, specially because this looks like the way pytest was invisoned. However please try the following patch instead. We've changed the pytest invocation to assume the relevant dir as part of the directories to load, as well as the docs and Makefile Thanks Joao && Anthony On Thu, May 24, 2018 at 12:24 PM Dave Page wrote: > > > On Thu, May 24, 2018 at 5:14 PM, Anthony Emengo > wrote: > >> Here=E2=80=99s a followup patch with the relevant README and Makefile ch= anges. To >> be clear, both patches need to be applied in succession to run the tests= . >> >> The error that you were running into was because the appropriate >> PYTHONPATH environment variable was not set. We updated the README to >> reflect that, but haven=E2=80=99t done anything to the code for that >> > That really needs to be fixed then. I shouldn't need to do anything beyon= d > activate the appropriate virtual environment (which I had done). > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --0000000000003a82d9056cf8c73e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
As part of the development environment we do not see = the reasoning behind not add PYTHONPATH to the environment variables, speci= ally because this looks like the way pytest was invisoned.

However please try the following patch instead. We've changed the p= ytest invocation to assume the relevant dir as part of the directories to l= oad, as well as the docs and Makefile

Thanks
J= oao && Anthony

On Thu, May 24, 2018 at 12:24 PM Dave Page <dpage@pgadmin.org> wrote:


On Thu, May 24, 2018 at 5:14 PM, Anthony Emengo <aeme= ngo@pivotal.io> wrote:

Here=E2=80= =99s a followup patch with the relevant README and Makefile changes. To be = clear, both patches need to be applied in succession to run the tests.

The error that you were running= into was because the appropriate PYTHONPATH enviro= nment variable was not set. We updated the README to reflect that, but have= n=E2=80=99t done anything to the code for that

=
That really needs to be fixed then. I shouldn't need to do anythin= g beyond activate the appropriate virtual environment (which I had done).= =C2=A0

--
Dave Page
Blog:= http://pgsnake.b= logspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company
--0000000000003a82d9056cf8c73e-- --0000000000003a82de056cf8c740 Content-Type: application/octet-stream; name="0002-Use-Pytests-v2.git-diff" Content-Disposition: attachment; filename="0002-Use-Pytests-v2.git-diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jhkxq6yw0 Y29tbWl0IGNkYjRlYmFkNTk0MTUzZTYwYjI4YzNmNmNiYTUyMzE3YjhlMDI3ZmMKQXV0aG9yOiBW aWN0b3JpYSBIZW5yeSA8dmhlbnJ5QHBpdm90YWwuaW8+CkRhdGU6ICAgVGh1IE1heSAyNCAxNToz MToxMCAyMDE4IC0wNDAwCgogICAgQWRkIGRvY3Mgb24gcHl0ZXN0IGluIFJFQURNRQogICAgCiAg ICBTaWduZWQtb2ZmLWJ5OiBKb2FvIFBlcmVpcmEgPGpkZWFsbWVpZGFwZXJlaXJhQHBpdm90YWwu aW8+CgpkaWZmIC0tZ2l0IGEvTWFrZWZpbGUgYi9NYWtlZmlsZQppbmRleCBmMTYzODA0Li5lNzAz ODhiIDEwMDY0NAotLS0gYS9NYWtlZmlsZQorKysgYi9NYWtlZmlsZQpAQCAtMzgsNyArMzgsNyBA QCBjaGVjay1wZXA4OgogCWNkIHdlYiAmJiBweWNvZGVzdHlsZSAtLWNvbmZpZz0ucHljb2Rlc3R5 bGUgLgogCiBjaGVjay1weXRob246Ci0JY2Qgd2ViICYmIHB5dGhvbiByZWdyZXNzaW9uL3J1bnRl c3RzLnB5IC0tZXhjbHVkZSBmZWF0dXJlX3Rlc3RzCisJUFlUSE9OUEFUSD0kKFBXRCkvd2ViIHB5 dGVzdCAtcSB3ZWIvcGdhZG1pbgogCiBjaGVjay1mZWF0dXJlOiBpbnN0YWxsLW5vZGUgYnVuZGxl CiAJY2Qgd2ViICYmIHB5dGhvbiByZWdyZXNzaW9uL3J1bnRlc3RzLnB5IC0tcGtnIGZlYXR1cmVf dGVzdHMKZGlmZiAtLWdpdCBhL1JFQURNRSBiL1JFQURNRQppbmRleCAyYjJjZGRjLi44MzEwZDhh IDEwMDY0NAotLS0gYS9SRUFETUUKKysrIGIvUkVBRE1FCkBAIC0xMTYsNyArMTE2LDcgQEAgcHJv Y2VzcyBpcyBmYWlybHkgc2ltcGxlIC0gYWRhcHQgYXMgcmVxdWlyZWQgZm9yIHlvdXIgZGlzdHJp YnV0aW9uOgogCiAgICAgKHBnYWRtaW40KSAkIFBBVEg9JFBBVEg6L3Vzci9sb2NhbC9wZ3NxbC9i aW4gcGlwIGluc3RhbGwgLXIgJFBHQURNSU40X1NSQy9yZXF1aXJlbWVudHMudHh0CiAKLSAgIElm IHlvdSBhcmUgcGxhbm5pbmcgdG8gcnVuIHRoZSByZWdyZXNzaW9uIHRlc3RzLCB5b3UgYWxzbyBu ZWVkIHRvIGluc3RhbGwKKyAgIFRvIHJ1biB0aGUgcmVncmVzc2lvbiB0ZXN0cywgeW91IGFsc28g bmVlZCB0byBpbnN0YWxsCiAgICBhZGRpdGlvbmFsIHJlcXVpcmVtZW50cyBmcm9tIHdlYi9yZWdy ZXNzaW9uL3JlcXVpcmVtZW50cy50eHQ6CiAKICAgIChwZ2FkbWluNCkgJCBwaXAgaW5zdGFsbCAt ciAkUEdBRE1JTjRfU1JDL3dlYi9yZWdyZXNzaW9uL3JlcXVpcmVtZW50cy50eHQKQEAgLTIxOCw2 ICsyMTgsNDAgQEAgY2FuIGJlIHVzZWQ6CiAgICAgQzpcJFBHQURNSU40X1NSQ1x3ZWI+IHlhcm4g aW5zdGFsbAogICAgIEM6XCRQR0FETUlONF9TUkNcd2ViPiB5YXJuIHJ1biBidW5kbGUKIAorVGVz dGluZyB0aGUgYXBwbGljYXRpb24KKy0tLS0tLS0tLS0tLS0tLS0tLS0tCisKK1RoZSBhcHBsaWNh dGlvbiBoYXMgdGVzdHMgZm9yIHRoZSBKYXZhc2NyaXB0IGFuZCBQeXRob24gY29kZSwgdGhleSBj YW4gYmUgcnVuIHNlcGFyYXRseSBvciBhbGwgdG9nZXRoZXIuCitUbyBlbnN1cmUgdGhhdCB0aGUg cHl0aG9uIHRlc3RzIHJ1biB0aGUgUFlUSE9OUEFUSCB2YXJpYWJsZSBuZWVkIHRvIGV4aXN0IGlu IHRoZSBlbnZpcm9ubWVudCwgaW4gb3JkZXIgdG8gY3JlYXRlIGl0CitleGVjdXRlIHRoZSBmb2xs b3dpbmcgY29tbWFuZDoKKworICAgICQgZXhwb3J0IFBZVEhPTlBBVEg9JFBHQURNSU40X1NSQy93 ZWIKKyAgICAkIGNkICRQWVRIT05QQVRICisKK1RvIHJ1biB0aGUgSmF2YXNjcmlwdCBvbmx5IHRl c3QgdGhlIGZvbGxvd2luZyBjb21tYW5kIGNhbiBiZSB1c2VkOgorCisgICAgKHBnYWRtaW40KSAk IHlhcm4gdGVzdDprYXJtYS1vbmNlCisKK1RvIHJ1biB0aGUgVW5pdCBUZXN0cyBvbiB0aGUgcHl0 aG9uIGNvZGUgdGhlIGZvbGxvd2luZyBjb21tYW5kIGNhbiBiZSB1c2VkOgorCisgICAgKHBnYWRt aW40KSAkIHlhcm4gcnVuIHRlc3Q6dW5pdAorCitUbyBydW4gdGhlIEZlYXR1cmUgVGVzdHMgb24g dGhlIHB5dGhvbiBjb2RlIHRoZSBmb2xsb3dpbmcgY29tbWFuZCBjYW4gYmUgdXNlZDoKKworICAg IChwZ2FkbWluNCkgJCB5YXJuIHJ1biB0ZXN0OmZlYXR1cmUKKworVG8gcnVuIGEgU2luZ2xlIHRl c3QKKworICAgIChwZ2FkbWluNCkgJCBweXRlc3QgLWsgVGVzdENvbHVtblB1dCAuL3BnYWRtaW4K KworVG8gcnVuIHRoZSBBbGwgVGVzdHMgdGhlIGZvbGxvd2luZyBjb21tYW5kIGNhbiBiZSB1c2Vk OgorCisgICAgKHBnYWRtaW40KSAkIHlhcm4gcnVuIHRlc3QKKworSW4gY2FzZSB5b3UgZG8gbm90 IHdhbnQgdG8gZGVmaW5lIFBZVEhPTlBBVEggZW52aXJvbm1lbnQgdmFyaWFibGUsIHRoZSBmb2xs b3dpbmcgY29tbWFuZCBzaG91bGQgYmUgdXNlZAorCisgICAgKHBnYWRtaW40KSAkIHB5dGhvbiAt bSBweXRlc3QgLXEgcGdhZG1pbgorCiBDb25maWd1cmluZyB0aGUgUnVudGltZQogLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KIApkaWZmIC0tZ2l0IGEvd2ViL3BhY2thZ2UuanNvbiBiL3dlYi9wYWNr YWdlLmpzb24KaW5kZXggYTg2ZDE5MS4uZmViZjFiZSAxMDA2NDQKLS0tIGEvd2ViL3BhY2thZ2Uu anNvbgorKysgYi93ZWIvcGFja2FnZS5qc29uCkBAIC05OSw3ICs5OSw3IEBACiAgICAgImJ1bmRs ZSI6ICJjcm9zcy1lbnYgTk9ERV9FTlY9cHJvZHVjdGlvbiB5YXJuIHJ1biBidW5kbGU6ZGV2IiwK ICAgICAidGVzdDprYXJtYS1vbmNlIjogInlhcm4gcnVuIGxpbnRlciAmJiB5YXJuIHJ1biBrYXJt YSBzdGFydCAtLXNpbmdsZS1ydW4iLAogICAgICJ0ZXN0Omthcm1hIjogInlhcm4gcnVuIGxpbnRl ciAmJiB5YXJuIHJ1biBrYXJtYSBzdGFydCIsCi0gICAgInRlc3Q6dW5pdCI6ICJ5YXJuIHJ1biBs aW50ZXIgJiYgcHl0ZXN0IC1xIHBnYWRtaW4iLAorICAgICJ0ZXN0OnVuaXQiOiAieWFybiBydW4g cGVwOCAmJiBweXRob24gLW0gcHl0ZXN0IC1xIHBnYWRtaW4iLAogICAgICJ0ZXN0OmZlYXR1cmUi OiAieWFybiBydW4gYnVuZGxlICYmIHB5dGhvbiByZWdyZXNzaW9uL3J1bnRlc3RzLnB5IC0tcGtn IGZlYXR1cmVfdGVzdHMiLAogICAgICJ0ZXN0IjogInlhcm4gcnVuIHRlc3Q6a2FybWEtb25jZSAm JiB5YXJuIHJ1biBidW5kbGUgJiYgeWFybiB0ZXN0OnVuaXQgJiYgcHl0aG9uIHJlZ3Jlc3Npb24v cnVudGVzdHMucHkgLS1wa2cgZmVhdHVyZV90ZXN0cyIsCiAgICAgInBlcDgiOiAicHljb2Rlc3R5 bGUgLS1jb25maWc9LnB5Y29kZXN0eWxlIC4iCg== --0000000000003a82de056cf8c740--