Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erWQW-0007ge-Od for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 22:11:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erWQV-0001YD-OK for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 22:11:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erWQV-0001Y2-In for pgadmin-hackers@lists.postgresql.org; Thu, 01 Mar 2018 22:11:47 +0000 Received: from mail-io0-x22e.google.com ([2607:f8b0:4001:c06::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erWQO-0005Tv-VJ for pgadmin-hackers@postgresql.org; Thu, 01 Mar 2018 22:11:46 +0000 Received: by mail-io0-x22e.google.com with SMTP id e30so8801760ioc.3 for ; Thu, 01 Mar 2018 14:11:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=efajTR8SG8qa60Au1+jqYfhTu0bVsP6021QLK/UCsF0=; b=l6hLLqalsoXEBiAkqe4nSYx8lvm1xrRH2E7M9R65/6M43KarMg4sBOCiPpvwjZfDDe HR/ZYMb8/Z2GvWli7yChyHoZjXh00rAUGsSwlbK4nECXXhXxhAmSnwGK2/wm4zI7QHFK FOW/Zv5hnNVDjVVnE6bLxuanEQVjS5Inn7X4JWH9C/gQNK3r8QMah0L9KFz8KwGfe7ae gji3PUUoE41E750aYLmbsuLiIQkB7keWjRw5vgv+73PGsrggfulNIbMTXOqJdNImeJ2u zahoX3UEbDseh+LaYgAqzRjuTqO7KXbCMv80XsHFpsYiMl1aWWgY09+xFpkdJcwK3wpz qg+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=efajTR8SG8qa60Au1+jqYfhTu0bVsP6021QLK/UCsF0=; b=DC9mt2BS23r74fgrNhTuIDt+P3DOEP5CB1pDe68E+ogZElAT9D3VgJmGPx93GywMJi YU2O9lfvZxeO6kJDsKrytznvNcDlmR/soMQdr8zExoc2132d4zKRljuPOhaYRFfJa1Em fQYKhuNgGBPW/97whqIjrh5TgRudv4HMGIQxOHaxWAVq9OLCSaPKQO0FLa2WoJywPsfa KrXBZEaERFZwifVlLxHzffiRk+2odNQ4HxYxJurQ/JqCCz6fKS5TI4lENV3JxUOXcyCt g+P5Z57tzG6r4gDTA1qthmy9dAjCIzcCtQo79+bpCmFUOkHN+GtDSXlieFYjSsbs8WOW lADg== X-Gm-Message-State: AElRT7F5gip9dJlf4m8JpHg5JeBifMAI7MYPpomp954/PFTh1CYan+kF QDmckaQz4v1tEy/T6T+4tiM5gL4oRcScTGnuS5JL4w== X-Google-Smtp-Source: AG47ELvgYeUlJu3pvMMf6PE6iNUmQtQYMKQEpDYKQKGX/QAoipElZ08xH61Dd5T55e7h8/eLTL2YbBL2haQX1daEqts= X-Received: by 10.107.200.69 with SMTP id y66mr3911989iof.116.1519942298758; Thu, 01 Mar 2018 14:11:38 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Thu, 01 Mar 2018 22:11:28 +0000 Message-ID: Subject: Re: [pgAdmin4][RM#3129] handle encoding issue in File manager To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c0b9acecc121105666124e0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c0b9acecc121105666124e0 Content-Type: text/plain; charset="UTF-8" Hello Joao, The pipeline is green and I believe the change is good to be merged. Thanks Joao On Thu, Mar 1, 2018 at 10:56 AM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Thanks Joao for reviewing. > > Attaching updated patch fixing PEP8 issues. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Mar 1, 2018 at 8:56 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Murtuza, >> >> The code looks pretty good, love the fact that you extracted it so that >> our file size stop growing and get more manageable. All tests pass on our >> CI. >> >> The only issue I found was linting: >> >> pycodestyle --config=.pycodestyle pgadmin/tools/sqleditor/ >> pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py:12: [E302] expected >> 2 blank lines, found 1 >> pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py:53: [W391] blank >> line at end of file >> pgadmin/tools/sqleditor/utils/tests/test_query_tool_fs_utils.py:27: >> [E121] continuation line under-indented for hanging indent >> pgadmin/tools/sqleditor/utils/tests/test_query_tool_fs_utils.py:29: >> [E122] continuation line missing indentation or outdented >> 1 E121 continuation line under-indented for hanging indent >> 1 E122 continuation line missing indentation or outdented >> 1 E302 expected 2 blank lines, found 1 >> 1 W391 blank line at end of file >> 4 >> >> When this is fixed I think we are good to go >> >> Thanks >> Joao >> >> On Thu, Mar 1, 2018 at 3:01 AM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to fix the issue where user was not able to open the file with >>> non utf-8 encoding. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> > --94eb2c0b9acecc121105666124e0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Joao,
The pipeline is green and I believe the ch= ange is good to be merged.

Thanks
Joao

On Thu, Mar 1, 20= 18 at 10:56 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
=
Thanks Joao for re= viewing.

Attaching updated patch fixing PE= P8 issues.

=
--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company<= /font>


On Thu, Mar= 1, 2018 at 8:56 PM, Joao De Almeida Pereira <jdealmeidapereir= a@pivotal.io> wrote:
Hello Murtuza,

The code looks pretty good, lo= ve the fact that you extracted it so that our file size stop growing and ge= t more manageable. All tests pass on our CI.

The o= nly issue I found was linting:

pycodestyle --= config=3D.pycodestyle pgadmin/tools/sqleditor/
pgadmin/tools/sqle= ditor/utils/query_tool_fs_utils.py:12: [E302] expected 2 blank lines, found= 1
pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py:53: [W391= ] blank line at end of file
pgadmin/tools/sqleditor/utils/tests/t= est_query_tool_fs_utils.py:27: [E121] continuation line under-indented for = hanging indent
pgadmin/tools/sqleditor/utils/tests/test_query_too= l_fs_utils.py:29: [E122] continuation line missing indentation or outdented=
1=C2=A0 =C2=A0 =C2=A0 =C2=A0E121 continuation line under-indente= d for hanging indent
1=C2=A0 =C2=A0 =C2=A0 =C2=A0E122 continuatio= n line missing indentation or outdented
1=C2=A0 =C2=A0 =C2=A0 =C2= =A0E302 expected 2 blank lines, found 1
1=C2=A0 =C2=A0 =C2=A0 =C2= =A0W391 blank line at end of file
4

When this is fixed I think we are good to go

Tha= nks
Joao

On Thu, Mar 1, 2018 at 3:01 AM Murtuza Zabuawala <murtuza.zabuawala@ente= rprisedb.com> wrote:
Hi,

PFA patch to fix th= e issue where user was not able to open the file with non utf-8 encoding.


--
Regards,
Murtuza Zabuawala
Enterp= riseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQ= L Company


--94eb2c0b9acecc121105666124e0--