Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erWLo-0007K7-TW for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 22:06:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1erWLn-0006xh-VF for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Mar 2018 22:06:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1erWLF-0005uG-5Z for pgadmin-hackers@lists.postgresql.org; Thu, 01 Mar 2018 22:06:21 +0000 Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1erWL5-0005M0-72 for pgadmin-hackers@postgresql.org; Thu, 01 Mar 2018 22:06:19 +0000 Received: by mail-io0-x22b.google.com with SMTP id d71so8787074iog.4 for ; Thu, 01 Mar 2018 14:06:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u6K6C9SR1Gsg9dkrNaJtWfR95Q5gTtm2lwKXpTL9G2M=; b=iWnuHJXpnfC6Tor2lQ5YJ8Rzcqt4ildYrXGGXVx0AIvttSHzYY5oreVHOkrQ2Yhw/a aeVCfTix8C6NhlJBD16ekyoheA1XOjFeGLwqIHgfZxLHKSGQa645Mq6tbrDawDW5hHtO WyZbMftUgcE9s+sunryJqp7KfF2BXQygjna1GA1aT+z3Pw2rYPscAz/P7BLDF409kPDr hZhnS8k0KazkEQKyYgi34gs/obAdNqnaweyCX+tsWsqONLS2oL348u40Kb6LroRXQX87 WeSrOfOX9h7Y3rHXGkeDisu9AXbBwyaEFoqnlYioaMWOmOwLv8HfjaR1+TbHtA9FT4m2 vmsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u6K6C9SR1Gsg9dkrNaJtWfR95Q5gTtm2lwKXpTL9G2M=; b=ms7mHuN9sR1aA1i0ArAgDaYYZvYgk0sqeq/0b27R0V8nuUme05hu0pC9ZHWGzW9Hs/ jLwalOLW2hgyzJgnClPLX5MXHsgGDmSqHUoYZ9sMglXHep43uFdcQZM0wxLNbXw6HrmO 5TAw/qiOraX5jAM17Inv5NHAGUIoAXZAGqt3xkK1wwDneERN3KuR/MH95E8O2SgJKuGK e0Koe7/HUq5VbbspvBWnQEwZqBMLYPwbNIQwNIIE237ifeA0HZqldQvN4QLexg+SMW74 iPPdnDJPuYCkGQDKGB8lM6NFdl3XgwnTSrp5QF+5WwKyW8g38QUnAEonzSr4OmfzDXSc eUYg== X-Gm-Message-State: AElRT7GF4X30/aR/LAXiybE1hDVyoBMpTflN46GdsfJMXvgzScfzC8cn xDzE7eYhPIsn2UR99lfXxfw9GD6WGyoAop5bVSUblA== X-Google-Smtp-Source: AG47ELvmEXqTwjk1IixgEXcz/XS7V2sHXqnB5usPZXggum+R/mChkElpVIvtWU5xxaWSPZUVbpH3b5oGxBUs48Io7mE= X-Received: by 10.107.39.5 with SMTP id n5mr3840045ion.189.1519941968422; Thu, 01 Mar 2018 14:06:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Joao De Almeida Pereira Date: Thu, 01 Mar 2018 22:05:57 +0000 Message-ID: Subject: Re: Bug #2309 fix To: Neethu Mariya Joy Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="001a11406f181b957a05666111ca" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a11406f181b957a05666111ca Content-Type: text/plain; charset="UTF-8" Hello Neethu, We run the patch though our test pipeline and all tests are green. Everything looks good with this patch Thanks Joao On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy wrote: > Hi, > I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science > at BITS Pilani. > > I've attempted to fix https://redmine.postgresql.org/issues/2309. > Codemirrors catches all the keyboard and mouse events when 'readOnly' > option is set to 'noCursor' and does not allow copying. > So, I've set 'readOnly' option to true. In order to hide the cursor, I've > added a class 'hide-cursor-workaround' and applied css styles to hide the > cursor. > > I'm attaching my patch as bug2309.diff below as per the contribution > guidelines. > > Hope this helps. Thank you for your consideration! > > Sincerely, > Neethu Mariya Joy > GitHub | Linkedin > > > > --001a11406f181b957a05666111ca Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Neethu,

We run the patch though our tes= t pipeline and all tests are green. Everything looks good with this patch

Thanks
Joao
On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <neethumariyajoy@gmail.com>= wrote:
Hi,
I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science= at BITS Pilani.

I've attempted to fix=C2=A0http= s://redmine.postgresql.org/issues/2309. Codemirrors catches all the key= board and mouse events when 'readOnly' option is set to 'noCurs= or' and does not allow copying.
So, I've set 'readOnl= y' option to true. In order to hide the cursor, I've added a class = 'hide-cursor-workaround' and applied css=C2=A0styles to hide the cu= rsor.

I'm attaching my patch as bug2309.diff b= elow as per the contribution guidelines.

Hope this= helps. Thank you for your consideration!

Sincerel= y,
Neethu Mariya Joy
GitHub=C2= =A0|=C2=A0Linkedin


--001a11406f181b957a05666111ca--